From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by sourceware.org (Postfix) with ESMTPS id 46B813861859 for ; Thu, 21 Dec 2023 06:45:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 46B813861859 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 46B813861859 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703141105; cv=none; b=A6rYWKPRnUVSKh3tlfry8LrmEUi+G8jSIHZuGBYKslMiojoxX+XCOLi7yn5gpGoEXG5dbET6ue+hO/HfPYybomaMZlw16bUQwHwWqDswz3hK/SFK0J7K+eIy2AH9IMWfAXZGGc7XqZo0mbAVVNoo2OqsTOYx5B3rdShqpaBFTtY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703141105; c=relaxed/simple; bh=dMPzcscgqSk8nWL8ozWDe93IydLF5TsFEuScfpW8wFk=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=k+gojwdN1Run47mO4uwfKLpO6KAcK2nCgE9mH4FUk0qvtgdhZlELKcp+GVpsGMfb/EViVHDZxWWyQWYceuQZLtLh3oXZwRQufwPL0lG/ZZ97iBs8+L/TREe5M5uRSbU2JTL017+n4XtLqouwYBLZt9fCRzX6F6xAQkwXmw59uIU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-59091e4a0f9so179994eaf.1 for ; Wed, 20 Dec 2023 22:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1703141102; x=1703745902; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=j9qyoKVQuFSJv9Vn5aPe3LNch9cqbIG5gbM0xync7c8=; b=WQPsSM7nqaFvG1EJwon4bOeFItoKBeWF7zp7LREiLq/zk2fJURt0HxHrX13zVsb7/H j40m4rBmjtODfCCVADypTAVbxrq7XKPaP/9hqTNpQk2bmTnERCIY3Vb7lI12zZS+8Ete Nv8IcYke/EtLIYD/ypSw7F23WMRA29prpEkl0m8QtzVx3UjUZrXV2wZZDNX7NGGh+mYM j70aclEMQraN1PGfU3JPL5d9UzBhMPS0Ez9/E1cGPHEZyticYI2844Tq5e0fHKNkzBJC lzsXrzYkcxLzDP77jXhY61u6xTIKVn4jzfPb4qrV8EslIg/8/AbtBCcJ+V0Tqlxzw129 Z+eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703141102; x=1703745902; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j9qyoKVQuFSJv9Vn5aPe3LNch9cqbIG5gbM0xync7c8=; b=Xcv7lnnNlo61Aq6XsKpUOstRN6dJB+WwRkfsYB4Z6lvQWs0YOG6ka6H0EEo14aK3hn KQSVJwzYluIkwrtmOUbHiIhgH+wNrW5zeAUM/gLbk5ci8JXw4E64jobCCl+mtyclNJdp aFjNVY9pNi+HqegqRb9pgPMW/x4u/h5tpK6p1nnQ+ZNYcz26kg0p+bspBywuwyHv6Di+ eIwJstzHPIaEBqswjI2dAWTMpcKhAG5OmO8rGWXWGf3ewRk0WO9BC6DaoyT9uD0IphJI NXytb6HZfZjw9WsaTlX001cqSGNKkClDD2TDvtMeF5/uw9TPjJ25ZkYRGyz/idm8CnpY K7dA== X-Gm-Message-State: AOJu0YzDw1doMuWTPLGTQ1WMFAulzJEiNBDTyrZTpeADOU3k7qYPCMsY YnQd3MPLrpFIq5NzbHO780CV+XCnnNFC6oNPHROvWg== X-Google-Smtp-Source: AGHT+IHqiMk01LvY3+RuUKrLMXh8StKTL/e8Zjg3McCp6yz6NawlR0P2IiUJ7LSW/c4xBaM7AS+F/WA7hc2QM5frC4w= X-Received: by 2002:a05:6871:82b:b0:202:ffca:ad91 with SMTP id q43-20020a056871082b00b00202ffcaad91mr776823oap.23.1703141102478; Wed, 20 Dec 2023 22:45:02 -0800 (PST) MIME-Version: 1.0 References: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com> In-Reply-To: From: Nelson Chu Date: Thu, 21 Dec 2023 14:44:51 +0800 Message-ID: Subject: Re: [PATCH 03/22] RISC-V: drop .bss override To: Jan Beulich Cc: Binutils , Nick Clifton , Alan Modra , Palmer Dabbelt , Andrew Waterman , Jim Wilson Content-Type: multipart/alternative; boundary="0000000000006a79d6060cff7048" X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000006a79d6060cff7048 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I passed the regressions of riscv-gnu-toolchain, so if no one objects, then it seems safe to commit. Thanks Nelson On Fri, Dec 15, 2023 at 8:07=E2=80=AFPM Jan Beulich wro= te: > It doesn't look to be a good idea to override the custom handler that > ELF has; afaict doing so broke .previous, and a sub-section specifier > wasn't accepted either. > > --- a/gas/config/tc-riscv.c > +++ b/gas/config/tc-riscv.c > @@ -4471,15 +4471,6 @@ s_dtprel (int bytes) > demand_empty_rest_of_line (); > } > > -/* Handle the .bss pseudo-op. */ > - > -static void > -s_bss (int ignore ATTRIBUTE_UNUSED) > -{ > - subseg_set (bss_section, 0); > - demand_empty_rest_of_line (); > -} > - > static void > riscv_make_nops (char *buf, bfd_vma bytes) > { > @@ -5202,7 +5193,6 @@ static const pseudo_typeS riscv_pseudo_t > {"dword", cons, 8}, > {"dtprelword", s_dtprel, 4}, > {"dtpreldword", s_dtprel, 8}, > - {"bss", s_bss, 0}, > {"uleb128", s_riscv_leb128, 0}, > {"sleb128", s_riscv_leb128, 1}, > {"insn", s_riscv_insn, 0}, > --- a/gas/doc/c-riscv.texi > +++ b/gas/doc/c-riscv.texi > @@ -138,10 +138,6 @@ Emits a DTP-relative word (or double-wor > meant to be used by the compiler in shared libraries for DWARF debug info > for > thread local variables. > > -@cindex BSS directive > -@item .bss > -Sets the current section to the BSS section. > - > @cindex LEB128 directives > @item .uleb128 @var{value} > @itemx .sleb128 @var{value} > > --0000000000006a79d6060cff7048--