From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id A1E54385C416 for ; Wed, 24 Aug 2022 11:37:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A1E54385C416 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oi1-x22a.google.com with SMTP id r10so13457663oie.1 for ; Wed, 24 Aug 2022 04:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=ocQMKeKDDk36e/p6m8t45iFd1mCZ6CT2F+6gbNlqJ78=; b=wlvkpqQNOO0FuxDOrQ30+3aMbUw3NgHbP8eTyt13e2RnjKB8NSJ4xz5rYHlaMRzbt4 spvCC9VpGSMTbq9czD4UZf4Jwo6l8Tj0n+vfAFRvSm2Nmp0SmOUZbAOzwAIwleGjuyqu RYawWN0cxpKjTSjnQv1nFSAykCKnoxRdNdzyM3EtglohSfCaPOjgz39wJTeDAZSAUe3G As6t/wLu2CJVwAVBrCsKx2/fGroy51JY2M24cMn53Rbo4Jf3bd7QOEmGeTeTs5ajUrrh CSjio1c/DJEj0qhDBvhwYzmERycoHs5cEoZyQDIZREzs5124HaBZfHsn1Y1Qsm12SFWa sWlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=ocQMKeKDDk36e/p6m8t45iFd1mCZ6CT2F+6gbNlqJ78=; b=2z7XyVgZPjQuq7xmAKJJ4sTGQWXpPFkclKMpo1vTO6zTSIKHlBbLltzUQkHJhXQX23 SEgdY6pVp+dHk9Fmk3y+ppmJ6I7lFZqvs81M8fCKIZQK4Mm4nINDPUfbvzvTE4akxLAH sFZU/XnQopidSDPRWKJvMTbZbzTeoRkQeWnhQ8ISlPxjKBsSzRB4DJG8qgE94UUkuIVM q8uRZ98t6N9r6ATBTTrNc3mRaeikMgFsw2iVZUivj3JwKch+tIkcAKBbpIJPpdfmBbWX ni3yTS5kjqTFf5tZClmDa3CWo5qk3jhkDFIZzPAuilTSrvy5Ms4oADQchGQTvUTGZP1f uBzQ== X-Gm-Message-State: ACgBeo1rbO0aqpxWARE2V9cgsKRbL0+auaK84QlkgUWD3+uhCKka+Qfz 0XezzIza9jGosxvSt2pnz3Zi07WOvcrQUIb5C5ihog== X-Google-Smtp-Source: AA6agR5RIhuGp36GruOlgN60uEvFu8HZw+EeU++39kx+7M8J9xmAoDUSU9XY6DtBhtIMpHkK4f/oWduVTyFDJRZHHwM= X-Received: by 2002:a05:6808:1884:b0:344:cc03:c64d with SMTP id bi4-20020a056808188400b00344cc03c64dmr2874333oib.107.1661341026059; Wed, 24 Aug 2022 04:37:06 -0700 (PDT) MIME-Version: 1.0 References: <9fdf589f8c54420f723a37bcbdf66bf665896365.1661304407.git.research_trasio@irq.a4lg.com> In-Reply-To: <9fdf589f8c54420f723a37bcbdf66bf665896365.1661304407.git.research_trasio@irq.a4lg.com> From: Nelson Chu Date: Wed, 24 Aug 2022 19:36:55 +0800 Message-ID: Subject: Re: [PATCH v7 3/5] RISC-V: Fix JALR target address computation To: Tsukasa OI Cc: "H . Peter Anvin" , Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Aug 24, 2022 at 9:28 AM Tsukasa OI via Binutils wrote: > > H. Peter Anvin discovered that we have wrong address computation for JALR > instruction (the initial bug is back in 2018). This commit will fix that > based on the idea of Palmer Dabbelt. > > opcodes/ChangeLog: > > * riscv-dis.c (print_insn_args): Fix JALR address computation. > --- > opcodes/riscv-dis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c > index 419c4746db9..162a2971320 100644 > --- a/opcodes/riscv-dis.c > +++ b/opcodes/riscv-dis.c > @@ -406,7 +406,7 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info > case 'b': > case 's': > if ((l & MASK_JALR) == MATCH_JALR) > - maybe_print_address (pd, rs1, 0, false); > + maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), false); OK, should move the related test cases in this patch. > print (info->stream, dis_style_register, "%s", riscv_gpr_names[rs1]); > break; > > -- > 2.34.1 >