From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id 02434385740F for ; Tue, 4 Oct 2022 01:10:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 02434385740F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oi1-x235.google.com with SMTP id w13so13005832oiw.8 for ; Mon, 03 Oct 2022 18:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=WT1EpWl5lIoj7pP8oCCbXxSBdWNZ2AESOcDcAYFcxs4=; b=ivKAefMg6vN9zRkyPx0qZRNXr4YvrY/Y3CXIoqPgz8UB2Xvsrlu7n18BBLCA51rWxH 5oNIAFNZ8Zml/CyMsQ8f5+VsgAff9Of1JTW+U+mPFBcU+IOMHFmOpGjJEGaQnY0ImQag gtsphB6kEhKUDu8MJB5mv7QI0h6e2C8EdM+c33OtXJvw0LGu3sI1UOJf2TEaUwJ+9Or7 FL6EywR0kFZNV6VabjhDQtBLQfk1jeUyNDqU2XL3wrBZI/HlhMMzOJKpCoNg1ieWFBvI vYEGqtUjtmG+4/pH+ylZA4keiHCpmapPEw+hluWrID5RxhC6lfdAC6qSid+fhH+bslGV PbdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=WT1EpWl5lIoj7pP8oCCbXxSBdWNZ2AESOcDcAYFcxs4=; b=6xOW2ne7GTDs3RMf8Qj4ILT4AXGdJbdGvTazXhCwC0AIhzdGJejezIiHzylb1BRI5e J5p9s1BuDpLqyM8/uZQyNQz6FSoyg9jk0DsU86jH7MBih9slqtcFTgmzlCwIS3TnDALn MZDmLJmac5HiCkp1FLa9W8lkJXDU+iA7Own36qR9D9An3RZxJHroQRafUj8/ARZzRFT2 IXXl8zjN4SixbM7GppwmhuVZJTKZXNVY1seA1jD2Z98i4Qv28rqFKVIxogZRpIv4X8Om qMM+F7FSG3bEOmZ9PagwHFUE35QnXeyr8FklvR/0csPIhqzRmHxUZlDSnBbucdNGC+Z+ iQrg== X-Gm-Message-State: ACrzQf1H1lMmGD+q2XMJzIGK9o0hWeBgzS4azl42UrpjiyTHLhXzHzFw zC2G5akzMwe4rG0vsqipR4eTDmiCSXlU83jOaAZ0Cg== X-Google-Smtp-Source: AMsMyM6+A31t4sSRhDdB81Hc4NdQuEvn30VaawsZLShevgtdw/y+kFPfB7NfYjIYyTV6VBC+ldeBhBHB0EGi/D1nC/M= X-Received: by 2002:a05:6808:bca:b0:350:b22b:1283 with SMTP id o10-20020a0568080bca00b00350b22b1283mr5386113oik.82.1664845826353; Mon, 03 Oct 2022 18:10:26 -0700 (PDT) MIME-Version: 1.0 References: <20221003101328.1790113-1-aburgess@redhat.com> In-Reply-To: <20221003101328.1790113-1-aburgess@redhat.com> From: Nelson Chu Date: Tue, 4 Oct 2022 09:10:15 +0800 Message-ID: Subject: Re: [PATCH] opcodes/riscv: style csr names as registers To: Andrew Burgess Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Please commit, thanks. Nelson On Mon, Oct 3, 2022 at 6:14 PM Andrew Burgess via Binutils wrote: > > While reviewing another patch I noticed that RISC-V CSR names are > given the text style, not the register style. This patch fixes this > mistake. > --- > opcodes/riscv-dis.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c > index 6ac69490b78..031c19334fa 100644 > --- a/opcodes/riscv-dis.c > +++ b/opcodes/riscv-dis.c > @@ -547,7 +547,8 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info > } > > if (riscv_csr_hash[csr] != NULL) > - print (info->stream, dis_style_text, "%s", riscv_csr_hash[csr]); > + print (info->stream, dis_style_register, "%s", > + riscv_csr_hash[csr]); > else > print (info->stream, dis_style_text, "0x%x", csr); > break; > -- > 2.25.4 >