From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by sourceware.org (Postfix) with ESMTPS id 1167938582A7 for ; Thu, 1 Feb 2024 16:34:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1167938582A7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1167938582A7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::2d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706805257; cv=none; b=M8/YbQ6DwCul6F34ec4E57GoTFdTVF2s7f1uVjtwmvFEZp5oG2br62FPdJ23XgJVlOfhBwcNtCjQRGV83U3CBQgwLRhl2pQdxEfijv6P16kz2XzGj4So/Od8ZPoa89OqBFoB20O1QIHDNwrPIxhKAtyZbOtsg9IFjJKd1zKYRm0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706805257; c=relaxed/simple; bh=Z8MUr4gVS2KDbVwLVIsjwg3fzm2d0o11+LzL6Ajt9b4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=TnhVpr3yHvPT5DAQGK6MQBnmaazrpmG6DuPlrm7UNhAiOqwYwz6olp/+7c6QAZgxpHdQvqem4ToEXKHyf1hI0tNtA4kIFUjgZR8xLbc9FgGSUR/RDcJkXPr1JNHH3+CnND+Nr5Od55E1xigGrYZ1KNPt8s564syYfrVyL3XnmnQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-214dbe25f8aso559634fac.3 for ; Thu, 01 Feb 2024 08:34:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1706805253; x=1707410053; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=n/co6X+OBGIXd4eG658fCiXjsMHAkcaBk+VnBBaSvfM=; b=vLv+qmM1gs5SvJcjmK2FM8XrAILZqBARfU86TUr+uJMC9kkedLHEPfu2F5Kss+aqzC rTRH/y4SO3V9IvB04CYPrz1zgA3/mqJ64QOpfCAEqaxQ6d1HC6ElQD16k9ie0cFLyEkR n3daz3C/dsHyS4kinD53A48i96e8VCpsgGiL+RexcurTI3z2SJWd/00j2XsTu30/hJcw Au4EiE9oC0xP3zedUi25jYD9s3NqYQUOgp9S3MvRTzL1y7WlCalIpRas5fcQoYPZv3og vJZVYCYcRLQGB0Qlc6dXo3DaYKcka1J12oMMjvPfEVeHzrbYuu5ybYH8K/G3tk5Y1XT7 m8EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706805253; x=1707410053; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n/co6X+OBGIXd4eG658fCiXjsMHAkcaBk+VnBBaSvfM=; b=osXi3zkT32fP67MQMmkrf3RoSzscWyj+O8ZLoAjqbFLbOInSTgDJ5JbJ8f55ZqdgT8 yglj91cosPkahzelLZsWGYRB34pZn+76BMJKw3VvSHBMHK8gjpnBz//BZI7ZVF1hojDT jmpwvN8qHZdBMLUTNeWp5ludHnmd94/SBrW8tk9n76Nsz6IWQyA7XklRtOsQGR+vw7aj aJ6QXQ3pPEmnHorafQYsVkD2xOjRBdTOt0cd6Dj7XJzYIN/hjeV/9+JLfWyBSZUQ9L3r DK5CTKPPyt4Xq0+7PqdVnimBzRQaK0gPG8tbi/6EbKMqiMCgCvBEAQJsbdvfqrowMOyC O7HA== X-Gm-Message-State: AOJu0YyWs+ObHbAxtGgw0/N8KOXFTkEmxGiKSlvYIKdiL0BcdI/W2zdd xLL9QmIkS/pdSGfY9CytCV3tjYDLEiS8Rqzo8U0I9vSkBALvw/KFBslGlAC6zQF8r+LWDsjoNiO c15sArLfeQJ08X4jU4t1AipvL6X2o7UGMejyBLgrM5kgVDtdmjys= X-Google-Smtp-Source: AGHT+IFuHibJad/SXMvyJbq3C9+vpMWiptJC0ekrlVRuy9xZtHCe4T5+OoixjNH6/HnoB5xXPtU+frb/K70GtiB0bvs= X-Received: by 2002:a05:6870:350e:b0:218:d3a2:1c2c with SMTP id k14-20020a056870350e00b00218d3a21c2cmr2666982oah.24.1706805253464; Thu, 01 Feb 2024 08:34:13 -0800 (PST) MIME-Version: 1.0 References: <20240108132432.901738-1-mary.bennett@embecosm.com> <20240116105425.1247721-1-mary.bennett@embecosm.com> In-Reply-To: <20240116105425.1247721-1-mary.bennett@embecosm.com> From: Nelson Chu Date: Fri, 2 Feb 2024 00:34:02 +0800 Message-ID: Subject: Re: [PATCH v4 0/3] RISC-V: Support CORE-V XCVELW, XCVBI, and XCVMEM extensions To: Mary Bennett Cc: binutils@sourceware.org Content-Type: multipart/alternative; boundary="000000000000d594950610549083" X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d594950610549083 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jan 16, 2024 at 6:56=E2=80=AFPM Mary Bennett wrote: > v3 -> v4: > * Remove trailing white space > * Since the XCVbi instructions uses a relocation, linker tests were > added. I think it best if we keep them just to prove that the CORE-V > instructions are correct. > I don't think keeping the ld testcase is necessary since you don't add any new relocation. The cv.beqimm uses R_RISCV_BRANCH, and only changes the assembler code, so adding an assembler testcase with readelf or objdump -dr should be the right way to go. Unless the cv.beqimm changes the R_RISCV_BRANCH behavior and need a new relocation, otherwise no ld testcase required. Thanks Nelson --000000000000d594950610549083--