From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id E344A382AD71 for ; Tue, 5 Dec 2023 06:45:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E344A382AD71 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E344A382AD71 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::32d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701758745; cv=none; b=a1OVYr+00M69fOTcra4SsC7CPgcGpkGUpp7iCNceDcw5CCTpZol6nKYitdjWGY3+1wcAOL4BIWkZ+TSIK1LUPC68uwO6N9s57sIHp1nstxRK17+XZ5kDNkw2NeVQvrClJOZHs/YIrmJxQs3qHtJjXXhJUyaird+ToAmXNjpMyVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701758745; c=relaxed/simple; bh=GlLMvj1xhdx+Xz4pvUcTAd6BQzxKLlvQMCOEKQl+7wQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=vidmWTnCnW4XLBVpBqsh6n7Z3utJnJ2VZCoFC2eATYWBl6f3k6cafJe/Vnw4sZGWbhaGTUIrBJcZvFLjRfoooe/axAbu5bBTiutsLzIrH6hee7Vj3KYQBMfhCflYDNh/2ci2HJHZCE0AaMuCzA1uI9Lv4S1YG2qe3vELS1U4O30= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x32d.google.com with SMTP id 46e09a7af769-6d8029dae41so2920772a34.0 for ; Mon, 04 Dec 2023 22:45:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1701758734; x=1702363534; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sjGfr+rCX82TqGVeWUWeitcOm6XCfi/0ZwJwr4zPMPU=; b=ymjZJe66ayCkJo2OYp9x1MjtExVwJqhwtz5BV1Cg9zg04EF/cpuxjMWBtUqjPX9WRu 2lGMPb1eilJdOEfVKvd73LCQa5hbrpyaz/vYHsKQb3f59lEkpr+1SzXi+T45gRTBEdqP 3eKa9f/IPyP7e2kuQZs7ONcV/xqSVV7B1qCNoaDdymAD2P8o+Z8l6V7+AW5XO/WjqdSp KX1PoL68qrGlc+BpotAn5KINU+myfRZRKmNB+xGQD0vMnIoxo9Djba83VTtDFgtr8w4F tiFW12bmmeupiuKdnyg221BfVQQw9UEWefJ2a0grd2DoemJgDrXTFmsr0fUFhrJPOzS6 BiDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701758734; x=1702363534; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sjGfr+rCX82TqGVeWUWeitcOm6XCfi/0ZwJwr4zPMPU=; b=guSWo0OPwP/jveJ71MSyg85CgQ4AxFbXjjQWfibdJBD3bYEwenstDhLuKewhh0wBHV i93J0PBHS/yJd5/55vXSbe264ZIwwPVoHtYv8HnsapeaxSY4jrDiFVz0Zmq15+pf3y65 I5w8AvnTJ1UOJDM1pZhyhXZC+CxAbvOMWGxBNrCabMMPJGuBn8AXMVIvzdXSOz2w0nHo zLJlI6M0vpu8+tiyqLCkph6CMymGQ+V4W4s90jhj1w/3o2QHr0inuNeMM54imrYyrt+w wlvHxeyrPIkgILIkBlAFxGUiH+Kqyg4VDTeACgwv8/23rC+5vxABZODuLL+4acv/x+5P j4Gg== X-Gm-Message-State: AOJu0Yz9Fo3rleWDsVyPxbehtB0gulzqDPtLPQlpSAqFZGQ4nFYoRroQ EXoj91JH2X4xx/UANlRmGEAjfQIiZTbOlNaXEXE2afxac+P9n/Th X-Google-Smtp-Source: AGHT+IGLatuwoYZc3zjPa2h35Zv4MUsNzkw4y/dZ6nJKxKkK20QkCpkpe2I2hJc9bCwY93WUOT+VREz0wC2O01mlmAc= X-Received: by 2002:a05:6871:8191:b0:1fb:75b:1300 with SMTP id so17-20020a056871819100b001fb075b1300mr5475478oab.82.1701758734003; Mon, 04 Dec 2023 22:45:34 -0800 (PST) MIME-Version: 1.0 References: <20230906200134.1033297-2-pjones@redhat.com> In-Reply-To: From: Nelson Chu Date: Tue, 5 Dec 2023 14:45:23 +0800 Message-ID: Subject: Re: [PATCH] Handle "efi-app-riscv64" and similar targets in objcopy. To: Palmer Dabbelt Cc: pjones@redhat.com, binutils@sourceware.org, schwab@suse.de Content-Type: multipart/alternative; boundary="000000000000d587d7060bbd94b7" X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d587d7060bbd94b7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Committed since passed the regressions of riscv-gnu-toolchain. Thanks Nelson On Tue, Dec 5, 2023 at 1:16=E2=80=AFAM Palmer Dabbelt = wrote: > On Wed, 06 Sep 2023 13:01:34 PDT (-0700), pjones@redhat.com wrote: > > This adds the efi target name handling for riscv64 to objcopy. > > > > binutils: > > * binutils/objcopy.c: add riscv64 handling to > > convert_efi_target() > > > > Signed-off-by: Peter Jones > > --- > > binutils/objcopy.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/binutils/objcopy.c b/binutils/objcopy.c > > index 2ce1b07bf7c..b64cbee3dd7 100644 > > --- a/binutils/objcopy.c > > +++ b/binutils/objcopy.c > > @@ -5129,6 +5129,11 @@ convert_efi_target (char **targ) > > /* Change aarch64 to aarch64-little. */ > > memcpy (pei + 4 + sizeof ("aarch64") - 1, "-little", sizeof > ("-little")); > > } > > + else if (strcmp (efi + 4, "riscv64") =3D=3D 0) > > + { > > + /* Change riscv64 to riscv64-little. */ > > + memcpy (pei + 4 + sizeof ("riscv64") - 1, "-little", sizeof > ("-little")); > > + } > > *targ =3D pei; > > return subsys; > > } > > Sorry I missed this, David just poked me. > > Reviewed-by: Palmer Dabbelt > Acked-by: Palmer Dabbelt > > Thanks! > --000000000000d587d7060bbd94b7--