From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by sourceware.org (Postfix) with ESMTPS id 51D963858422 for ; Tue, 15 Aug 2023 06:27:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 51D963858422 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-1c0fff40ec6so3446631fac.2 for ; Mon, 14 Aug 2023 23:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1692080854; x=1692685654; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=R1i/o+dgqrwZK1lkAANgP/wb53El6DILenhF0w9JrsY=; b=Dx3n3lvitDprFgwyfugIGNVgl4bFHRxxYf9eCvfBeD/XzYxUpCBSuQZj7h8+2wvyAp jo8oWagvVX+bvEWi9W7d+hcz+Y5XaHVyMEYO+kYk2VUtTUVI7wDqsTVXbjpmdsKMndFr tYSyFxQkEe7alFS66D8YO66TWeT+gSQMNBb7loUqBgIcpgkPgGbB20RCb4w4izBSjBXB hzUJw6VwSSGG60T5U8wVZn66ubhOD+N26BwwPuo4wrtg/PCPcdgbAsvliCD2sRd75cSt d5Z80Df4BcIBxsHwQ0WN2B4NA8+z+C4WnA/a+DNzjVcRfiF9R6u3tLgFZ0jrJ87GltIP bYBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692080854; x=1692685654; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R1i/o+dgqrwZK1lkAANgP/wb53El6DILenhF0w9JrsY=; b=DUyuyb9jUC+cOSTi6vAgbLp1V7P2KXjHRICcLITQqU3IHt/4Kx+IkMCNH6uwJyZVqE lfxijHK6nMyoXSZ7O/8fh+A3SEZYl5/l5J1sMzzzYcKhVBsd2wjHE/kdDweJyqSI/rwQ 9D9tYekQ4tpJ0919Pfv6sEXWAK3MNBPUY83tc6h5O0f3KxOSlabFB9rUvBGJGnuMrCLZ nanXotLzd0t1bbNMkDqZ4sY1ynvX9+bwx2+Qfp7ieemuoOasa4bQmnSIJMUDSrgpu/2B /qlSSWhrELmG+3u34j45cNjuWGWU1wJb1bhBIFEfWMwwWkz2toyYM/SG3qtdNueC4m9O Kgkw== X-Gm-Message-State: AOJu0Yw7gyj2N9c48QPbQLUj945vMbuXh/eN5rvZKO5bN9C39PsL75+n jKkOUxMGlCEeQM0cBKn1pmrH6ghOqKaTfgFM+Zm76Q== X-Google-Smtp-Source: AGHT+IGzD2/AMF4TR3CMeVdTEU8hihWzruQcdtAAobRDOck1wr0MQU5SUdV7Xu+jzbwwe+xKcj5Yx+FknUDxBHTzz78= X-Received: by 2002:a05:6870:a107:b0:1b0:7eac:70ad with SMTP id m7-20020a056870a10700b001b07eac70admr13062654oae.39.1692080854698; Mon, 14 Aug 2023 23:27:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nelson Chu Date: Tue, 15 Aug 2023 14:27:24 +0800 Message-ID: Subject: Re: [PING^1][PATCH] RISC-V: Make T-Head testing pattern more generic To: Tsukasa OI Cc: Kito Cheng , Palmer Dabbelt , binutils@sourceware.org Content-Type: multipart/alternative; boundary="00000000000046a35e0602f046d0" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,HTML_MESSAGE,KAM_LOTSOFHASH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000046a35e0602f046d0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable OKay, thanks. Nelson On Fri, Aug 11, 2023 at 5:27=E2=80=AFPM Tsukasa OI wrote: > Ping (from the last year). > > On 2022/12/29 12:51, Tsukasa OI wrote: > > From: Tsukasa OI > > > > On some T-Head vendor extensions, we test against the constant > > 18446744073709551615 (2**64-1) to detect invalid immediate errors on -1. > > However, it heavily depends on the fact that the value used to print > > immediate value is a 64-bit unsigned type and this constant is not (and > > should not be) important (we just want to know that -1 is not valid). > > > > This commit replaces all such occurrences of 18446744073709551615 with > > a more generic regular expression. > > > > gas/ChangeLog: > > > > * testsuite/gas/riscv/x-thead-ba-fail.l: Replace > > 18446744073709551615 with generic regular expression. > > * testsuite/gas/riscv/x-thead-bb-fail.l: Likewise. > > * testsuite/gas/riscv/x-thead-bs-fail.l: Likewise. > > * testsuite/gas/riscv/x-thead-fmemidx-fail.l: Likewise. > > * testsuite/gas/riscv/x-thead-memidx-fail.l: Likewise. > > * testsuite/gas/riscv/x-thead-mempair-fail.l: Likewise. > > --- > > gas/testsuite/gas/riscv/x-thead-ba-fail.l | 2 +- > > gas/testsuite/gas/riscv/x-thead-bb-fail.l | 4 ++-- > > gas/testsuite/gas/riscv/x-thead-bs-fail.l | 2 +- > > gas/testsuite/gas/riscv/x-thead-fmemidx-fail.l | 16 ++++++++-------- > > gas/testsuite/gas/riscv/x-thead-memidx-fail.l | 6 +++--- > > gas/testsuite/gas/riscv/x-thead-mempair-fail.l | 10 +++++----- > > 6 files changed, 20 insertions(+), 20 deletions(-) > > > > diff --git a/gas/testsuite/gas/riscv/x-thead-ba-fail.l > b/gas/testsuite/gas/riscv/x-thead-ba-fail.l > > index 4bb12e7f6423..bfafe4590e5f 100644 > > --- a/gas/testsuite/gas/riscv/x-thead-ba-fail.l > > +++ b/gas/testsuite/gas/riscv/x-thead-ba-fail.l > > @@ -1,3 +1,3 @@ > > .*: Assembler messages: > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > diff --git a/gas/testsuite/gas/riscv/x-thead-bb-fail.l > b/gas/testsuite/gas/riscv/x-thead-bb-fail.l > > index dd4a0df664eb..cde1c22ad253 100644 > > --- a/gas/testsuite/gas/riscv/x-thead-bb-fail.l > > +++ b/gas/testsuite/gas/riscv/x-thead-bb-fail.l > > @@ -1,7 +1,7 @@ > > .*: Assembler messages: > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(64\) > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(32\) > > .*: Error: illegal operands `th.ext a0,64,62' > > .*: Error: illegal operands `th.extu a0,-1,0' > > diff --git a/gas/testsuite/gas/riscv/x-thead-bs-fail.l > b/gas/testsuite/gas/riscv/x-thead-bs-fail.l > > index c8a7ff4e7f14..200218480c84 100644 > > --- a/gas/testsuite/gas/riscv/x-thead-bs-fail.l > > +++ b/gas/testsuite/gas/riscv/x-thead-bs-fail.l > > @@ -1,3 +1,3 @@ > > .*: Assembler messages: > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(64\) > > diff --git a/gas/testsuite/gas/riscv/x-thead-fmemidx-fail.l > b/gas/testsuite/gas/riscv/x-thead-fmemidx-fail.l > > index 33cddac856e5..4d40f66f3998 100644 > > --- a/gas/testsuite/gas/riscv/x-thead-fmemidx-fail.l > > +++ b/gas/testsuite/gas/riscv/x-thead-fmemidx-fail.l > > @@ -1,19 +1,19 @@ > > .*: Assembler messages: > > .*: Error: illegal operands `th.flrd a0,a1,a2,0' > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > > > diff --git a/gas/testsuite/gas/riscv/x-thead-memidx-fail.l > b/gas/testsuite/gas/riscv/x-thead-memidx-fail.l > > index c6bd25c0268c..44ca58bbf2cd 100644 > > --- a/gas/testsuite/gas/riscv/x-thead-memidx-fail.l > > +++ b/gas/testsuite/gas/riscv/x-thead-memidx-fail.l > > @@ -1,14 +1,14 @@ > > .*: Assembler messages: > > .*: Error: improper immediate value \(-17\) > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(16\) > > .*: Error: improper immediate value \(4\) > > > > .*: Error: illegal operands `th.ldia a0,\(a0\),0,0' > > .*: Error: illegal operands `th.ldib a0,\(a0\),0,0' > > > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > diff --git a/gas/testsuite/gas/riscv/x-thead-mempair-fail.l > b/gas/testsuite/gas/riscv/x-thead-mempair-fail.l > > index 32d98f475017..be3965559047 100644 > > --- a/gas/testsuite/gas/riscv/x-thead-mempair-fail.l > > +++ b/gas/testsuite/gas/riscv/x-thead-mempair-fail.l > > @@ -5,23 +5,23 @@ > > .*: Error: illegal operands `th.sdd a0,a1,\(a2\),3' > > .*: Error: illegal operands `th.swd a0,a1,\(a2\),0' > > > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > .*: Error: unexpected literal \(3\) > > > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > .*: Error: unexpected literal \(4\) > > > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > .*: Error: unexpected literal \(4\) > > > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > .*: Error: unexpected literal \(3\) > > > > -.*: Error: improper immediate value \(18446744073709551615\) > > +.*: Error: improper immediate value \(-?\d+\) > > .*: Error: improper immediate value \(4\) > > .*: Error: unexpected literal \(4\) > > > > > > base-commit: dc20b8f00abb74e2c26846c615ec5ba3a62f8677 > --00000000000046a35e0602f046d0--