From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 824FF3858422 for ; Tue, 15 Aug 2023 06:23:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 824FF3858422 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-ot1-x335.google.com with SMTP id 46e09a7af769-6bd0c953fd9so3492543a34.3 for ; Mon, 14 Aug 2023 23:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1692080590; x=1692685390; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fr8xGAXdTpAi07Bl7lL5FjrTNlD9S8iHS8BEvOUhXp4=; b=ktjFJlnnB7ZXtY9GdHCuaZL8IpIO2rq6QzcA/efKSB2vLoEFdYYeM+TEpSGXcTOGC3 9oliefPLkBZeHKAWQyXGHOWAxQpgmwlC6QUeaX/L8L9RI1a0F1Ugcgc/RY2AOr+1HDb6 Sv22fqnxi7UMIMY7JZwUiQZbblpBJbsfhCKK3aq5WDDcgStUdPG5IDzx8W2J7cE+XNxn wUys5q+DWD/c0C/PgXS3vDGBmF+IUdN3oX6siSoOUOPzK7JMo2ffWb5Juj79VfqPweZ0 Xith/kDXJbfYOeBKw8yyiYguoQXzsUr2R5h9TMe8fiGZQ1hZ+5NmFZ6nksgcWb3HHuoG BGsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692080590; x=1692685390; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fr8xGAXdTpAi07Bl7lL5FjrTNlD9S8iHS8BEvOUhXp4=; b=RugrG4M6RcnNVt89VAP2U1ZFGf9H5war8DywTkZTRGv1Ah8LDzYDTqQsGRiPd3SYAP ZRhWF5ET5GAfFKRo9E8gwfvXxGnoarZ2e3KBsNmWvL83fzNGrpPrBkgt5nYkAZo9Hh26 PDld/NrCSTh2UUOaxf6XcjnsMbmg+xR6o8z1Pakv25Ka8cHxHUvxEPxjF35FNK+G5gWf PNW8WTNUm9/xgLtN8bpYFar87iEDK8+n/W65CVKNdOtQbVmPMkkFCYtnxURfPD1hGlv5 kqQT16hIfTy2l6GjASrXfMixdKqLmvwsehlK2JTA8taGf8Psd87/AmuQm532ZpADGyvv bb5w== X-Gm-Message-State: AOJu0Yz+/jvL6Lx9DaR/9vCcKNwKu1oA/kPIyyBafHlHPa3z9RTQ/6ng brMrDtS0l8bpD2dbSg38cdx4Cm+WqYrybn2QjVd7k9x9ytRJTGf7deU= X-Google-Smtp-Source: AGHT+IHAgsZ5XVOb4hQeu1VEaFTER2ss8SBU6xsXqatsT6PRx2VGR4wu9aPZNKMDVTe1GuE+hOFQEMbvu8F+MlI04tQ= X-Received: by 2002:a05:6871:5d3:b0:1be:cca5:3df6 with SMTP id v19-20020a05687105d300b001becca53df6mr10404030oan.35.1692080589792; Mon, 14 Aug 2023 23:23:09 -0700 (PDT) MIME-Version: 1.0 References: <59e21b61a95f323f0771e528c23166f110e2e19d.1691805058.git.research_trasio@irq.a4lg.com> In-Reply-To: <59e21b61a95f323f0771e528c23166f110e2e19d.1691805058.git.research_trasio@irq.a4lg.com> From: Nelson Chu Date: Tue, 15 Aug 2023 14:22:59 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Add "OP_P" to .insn named opcodes To: Tsukasa OI Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Kito Cheng , binutils@sourceware.org Content-Type: multipart/alternative; boundary="0000000000007c7c2f0602f0365a" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007c7c2f0602f0365a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Aug 12, 2023 at 9:51=E2=80=AFAM Tsukasa OI wrote: > From: Tsukasa OI > > This commit adds "OP_P" (OP-P: packed SIMD instruction opcode intended for > the 'P' extension but its use is first approved for the vector cryptograp= hy > specification) to .insn opcode name list. Although vector / packed SIMD > instruction encodings are not implemented in `.insn' directive, it will > help > future implementation of custom vector / packed SIMD `.insn'. > > gas/ChangeLog: > > * config/tc-riscv.c (opcode_name_list): Add "OP_P". > * testsuite/gas/riscv/insn.s: Add "OP_P" vector crypto testcase. > * testsuite/gas/riscv/insn.d: Likewise. > * testsuite/gas/riscv/insn-na.d: Likewise. > * testsuite/gas/riscv/insn-dwarf.d: Reflect insn.s update. > --- > gas/config/tc-riscv.c | 2 +- > gas/testsuite/gas/riscv/insn-dwarf.d | 43 ++++++++++++++-------------- > gas/testsuite/gas/riscv/insn-na.d | 3 +- > gas/testsuite/gas/riscv/insn.d | 3 +- > gas/testsuite/gas/riscv/insn.s | 1 + > 5 files changed, 28 insertions(+), 24 deletions(-) > > diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c > index aaf8b9be64fd..64eba22ddf29 100644 > --- a/gas/config/tc-riscv.c > +++ b/gas/config/tc-riscv.c > @@ -867,7 +867,7 @@ static const struct opcode_name_t opcode_name_list[] = =3D > /*reserved 0x5b. */ > {"JAL", 0x6f}, > {"SYSTEM", 0x73}, > - /*reserved 0x77. */ > + {"OP_P", 0x77}, > Refer to the draft isa spec, https://github.com/riscv/riscv-isa-manual/blob/d145558f954f51eeef81655e9b07= 4f87e6fbb92a/src/rv-32-64g.adoc#L23 I still the 0x77 is reserved. Do you have any plans that try to update the spec first? Thanks Nelson > {"CUSTOM_3", 0x7b}, > /* >80b 0x7f. */ > > diff --git a/gas/testsuite/gas/riscv/insn-dwarf.d > b/gas/testsuite/gas/riscv/insn-dwarf.d > index b8bd42dff18c..53fb85eb4625 100644 > --- a/gas/testsuite/gas/riscv/insn-dwarf.d > +++ b/gas/testsuite/gas/riscv/insn-dwarf.d > @@ -60,27 +60,28 @@ insn.s +53 +0x9a.* > insn.s +54 +0x9e.* > insn.s +55 +0xa2.* > insn.s +57 +0xa6.* > -insn.s +59 +0xaa.* > -insn.s +60 +0xac.* > +insn.s +58 +0xaa.* > +insn.s +60 +0xae.* > insn.s +61 +0xb0.* > -insn.s +62 +0xb6.* > -insn.s +63 +0xbe.* > -insn.s +64 +0xc8.* > -insn.s +65 +0xd4.* > -insn.s +66 +0xea.* > -insn.s +67 +0xec.* > +insn.s +62 +0xb4.* > +insn.s +63 +0xba.* > +insn.s +64 +0xc2.* > +insn.s +65 +0xcc.* > +insn.s +66 +0xd8.* > +insn.s +67 +0xee.* > insn.s +68 +0xf0.* > -insn.s +69 +0xf6.* > -insn.s +70 +0xfe.* > -insn.s +71 +0x108.* > -insn.s +72 +0x114.* > -insn.s +74 +0x12a.* > -insn.s +75 +0x134.* > -insn.s +76 +0x13e.* > -insn.s +77 +0x154.* > -insn.s +78 +0x16a.* > -insn.s +79 +0x180.* > -insn.s +80 +0x196.* > -insn.s +81 +0x1ac.* > -insn.s +- +0x1c2 > +insn.s +69 +0xf4.* > +insn.s +70 +0xfa.* > +insn.s +71 +0x102.* > +insn.s +72 +0x10c.* > +insn.s +73 +0x118.* > +insn.s +75 +0x12e.* > +insn.s +76 +0x138.* > +insn.s +77 +0x142.* > +insn.s +78 +0x158.* > +insn.s +79 +0x16e.* > +insn.s +80 +0x184.* > +insn.s +81 +0x19a.* > +insn.s +82 +0x1b0.* > +insn.s +- +0x1c6 > #pass > diff --git a/gas/testsuite/gas/riscv/insn-na.d > b/gas/testsuite/gas/riscv/insn-na.d > index 55bf301656b2..d43f07906fe4 100644 > --- a/gas/testsuite/gas/riscv/insn-na.d > +++ b/gas/testsuite/gas/riscv/insn-na.d > @@ -1,4 +1,4 @@ > -#as: -march=3Drv32ifcv > +#as: -march=3Drv32ifcv_zvkned > #source: insn.s > #objdump: -dw -Mno-aliases > > @@ -59,6 +59,7 @@ Disassembly of section .text: > [^:]+:[ ]+00c58533[ ]+add[ ]+a0,a1,a2 > [^:]+:[ ]+00c58533[ ]+add[ ]+a0,a1,a2 > [^:]+:[ ]+022180d7[ ]+vadd\.vv[ ]+v1,v2,v3 > +[^:]+:[ ]+a2402177[ ]+vaesdm\.vv[ ]+v2,v4 > [^:]+:[ ]+0001[ ]+c\.addi[ ]+zero,0 > [^:]+:[ ]+00000013[ ]+addi[ ]+zero,zero,0 > [^:]+:[ ]+001f 0000 0000[ ].* > diff --git a/gas/testsuite/gas/riscv/insn.d > b/gas/testsuite/gas/riscv/insn.d > index 89e076d126d0..fc3d0437c1d0 100644 > --- a/gas/testsuite/gas/riscv/insn.d > +++ b/gas/testsuite/gas/riscv/insn.d > @@ -1,4 +1,4 @@ > -#as: -march=3Drv32ifcv > +#as: -march=3Drv32ifcv_zvkned > #objdump: -dr > > .*:[ ]+file format .* > @@ -70,6 +70,7 @@ Disassembly of section .text: > [^:]+:[ ]+00c58533[ ]+add[ ]+a0,a1,a2 > [^:]+:[ ]+00c58533[ ]+add[ ]+a0,a1,a2 > [^:]+:[ ]+022180d7[ ]+vadd\.vv[ ]+v1,v2,v3 > +[^:]+:[ ]+a2402177[ ]+vaesdm\.vv[ ]+v2,v4 > [^:]+:[ ]+0001[ ]+nop > [^:]+:[ ]+00000013[ ]+nop > [^:]+:[ ]+001f 0000 0000[ ].* > diff --git a/gas/testsuite/gas/riscv/insn.s > b/gas/testsuite/gas/riscv/insn.s > index 48db59b14e88..915b7ecc9634 100644 > --- a/gas/testsuite/gas/riscv/insn.s > +++ b/gas/testsuite/gas/riscv/insn.s > @@ -55,6 +55,7 @@ target: > .insn r 0x33, 0, 0, fa0, fa1, fa2 > > .insn r OP_V, 0, 1, x1, x3, x2 > + .insn r OP_P, 2, 0x51, x2, x0, x4 > > .insn 0x0001 > .insn 0x00000013 > > base-commit: 6a6859cbff7ac3fcf81689c47d19e716e9bbac2a > -- > 2.41.0 > > --0000000000007c7c2f0602f0365a--