From: Nelson Chu <nelson@rivosinc.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>
Subject: Re: [PATCH] RISC-V: Zicbo{m,p,z} adjustments to riscv_multi_subset_supports_ext()
Date: Fri, 14 Oct 2022 09:19:19 +0800 [thread overview]
Message-ID: <CAPpQWtDkKU6d_M7GXyQZQ+ijOY5uKipCrCobj2vCS7G69LkPTQ@mail.gmail.com> (raw)
In-Reply-To: <ffa9c1d7-e8c2-a62b-ef3e-b565c0ffbe5b@suse.com>
Looks reasonable, please commit, thanks.
Nelson
On Tue, Oct 4, 2022 at 9:56 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> The lack thereof did caused gas to issue "internal: unreachable
> INSN_CLASS_*" errors when trying to assemble respective insns without
> the feature(s) enabled via e.g. ".option arch, ...". Of course a proper
> hint towards the missing extension then wasn't given either.
>
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -2440,6 +2440,12 @@ riscv_multi_subset_supports_ext (riscv_p
> {
> case INSN_CLASS_I:
> return "i";
> + case INSN_CLASS_ZICBOM:
> + return "zicbom";
> + case INSN_CLASS_ZICBOP:
> + return "zicbop";
> + case INSN_CLASS_ZICBOZ:
> + return "zicboz";
> case INSN_CLASS_ZICSR:
> return "zicsr";
> case INSN_CLASS_ZIFENCEI:
prev parent reply other threads:[~2022-10-14 1:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 13:56 Jan Beulich
2022-10-04 16:08 ` Tsukasa OI
2022-10-06 4:50 ` Tsukasa OI
2022-10-14 1:19 ` Nelson Chu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPpQWtDkKU6d_M7GXyQZQ+ijOY5uKipCrCobj2vCS7G69LkPTQ@mail.gmail.com \
--to=nelson@rivosinc.com \
--cc=andrew@sifive.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).