From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by sourceware.org (Postfix) with ESMTPS id F0D003858401 for ; Tue, 12 Dec 2023 09:38:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0D003858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F0D003858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702373917; cv=none; b=IiB8wPXe4XdNgne8A+d7plQz5BtndWxGJQeEPvvuZk4YFiVmTSF4G2oJmu9SjlMQviwP4qfAe6jb7oGzsDugSy2Pv5YhaU+H32bFxDqiNssvUzeNiZtlF0602ddb37T0pXf0inSQifhw28LVCpTh3x7+qQFauj+IJDV1GUrVX+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702373917; c=relaxed/simple; bh=E1WA7qK1pEbbYOg8uVjwUixpQtRkR9o6emMKhLdqQ0Y=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=fJl/2xuf1B9GJhHDIlGfRXcLkt19wtqsrYxqaHCbo8xObPsGjJCk5xnsNbCBusYRQUFUHKu7AF6UMjJUCbdBwsV451myhrS7VgET5iPek0WmRN4YyyQbHvrjKlBWr2uWrAcw+dGKgV9h2+sgaRPFn7dI7WXEaH6SoVi/mhNm8H0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-202d6823844so991965fac.2 for ; Tue, 12 Dec 2023 01:38:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1702373914; x=1702978714; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wsnEZwZ+sHrRL7vj6IbCFZkkkKh6bzsLLPFIEV6oRSQ=; b=wcAwnKBuxwOdk59qAg/soJzQ4jb0NLh0oPlVRAsPXf0uKAGP7t5dofTwK/HwUKCjGP g8ZyNta5Bp5/Xne7PhSKnNX0GakxSEyNbW5zXweT/Iv7HeVwdeZ+6dF/9wzuOjWZkQHl QSEpGwkE8uK8tyDDCH1HmSOG9TUVZJZYIOwUtTb+8WNjRuVvUnJV454YkastBxmGqsqk QGJ54tiwMi2iFFAHkS8Z/IwUxrftYxcVg19Gor7EdVclgH7iSY3dS80LCcv4WEac/UB1 IW+TmLsrYKtoWk5dm0Amb1RvJ1xIovEN6ndnL4RlVUpomnpwkXvmu398i7y5oog27/R3 MKCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702373914; x=1702978714; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wsnEZwZ+sHrRL7vj6IbCFZkkkKh6bzsLLPFIEV6oRSQ=; b=oFM0hXgOHV2VPvtHU7RdpMoOGqQpv65dmmVoo2EsPeN0ig0ZRZ//nG/3QAmKIz6iN6 3STMNvwl9c+qRsKXdvhsVhdBhJJIJdWWs47OHZ+ntGPHhbBioXxw+rgrPS+OjfgEu0c3 vGmPssGdm7ZwIijngC1FqdjC6wpOkHEOYzoEMtWyJnTJDE2Q0Q30OBDertTfNDgDG0x4 Nap3CqmkhG3CQ8nYCA0TXURtS0xFWUNzqpzHJflmnvim/HAuCRJWisU5ayfMT6evIUV9 eDe8Yipqx86Fge9+CmV8euuC6laBuchZ3nikW7X8ynJRvu5k9K5o/ZDMx/ISeBItDfVp 9YLw== X-Gm-Message-State: AOJu0YwKR3ptKhMQfjI471AJZetGa03EdKg8JgAPkl8gLVyxhtnyjU20 dLScK3RfsxTFUyqnE2FLZV+YHOmxcpPS/8I+qjapHos+jyHmGwgAYqE= X-Google-Smtp-Source: AGHT+IHdeVCKNHQSsbGyHS8fY1ntawyIkp+hiYyibWQQB/lYd6Ua1I2WtuI3dc+wJHBPqGeK+oBaAnjN6vSMGZ3L5ac= X-Received: by 2002:a05:6870:b605:b0:1fa:fcd5:9bb6 with SMTP id cm5-20020a056870b60500b001fafcd59bb6mr7285878oab.22.1702373914661; Tue, 12 Dec 2023 01:38:34 -0800 (PST) MIME-Version: 1.0 References: <20230920083124.2072273-1-ruiu@bluewhale.systems> In-Reply-To: From: Nelson Chu Date: Tue, 12 Dec 2023 17:38:23 +0800 Message-ID: Subject: Re: [PATCH v2] RISC-V: emit R_RISCV_RELAX for the la pseudo instruction To: Rui Ueyama Cc: Rui Ueyama , binutils@sourceware.org Content-Type: multipart/alternative; boundary="000000000000756a69060c4cd012" X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000756a69060c4cd012 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 12, 2023 at 2:40=E2=80=AFPM Rui Ueyama wrote: > https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/397 has been > merged. > I also completed the copyright assignment form. > > Could you merge this patch? > Sure, Thanks for helping to push this through. On Tue, Dec 12, 2023 at 5:25=E2=80=AFPM Andreas Schwab wro= te: > On Sep 20 2023, Rui Ueyama via Binutils wrote: > > > @@ -4049,6 +4057,13 @@ md_apply_fix (fixS *fixP, valueT *valP, segT seg > ATTRIBUTE_UNUSED) > > break; > > > > case BFD_RELOC_RISCV_GOT_HI20: > > + /* R_RISCV_GOT_HI20 and the following R_RISCV_LO12_I are relaxab= le > > + only if it is created as a result of la or lga assembler macros. > */ > > + if (fixP->tc_fix_data.source_macro =3D=3D M_LA || > > + fixP->tc_fix_data.source_macro =3D=3D M_LGA) > > Line break before the operator, not after. Thanks, committed with updated ChangeLog/messages and this line break fix. Nelson --000000000000756a69060c4cd012--