From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by sourceware.org (Postfix) with ESMTPS id 29BA9384D99E for ; Fri, 18 Nov 2022 09:34:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 29BA9384D99E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-13ae8117023so5301260fac.9 for ; Fri, 18 Nov 2022 01:34:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VQVQQiNS/ByHRzvCinhN6T20g27PU9rcrUK1i4zro18=; b=ZYpCAwXOmrETwOHgBFhN+cBmm/9Y4k+KBKGj8j131pBQmIZgbqgaroHVrqCCKJI1EB JwQd6zkcvdA0JWbYDQ+We/+u/NZcq5t/WKYPgUwdbD/729+giIKmgGfxIFU0Ni4PSQAS GYC/z73hkrAjE3kk2S8g47DmXesfvuEFNqP4zS+HOXO9bbDPiwY6BGxVYY/65tTMrJWN gsTPezFvjRVvssYMs/RWQeOBrFMWY+5akojQHFvUzOhqx9Z4JgVRvAgVggkOFQTTzHaa eWC+eynkqxJYhuTovaQKo3kEQdiupqq5LEqWejupwRnDfIeV9ouiZUMC9vkRqDteY3JD xjIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VQVQQiNS/ByHRzvCinhN6T20g27PU9rcrUK1i4zro18=; b=xBwIUHmc8jTT56jhej7jdRWeIiLpfBPXTXbVbOmd1kkllZB8IttkJadycc18o8I+Jw 9V5HK4z6ZI92RxIAtbZJ5I2HvX+ImsDm56PrC/Vc7+yhYObeAOUtXuygc/6ua82Qt/nn ih2XXdsFd4vdHWTVdG6OPOQFnzIV3cH/6UX8OPumwkLJ5e0RuL/oLouhY2VZSoOkm8Pf 0gujxt08VPYatnZp1HJohGDy+S6zWnNzdd+MrpPLXIUkjzv0Ver0adVBdDp26SqzmhmL bqWDVqyp2Q+m/weZj2dD761JCLItaUJ4iX4yCO8he5JIM4dy/bW26WLC9sml1eC1JjvH dlJQ== X-Gm-Message-State: ANoB5pm0bDwcyMXPixP6Q2yMaQfawbD9t1QY6utXeW9fAEmFpE8cfZTw nwmwTrmxxdAgliy81NN+JTU0r72PoVzssrdxNKXqhpNcRDstBQ== X-Google-Smtp-Source: AA0mqf5VIqxP3z7ChsCCuXPoEqLvFWOgY0wa1BEbowTKAC9Ja7j91WKqhEnammWRooJuVIWOhd+TVML5gAEDWxLhdWg= X-Received: by 2002:a05:6870:d582:b0:142:6390:4724 with SMTP id u2-20020a056870d58200b0014263904724mr3168116oao.82.1668764057570; Fri, 18 Nov 2022 01:34:17 -0800 (PST) MIME-Version: 1.0 References: <20221118003212.3628771-1-christoph.muellner@vrull.eu> In-Reply-To: From: Nelson Chu Date: Fri, 18 Nov 2022 17:34:06 +0800 Message-ID: Subject: Re: [PATCH] riscv: Add AIA extension support (Smaia, Ssaia) To: =?UTF-8?Q?Christoph_M=C3=BCllner?= Cc: binutils@sourceware.org, Andrew Waterman , Palmer Dabbelt , Jim Wilson , Philipp Tomsich Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,UPPERCASE_50_75 autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Nov 18, 2022 at 5:08 PM Christoph M=C3=BCllner wrote: > > > > On Fri, Nov 18, 2022 at 9:12 AM Nelson Chu wrote: >> >> > +DECLARE_CSR(hvien, CSR_HVIEN, CSR_CLASS_SMAIA_AND_H, PRIV_SPEC_CLASS_= NONE, PRIV_SPEC_CLASS_NONE) >> > +DECLARE_CSR(hvictl, CSR_HVICTL, CSR_CLASS_SMAIA_AND_H, PRIV_SPEC_CLAS= S_NONE, PRIV_SPEC_CLASS_NONE) >> > +DECLARE_CSR(hviprio1, CSR_HVIPRIO1, CSR_CLASS_SMAIA_AND_H, PRIV_SPEC_= CLASS_NONE, PRIV_SPEC_CLASS_NONE) >> > +DECLARE_CSR(hviprio2, CSR_HVIPRIO2, CSR_CLASS_SMAIA_AND_H, PRIV_SPEC_= CLASS_NONE, PRIV_SPEC_CLASS_NONE) >> > +DECLARE_CSR(hidelegh, CSR_HIDELEGH, CSR_CLASS_SMAIA_AND_H_32, PRIV_SP= EC_CLASS_NONE, PRIV_SPEC_CLASS_NONE) >> > +DECLARE_CSR(hvienh, CSR_HVIENH, CSR_CLASS_SMAIA_AND_H_32, PRIV_SPEC_C= LASS_NONE, PRIV_SPEC_CLASS_NONE) >> > +DECLARE_CSR(hviph, CSR_HVIPH, CSR_CLASS_SMAIA_AND_H_32, PRIV_SPEC_CLA= SS_NONE, PRIV_SPEC_CLASS_NONE) >> > +DECLARE_CSR(hviprio1h, CSR_HVIPRIO1H, CSR_CLASS_SMAIA_AND_H_32, PRIV_= SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE) >> > +DECLARE_CSR(hviprio2h, CSR_HVIPRIO2H, CSR_CLASS_SMAIA_AND_H_32, PRIV_= SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE) >> >> Just curious does the spec clarify these belonged to smaia? or should >> these just belonged to h? > > > The AIA spec says: > "If a hart implements the Privileged Architecture=E2=80=99s hypervisor ex= tension, then the hypervisor and > VS CSRs listed in Table 2.3 are also added" > > So I think the way it is modeled is correct. So if we only enable ssaia and h, then we can only use virtual supervisor aia CSRs, but cannot use the hypervisor aia? If that true, then looks good. Thanks Nelson