Re: [PATCH v3] RISC-V: Add Zawrs ISA extension support

[Nelson Chu <nelson@rivosinc.com>]

On Sun, Sep 18, 2022 at 4:20 PM Tsukasa OI via Binutils
<binutils@sourceware.org> wrote:
>
> Functionally, this is good as is.
>
> For formatting, there is a small room for further improvements (as I
> comment below).  This is not your fault but because of my recently
> upstreamed 'Zmmul' patchset.

The extension orders in the riscv_supported_* tables are not really
important for now.  For the single letter standard extensions, the
order is kept in the riscv_ext_canonical_order.  All extensions should
be arranged to the correct places by calling riscv_lookup_subset and
riscv_compare_subsets, and all rules of order are mentioned in the
riscv_compare_subsets.  So make them in order just for tidy, but won't
break anything.  The problem we met for the zmmul is g's imply.  The
order in the riscv_implicit_subsets really matters based on the
current implementation, and not sure if we will have another choice to
remove the order limitation when adding implicit extensions.

Anyway, the v4 patch looks good and approved, so please commit it when
you think it's time.

Thanks
Nelson