public inbox for
 help / color / mirror / Atom feed
From: Nelson Chu <>
To: Tsukasa OI <>
Cc: Christoph Muellner <>,
Subject: Re: [PATCH v3] RISC-V: Add Zawrs ISA extension support
Date: Fri, 23 Sep 2022 12:34:25 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, Sep 18, 2022 at 4:20 PM Tsukasa OI via Binutils
<> wrote:
> Functionally, this is good as is.
> For formatting, there is a small room for further improvements (as I
> comment below).  This is not your fault but because of my recently
> upstreamed 'Zmmul' patchset.

The extension orders in the riscv_supported_* tables are not really
important for now.  For the single letter standard extensions, the
order is kept in the riscv_ext_canonical_order.  All extensions should
be arranged to the correct places by calling riscv_lookup_subset and
riscv_compare_subsets, and all rules of order are mentioned in the
riscv_compare_subsets.  So make them in order just for tidy, but won't
break anything.  The problem we met for the zmmul is g's imply.  The
order in the riscv_implicit_subsets really matters based on the
current implementation, and not sure if we will have another choice to
remove the order limitation when adding implicit extensions.

Anyway, the v4 patch looks good and approved, so please commit it when
you think it's time.


  reply	other threads:[~2022-09-23  4:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-18  8:07 Christoph Muellner
2022-09-18  8:19 ` Tsukasa OI
2022-09-23  4:34   ` Nelson Chu [this message]
2022-09-23  7:13     ` Tsukasa OI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).