From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id EA5CC3858C52 for ; Fri, 23 Sep 2022 04:34:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EA5CC3858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-127dca21a7dso16739692fac.12 for ; Thu, 22 Sep 2022 21:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=/9gumrwhmNR/DQTns+a7RSyuFm1qBeQpuuQlIS3u/Q4=; b=r2a65jJjzlQMjf7APJIUjTYcLj/3CVBjV1Edo6KYO9LPd5u8NhP9Ha5r5DdI2q17P9 dXw1JrjwSwFp0dGsZjcvW2OJtmgdlwmRauJXg3Ftbmff5f/DWK1MqsOR0MU4TKDBOP3a fg6yKtPMCEkc4Wi+G2lUVbmbc4zPQv1WbrdmXen6ZZAa0WmcBFRSaWXTt8rikriBmS8J qPHMxy1BoEyTF+80LP+DnqeJNxzSmNPTAWPnd5MIBpKWojgsNoKYbT6No0Jm2ISHDVTk OrQ52gtrTux5L8ADjdnlEOLjzil+ALIVPcS4smPGpCpvSpWbYEGokB2+mSXISv+UVKwi WHyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=/9gumrwhmNR/DQTns+a7RSyuFm1qBeQpuuQlIS3u/Q4=; b=TqdibNyd59lQO5U5PVoyIxaQdOxcs2E9SNq9LbuQW7pbHLTlYmeiPZiOP6aN2kSY5P EidOmmhZlA62U0rr6AtCghlGIWmvBPVHsXQ9HSqGitAl583oKUtYWdB8a+9oTB1kLhUC fEPZtD2etV5BoKgGPARpsa5b17nF1vlSDCiV0WSMgWeYb4F3Slx0ypvN6tlC94Af/OR6 dF9MhpNlTx1WUdcSaDVPCsZWn6AMhXakHKEgblVFPSVkdVl5em5RZBmcm6+eBYXQP+iz CS98Tbl/4FWzGDCYcIKo18upRW/EVT+OtDMcFuHFOTwk6c9h+MlnoaeYF2ECsgdMtVK2 EGWA== X-Gm-Message-State: ACrzQf2T7Q/UBtfBX3SfMX4x/UqS5iuX8EfPYudvVJRMNdTTObr7x8QB ouX6Lxn3ONakn7tf/9oQhdfyPnbCaYFZuvJgRIP7BHaB+5A= X-Google-Smtp-Source: AMsMyM7QP4myxne1HgoIjcH6PizgKot7YRYSn/bpHAJmw6s1rNjCL0KvkWYyOTwRSoCMfoRWyjjnJszxxNVL/GeR25E= X-Received: by 2002:a05:6870:58aa:b0:118:307d:bb43 with SMTP id be42-20020a05687058aa00b00118307dbb43mr10366119oab.82.1663907676400; Thu, 22 Sep 2022 21:34:36 -0700 (PDT) MIME-Version: 1.0 References: <20220918080731.2551374-1-christoph.muellner@vrull.eu> <0dea6e14-323e-64aa-1a61-2574d17e980a@irq.a4lg.com> In-Reply-To: <0dea6e14-323e-64aa-1a61-2574d17e980a@irq.a4lg.com> From: Nelson Chu Date: Fri, 23 Sep 2022 12:34:25 +0800 Message-ID: Subject: Re: [PATCH v3] RISC-V: Add Zawrs ISA extension support To: Tsukasa OI Cc: Christoph Muellner , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Sep 18, 2022 at 4:20 PM Tsukasa OI via Binutils wrote: > > Functionally, this is good as is. > > For formatting, there is a small room for further improvements (as I > comment below). This is not your fault but because of my recently > upstreamed 'Zmmul' patchset. The extension orders in the riscv_supported_* tables are not really important for now. For the single letter standard extensions, the order is kept in the riscv_ext_canonical_order. All extensions should be arranged to the correct places by calling riscv_lookup_subset and riscv_compare_subsets, and all rules of order are mentioned in the riscv_compare_subsets. So make them in order just for tidy, but won't break anything. The problem we met for the zmmul is g's imply. The order in the riscv_implicit_subsets really matters based on the current implementation, and not sure if we will have another choice to remove the order limitation when adding implicit extensions. Anyway, the v4 patch looks good and approved, so please commit it when you think it's time. Thanks Nelson