From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2e.google.com (mail-vk1-xa2e.google.com [IPv6:2607:f8b0:4864:20::a2e]) by sourceware.org (Postfix) with ESMTPS id 5D8143858D37 for ; Mon, 15 Aug 2022 12:59:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5D8143858D37 Received: by mail-vk1-xa2e.google.com with SMTP id c12so3614564vkn.13 for ; Mon, 15 Aug 2022 05:59:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=/zn6SfuTKetdrdd3IASu4vINl5Vr4oI97gzDJTPbHR8=; b=i9djmX3lHJwGQAeyQBotZ+NSYleZHQuqM9D83/0xJy6Wp9dJs7Fk9bSByqp3MTctHG eb3C607BM71roZTtv4gKiCcrybbnfcgTZFcg7rQjFnWaI3iH799+pNtMaLq+7Pnp3C/c DUMqUW7oPvMurploGBOHXMsI6+EpjWyrZkeMufEwWKiJ5QlonfyswFnI8ANHH/Lj5TxM Rbyzod+iE3uDBqlmTA5dn17PsbcAZ3aPfyxe+VRKqrZhmCHL/pXDgsldp87hlhLQDPZ6 KCAzvx1Azcvg4Nff8t044MMuIxfb9234XEQMZtHw3oDG88dKUy1rQyuN78byl12T4Sm/ +D0Q== X-Gm-Message-State: ACgBeo15LYW86JztSyABWf2CGv7m17iQDllwczhTYKMRGpSFMrWkcX0G 4/pM+Tr8d/5u5tIYmNl0cWEbRiTdRlGdg0RfV5g= X-Google-Smtp-Source: AA6agR78b0P4FTdb8ZbJm9mjWLvh9q+YNm5HTbrTYy3Rn25bg+ErluOMPuoXldRVn/f+tNZHwKgsWJTM8E81TqGN9FU= X-Received: by 2002:a1f:b4d8:0:b0:37c:e38:1ec2 with SMTP id d207-20020a1fb4d8000000b0037c0e381ec2mr6602234vkf.26.1660568349675; Mon, 15 Aug 2022 05:59:09 -0700 (PDT) MIME-Version: 1.0 References: <20220626190005.7727-1-ghostmansd@gmail.com> <20220725131020.128550-1-ghostmansd@gmail.com> <20220725131020.128550-4-ghostmansd@gmail.com> In-Reply-To: From: lkcl Date: Mon, 15 Aug 2022 13:58:58 +0100 Message-ID: Subject: Re: [PATCH v6 3/7] ppc/svp64: support setvl instructions To: Jan Beulich Cc: Dmitry Selyutin , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 12:59:12 -0000 On Mon, Aug 15, 2022 at 7:18 AM Jan Beulich wrote: > On 25.07.2022 15:10, Dmitry Selyutin via Binutils wrote: > > +Disassembly of section \.text: > > +0+ <\.text>: > > +.*: (37 00 00 58|58 00 00 37) setvl. r0,r0,1,0,0,0 > Out of curiosity - was it intentional to omit a case with the last > operand non-zero? one for Dmitry - i believe these are all auto-generated? > > @@ -6769,6 +6789,9 @@ const struct powerpc_opcode powerpc_opcodes[] = { > > +{"setvl", SVL(22,27,0), SVL_MASK, SVP64, PPCVLE, {RT, RA, SVi, vf, vs, ms}}, > > +{"setvl.", SVL(22,27,1), SVL_MASK, SVP64, PPCVLE, {RT, RA, SVi, vf, vs, ms}}, > According to the web page SETVL has a number of pseudos. yes. > I guess you've omitted those for simplicity in the initial submission. and because there's a python-based (very-easy-to-hack) program which does the same job as gas, turning SVP64 assembler into ".long xxx; v3.0opcode", and it doesn't have pseudo-ops. > I'd like to point out though that the web page isn't really > crystal clear as to, in particular, the Rc field's applicability > to every one of the pseudos. ah appreciated, i've added examples. more will be needed now that there's also setvl-from-CTR as well. > (There's also a typo or two which > makes things a little ambiguous, but there it's reasonably clear > what is actually meant.) appreciated. any feedback is more than welcome. context there: despite now being an Open ISA the amount of attention Power is getting is surprisingly low. hence any assistance and feedback is all the more precious. l.