From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2041.outbound.protection.outlook.com [40.107.96.41]) by sourceware.org (Postfix) with ESMTPS id 632323858D33 for ; Mon, 9 Oct 2023 10:53:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 632323858D33 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AvRa6vy746Ivebrfn/XsirH0355UeBstLNn4XCXVKADzjLw8rinsIR/SxbQ4ncZ5IQfPVViZ/4N8l3BUQvc9T9q6PQ0ILUF+xrm/g78rcwikIYnqduheZyDIRB6x1tiewNlNhGfHegVW1RIzalXzojWSefPLTcOpMMtbmOetEXfmrHfG5phQI2ptbttrHWPZ881vOG+o1v83NyHqlU9d+/B4dN5TaeUSl8QgpzeVQ6exB3d8nQufffLSfAZMRva8nFfIT0HxZS1KQTflLj6PIqMHTH12tzqaBIb0RWsNBSQNPtyjuHDKA0cUnz4RLVys46gvXqIoA5MVDjDsFayynQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5wW0KDyStf20WxILXy7VrYQMi8IBNDyAt+HB2duwvXQ=; b=jOCoBwCrr2BNIE8JayQyYUf6b6zxL8NgEVztdken1uoY9GmFc6n5lQ2Q/oF2i1xvIaKn76+1AmTA6wWeqRvtwDXIQPi5sNn7FwOIVbJXKZ++FvusjxO+0W0ISZPDlzLhh9TZn+onnbv6vm5N0NqCRmVQ9Xo0QRgzu1QpmUyUgooA8lPzYqrTAuf7DHgeZKErJFuV5tRfhSQCDWnbXdmdjI9pgSccGCSrcTFKHdiNNY1b8nkbMZOgitLA3JZxKfrY5P/4kCUkHg9ZmTB207ed9mYpkIgf7V7zfOhajtejIYjb8XCBDLgNa/m+jFZuGMTz3bzxQeGjvqffntZFyT2dvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5wW0KDyStf20WxILXy7VrYQMi8IBNDyAt+HB2duwvXQ=; b=uxd2RfKCe1+4rMyOmLRx/LNyvOcvwFOnuRJA42y0T3AV2DQ2dAh4sTefJe4/X3lVd1JwFIIA+ofkA1V8SpLLonbPrg3R8A7dPg1YakXeqAU/drv805IxPnxGsBK3IiXx41RkdjEIyRIp+8IB9hpzDre6OoxZNb05Kt9mqStPxF8= Received: from CH2PR12MB5004.namprd12.prod.outlook.com (2603:10b6:610:62::16) by PH7PR12MB7843.namprd12.prod.outlook.com (2603:10b6:510:27e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.43; Mon, 9 Oct 2023 10:53:22 +0000 Received: from CH2PR12MB5004.namprd12.prod.outlook.com ([fe80::53cc:feb5:431:6de1]) by CH2PR12MB5004.namprd12.prod.outlook.com ([fe80::53cc:feb5:431:6de1%4]) with mapi id 15.20.6863.032; Mon, 9 Oct 2023 10:53:22 +0000 From: "Frager, Neal" To: "Maciej W. Rozycki" , Michael Eager CC: "binutils@sourceware.org" , "Erkiaga Elorza, Ibai" , "Mekala, Nagaraju" , "Hatle, Mark" , "Mutyala, Sadanand" , "Nali, Appa Rao" , "Hunsigida, Vidhumouli" , "luca.ceresoli@bootlin.com" , Nick Clifton Subject: RE: [PATCH v2 1/1] opcodes: microblaze: Add new bit-field instructions Thread-Topic: [PATCH v2 1/1] opcodes: microblaze: Add new bit-field instructions Thread-Index: AQHZ94qevy3iAKR6zECrNTXFT3d2rbA9JEqAgAGUB4CAApUFgA== Date: Mon, 9 Oct 2023 10:53:21 +0000 Message-ID: References: <20231005125103.1330807-1-neal.frager@amd.com> <5d2ce973-6287-db3d-fc82-966914f765a7@eagercon.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR12MB5004:EE_|PH7PR12MB7843:EE_ x-ms-office365-filtering-correlation-id: 9c39c892-515b-497a-cf8c-08dbc8b5f476 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cSlfq7qMJG5dihws4b1XpRUiT2imL7PrAZ1h9KUI9yKe5i88r4q8hYzLiuQXpHSQqIrUe5GTnOAQ0pgEx2c4JKb8S+4gbGyRqV+uSnecv567seBSp19czTVFxWuuX2fBVOKYopFLk5dhr1TyzcKbjFEUzwx480Fh+7WD/JfxKQ3j1ps9zTx/cic0jbhBmg7MZVDs4rDiemhdHq3Ng5/QWv+Dwi4yLGPdP3pwXGI+6MFPrhcDwnuhtDfb//RBoStb1psNMETg/Prhri3/4DXVCYAR9xjF8Z/kP4S03wl4EmqCguvzi6Js3CSi5w2fh9bBWoItIC+57JMNPs61lD6MZ5x3zPHZBx9kBgwpJ6Y5hV83PeHiLH5e5xx1xl2SYvX/HRO3tNYtbKvtAgSbNraaa0y4p8Dm381ghPtRKwq2+sWy6BVyyF+C98EBwL5pzJ898sFCMw8WRX6XSYFokYsgI9q0Sa9pGSWSAaJfvGhx7+u4ZYFLXoaQEgSKiqIfx6/QNtoimvha4Y0puF/zMwKfkMcBN02rXbnWL9RlNrlbWKogfygOQikAc+hDt8qoSfi5YmmA+oAEwe6IL0AN8FARQVuyFCWuJtWUyMBRYrFhuF4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB5004.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(396003)(376002)(366004)(136003)(39860400002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(122000001)(38100700002)(38070700005)(86362001)(33656002)(55016003)(2906002)(9686003)(478600001)(966005)(41300700001)(52536014)(8936002)(5660300002)(4326008)(8676002)(7696005)(71200400001)(6506007)(83380400001)(66556008)(66476007)(316002)(64756008)(76116006)(54906003)(66446008)(110136005)(66946007)(26005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Uzqiq3YZeT3UqYHazO2SWR6vlxur8HLm0svrKh5KlwIqOYGxBkpLcXo6yvn6?= =?us-ascii?Q?CsoAaDVNAH6qkZMb58qMJxK1Onxysq09np6o1JvwvibqQTQZzeU5fNVLH3eH?= =?us-ascii?Q?E5+s3w7xP34UYu5t891FUL6gKU5sQqy9cA+MQYLZJECr/kFDktnI8TFh0pfy?= =?us-ascii?Q?N7Vf5sS9h4rut/fUXwnXzDU1bSOHc2q4Lb5ooe2X8LanIG3BBK01iGMEyDIB?= =?us-ascii?Q?4Ss10lTOpZXtKpXZncLHHmf6XG+nAyqqbj9PYbGn3SIl6jtLCQzQjMACB9ru?= =?us-ascii?Q?OPEp+KTf0HBeImDN+MlgFhObZuCTyMKTpPzJmNqc5PHYYvgJoJq0aMJmJJG7?= =?us-ascii?Q?7ECKtzsOC/xtxP+2+3YPHYXbUno5/SD3WN0fvInJbzHNvavpjI/j+Ijjk/w2?= =?us-ascii?Q?QJX++PkqZkBIWvRSMKnw4oD4U0hf8bIqzGK7jZA7qgYO7cXcaRsXSiyQqltL?= =?us-ascii?Q?Uo5DE+Icj7g8lPJ/H/6Ie9eOOfmhMYZsympgnzu6RmPbig7I3t/StDrSnh3W?= =?us-ascii?Q?iZvDGMHc15MVeEx9CU5aIgjKuFjHd4ZhHj34p1KqSEG6MnP0e5CwYOfryuIp?= =?us-ascii?Q?zZgaymTGG/AYayh40vGuNAIa1DRA/5ordlT9G833B2TYQtlQdX0XO2PWL9D2?= =?us-ascii?Q?64W1vJ4Lo69z+YtEXoyh2vPR+F5CGwlIKQF1mPtObzaAFaTS0aEDlMtGdZ5E?= =?us-ascii?Q?hAGmOvzOzQuJq2m1gNZ0q0fw3hpOIvwOD/Jd+w4SZXxHYm/AkvTOP1XQbtEY?= =?us-ascii?Q?PjMn4gw2/oMJTau3uWtgkuvuZAmJ3s8XwVrwiVQKsKBagEjU+mersYKhdyW8?= =?us-ascii?Q?x25kdJSuelXwxLMw4VrtKedpZTQ99+0PuyPCqzla4hZdww6J5uhTYtTz5QIv?= =?us-ascii?Q?IR56D0Thqi29rP6mw+36b1egqfDHefpDAlI2yPblxutnAIDR98oz3AEKQ48A?= =?us-ascii?Q?85fe7pSEoPV2D2QCudVziV9d28ZF7qAYXfH1PTdoVOAEuqWIc8bzBO3L6ET0?= =?us-ascii?Q?yPUlsBkG4sLPoHYsVeHFzqV6bxtLZZHuByNVOGl/2/wknM10a9ec0qsJFEP7?= =?us-ascii?Q?NBNJYHMVx/0L+olsLnhIntEF6uko4V53Mq5EdvVYnwUvdS2ic5EMMDpjWYx7?= =?us-ascii?Q?KVtcdmbBc4d8pyB1M0aJqYEuFD6bdrrFN7FuzUlvARYIWZ8/OTVslGGcwWxN?= =?us-ascii?Q?WAHYfkoNTh+ZMiOWZV2KlAFMUnAWvucwhdHstw6yvMx/V5NpFT7eZhdyKxdA?= =?us-ascii?Q?OPZdFDuZWlprzIUxJ7jXVooUu9BtQCx0tD42RodODpITlQ44W4QjX39O7TpR?= =?us-ascii?Q?S4DeYaEeOFJ+cigtZbeeU/luoeHxXaLlPECMs0KLSYX8EOJZ2o3ZIRUrl0FK?= =?us-ascii?Q?3ri/6cm3Y2hhYxk9k4AC9jcmdyBJq4yXKCIz8EFfvsFC2TM/VjgTSFCYF9DW?= =?us-ascii?Q?Nl5jS2Xcd404V67gp6jBEaHrn8hh08iUtbtQbUnY3tx+HHaEb6VEHA0s7wkv?= =?us-ascii?Q?bJOfvBrN/iHY4XMoOVP5hJtCK6D0Hvp/r3z2EDlCoLYGsvcDUjadvCuoq8w1?= =?us-ascii?Q?VhG/+9kTCQZDCTHBjJs=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB5004.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c39c892-515b-497a-cf8c-08dbc8b5f476 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2023 10:53:21.8929 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mvdjfXJx5/zXy5+OSnuBfTHQyRS+D49/Ywh4jnf0rdiUY8uU+Ph1kDlxiI0bKsWD X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7843 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > > This patch has been tested for years of AMD Xilinx Yocto releases as=20 > > part of the following patch set: > >=20 > > https://github.com/Xilinx/meta-xilinx/tree/master/meta-microblaze/re > > cipes-devtools/binutils/binutils > >=20 > > Signed-off-by: nagaraju > > Signed-off-by: Ibai Erkiaga > > Signed-off-by: Neal Frager >=20 > Committed. > Yet it has caused numerous regressions: > microblaze-elf +FAIL: unordered .debug_info references to .debug_ranges = microblaze-elf +FAIL: binutils-all/pr26548 microblaze-elf +FAIL: readelf = -Wwi pr26548e (reason: unexpected output) microblaze-elf +FAIL: readelf --= debug-dump=3Dloc locview-1 (reason: unexpected output) microblaze-elf +FAI= L: readelf --debug-dump=3Dloc locview-2 (reason: unexpected output) microbl= aze-elf +FAIL: readelf -wiaoRlL dw5 microblaze-elf +FAIL: readelf -wi dwa= rf-attributes (reason: unexpected output) microblaze-elf +FAIL: readelf -w= Kis -P debuglink (reason: unexpected output) microblaze-elf +FAIL: readelf= --debug-dump=3Dlinks --debug-dump=3Dno-follow-links dwo microblaze-elf +F= AIL: DWARF2 1 microblaze-elf +FAIL: DWARF2 2 microblaze-elf +FAIL: DWARF2= 3 microblaze-elf +FAIL: DWARF2 5 microblaze-elf +FAIL: DWARF2 6 microbla= ze-elf +FAIL: DWARF2 7 microblaze-elf +FAIL: DWARF2 11 microblaze-elf +F= AIL: DWARF2 12 microblaze-elf +FAIL: DWARF2 13 microblaze-elf +FAIL: DWAR= F2 14 microblaze-elf +FAIL: DWARF2 15 microblaze-elf +FAIL: DWARF2 16 mic= roblaze-elf +FAIL: DWARF2 17 microblaze-elf +FAIL: DWARF2 18 microblaze-e= lf +FAIL: DWARF2 19 microblaze-elf +FAIL: DWARF2_20: debug ranges ignore = non-code sections microblaze-elf +FAIL: DWARF2 21 microblaze-elf +FAIL: D= WARF5 .loc 0 microblaze-elf +FAIL: DWARF4 CU microblaze-elf +FAIL: DWARF5= CU microblaze-elf +FAIL: Check line table is produced with .nops microbla= ze-elf +FAIL: line number entries for section changes inside .irp microbla= ze-elf +FAIL: line number entries for .macro expansions microblaze-elf +F= AIL: line number entries for expansions of .macro coming from .include micr= oblaze-elf +FAIL: lns-duplicate microblaze-elf +FAIL: lns-common-1 microb= laze-elf +FAIL: ld-elf/pr22450 > They all seem to follow a similar pattern, e.g: > exited abnormally with 1, output:readelf: Warning: Corrupt unit length (g= ot 0x4e00004e expected at most 0x4e) in section .debug_info > FAIL: DWARF2 1 > or: > exited abnormally with 0, output:readelf: Warning: Corrupt unit length (g= ot 0x20000020 expected at most 0x20) in section .debug_info > FAIL: Check line table is produced with .nops > Configured with: > $ /path/to/configure --disable-nls --disable-gdb --disable-gdbserver --di= sable-gprofng --disable-libbacktrace --disable-libdecnumber --disable-readl= ine --disable-sim --enable-obsolete --enable-plugins --build=3Dpowerpc64le-= linux --target=3Dmicroblaze-elf > Just reporting in case it's useful as it has popped up in unrelated verif= ication; I won't do anything else here. > NB I've skimmed over the change and noticed it does not follow the GNU Co= ding Standards in many places, most prominently in `get_field_imm5width'=20 and `get_field_rfsl', but also elsewhere (which is easy to spot looking thr= ough the diff). Hi Maciej, The patch I submitted does not modify the 'get_field_rfsl' function, but pe= rhaps you could review the 'get_field_imm5width' function? Could you explain what is not followin= g the GNU Coding Standards, so that I can fix it? static char * get_field_imm5width (struct string_buf *buf, long instr) { char *p =3D strbuf (buf); if (instr & 0x00004000) sprintf (p, "%d", (short)(((instr & IMM5_WIDTH_MASK) >> IMM_WIDTH_LOW))= ); /* bsefi */ else sprintf (p, "%d", (short)(((instr & IMM5_WIDTH_MASK) >> IMM_WIDTH_LOW) = - ((instr & IMM5_MASK) >> IMM_LOW) + 1)); /* bsifi */ return p; } Best regards, Neal Frager AMD