From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2051.outbound.protection.outlook.com [40.107.220.51]) by sourceware.org (Postfix) with ESMTPS id 25C373858D28 for ; Tue, 3 Oct 2023 13:56:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25C373858D28 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CI6H+rusnJDqP/SiEEkKZ8rxuCrTBRhFvNDRib8ionNJfKlAoDF/HiYbqoN+7OLShIdbcCMRc9lLBnsm8pXwsPyVpYyFay6Y5vqoTkjT2Pf9i4DxqwhT07cKxJVLnlX5QoS/T/9dC4ElBUFuxbZzfWg4MYsMaL0tAeDBpFvfjeKMZZy7fVBRQySnlMcs5vdP6JaVeaQxIrrA//TNfM09TbvOynE7LbaxZznoPiOw67o9Z9PBpVjWBFIZERjK4YGZLpwIQlCTb7H4mb/Y35VrITq3HiCJ04zI4nXTeCzCtUH/tHVqzPjmOXfp6JtOfOuh3qkzsB8e2+5csEJOaYvxwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xll3ao8jjpiOxLiPh8bj1gNAaHubZtXI8Q973A4szzc=; b=lV0ErjCv8DKM6uHiZcwHbBmln6sIIK+XdlVLr5Yxx5KpBZJ5w8vOtbrcF7hDUN9j/pwTxKUPKP7CzOo1StqcPf7BGDDN4PKy2NzMw1rtyI6FnW8wwffPcQ/LWXhUts/vVWVeHlexhwX+puVGhAU2iE0MpJKf2VG+RU2Q/6zkcBrREvbmUJr5dCoqUGYtaxeopzWmR7LxFwcjpqfWZKIGncTEvFotFUtXTFffEdiHGu5jKepaCRXVI8nHkl4Kmac2VN4wtReLHtqAC7xFoSntLyWX4eM6qaebtFkGbjsblavrjnU8wN/wus1cVOSz5ETToHfB97crlhj0o+wJaorMaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xll3ao8jjpiOxLiPh8bj1gNAaHubZtXI8Q973A4szzc=; b=sXYihIbkqopEeABPeVa6cF48QUjyY6aZPciHTnlDdSC9AdIuMKSnQJw2Xh7jE/hPFl27EIlrTT+49KuS4yNFbnIGOjQsACcCFtFQOjPmHZ/L2DMY/u/R6zd7eksVxdt9hZyBtomudT8BIK8xa6bTPXh+tCfs/PjX0UscDQ3l5Bg= Received: from CH2PR12MB5004.namprd12.prod.outlook.com (2603:10b6:610:62::16) by CY5PR12MB6154.namprd12.prod.outlook.com (2603:10b6:930:26::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.33; Tue, 3 Oct 2023 13:55:59 +0000 Received: from CH2PR12MB5004.namprd12.prod.outlook.com ([fe80::c780:32e8:203:be20]) by CH2PR12MB5004.namprd12.prod.outlook.com ([fe80::c780:32e8:203:be20%2]) with mapi id 15.20.6838.030; Tue, 3 Oct 2023 13:55:59 +0000 From: "Frager, Neal" To: "binutils@sourceware.org" , Nick Clifton CC: "Erkiaga Elorza, Ibai" , "Mekala, Nagaraju" , "Hatle, Mark" , "Mutyala, Sadanand" , "Nali, Appa Rao" , "Hunsigida, Vidhumouli" , "luca.ceresoli@bootlin.com" , "Frager, Neal" Subject: RE: [PATCH v1 1/1] opcodes: microblaze: Add hibernate and suspend instructions Thread-Topic: [PATCH v1 1/1] opcodes: microblaze: Add hibernate and suspend instructions Thread-Index: AQHZ8cME2z915aTFFEqT2RCU50t/S7A4Ho5g Date: Tue, 3 Oct 2023 13:55:59 +0000 Message-ID: References: <20230928041939.2238068-1-neal.frager@amd.com> In-Reply-To: <20230928041939.2238068-1-neal.frager@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR12MB5004:EE_|CY5PR12MB6154:EE_ x-ms-office365-filtering-correlation-id: 7c6c6801-e522-457e-5e37-08dbc4187928 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EAT1kDPvuSG0DsqErz8mngtkau7ZUytji9fjDoss0IKW6CgeO6TNkFYxrDA7l4aX03m3B0fTDIU4ufbazE+Nrd7V+Qzh9HttI1eZk0T1VkxmzQkZsrIamGW48PqJKsDM187bBgruAhxw9aFI20UXrY2e/t7BtAT8h51e790vsX5WoDh1qvDB/S+nAMc8O1yfmqWR5zuVgceUsoQ4PgqjSgKeWCv8LsIZ7U547VmRcOSBJcNKyq07lMoDNx4me1vd9Y8chGoRSwIffjhbEQtozCTPktVR5RrbvQM5CfIqaZ9bl2Nrs2+tVmLlYDP63Z86fOlX7hYdN3x2VGaQjuJSkxjACa3vNFh6wlhMyZXtRy6C3UTmJ8yVLicgUpIejsIPi9PTDCXztDGP+R9QRB6eLrmRnblXaZC/pY8EdKtN4FSR0PE9sI4I+BobcFLDUaQze15lMB5Xin9nxkhzKjZqZjEgDnvCd7eyuDuUKc2R975ohHCM0fXAQw3ncgXlNPtF5fuz25Xq74yYCt5Ow8ejH4HXXtKJ/UmECIij4OHTHl5StchkVb15718iNlh6OOWNoJ4fzTunyBRdXS+wVk04vyg9REBSz4w+7TjC0mMWUaM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB5004.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(346002)(366004)(39860400002)(376002)(396003)(230922051799003)(1800799009)(451199024)(186009)(64100799003)(122000001)(5660300002)(26005)(52536014)(8676002)(4326008)(71200400001)(8936002)(478600001)(86362001)(966005)(76116006)(38070700005)(38100700002)(66556008)(66946007)(55016003)(66476007)(66446008)(64756008)(54906003)(316002)(110136005)(6506007)(7696005)(9686003)(15650500001)(2906002)(33656002)(83380400001)(41300700001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wlrZyd4KeqtJSMQcPj4lvxq+XxwjDPIEV/laO+EoSo+RZ7bk80zhSNh2aIud?= =?us-ascii?Q?l54IOPwjcH1Kr5hWyyD1ia6NCd3c3bP4HmumkCmude69/Xc7NVhmQ8BaTLiL?= =?us-ascii?Q?rjmzFV6GmymbvgMhbPGzxOqiD6WvotxIOtRQ9X/931tvXKZYfnst60oqvPug?= =?us-ascii?Q?0XKoTWpV1oB7aP4JIl2/xLNNTUOhdjoSmUaSpTJHHJzD44LExhVe2ISPLBHw?= =?us-ascii?Q?ljijdncPZ8NNNVJ/P8kdYd59M1WbSfa7uLIKwntPDbTA8j8HntbSsjXKaGUL?= =?us-ascii?Q?IXLsMeoL+rd6FsHBXPnRgzS/P59g9cffBAnOYOmbnw0SghYyAzxqikB1BDur?= =?us-ascii?Q?GQapSM+jcA0fS+V3P3lotNYgu+CrnlSsQ6FVvYvkqluilS6g/XbK+MzkBubQ?= =?us-ascii?Q?wptf98t9vsJgE7uOOXGpYb+SpZVuvINNFs71BIeb8pBduZhk8qzu11K8QC0j?= =?us-ascii?Q?GMf0lqFlsq4OVcGYvrg+o0cnswQLce35+RZJD/FDipDMfnIhyznVrRkVV6UZ?= =?us-ascii?Q?KbjZVCuOs728h1x5dzfi9lkfM0rGsjNZ1YKL0pRdgRMVSKqCO75jIi4HFfUe?= =?us-ascii?Q?yiyz7ITFfT4IJh3Xg1bD6rmMev8fxo+DNcwD4rHIQYkzuoYS035M7PR6Llah?= =?us-ascii?Q?H4u/De1MwJreETLeYOjA+yQ8JCJ0Hh2nKnN9sy9xCvEa374lZCCr+GTjHJhF?= =?us-ascii?Q?LWs4G+9yp8DjmheYG+kHqdyqsmREhuivYz9uI6WeXqwSLAyyzk6HJIx0yMWq?= =?us-ascii?Q?2hpCeo0vuqxFqzb2/XIyUzF1C0tE/+cylWPTFDzp6Uu73Yb1tANVSXJhXW9M?= =?us-ascii?Q?TSvi57+pPTTUo7aBJYtm3DfU+INkNu4PJwiXx2A6kyFj/NIuRwTlIbOXb8B0?= =?us-ascii?Q?NkgH09rzXKmE6fUpv2/5sgoZyv87ZNj/ACg3EyjhacdmdAI3p3U2g+aS7LSX?= =?us-ascii?Q?m7R4OkWkUkIPXwcNunMK8NAzoFbTO9uo9zNzwW+3WSM8jYJtqF22JIf9mjYt?= =?us-ascii?Q?5csWVi/9tIXLKc6kkLRBLH9ZaXtI8MYSV6/slbjQJVWLh0d22YHmjagzzCvH?= =?us-ascii?Q?e8p4CHi+CQZH9MOAE954h7bJvFVFDsIVv/qHSA3f4hma8aXJOzX7BvOuXFJ1?= =?us-ascii?Q?Rb0268mJf3QgZysWtU9UebfUKPMr5gJIq99XVQ4WtlfHibar5M6r2wv0szgK?= =?us-ascii?Q?l8pJoQmOi+ao4tetF7lEmlVaCPSUL3BK6S+i7/EgAs0HrKRxrryC+yCosEsi?= =?us-ascii?Q?QE+xveRL8PDBlT/3k7EHVegYXcNqWtA8IUGRJxDHEfvzVRzzqwJ3seyQTejE?= =?us-ascii?Q?ai8o0q4zUYBKf6Icpsus5t/eU52Mrm+rSjChJkI9rhlraqCcENHIhJpoTyVC?= =?us-ascii?Q?9veHPl529zPMsSuBY8nPh88k4P3fqhmwTnyxfgc5+an6TCpN5pYFH8w9nVIY?= =?us-ascii?Q?CEs6TNU7fLHoQ0IuYMoRPcS216zvqtfXSdXf3bI+hZFspIo40aHb5UZ77Ls+?= =?us-ascii?Q?LDy7pI0IkQoNaVm3HLxb7FpXXS4b+RU8Wsq3q9uh7WrHX2Vs054eSSilxCUF?= =?us-ascii?Q?JWq3bySDtKV2xyrmWtE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB5004.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c6c6801-e522-457e-5e37-08dbc4187928 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2023 13:55:59.3993 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jKY2dz5GmvAUhIC57Q/pfqQMGHeCoJhmnaHeFB+zdGHw5t0d88rH6txVDDnP7obH X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6154 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > This patch adds the MicroBlaze hibernate and suspend instructions. > Further documentation of these instructions can be found here: > https://docs.xilinx.com/v/u/en-US/ug984-vivado-microblaze-ref > This patch also re-adds the clz, mbar, sleep, swapb and swaph instruction= s which were missing from the MicroBlaze instruction list for some reason. > Signed-off-by: Neal Frager > --- > opcodes/microblaze-opc.h | 2 ++ > opcodes/microblaze-opcm.h | 1 + > 2 files changed, 3 insertions(+) > diff --git a/opcodes/microblaze-opc.h b/opcodes/microblaze-opc.h index 7c= 70c80a27b..6b9701bb67c 100644 > --- a/opcodes/microblaze-opc.h > +++ b/opcodes/microblaze-opc.h > @@ -405,6 +405,8 @@ const struct op_code_struct > {"clz", INST_TYPE_RD_R1, INST_NO_OFFSET, NO_DELAY_SLOT, IMMVAL_MA= SK_NON_SPECIAL, 0x900000E0, OPCODE_MASK_H34, clz, special_inst }, > {"mbar", INST_TYPE_IMM5, INST_PC_OFFSET, NO_DELAY_SLOT, IMMVAL_MA= SK_NON_SPECIAL, 0xB8020004, OPCODE_MASK_HN, mbar, special_inst }, > {"sleep", INST_TYPE_NONE, INST_PC_OFFSET, NO_DELAY_SLOT, IMMVAL_MA= SK_NON_SPECIAL, 0xBA020004, OPCODE_MASK_HN, invalid_inst, special_inst },= /* translates to mbar 16. */ > + {"hibernate", INST_TYPE_NONE, INST_PC_OFFSET, NO_DELAY_SLOT, IMMVAL_M= ASK_NON_SPECIAL, 0xB9020004, OPCODE_MASK_HN, invalid_inst, special_inst }= , /* translates to mbar 8. */ > + {"suspend", INST_TYPE_NONE, INST_PC_OFFSET, NO_DELAY_SLOT, IMMVAL_M= ASK_NON_SPECIAL, 0xBB020004, OPCODE_MASK_HN, invalid_inst, special_inst }= , /* translates to mbar 24. */ > {"swapb", INST_TYPE_RD_R1, INST_NO_OFFSET, NO_DELAY_SLOT, IMMVAL_MA= SK_NON_SPECIAL, 0x900001E0, OPCODE_MASK_H4, swapb, arithmetic_inst }, > {"swaph", INST_TYPE_RD_R1, INST_NO_OFFSET, NO_DELAY_SLOT, IMMVAL_MA= SK_NON_SPECIAL, 0x900001E2, OPCODE_MASK_H4, swaph, arithmetic_inst }, > {"", 0, 0, 0, 0, 0, 0, 0, 0}, > diff --git a/opcodes/microblaze-opcm.h b/opcodes/microblaze-opcm.h index = 92c245dc0fd..95c64fd7b00 100644 > --- a/opcodes/microblaze-opcm.h > +++ b/opcodes/microblaze-opcm.h > @@ -59,6 +59,7 @@ enum microblaze_instr > aputd, taputd, caputd, tcaputd, naputd, tnaputd, ncaputd, tncaputd, > eagetd, teagetd, ecagetd, tecagetd, neagetd, tneagetd, necagetd, tnecag= etd, > eaputd, teaputd, ecaputd, tecaputd, neaputd, tneaputd, necaputd, tnecap= utd, > + clz, mbar, sleep, hibernate, suspend, swapb, swaph, > invalid_inst > }; =20 Hi Nick, Have you had a chance to review this patch? Thank you for your support! Best regards, Neal Frager AMD