From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-74135-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 8995 invoked by alias); 19 Jan 2012 13:53:05 -0000
Received: (qmail 8986 invoked by uid 22791); 19 Jan 2012 13:53:04 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Jan 2012 13:52:50 +0000
Received: from localhost (localhost [127.0.0.1])	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 02AEDCB3B04;	Thu, 19 Jan 2012 14:52:51 +0100 (CET)
Received: from mel.act-europe.fr ([127.0.0.1])	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id 2GfPSO9B8vwh; Thu, 19 Jan 2012 14:52:50 +0100 (CET)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67])	(using TLSv1 with cipher AES128-SHA (128/128 bits))	(No client certificate requested)	by mel.act-europe.fr (Postfix) with ESMTP id E37B5CB3B02;	Thu, 19 Jan 2012 14:52:50 +0100 (CET)
Subject: Re: [Patch]: Improve handling of DW_LNE_define_file
Mime-Version: 1.0 (Apple Message framework v1251.1)
Content-Type: text/plain; charset=us-ascii
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <4F181B62.6000102@eagerm.com>
Date: Thu, 19 Jan 2012 13:53:00 -0000
Cc: binutils Development <binutils@sourceware.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <DA102DAB-6373-495D-AC82-AD3852888FCD@adacore.com>
References: <FB3BD091-6416-4F4D-B59C-B6A8B00362D2@adacore.com> <4F181B62.6000102@eagerm.com>
To: Michael Eager <eager@eagerm.com>
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00203.txt.bz2


On Jan 19, 2012, at 2:32 PM, Michael Eager wrote:

> On 01/12/2012 04:05 AM, Tristan Gingold wrote:
>=20
>> index a775818..08f472f 100644
>> --- a/binutils/dwarf.c
>> +++ b/binutils/dwarf.c
>=20
>> @@ -288,7 +289,11 @@ process_extended_line_op (unsigned char *data, int =
is_stmt)
>>        printf ("%s\t", dwarf_vmatoa ("u", read_leb128 (data,&  bytes_rea=
d, 0)));
>>        data +=3D bytes_read;
>>        printf ("%s\t", dwarf_vmatoa ("u", read_leb128 (data,&  bytes_rea=
d, 0)));
>> -      printf ("%s\n\n", name);
>> +      data +=3D bytes_read;
>> +      printf ("%s", name);
>> +      if (data - orig_data !=3D len)
>=20
> This should be
>         if ((unsigned int) (data - orig_data) !=3D len)
> or change len to "int".
>=20
> I prefer changing len.   I can check in obvious patch.

I think the cast is cleaner as 'len' was already used as unsigned.
I will commit the fix.

Sorry for not having seen that.

Tristan.