From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04olkn2095.outbound.protection.outlook.com [40.92.47.95]) by sourceware.org (Postfix) with ESMTPS id E1ED73858D33 for ; Thu, 16 Feb 2023 21:37:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1ED73858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bjYKkcR5gEWPkOqdqrnywl7A3e779dsK5YlRgRtPYRyl+FPLzHJg3tGCqPUVrJle1QUa/cQYaVSe9ADDR2z2zDPCUOC5XDmFkhGGQB0KrzDrLBmQIvWwXPTZvmOXcDfG/rMHbCRl04Qz4+/7jzTAtuERuhLZvrgdB/RbQih/3EARocfq4mU8msG+cQdpSclfI6mWaYmJ93V47/ieBZLT9SCaKxsMmJd7rbE5Uc2eZPnfpxJdpt96GK5rHmXWO7oTTDVgdOPGBTd846nIiYdcHm+B/7Ze33guyF13CRrzibAqzNbGSS0Kj11ckXk3c6ghP6MiFxuQkruF6jfOjKXH4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YupLNcAET356nU/4s3M/BFaToXsypBnmfqSjY2W4TJA=; b=CyU87WPSkrewXkZLxUE3BCadpDmI9zHAPFR8OgDAODXJXssBdBhZmKjpT3qQGbeaT7JiHTcWRdTS4arUMBCMJEcdGX/lympWatzRmH3GIB4QN6HXY4maA2ioN1RcAwiSkkmq2034z7DTyneFZgS1KdDqteAD92jtFUEH3KfxdxQIeYTnQ9zEIuInn7n6LHFlMAJevHkef7aFPg+0rpkpu4zZN9+KP8gbCjeN+z5fchiYVB3Csp9Tu/rfJqiaaJPuJ6SPfovhJtixHpcdjw7l7frYmi0MA8k/8m5xBp3FGo9e89MqhanuCYEeIXWJggjXRFMjjJRjOMqvQ8P9Rz3jxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) by DM4PR12MB6133.namprd12.prod.outlook.com (2603:10b6:8:ae::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Thu, 16 Feb 2023 21:37:57 +0000 Received: from DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::703c:6d1b:cf20:c631]) by DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::703c:6d1b:cf20:c631%9]) with mapi id 15.20.6086.026; Thu, 16 Feb 2023 21:37:57 +0000 X-Gm-Message-State: AO0yUKX8SbrB7MfzSfm2EiHAnkNHhidjJj69wMxGHz0hdhtrRRItDRyF y82g8UOF1SCHqJi3ZA63/B1fltfrPDoH26IHXUc= X-Google-Smtp-Source: AK7set+Hz7nzSuMqHVUI4DEwoevuwk9hRAvb2XcYbU3TAIF4Y6jktxYSZz40tHUZte8PJ6x2Q33WvMHJCnbGiY2sxLo= X-Received: by 2002:a05:6a02:241:b0:4fc:f8d5:548a with SMTP id bi1-20020a056a02024100b004fcf8d5548amr14857pgb.5.1676583053055; Thu, 16 Feb 2023 13:30:53 -0800 (PST) References: <20230216204006.1977-1-binutils@emagii.com> In-Reply-To: <20230216204006.1977-1-binutils@emagii.com> From: Fangrui Song Date: Thu, 16 Feb 2023 13:30:41 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC v0 0/1] Add support for CRC64 generation in linker To: binutils@emagii.com Cc: binutils@sourceware.org, nickc@redhat.com Content-Type: text/plain; charset="UTF-8" X-TMN: [MenyJgYxZyna+51yfZVwREuB0Pu1M09W] X-ClientProxiedBy: BLAPR03CA0160.namprd03.prod.outlook.com (2603:10b6:208:32f::25) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5765:EE_|DM4PR12MB6133:EE_ X-MS-Office365-Filtering-Correlation-Id: c32eeec9-7a75-4738-a15e-08db106611bc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d9OCehL58xJHO4GPNUjs3oYp1CCHVBgDNy7AoGkPZNJJHmf7T3QpxXsSX8WbPZUwMTeFaSasWdC7NaTsvqlq/AS2eLI2x5bruPSqMQUp9YbbbO/dRP94GGYQY+ApNGARdfNyD3xO0DuAql4KzDn03ILIzjr9jZLI7uWRpOu3fO6Yv4TO+jcMHYwxIpHqFWW9Gu+TUmCm4t0YiLa6zXjkHOZEK9vgtFmv74v8MDtYkv6sx6EkJdKNp16oUSZUVN3IdfY7kdKF6IOmFvMSLUHl4n8UZgvyLkcmYgpVjLX9R+B572NzE/Zt/AIjFShTMtEliR6RsjwaWEhbG1iPPaT+PrpfpBCVqeZ1nrC5W7H3rLiCO18xoQH1yWEhQYARVWs50WjT6FFDmOJYw9CQHKm761SaiR+zevUpup0U8fIrYY81g/xMZ6dr0xQpBN9wXZigkUxOG8TbXnATULZ6ZYJMmXBvRIt8QPgDMRxTnhTS93mjbJmfQRhNm28cabg3pEFleAwHrnxi3ab/CLdN+kBwqUrxLv5KSZ8z9RsaIcCzX5dGAIC+42Weh32FmBfj+ZuvWOsB/PJYTuS+5yBYRoaJ5K4RyZEmrG70tlbeL/E3wRSj2Rn0Vi0Jzjz4ORl/lYiN87kuH8VvJ9P+Iou88tQIHg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnpNOE84L2ZpL0ZBb0xaY0FZOTlhajZGZzNWUlhkcCtlS3pSQmxSWWE0YnpV?= =?utf-8?B?cEhIUldZcW8yaS85aW5IZHVHNVA2ODJ2MnJUdmV5RWM4NVNHUFZQaCtBbjJV?= =?utf-8?B?V2RpSmVCdWFVdWc2RVR6WVBHTlVRLzhFa3YrY1pCTUp0SHhCWXRqeFlCMm0v?= =?utf-8?B?aVd5OE10RThRNEMwWnZHZFo4enhwaWdKVEVXeXhTcDZkeHJyZW5rNHd6ak82?= =?utf-8?B?b1lTYTFncy82QTZ1bUQ4d2xRZ0dsUWV3T2RUeVc4RmF4SnllWXpZVXZNTXhw?= =?utf-8?B?Z3RiRERPSnh6ajJsY2VocXVHTUFIc0NnWllNNFJzY09nbjdNVEVYM3E0bStk?= =?utf-8?B?Y0JoRHp5Y1lFckdqU1lPZDdHTFNSbldsajNvRGhaOVJKWDdVU29xK0FIZmtJ?= =?utf-8?B?d2FaWjB0aDVMUXFESDZiNmRkcWhoUzA5YUs5bUVTcytadnFMWkZCbGlCc0VJ?= =?utf-8?B?SlI3ckRUVExPbEdzdTByZnowTkZZdFZNaHJ1MTFUNzMrMTRHVDVydStZbnBQ?= =?utf-8?B?aTlmZVNsTXZ3Qit2L3VCdjJaN2Fra3NwbkxMRHVkeWJNckhweEVTVUJuLzNi?= =?utf-8?B?STdaSUd1TlNTUFVTcFByYkk1OFVSZElOakpmdEd6TXhZbVVxL3dHbjgxMFJy?= =?utf-8?B?Qm8vdkYwZkduZ3phaHkxbHZmWEdvZWJmbEVVUGJSS2c3UU5OY0lKOC9rNjdD?= =?utf-8?B?Mi9NZENVSVBmSWUwaXdlamp5dlFkN0c3NWttamIwZUZzR3N2elJrS0JiM29F?= =?utf-8?B?L1NtOXlQRm5yZzN6bjRkK0xJQkc3RjFvalZiWW5oR2hqUVluOWFBTzlucnpa?= =?utf-8?B?NGFIRVVZNXlNMHZSNldTSkU4UTRtZnF5UncxVCtLSmhibDZwbUt6NnEwNmlF?= =?utf-8?B?Mkc2Q25MRTJMZUdCOGtRczJLUUF2NmJwcFRjdVgvTjZoSTBLS3BXT1N1UXh3?= =?utf-8?B?ektWaTNYOG84aFIwZnpXbWM4L0FINllQU1p1aUY5RCtTQnJqemNObDZjNDc1?= =?utf-8?B?aitSV3Q5RW5nRlZnQnhJbUU2d1BGME1tN09FeFZsSWJEbDZFb2dwT05IRThT?= =?utf-8?B?cUxhNjR4TnhyQ0tnaUdqRXRMcGVqZVJRNTJHOXZvQlpkbnAvM2xkd1hNSHhB?= =?utf-8?B?VGMrRXRjWWhaRlg3QmhYUUM3SjRpTk5tTS95VTFhaXNnK1FWYnh1R0ZzekdX?= =?utf-8?B?QXZ4SWFuZjJZbEZrZHZxRHBXMnpMMEJFOUVKSHl4YkxrWTR3NFhQeHUvai9o?= =?utf-8?B?N0tlYVFTYlRmYzlJTzBLWUMxdHZONWx5ZFpoMjl5QW9ha3N2OFYrRHZsRmFw?= =?utf-8?B?RkZ5bU5xWmRmVmVGdDVEWHc0REx5NVpFQ1BjR0hlV2lYNXFjcklRT1E5WStE?= =?utf-8?B?SlNBamQvNk4yQkR3UkhkbG1DMmFMZEhEUFpDZDNqVElHSFJ3QmMwQzg1RWNj?= =?utf-8?B?UUwxbjhReWJBeGZ5aWxOUXlLcmFlVHhKWVp0UGxzSERQUm1FWjBLaFQ5Vnlw?= =?utf-8?B?a0NYcVZaTjlHVDhPSUw0TXJlWnRGM0hFMUkzaFFJYWRlSXp6TW1tdGhrTU5s?= =?utf-8?B?a1Z0eEpzNTNEL3RhUmJqV3IxUC9zblJOeG9VWkZZYVhZMmhENlFYazdzS3ZP?= =?utf-8?B?K2Q4NVhkVkx3ditobEd5c3ltLzhuRzlVWU1HaWppZFJ1Vno3c2V5Y0RCNzZ2?= =?utf-8?Q?F/95sxZfT9cXjP44koYV?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-71ea3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: c32eeec9-7a75-4738-a15e-08db106611bc X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 21:37:57.6152 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6133 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Feb 16, 2023 at 12:40 PM Ulf Samuelsson via Binutils wrote: > > Cleaned up attempt to generate CRC64. > > > Added code in lang_end() to calculate the CRC. > So far, I can retrieve the location of the CRC > and the start and end for the area. > I can fetch the .text segment as an asection but > > if ( bfd_get_section_contents (link_info.output_bfd, > ts, > text_section, > 0, > ts->size)) > > fails... > > The patchset should contain the LICENSE and the testsuite > but git-send-email does not like if I send 8 patches. > Sending 6 patches is OK for some reason... > > [PATCH v0 1/6] CRC64 header > [PATCH v0 2/6] ldlang.h: CRC64 > [PATCH v0 3/6] ldlex.l: CRC64 > [PATCH v0 4/6] ldgram.y: CRC64 > [PATCH v0 5/6] ldlang.c: CRC64 > [PATCH v0 6/6] ldlang.c: Try to get the .text section for checking > Hi Ulf, can you state why a built-in support of ld is needed? If you want to embed a checksum, you can use Output Section Data to reserve a few bytes in the output, then use a post-link tool to compute the checksum and rewrite the reserved bytes. I am asking because I am unsure whether this feature is generic enough to meet a majority of future users' needs. We can reasonably expect that other users may want to use different message digest algorithms... Cheers