From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2107.outbound.protection.outlook.com [40.92.42.107]) by sourceware.org (Postfix) with ESMTPS id 2C9233858D32 for ; Sun, 8 May 2022 05:46:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2C9233858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CzffVgedlDP8X4MKHPI/86AIS9qei0y1WVDqgbXP5cEK6qzQgPhOt6a80MMMrIcCGbRzgAUbc3cmqjnbHvtBtdy17lEbmm5jaeC3Wd4xig5vpEAuqUiZwtSAWeICSnYRPwhdz3NSSJ5w9e5VLWY6rYK07X+urNT/cxx754Ud/WyCKvas4YIgQgX0FUu3epZ96u+R1MsMrZJj5hd+f0gGRSm2labVpxrGkG0XcAWGN5NrpvTiC5eyhA0wA7WQqdezarXpzdKw6E7KdnofBcwW2j9xGX2F2E9zYKt4QCJBoIHF5XO3H61cOerL5Rv5zlKODSOtg6yqkaWfxhp7tquxLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UZWp3D7G/capHv4ruOZbncKpyqrE+e8oe9tFGELxTK4=; b=Y41VFf4j+1X/Ei2nZtF6Rjy0iRtniYYPizgYRM/LfIaYoSNwLPJI4bS3mCFgZXsxKZ94kRZisVRe2WR9S4QfsHgiyLiX9bnE+jvVSC1T4uwv/jXWY6USmAaoeBB3SN5tgi//lgBEddSL86cJ0+8KUXoZzhMJ8xtXKCnTAeW8YPS3RAIVXAumC+TgSS/SbtYvxupOtHQVllrwf4fNFWRcQ1JiV5qAJ05WcNcltwTNFozU8sOphIbgMIb3xAzD6KFH+QXSDfxi1VIR+JyUOzU/tvl2SaqDgoBQGtJmrH4I+hTqCNGhrSCUK1ROthqyeQjLe7y3iivuvvHTVrMARA/C3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) by MN2PR12MB3504.namprd12.prod.outlook.com (2603:10b6:208:d1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Sun, 8 May 2022 05:46:39 +0000 Received: from DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::157b:f0dc:aacd:afc1]) by DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::157b:f0dc:aacd:afc1%3]) with mapi id 15.20.5227.021; Sun, 8 May 2022 05:46:38 +0000 X-Gm-Message-State: AOAM531bTlrl93ChmFiEMEeprKyYyIOq+uqdFYnEwicmfPFgbQ627tfB PnHQM1t8YP9twBFs2dHo4xky6HOFyDIKfMwhu04= X-Google-Smtp-Source: ABdhPJzXmhlu+rLlOT8o+h+1avl4/57MlNF0XReRxMWwg214Y5MsE5cx18lc8LMhGOzYwZSMqAt7ATa6f/4JAACHTnI= X-Received: by 2002:a67:f9c3:0:b0:32c:e32d:c7ab with SMTP id c3-20020a67f9c3000000b0032ce32dc7abmr5604717vsq.52.1651988796593; Sat, 07 May 2022 22:46:36 -0700 (PDT) References: <87v9115um8.fsf@redhat.com> In-Reply-To: <87v9115um8.fsf@redhat.com> From: Fangrui Song Date: Sat, 7 May 2022 22:46:26 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Commit: Add support for displaying unicode characters To: Nick Clifton Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-TMN: [uvllVXFHww1esH77QkkHFBlY2qiydSGP] X-ClientProxiedBy: BN9PR03CA0207.namprd03.prod.outlook.com (2603:10b6:408:f9::32) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 685116eb-c7f6-4afa-d2ef-08da30b61e91 X-MS-TrafficTypeDiagnostic: MN2PR12MB3504:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jl23fITXOIWvqHqcV0mmyC1RkXNg1tPaeH38HSIW05LBFt4J8qfrjPMdlZCPoNGLW4i+4/n5EIEc9zaZdUHnsDGoBXtnoaMX3o+LNTwdVN+q+f/FVWaIxhnAYfUdMZSKHSqdhVrMckbuDW0SH9FkfdLNmODXmLcBGuHRittHjYkFxoqdz2VPugIT1ytBXSHaBxwiK8w4hA+QzKh+z4lAokX2138PtSHEjlbalmkBJ2sRV7bOhdrPLvKtifuKLWQCqD8AoUUgPgmkVrRbV1VLH1Z4acp0mA5UxKNn0aGD8Q1BfZuF9mALSdpF4gBiabI1l/qt7BC0cz7JfU9G9FXRgGwvuRyJ+NVS3aYT9AKLymoIAbPkCOSmbjyYtSz7gEfEimO8mY0hWtMfhdXtOEid3nJPf8Ic8eqpc0vZipSi2oFseDPd/W50YFpYk8P/QzmV03lYOZs8its2OtBguca8dlTN1t5oucAq17H58xB2541mJIP+cxtKAzWxqy/Ffe4bkQro0hDJcCR3x2AcMGe/XXBQzr1nSBJi2YxFzmXzTc7mRBpO5Jl510QwdyMsOxTCGFMDaZYJcXoyylOJ2uy1L+GJpIyHyt1xks6/KMiN5v2D/PMyCHIQtOxXYUHIjOWNycRosdF1EmeOl8yxVLPWhTfmdeYJ6Ojk/KvgvDhLK8lukIvAfYkamCM1j7Xhge6y X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGdZZkFJQUVTOGdsVUhZSCsrak9QUE1SazFEOUdNQktxK1VoQ0JjTDR3cEpF?= =?utf-8?B?ZHExK3pzSmdVVklsU2NSQm9VVFd3T2lpUHNIbVNCQlVRN2RXTEZacnJ0ckFk?= =?utf-8?B?NW5VcFljTVcvOWRMTmwrV2hDdjF0a1IwTzZ3dnNldEZlQ0tqZERRSTBzanVl?= =?utf-8?B?MS81eEVrSEtFdDJhUnlaT1NhaWQzTVBFWlhIVXNrVHB5V2cvMUkvUVhENEpD?= =?utf-8?B?cGlMTnpzSVFWbXVCaTVaT2ZNN0VsK1ltOG5IdFp0Szg4UHlYMjZ2Rm9YTmI4?= =?utf-8?B?NTFtN3RIWG8yZVBtaDk2ZXk0ZStJZkJJK01MWXlORXNMWGRoUVZDeXBtb2Nz?= =?utf-8?B?aGJtVWdtL2lRVHRNd0h6VHBSNFRNR3FxMXlQdDkzbk1DOG14WnVYZXVWeGdY?= =?utf-8?B?L3UrN21uSWJEcmtqY3hoWUE0VXM4Zm9JaS9wd2dXYTFOemd0Q3Z5YjRuQzl0?= =?utf-8?B?MUF3QmtyK2ZFYlZlZWViSXdNbzhSaUlUWkQrMFRTVSt0bTFkVG90Z1JVbTUv?= =?utf-8?B?OFpyYzNQZHpyUXRqZnFwS1plMGs5VWN2NEVJS2NJYnBaK243YkZSVzVsUVJm?= =?utf-8?B?NTIzUWFOZ0wvRDB4WlVVb1lvZ0ZXZExjSmVKUFFJQTc1RkIwZlNjS3FSanRS?= =?utf-8?B?UDZnd2t2b3NsenpvRWhxSHJaQWtSM0VpMTU5dW95YmhPK1Z3Sk4wcHVuZkVW?= =?utf-8?B?elRYdDlzbWt3UGdaY0pPTmJ2VWR4anBZRTlKVlFRc2ZRWEVtK1h3ZWFyU2tD?= =?utf-8?B?S0ZmcXlDL0x3WXBPMW5MdUdSM1JjVE5zZ1c3MVhxUFVIb2taNkpRYVIrSit2?= =?utf-8?B?MkpwME11T1BIN3VSR3dEdlphN2o3WHgybi9xK1Q4aittdkorb056TGEzOGQ3?= =?utf-8?B?VXJEREFvSUhIZHRFUkRxM2toR3dOMlNhS01MOHFrQ0tHWW9rNHY5cFJIUmI2?= =?utf-8?B?Mk14eTFEb2ZyZjFzcUpvS0RIeW1qNTZaOEVrMVQyNllIenhXb3lnaHZKRGxK?= =?utf-8?B?dUJjT0g2YTFhZnpIbXFWYS9nakN5UTBSUTY0ZXVRS2o2dmkydnJnTiszVDBj?= =?utf-8?B?UE9HcUdxMTNOY2ZCa1NsZjE1ZStHN1pTRHV3OHBDdmROWXZyaTQ5MGI2dlNq?= =?utf-8?B?S2hBWmRuK2Z4NFpzY3Z3ZWtmYXZoOTBxcWFYeHB5aXZTR3pxSmJlbnhidVoz?= =?utf-8?B?MG1CaDc0RHdldnhwbFkzZTFRWFJiWE9ucitPSVpIV2dxWkNKdm9vVzBkNnJt?= =?utf-8?B?TUFSRGU4VkZuMTlrQjhadGhRdXlQSHRwMzVDei9aM2VtWE5xWnZrMFREMkRv?= =?utf-8?B?ckZCYmg0MWhSUjhFVmdEMXJYTEZjZnNwL1lRWklES2lUOXVLM2hSajZkdzZz?= =?utf-8?B?RzBMQXJWYzZNZFhQc0g1ak5EcjNmODNSL2FTNkRIbEUveFdueEtJblprM1I5?= =?utf-8?B?TUtFRGxwZnhQcnVRZ2tTRUs2V0luL1NTaXFrK3hWQ1R4dVJBUkZvUG9hdXJD?= =?utf-8?B?ZGxsdnFjSTIwd2k0NkpHVEN5dUFBb29BTEQ0eGpwRzNRUEI4SlZDUXdySDNE?= =?utf-8?B?Sm1FanJ6bXJJRVRjU2tEVHBnT0xxRDRSZVk5bHExK0xRaUN0VEI1ODJBbjFz?= =?utf-8?B?MTFMZWlGbUxOMjd1WGZxcWI3QTMzZ3FlZ2JMczVpcUlSR0VySEd2akltY1g1?= =?utf-8?B?QmJQbjNJYnhKSndXdmJFOE12b1gvMzQ5dU9UYVBNVHBiNCt2YjFCSlJadGxB?= =?utf-8?B?ZnJtc05EK281a2RYYTlKU1FBaW0yanBTVFhrUktsYnZzb1lRaUZjTkx4d1V5?= =?utf-8?B?dkF5QzZSZjFVMDJ6VTZyU0FoTFVHRHlBdUVXcFZ5L0dyL2tLVmJLZGEySW11?= =?utf-8?B?aE1ZajBMYnhTRGFGL09UcDZvTDJIUWxvQnpYdGUvcFdDQWc9PQ==?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-71ea3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 685116eb-c7f6-4afa-d2ef-08da30b61e91 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2022 05:46:38.5943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3504 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 May 2022 05:46:44 -0000 On Tue, Nov 9, 2021 at 5:25 AM Nick Clifton via Binutils wrote: > > Hi Guys, > > I am applying the attached patch to add the ability to display unicode > characters to the nm, strings, objdump and readelf tools. This is > part of a response to the Trojan Source vulnerability that was > recently disclosed. I am also working on a separate patch for gas, > but that is not quite ready yet. > > Cheers > Nick > > binutils/ChangeLog > 2021-11-09 Nick Clifton > > * nm.c: Add --unicode option to control how unicode characters are > handled. > * objdump.c: Likewise. > * readelf.c: Likewise. > * strings.c: Likewise. > * binutils.texi: Document the new feature. > * NEWS: Document the new feature. > * testsuite/binutils-all/unicode.exp: New file. > * testsuite/binutils-all/nm.hex.unicode > * testsuite/binutils-all/strings.escape.unicode > * testsuite/binutils-all/objdump.highlight.unicode > * testsuite/binutils-all/readelf.invalid.unicode > I just learned that this patch added -U as an alias for --unicode. In macOS nm and llvm-nm, -U is an alias for --defined-only. --defined-only seems much more useful than --unicode. I wonder if it is too late to redefine -U as --defined-only... (On the llvm-nm side, I have filed https://github.com/llvm/llvm-project/issues/55297 . If it needs to keep compatibility with GNU nm, it will need to drop -U....)