From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2024.outbound.protection.outlook.com [40.92.21.24]) by sourceware.org (Postfix) with ESMTPS id 90BE9385843A for ; Fri, 28 Apr 2023 08:09:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90BE9385843A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQ2et/HN/AVWYhvDGIs4XIcWCXMbJsdxZihIbiGN1dPoGTToMgTt5S9hnPrCc+zOC2m5av5xdhbUarHfO7iIrNIqykQ0D5xP2NO64wdAbnQXa4yHp3cG8IHDK5KXp2rndkwShFURjaCDtIkjEWSFjOyF2A8rKYEsi3HYUZQomHxyHACTJsxxkUEtqZ6wdfV/wMw4L2ed/RfaInb6uqpvh09PET7D9TnOaXuXxDfPgANfIlHgoYUboJUxg79+0FQHeDdVoUQPdQYwg/vPxe3+SL2PpjgnsUdWQXd2jAszif0Wh6Xbbt5+qjKZliRxienDi5Q/A7fJUNPOftqECRm1KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JvqwhX8pp2oNugFja3pG4nVcYC74M5Av229zvOarJCk=; b=HuVrkZINCy0HJWXJM4FPvZXl7n16biYHnCBjxGkFaEgMj81lDHoKDb5RnZzFJAqMz9lDGCTXKiUyBPLMfhMt/eb07GoI45mrlqMmbtdjMgWsu07LpZWQ0Gd7gmDT7hHMaYtfV+U7jK0G3VdsZ0Mj/0lFNlu+9+SMcAQGf7rSlZtL0xPyCW/0+f19QxIGSffyMKLAGfa663xg+str7+XpmWjL8WBIpT8+DE0bV0phiIEsopVW9ma5LDQitjDgo14V/8bXqgqw3FEmBZYWxXK0or9ZR3vWhgL0pEKH4athUsjei4HqccmeHQST/PgWydAT22I5zAVr3yCPoNIcWOY6aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) by SJ2PR12MB8717.namprd12.prod.outlook.com (2603:10b6:a03:53d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.22; Fri, 28 Apr 2023 08:09:09 +0000 Received: from DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::5b4b:77d7:9922:f37e]) by DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::5b4b:77d7:9922:f37e%2]) with mapi id 15.20.6340.021; Fri, 28 Apr 2023 08:09:09 +0000 X-Gm-Message-State: AC+VfDyzJZ9iGH3Azpt4HqWBen1a6yA0WFXEwsPZXM2ZUCpsxnAh4qz1 wB/8G90U49Lm8J9r2dI4yZBhrYvkynR+ieagV9Q= X-Google-Smtp-Source: ACHHUZ4in7IqPapkHooSqwWnct1LILBn5nDxDKXaATClOxDcb8mFofEzv8X+EvAWA5WEqZnGtFB3W5qP2Js8puqa1u8= X-Received: by 2002:a05:6a20:7d9b:b0:f8:5cc:d869 with SMTP id v27-20020a056a207d9b00b000f805ccd869mr5392079pzj.35.1682669037734; Fri, 28 Apr 2023 01:03:57 -0700 (PDT) References: <89f892c8-e378-b81c-7b13-322a7876a252@suse.com> <87354otl13.fsf@igel.home> <34bd2f40-b9d3-3de1-25b4-3f29cefd06e3@suse.com> <119b3b40-aec0-cc5c-2732-13f4626460f7@suse.com> In-Reply-To: <119b3b40-aec0-cc5c-2732-13f4626460f7@suse.com> From: Fangrui Song Date: Fri, 28 Apr 2023 01:03:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 5/7] RISC-V: relax post-relocation-operator separator expectation To: Jan Beulich Cc: Nelson Chu , Jan Beulich via Binutils , Palmer Dabbelt , Andrew Waterman , Jim Wilson , Andreas Schwab Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-TMN: [JDkkF7BbU2Zirde0g2dvdFcVxbR0T/5S] X-ClientProxiedBy: BN0PR08CA0009.namprd08.prod.outlook.com (2603:10b6:408:142::13) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5765:EE_|SJ2PR12MB8717:EE_ X-MS-Office365-Filtering-Correlation-Id: fb12047e-d000-4755-ce6b-08db47bfd7e8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LWVeUFBqhyVsEAvwp9e1VI7NCgCy7o0DYfqN71pT8P+9GSrUbqy3BKWq8i7hgcSoYl/2fxoHwtEf/spoRq2NKpXRgCmDNE+zVF03Y/ha3KJMQ28UkxNaeOIiVj3YFBBQLBKeKNM8H1ZGXzF0cwOgEGorpP+YUSObgG2eISb5zpAIKvntXtVDb8sQZVBYdoSasv3J5iYqqzPcN6IIYe64TyK8YZHEm4hNfjlaTc0xI5yCLh6bI3THA6wEKuJJi23yGPlRDgwTjZM5fFRW+TUkL0gFGdKfHufoAZMMoKZCJUVMBoUhV33nXai7ShTzXVbTxIAJoHhruAvCOYTdNht0MTpPq0tCnNJvMV5ulC7P/Pb+/OgLluFXNdl6DnAYokiGcRnH7584Iiqs0+mlkE41BYKj6LRsM/kYkCY0FGgMJI4b7L5QyK1CMYA4uNZo8Fud/2x3P/5tgHqhCOP8yREClgEsdkiJUTmrjvImwl5CFNCtaKlMxtAmPEvxEaf4zWKP18ROR3aCOWPYx6fOh/tP++KNl/6WlBtVESM1nY7oAFPwcfhtcatVB8FWcVsJ/azn/yatdeMQXgI6iwobkhV4yeaz7/rEHh+lvY0OrmCrNd1aRTh9JgXVFg4hbuASeDaU X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bk56UWZ6S0tTb2N4VzY2eVBiQlU3NnI1YXVkS3JJSVllcFlOL0tHajg3QzdE?= =?utf-8?B?Nnk1MytiN1QrTTFYSmF6d0V2ZlVJZkRxU0IvWlhGek1CVkNmaWd3OUJEZmtK?= =?utf-8?B?bEpxSzQvdytMa3lZRlBMTXAxdjhnSmQwWHQ0aC9obkZoQ0ZHaEdvNEtSWjJv?= =?utf-8?B?dVdESlV4bFdCNlpwUWNJQXloS2JsbXp1MHlkSDNncGxkSVIyeTNtbkRlV1A0?= =?utf-8?B?WG1LR3lUTXZyWCt0ditPV2hiUTg3blVuTWU1Y1dVNDU1Z0V5VWZCRkFtcXQ4?= =?utf-8?B?aXkzK1REa0UzNDB5YlZqdFNab3g0bHpjMUE1Snl1VEhlQS9CdUVHc0p6ZG1B?= =?utf-8?B?SUNCOWZBT2JIaXpGd1FSb0tVVVZDZ3lRZ0FiZDlPV0dBMDl0N2N6NkNrZHZI?= =?utf-8?B?b3BTSzFPUTY0WG9UQnh6Yi9maFBxU3o5RUV6b2FVWStSdzYzVjNmcDMxNkxH?= =?utf-8?B?S1J0T3NrendubU5pVklsYlh6ajYzYXhMMXd3UXRJQVhxL2FuZnFkMVRzK3Uv?= =?utf-8?B?UnhBaWQ5SXlFN1A0YmordjhPbUlIVTlxdjk4S0FhbU1tRkgzS3YzamF3aE42?= =?utf-8?B?bFdZSUFKZjJ5d3dkdFJ6czZpMlZOK0NDSnh6SG1jMkJKKy9FM3JiakhDN211?= =?utf-8?B?eThCWXBsUmZITHBLYW5qRWd1K0p3NThlWHBBMnhxM1pPbjRvbExHS1d1VGxF?= =?utf-8?B?WWJWVFpaQzRadWE3QW00Tis5VzhsUzJpUmErYlp4ME91cUxjUXZyRnl6Ykhm?= =?utf-8?B?czZHbWFwRG5lcmkrUEpmdUdXL1ZhbGxVNnNla2hJaUluQ3pQZTNWU1BJeGh6?= =?utf-8?B?M242elJrRE5DQW5MemMwSGlMa2RUSDg3ZTJQakI4blZ5Mk9OZWxuRytsVmZk?= =?utf-8?B?d1h0SGEvRDByT2dKbUs5WWc3Y0JRUkI5bi8vYm03Y2QwTzlwM2NqL0FvNmwr?= =?utf-8?B?R2ZEK2owMU5ZRUE4VDYwM085R1RQdVk5UTliaVJZM24xbkE3Q3k4TXJvNnVE?= =?utf-8?B?S1Z4djJ2dSs4THdrNVZzbU1IYlY0T0c2Y1cwZjh6by80K3lPM3NNYjFrRW9S?= =?utf-8?B?a1dISkF0ZnpVb1Z5VE5UVE9ZcGVZZ0RldFFGejhZa0Nqc3RoM1FDcjdlNmx5?= =?utf-8?B?cDJLZS8xeGN0S29COHlVdHc1akxlUGEvakJQS3d3ckVnNGxiZ1VxUUJDV1Fh?= =?utf-8?B?L203ZWZhMFZQQ3BlblQxcHJiSXMxWnQwbG1kM3hhOFRZNFV2dTFLQjZjMncy?= =?utf-8?B?MjY0LzByRThTai94eUt0Vm05MWhJWHRCaXpGN2dRVDlSZFdvRGpNR3JWSDF1?= =?utf-8?B?ejYrUXlyNGdac3VIaDRaNG9yRkFMUFVoUE90UklvNmxzcWtBc3l6ZHdyN3JV?= =?utf-8?B?NjBpMWxhLzJXWXFkbE1LeHhxTGo4b3hOSnVOd1dFQVFjMlAvTzMxQWJRSkt4?= =?utf-8?B?NDdGK1UrUTV1S1F6SHNqbUdLU2p6bERRekkzWSt0eFRYaTlHUDEyNjFJNmRt?= =?utf-8?B?WStESmtvbHFZVG5QdDJNUVNkK01wdUlXUENDdlVBcmY1OHV6YkVPUWVNalAy?= =?utf-8?Q?KDL9+XQVO3RfkLHweg4twd0Ct3zTRbX24V3m2eoQvcH4Wa?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-71ea3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: fb12047e-d000-4755-ce6b-08db47bfd7e8 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2023 08:09:09.2778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8717 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 27, 2023 at 11:05=E2=80=AFPM Jan Beulich via Binutils wrote: > > On 28.04.2023 03:29, Nelson Chu wrote: > > Sorry for missing this one. No, not a request. I'm fine with both, si= nce > > this patch won't break the risc-gnu-toolchain regression, so most of th= e > > stuff already used looks good. It seems that the risc v-asm doesn't sa= y we > > "must '' use a parenthesis after the modifiers, it just shows examples = that > > all use it. > > Hmm, interesting. My interpretation of especially the table in the doc (n= ot > so much the examples) would be that it pretty much mandates parentheses. = One > might even go as far as taking it to mandate no blank between reloc speci= fier > and paren (but I wouldn't feel well going that far without it being said > explicitly). So my plan was to make the alternative patch, and then leave= it > to you (incl other maintainers) to decide (with my personal preference be= ing > the yet to be created alternative one, now that I've seen the doc). > > Jan I agree that rejecting `%hi sym` shall be a reasonable change in gas. The LLVM integrated assembler (used by Clang and llvm-mc) rejects the syntax. % cat a.s lui t0, %hi sym % clang --target=3Driscv64 -c a.s a.s:1:18: error: expected '(' lui t0, %hi sym ^ a.s:1:18: error: unknown operand lui t0, %hi sym ^