From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02olkn2074.outbound.protection.outlook.com [40.92.43.74]) by sourceware.org (Postfix) with ESMTPS id C85C1385842A for ; Wed, 12 Jul 2023 15:50:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C85C1385842A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BWFdUqnrkvKLX9fhm5W33gRrS4UjZg+26iHGiet4UZlxXUHB8Li81lp7vshhW0bx0YmoCG5YtAkKxGfALT6ihjfz3/HVFywCjsoBwI//8qrNqs5HVuLauWOGm9rLOMdstyxCr+pD6OY15n/GwDaqecS/azfh9MzJl94RjucFMgD4c4W9cvTez0OyJQUq5hDhMdfFG0L3iwXxw909+anruWTu/uKNqsZTPWBFfA8zGYF6BlPkGq3CgSNWFWS17ID7FKjKpNR5p8iolLY2HpVJc1EAL7tBc3zPQeZYrPUtZUegAuh2yx4EYN/MkqEphmYW43+Z0ksaxBFaFYQLTw/U2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dntPtMNfKeP0hQ+sBOvWzjsDTZ/Bw3SmBhR596LSVdY=; b=FoHjCt1luFZr5e6CLVLSRdzsQVEydBrUu8kHiUTuHnrb3N4E/7sx1PDLo5KZHMMjRbhPUG1vgAQp7L0onirCXkVyMBBxWC31OAu8ql8l8AxybFFJzN/J7i7mQfPjqke37VsrDLB1/P9wpSOxkIWEuE7PBryga1b0OLNl93PtMWOJeLUfuNlkBYqQSf3ZIDNDWEW7p07hVh03X/3uSbSRKrG3KMAPSDVEG1v/a5asKtR0IYdiTGjY18v1bATU6w6Vs/eNUJCOhLZuYFfDvIjZme/RXH6Qpq21M1iMyFlx5tlnlnrDwOgTcs7UfyZElxzpzMVcH9I4Y2r+MKS8N94jmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) by PH7PR12MB8828.namprd12.prod.outlook.com (2603:10b6:510:26b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.32; Wed, 12 Jul 2023 15:50:16 +0000 Received: from DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::670e:64bd:78ea:b489]) by DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::670e:64bd:78ea:b489%3]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 15:50:16 +0000 X-Gm-Message-State: ABy/qLaFrS+D/vKygdrcKcp63i+AfJFPfwyM3w6X+3I7GgqUcukMKX2v Aq2fbLKyJbgL/g+vT95FTU6GqPCNKZALnV8IxAI= X-Google-Smtp-Source: APBJJlFx9Deim8yazdlCNTM0+pEG7JureJlIRmiBuVhAvh/ou5S+d1DD1NMJbHgOoz4xtFDfmZNbtjIUwyglIdzKogY= X-Received: by 2002:a17:90a:5793:b0:263:f5f8:beed with SMTP id g19-20020a17090a579300b00263f5f8beedmr14087382pji.19.1689176532010; Wed, 12 Jul 2023 08:42:12 -0700 (PDT) References: <20230708053035.528911-1-maskray@google.com> <2a422912-1b90-d1d0-49ba-c2898680a6fe@suse.com> <20230710180734.tfgfctsvl7ipo6at@google.com> In-Reply-To: From: Fangrui Song Date: Wed, 12 Jul 2023 08:42:00 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4] PR30592 objcopy: allow --set-section-flags to add or remove SHF_X86_64_LARGE To: Jan Beulich Cc: Fangrui Song , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-TMN: [pDmLIMuSEs4V80mtvQYHYh4zksLNfueU] X-ClientProxiedBy: MW4PR04CA0306.namprd04.prod.outlook.com (2603:10b6:303:82::11) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5765:EE_|PH7PR12MB8828:EE_ X-MS-Office365-Filtering-Correlation-Id: 10cfdfa3-b012-4826-1bae-08db82efaf98 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pUmK+dY0cNFyH+MYgoTRYxv/eeCVFzXzZmuEnTj67NSbZGEkU80E+lxkaEBHJdw0NxVWtzsv69UH8yTwCLp2zjPexsJMpXKr1tJSK/eCi+nMpYWGgSGhWWP9ZAyyTB4QVJR4hY5HNhi66G55jo4kivpBMlQflzWqTJQfk6XlyCwSlA5CfY4QEx1PRZ3x9YUeEA7CfFHVskNAIfYCMaKaHiKnvEBfeG0Rx27iY85axn0OX725hbasTl+XidL8m75lx0ZUbuvi23CQaWb7aX3EJ+Tmos80TyX31sExvQZtma7m6meCId56Ues1r99pVISsTc6q5bR9mCLI0k2MxSSG9YuOxF2ii9eGD2OUtDduwc4qdztqkfiOFzGRXXDqo3Ydq9/lkpwJTHg7fAHxc1nCsxL88Xudr1NY9JvNNfvd7KfybKO/ve5i4ZFR3cC4aQ+o8yxiBizk8tLpVZBU80NBfLCcDMujOUJs6EaZAscGmJvw0M/eQl+y0RaIE3Pc+oQWTS/Cgu4a3TvK614NQKsHDjHGAhDZRBZzzWFTnXjSR37ifdJ7X3ka0WAOx7jrZWsr X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2JRSkVlS08wR3pHSEhmQmRrWFBvMEN0Qmp5MnRrcVFWdnphQVZWUXFQd0Fz?= =?utf-8?B?eTBtZzJyNGxWTnNlVnh5SGZ3ZFZ4UU80aTNSNVFOUE85SFp0cC83Q2FHeTZH?= =?utf-8?B?UjlhanlKbHRLNVh6d3NvV0dNRkczWks3Y2pSK1R1SWVFR1BFQVRVMUNCUU5L?= =?utf-8?B?RmZXUkZKa1VIcm5KeVhuSCtyM2dJUTRQWCsvMUhKZUpycHJnbC9zVWtLWVov?= =?utf-8?B?TDJkbmV4VlovU1BkaFZDcG14alZ1MVRrTnJpbWFnZllaVkZyQmFER0ZEK2k5?= =?utf-8?B?UzVqckxVTWFrMVB0dkZuNmRlUll0ZkpvRjBxdEt2RkRwTHRqVWtrK2lkQWY3?= =?utf-8?B?SlNNVm1rQkhXTzUzYTlIS1lFS1JNME9OMlozOUt0b1AxajdudzN4SjR4d0Fx?= =?utf-8?B?SkpuRGY3cWk0bmZjT29lZXR2M2xHZlZFcE1aaE44VXZjeEE0RTJKcnhraE1z?= =?utf-8?B?MVhjb1l3L0xJdE9Zd1dPQzlJcW1WeVdxWHMwdDFzSmJ1QkkwczVobUtUcDJP?= =?utf-8?B?MUhic2prdXlVaVhRVzAzQkQ4aGlJZiswcERaV0xrREtjOHNJN1NjN0RaeEY5?= =?utf-8?B?aG1Sa280UjJyMnA4Lzk4WXh5UHI3S3NHRG5sSGtONVR5czZBRmFPOFNGLzg1?= =?utf-8?B?UmlFL1Q4aW1MVEF3T1VENWFaRjh2NFRMU2pqbWVrdlUxQitJdi9VRDViVDlh?= =?utf-8?B?Qk9VMXZiRG1wNVVVZENrYjJmS1BNMHpEclRSWmNVaWVQRW42TWhLNURxWUdv?= =?utf-8?B?c2ptb0tSbGo2RGRlZVFLazQ4anJuckVCM2FueVFYVHZNSUwxTVlMTHJoU0Fk?= =?utf-8?B?OTh1M0p2eDdOUHhDY0lKUk12bEExMEV1bU9oNDVSMVlzR2dURDVhUVQ5YjlD?= =?utf-8?B?eDJGNHArbzR6MmN3NGxkeDhJREJsLzRoazdQRUFad0tsNHRQL2VHcm81SEdQ?= =?utf-8?B?TTJrTnZVM3YwRi82SEM4OGJNVThVVVVxNTV2dmdURVNBT1BvUS9WZS85ZnFp?= =?utf-8?B?TENjUGR6SXRERGRrL0owK2h5QlZQa1FZMVdPOWFVVldUNS81UWtvSlNMRU9s?= =?utf-8?B?ZU1lb1dhMlN5T1FkcnFRZEJVeVUrQ3pNRWRiZFNHN2IwbGIxZGswQ1hzMU5q?= =?utf-8?B?TWlqeWFaTnFPZ2ZXUFBFVXBYdTNLSWF5YzJIeUQzNDg2QklNRzRZcmc4enRJ?= =?utf-8?B?WXR5dXU5cTdhZDZiMUFxNFkwcWFpZUpwT2dmWnBDVkJSUzNRM20vUnBKVkFi?= =?utf-8?B?U1JJZEZhTFVjVmtVaFVLSHMzWlJVSUZ1VDdsaU5rekdIaUhGa1pBcVFZWEFv?= =?utf-8?B?OTcvM0dLdWtVMlVLaDU3RFFSUVVaSlJUOVd2eFRraGluUS9KeE9HbTFRVXV5?= =?utf-8?B?YS9ISHcySEU4dFU0Rit5RDFZZmdkUXYxL2h6MElwT2pjQVFmWXpqeG5la1ds?= =?utf-8?B?L0ZROHN3WXdkd3FKZXJvWmpTaGdmdWZ1a3FkVUhUNS9xaVBWeFdOTC9XdWk2?= =?utf-8?B?UThyZ1QwMGgxRTloNlkzMTh5dGJ1anZONzZtY21HcGtmb25NRGF0UVFJek1p?= =?utf-8?Q?tL+5uHR3UB+pICph1YP9bF+jUwQo6s9z99Tgp+xQdWRVtq?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-71ea3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 10cfdfa3-b012-4826-1bae-08db82efaf98 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 15:50:16.1372 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8828 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jul 12, 2023 at 7:32=E2=80=AFAM Jan Beulich via Binutils wrote: > > On 10.07.2023 20:07, Fangrui Song wrote: > > On 2023-07-10, Jan Beulich wrote: > >> On 08.07.2023 07:30, Fangrui Song via Binutils wrote: > >>> @@ -2631,6 +2634,19 @@ check_new_section_flags (flagword flags, bfd *= abfd, const char * secname) > >>> bfd_get_filename (abfd), secname); > >>> flags &=3D ~ SEC_COFF_SHARED; > >>> } > >>> + > >>> + /* Report a fatal error if 'large' is used with a non-x86-64 ELF t= arget. > >>> + Suppress the error for non-ELF targets to allow -O binary and f= ormats that > >>> + use the bit value SEC_ELF_LARGE for other purposes. */ > >>> + if ((flags & SEC_ELF_LARGE) !=3D 0 > >>> + && bfd_get_flavour (abfd) =3D=3D bfd_target_elf_flavour > >>> + && get_elf_backend_data (abfd)->elf_machine_code !=3D EM_X86_6= 4) > >> > >> DYM > >> > >> if ((flags & SEC_ELF_LARGE) !=3D 0 > >> && (bfd_get_flavour (abfd) !=3D bfd_target_elf_flavour > >> || get_elf_backend_data (abfd)->elf_machine_code !=3D EM_X86_64= )) > >> > >> ? > > > > I do mean that this check is fired only when the output bfd (abfd) is > > ELF and the architecture is different from x86-64. > > > > The bit value SEC_ELF_LARGE is shared with other object file formats > > (COFF SEC_TIC54X_BLOCK; I don't know what this target is). > > If TMS320C54X has a section with the SEC_TIC54X_BLOCK flag, we > > don't want to report a fatal error. > > Hmm, I think I see what you mean. May I then suggest to re-order like > this: > > if (bfd_get_flavour (abfd) =3D=3D bfd_target_elf_flavour > && (flags & SEC_ELF_LARGE) !=3D 0 > && get_elf_backend_data (abfd)->elf_machine_code !=3D EM_X86_64) > > ? > > Jan Yes, I think we can do this, but the current order likely leads to better performance (does not matter, though) since `flags` is a variable that's immediately available. and matches the style of flags & SEC_COFF_SHARED. That said, I do not insist that we insist on doing this. Feel free to change if you feel strongly:)