From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10olkn2093.outbound.protection.outlook.com [40.92.41.93]) by sourceware.org (Postfix) with ESMTPS id B8C56385840C for ; Wed, 6 Dec 2023 03:51:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B8C56385840C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B8C56385840C Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.41.93 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701834696; cv=pass; b=IdbS/UBX2ahbFQOMixF7nQKa2M0Xt9gImQYittPdLJhTlJyVYA2rph6QOTN/MVaJLbW5Hhq6t3ngF6bEOaUqLV4jMin/BMlyImXpjvXKQtdR+fwhMiaPBMOtho/6E7Gh48//lguIKc7/h3mePRho/veGL5whbbQzuxn+vuyfwzI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701834696; c=relaxed/simple; bh=Oodz+BhFaWxuPBMqR50wuJ9N+PtqSI7LJ1z4Xaw5/gI=; h=From:Date:Message-ID:Subject:To:MIME-Version; b=WurpxIGWwqJiHpZ4GoMOrBAeavJFgMLHHUeeTMypxB4OmLJcky/gj7F1JabvshJ1d5d4R1vuGJYUQ7RIT2ng44anGU7cSlRoq4Bhpol7ZG5gQgCo/AXPjHeYnLU3SNjc+ENZN7Yt/9vMaDcb11YuYfHHPacb8ccgP7IG6TZfZrk= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NoGCed2/gvceWYvSS7mbDFoiKxX96GCGLd4j5KHAr3yCyieosSnldjEVre6ygtSKt/UheDx4M2/y5HUMGl5TPsovsEGwLuxiiEPOZ4dUTQpl0z/iHwLqI9HC93VqAFUdrPO26FqlsxofXQ4G3qhVbxnQPhyQCeBr5JMokQXrW6wQ3fcNNSyDT94g+epERk9s3U/7RuuTZYiSoSp7Y1YMi/lIixDO53k7J7hyF70/4RW+kKUgnnFWBFjM7h/vY4YFqyD6Gz6X3S2l96IsZ0JEjm3fquD0Ow++TQVmSc3zqiNAE41jrV7jGHIVECjjcHhEzWg6f7FMGpltiLZFFcMzFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZDIF/OxGqJlKQ0+2FPo3SVUs6LPsNyCW0/TJGF4YXtI=; b=htt61uSJWGUeWpud9K/aDo6Wr7Wvt48VAIXLgglOmXy9YDyD6h+TIxc7A8tVe+03VHoPDDbGQOnJ3trKvt7pKZ4JGOr0RvbsrBLKAxbY+A0cXBBP4wOx+OvUlenDsh+F7gkQu906itEUE9pyTeylKqcpHfCHAHCN1AU7neBbHdf+R+nzV3TgMzsXSqLIP1XhqLOaDCbHU5LhM12x+lgv4i2MLCLOm8TtrNsVtNqvp89FhKURGxt8IUJS0XvGnbln3qeTvRIk08JktqsNaabIqhwjeK6n9/sxrpt6KJe+nS0/WYqey7rjLorJM2w/FjEap2FbU/Mku4k7ho6oKOGgsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) by SJ0PR12MB6709.namprd12.prod.outlook.com (2603:10b6:a03:44a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.25; Wed, 6 Dec 2023 03:51:32 +0000 Received: from DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::2493:49ba:b06b:fa80]) by DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::2493:49ba:b06b:fa80%6]) with mapi id 15.20.7046.034; Wed, 6 Dec 2023 03:51:32 +0000 X-Gm-Message-State: AOJu0Yz1LfLM9nA1p5i2WzDDvta79TffbRgK8wtGHSgzvN5BRH+puOpv bt3UKsnHUYiQjd5gurQiIS3X2Ru5IKDmrVt8vro= X-Google-Smtp-Source: AGHT+IGjRKKHJYXZIx8p/WGyp0izaNxA+JFrKrsBqPjL4d8muFIKCz4+KGlkOogIWpAzQ9eWS9YsEcZ6M6tfeoLonpA= X-Received: by 2002:a05:6122:1821:b0:4b2:c554:e9b3 with SMTP id ay33-20020a056122182100b004b2c554e9b3mr404828vkb.21.1701834342944; Tue, 05 Dec 2023 19:45:42 -0800 (PST) References: <20231206031724.2330403-1-mengqinggang@loongson.cn> In-Reply-To: From: Fangrui Song Date: Tue, 5 Dec 2023 19:45:32 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] LoongArch: Add support for b ".L1" and beq "$t0", "$t1", ".L1" To: mengqinggang Cc: WANG Xuerui , binutils@sourceware.org, xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, cailulu@loongson.cn, xry111@xry111.site, maskray@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-TMN: [Ko5kvDHjqMUgG76knPHYJDlq8b+jliFu] X-ClientProxiedBy: CH2PR17CA0014.namprd17.prod.outlook.com (2603:10b6:610:53::24) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5765:EE_|SJ0PR12MB6709:EE_ X-MS-Office365-Filtering-Correlation-Id: cf15c958-09fa-46b8-f96e-08dbf60ea270 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7miZI72j0/scDKrmWAm5/J4+RwOa1mPTfXVuOceFglmNoJIWsXsIhALnojP2MLTjwKas26WBwFPbMGMx8oJXlK2NCFwBTjR5r9NkswuL/r4QK6ln5V98g+E0lcZEMpV7+GbJ1UfBFwKdJKF3ox/rlKLGAkYFO8swIG+J+JE/BdcRhRYJCiXTLD7frhPHELMvxEG1IZGzavjPdDKoO03Ddo6y77Dwod/2K8OOyTvsxt0JCCqJKmTkUqKXYh/7UpGjn+9ckM3FjP+uXM6t2x8g4Nshk8skD6WjUhtpbUQBNatbRtAHKL9y2va17qwcl2hxyci2AzDcjOv35Tqe5FMHXUXCFdOrS2fJIPxGyhw7bV03N2fh87FWvaosYQMa0k+3UILXQx9SUvBrvorm5PqnfmMUCt02PMaHjpKt5SgtwNuuBBEmPpRcspF8myCWmUuLz+4LB44XLM/mV7hRfHh4xvcV19Q/TpnaXOpoJi9ONstgNmBIS7qeNIhV1g7ub2pCwkct5W7hh99SzdhVUVt1bbfrswHC81TPXvZxR+uGRylqs+ZWiIU0t8hY0wRbaAZ/ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TENPMEF1QVE2QldBcmhaMWppZzJkUUpYaXVOV1VIWVBYN3EyTUpSU25GUlpW?= =?utf-8?B?dC9kMWhHMFhEVlZEaEhxSm0rbEFVZkpRV1N3eFQ4ZEV2TUR5aEl1WmNnT0Q2?= =?utf-8?B?QVdzVk85ZEYzZmFXLzZuUlF4N3A2TEFqL0svVkxsTHFOa3ZIUG41Smkxb3Zw?= =?utf-8?B?ejAwNUdudFNiTU9lQi9jZWlmekx0cU5VVUxSMHM4ZlQwT3p0VTQ2S1JKSENK?= =?utf-8?B?ZHN0WktCRWxqbi8wd0xTSWRXcHBpTFRRbUZCaW91SHg0UVdaSHZZcUxjTWxP?= =?utf-8?B?YzNrK2t6VGphUUFjM0RLVTVaRCs4ZG9iTUhMVTJ2WVh5OUdpUG1BQUUxQk9w?= =?utf-8?B?SU1UaUZSeTdMTVNDZTNvdnJWa2dMakNod2Vsa09HNE5iUmFqNHpJT0pGMy9L?= =?utf-8?B?eDF0MS8vN1hPU0JUclJsQkNDM1MwUTJlODB2YTRFWlprMkRiUHlPNGdIeUhr?= =?utf-8?B?UUtLd2YzSE0zdTdKSUxYOXc5THV5QitiS29oL0NKdWI1WmhQWkY0Vk16eHBl?= =?utf-8?B?cktqYjFWYnVDUXBwcnBUaVJZZW5YNkEwNXdJbXdVNnpDSC93K0d0WncyK21q?= =?utf-8?B?cTM1T0RDQStQOXl5LzJjN3hjbVJQcjZYQzQrWTZBU09oUGlpZTMzcFRYUGZC?= =?utf-8?B?a2RxYnhpVzY4VjR1Y2Rlc2NWbnhpd0VCWE1yVGxBbFNBSms4V0NpdFJZY2RH?= =?utf-8?B?NmpabkxaaTgvSkUzakkwRUVkL3U0MUxsUlJhZnNSVUEyRVA4ZUdHNnRqeGxW?= =?utf-8?B?MjFVQVVmS0IxV3VKSkZLWkRzSE44ZnNpY255NkEvU2hVcWtocTZFYVRpcVFI?= =?utf-8?B?TXJ6dGkxTzFQaUdqdEtPcVhNVlFhY3BTK0xwSTNEL1hNTTM0ZGhFWk5nbTZO?= =?utf-8?B?R1lxdXNaQVNGZndQV1dkTk05eDVsZ0pVZWUvVTlWWG4rMXhaWldBVnZadTNh?= =?utf-8?B?U1JRaElvdTZxN01LbGVPVnFqT1R1STF1T1MxV3k5ZkdrWHVqQzlhejBTdTR4?= =?utf-8?B?eDhQeFFLbjlrWmR4empLL3M5VURBVitHczgwQit5ZWtrcU9FbWt5cDdzK1dS?= =?utf-8?B?Tjh6TlJMR21aUktGNTVkVmZMZTUxck40eWRTNlpNNWlJODFBRHppSFBoRTZ6?= =?utf-8?B?MkZjZUVKOWFicU9UU0tEQ0RodDlyTmxkd0lIZ3FhMG5jUzlFZlduUjFkUHRl?= =?utf-8?B?aDMyQ21VOWJaVm56OHMyVTYybHpTUGNrOHZGTzZ6dTFPMUh2VkszNjd1VVZh?= =?utf-8?B?NWcxS0VVQzlVOGgvNTBlN2UrNmVKdFpIWW5lVFYxdnk4QjJKS2pxQVFZV0lV?= =?utf-8?B?cGcwRHQrZ2RRYW9QNE54a1M5aW1oTG5iUHVpbURFL2JKbnpES2lHNG9ZV1BB?= =?utf-8?B?TmZ2TTc1ZHZuMTlaS3FkUWdZcnVNeDlDMkJQUlJvQlFPRnVzVmNTUDF6SUlR?= =?utf-8?B?UzR5OWowVk51S3FCR1Y5VDdpa3J6WHZ5bUZRNFlCRnZKc3cyK3h5SmhvV0tD?= =?utf-8?B?MDI1U1FPWUpiK3FabG5Oc0prd05EV3lTeXJoeFM0TEFFcytwbEpJUVlCSkJ5?= =?utf-8?Q?CedB+tCWCi5/KFVBa3LkaVJl8bwjBAdB7/cQZsAxf8sVdp?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-5183d.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: cf15c958-09fa-46b8-f96e-08dbf60ea270 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 03:51:32.1270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6709 X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 5, 2023 at 7:28=E2=80=AFPM WANG Xuerui wr= ote: > > Hi, > > On 12/6/23 11:17, mengqinggang wrote: > > Support register and symbol names enclosed in double quotation marks. > > --- > > .../gas/loongarch/double_quotation_marks.d | 11 +++++ > > .../gas/loongarch/double_quotation_marks.s | 2 + > > opcodes/loongarch-coder.c | 41 ++++++++++++++++--= - > > 3 files changed, 48 insertions(+), 6 deletions(-) > > create mode 100644 gas/testsuite/gas/loongarch/double_quotation_marks= .d > > create mode 100644 gas/testsuite/gas/loongarch/double_quotation_marks= .s > > > > [snip] > > > > diff --git a/gas/testsuite/gas/loongarch/double_quotation_marks.s b/gas= /testsuite/gas/loongarch/double_quotation_marks.s > > new file mode 100644 > > index 00000000000..bb8acb99a40 > > --- /dev/null > > +++ b/gas/testsuite/gas/loongarch/double_quotation_marks.s > > @@ -0,0 +1,2 @@ > > +# Before only support beq $t0, $t1, .L1 > > +beq "$t0", "$t1", ".L1" > May you provide some explanation as to this feature's intended use case? Agree > Because it seems pointless otherwise without some kind of scenario > that's both valuable to support and impossible to do so without this > feature... I think it will be consistent (with other architectures) to support quoted symbols (".L1"), but it would be odd to support quoted registers.