From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02olkn2011.outbound.protection.outlook.com [40.92.43.11]) by sourceware.org (Postfix) with ESMTPS id E2E07385829E for ; Fri, 26 Jan 2024 19:28:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2E07385829E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E2E07385829E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.43.11 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706297320; cv=pass; b=jqYZ1sIHrtp0fhdN2IP9g1teFylrZHgouvpF97WeK96Bqt15xBd8asNQ38BA8jzxb48gdbuLK6hyo0rCCTGSWV1+iwvyd6cZg0zxdfSfZt8bOVy06vC4P10VE+XhyHbCJTKic9n0V02b8LmJkca6uOwu2jKNZnCO0sVrYAc7SXY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706297320; c=relaxed/simple; bh=lr48CSq5T0yHkBw/tltC98CkmIw6x7a2KwRVjDFPPpA=; h=From:Date:Message-ID:Subject:To:MIME-Version; b=ShcnCMdA/t09l45z7Hu/qBstrrwcyQbXWYZTLAMmJ9whobO8CO8DMHPEXpGe0JwgCTuMP3BtVHZ//eAEKlV6HYoIpZ9vm8yMJEalqrEuEDdl0KIv0tRNUKyl0YVsExZKoQlDznINKcocoaE7C+/7C9iPxvVpHHOelq1Y+LtGG6w= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ybk/DCxaSv27p5HRDzY7WwK98FNt8sTTRmXXrT7kB5MtYgokao3/FSQ681AFHU1AflmRGTktKbnQW1wjZQ+gvRK7dvPAR89YkWZ1d8s+9uGpd0jZx3RlMNubo20oSkBB4yWaXatmfB4MF6uEyfH6xRuUVv864uYwK51pKL/4WfW8l20zyGdJNtU0VUYVWcvKBbJS7c/PKTYXJCylVaEhFgHl5XUXwTTdCrZDtzvdfnetpP95GzUrXMlmg2Xky3yo6FPjPXbgw3OZJuIaBPUpIT9XXo+YEAVWU52kG/SCV4/F0EV8t7dvu9rP1NLVi6Qee+z+9JJngBZa2itf7NW2ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=43iTyryvJAb/S9BvjFGFjWRNon0lK1uSZ21yBnXUxU4=; b=AMFbEj/0WBywT0MZuphGYUtvj+NHbaPCSrvQT1BHCgNKYpSOD10xYBOH74botGu0wJeeNOVoCZ/ACdcHPLQDHubOxfWEBY10cVPdk8gPYZNhGpEtqAu5HU2iRU/w379J1tqS+a4QR7/Pc66IvPrQmDDZLimcZloaq14hybE+X17qwidEJFVtz/XQa/I/hS5rHsg5r5C+yQbarrgRSHAZHJlUPQEUOzDAskns0tdl+V3oA5x5EO037ORYBpb7fXJ1Y6CcjpSTVpeXQmbZ9Q7sKc6JrGw8IzctHYlo4r7bUplaSJJYt10ziWC35m/YaRlgSFFeQcmy77MwzkqI2rxthw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) by CH3PR12MB9455.namprd12.prod.outlook.com (2603:10b6:610:1c1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Fri, 26 Jan 2024 19:28:35 +0000 Received: from DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::fa25:6d58:7ae9:9c0b]) by DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::fa25:6d58:7ae9:9c0b%5]) with mapi id 15.20.7228.022; Fri, 26 Jan 2024 19:28:35 +0000 X-Gm-Message-State: AOJu0YyWQXizT7fHO/RUyPxpXSgcLtWe9rO5iLvIiZpyEYsqj0PzKopE 9Yg1JtliC8w3xyVAib01OBwgeNe7F4CVpu9yphEhsTbV2TvxgNzHhm9wLgGQXT5yrq3sjQRN5iZ cdKcbY3zzG9x4b3rmA5CLj7vl1v4= X-Google-Smtp-Source: AGHT+IH7nkC2Rx7Bzxrj4iZAKlVFE2xwamiTWg4WkZFYun9IV6HSU+KGIXavRC5IcCM0dDapsXzSLdRl694nKULc8lM= X-Received: by 2002:a05:6122:1822:b0:4b6:be94:acc6 with SMTP id ay34-20020a056122182200b004b6be94acc6mr256898vkb.10.1706296840198; Fri, 26 Jan 2024 11:20:40 -0800 (PST) References: <20240126185652.3464023-1-hjl.tools@gmail.com> <20240126185652.3464023-2-hjl.tools@gmail.com> In-Reply-To: <20240126185652.3464023-2-hjl.tools@gmail.com> From: Fangrui Song Date: Fri, 26 Jan 2024 11:20:29 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] ld: Output error for linker warnings with --fatal-warnings To: "H.J. Lu" Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-TMN: [eQL7A9g2QL8w0dIiF93zP8927Q83Nm2z] X-ClientProxiedBy: BN0PR04CA0061.namprd04.prod.outlook.com (2603:10b6:408:ea::6) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5765:EE_|CH3PR12MB9455:EE_ X-MS-Office365-Filtering-Correlation-Id: 70af9ac4-aca7-4cbe-dca0-08dc1ea4fd77 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CqZOhiZKBdyC8SxNbRZjsZmWcJXoMRnXGXbHYSsw+lQe2sj3upaGf1HS9rUqP9jJYAlCpzJ+MzZahgCQHYH/pATBtIygoOdpvd6fMedA1Sl0m4UGN6tazB0S9FqTLl0L+2KVR9ijcse29pAC1DE9I0JnEhxitg05LdBH+b4YzFdDCKDOGyTHY1M7gbLQn3C853FGKkkWTEkdr2iQrhJ2hOhwXGfINu/0mXzLiqyNUq4fJYybwXFewpPQdCDg/lsCkgTeLdOewJ2gCe3pXAb7f0ociRmyvTDoGcHooycbIuxFG3L7iXkoqSyaDDDEBkrVNGBKLUBy9AdVdqiD6janqasPOBbFrrbBfcVd5fqGRv15zA063q7eu6UlhG96Umg5LKzGId4PHVQHzdHf8CsbCx76u4hohzRikI7//YwSHfJKI5Qy2S6P7wmN8u4SM3W4I/sGXRrA7bTUmxcnOCnxCymhpp87LAY9ma8WhVQsLGsJ5cb6h7bb26yDJqnE4iQVpzXML5wsrjKOfF27swZiulGQPsAcS7sGdi1UhYbrzF4FgxR9Y+cWRDGS2+QCdErK X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGRlMDIrTnYzRVVYZDZYSWhjbUE3aHJCY1BzVU4rbDFCNTMyQmtRRFVUcFQy?= =?utf-8?B?TCtKNXdPUE5RaXpsRWNHT0VrdEQvRXk5Njg5dmIrZWhCZTZLVTBQeEdmeVNs?= =?utf-8?B?eXZuNTlFMW1xMHhlZEllNDdMeWRER0ZhNnFzVmwyc2dQeFFwUGFYaUFzK1ZL?= =?utf-8?B?VUxMeGZXZnVhR0QxbkVHYmc0U2lkVmI3UFYxU2JQY0paT3pvR0RHVnV0eHNp?= =?utf-8?B?WnB0ZVB5Z1FYRitwSis3bzkyNDR3SERrbnRYMC9EdHhrbXEyK3VoNEhoTm9x?= =?utf-8?B?N202QnhsS2xENHY0NjNJWXNWMDRxNEpCLzlHUEtiTWltTVljNDQ2amNMYW1x?= =?utf-8?B?THR2YW14L25DWWg1N0kxMlVaWmhOb0tuZGxnSHBWS05lUUh6ZnNndDhKMnNI?= =?utf-8?B?bDRkQ051OVFJUFNVT0x5ajBtQkVPSFZpRWgxY2pQTWI1dktZZkozTXBITk9r?= =?utf-8?B?YXB1Sk9ZMDY2Rkx1YnBBTGxhVUN6VUk0UTZZeWIxYnUvVDI0M24vc3JJOUtl?= =?utf-8?B?U21UVkRhZVAwaldiNk1ucWZrSnBya1MrNkUwWDJxYVJvdXU3bHJWUi8rcHZD?= =?utf-8?B?SFFjOCtVd216LzAyaHdBdi93Rnh4aE8rTEdCNXVUakxLY3pBR1JzcHErdnlt?= =?utf-8?B?TTVtc2tzQkdjZFQ0OENEZkdDSi9TNWRjQ2RUZGZTZ0Y2U2h5V2psRlVZVmNl?= =?utf-8?B?dHlmSUwrY2NLZlJ0WTNTU2pwRGVvZkVGZFJUczJ6M25xQjJRaERPWEFFcjVX?= =?utf-8?B?REFwelZIK0N1V1J2NU9FTzJ0ZHpsZDByY2R0S3cwRDJhUGRGVkI5aXdBYWpk?= =?utf-8?B?U3lzQVJoZTFleG5vQklEdWNITlM2TTJicG80YVFCTGp6OTdXMk51RGczN24y?= =?utf-8?B?N010NC9MWTdjaGVFWEF4YzlDMWRpbmNFQ0dEUEV6N2RHMW5kZDgzQ0JvNGI0?= =?utf-8?B?UlgvYVJoMEE5N0luMTR6ZStCVEJ0U3M2M2RMUGVUeW1qd3RBRk40S3ZYdis0?= =?utf-8?B?dndVdCtaeCs0YTkzNTgyWHRiMVJqMXB0U1lWT1pNNUQyY2xhU0lHZE16QWJF?= =?utf-8?B?OU9NaE1SZ2NrSk0zV2RJNHBtVW1DZ3o5VTdPZHFRUS9ZUUhtbkV3dlhSaWQx?= =?utf-8?B?bzNGWnNnY1Y1VEt3NWRWZlFZQjdvYXR5N2VJby9EZmdHc25HUXVuTEdmNHVQ?= =?utf-8?B?ckNaNE0xZjdnQ1FibmZKV1IvOGJ0WVplOTZHNFI5ck10dzVMSldrU3phdmxM?= =?utf-8?B?OVBqZmdKSm5SRWR0QUZmdXhBbEFVZFlMU0dKYjYybUFiYSt2blRKR3Y1UFRZ?= =?utf-8?B?elRLK1paaEFDR25acWh5eVdpQXM2eWZBeXF4aEcydWp3TEdOcm1tMmtWV1BD?= =?utf-8?B?K2RRNEtVRDdEa2hWT2laNmgvZWd6Rk9jbzZrelZpU3B2K0FaNXJPK0hFbnRo?= =?utf-8?B?QnpPZUdWWk51YzBna2ZMcTA1dkJXaC9hSTZsVkZaTzhkdGZ4YUpxN1ByZWQ4?= =?utf-8?B?MUd5UnkzT240dXI2ZUJ1OTVWVUVFcldJeXJuY3lmV1NheXNRdGtwMzM4Sm1z?= =?utf-8?Q?6RjrPlPcIia2dCwsFpTuDpaLxsvS6bD9aEjv4b3FoSEXKY?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-71ea3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 70af9ac4-aca7-4cbe-dca0-08dc1ea4fd77 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 19:28:35.8760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9455 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jan 26, 2024 at 10:56=E2=80=AFAM H.J. Lu wrot= e: > > Since --fatal-warnings changes warnings into errors, we should output > error, instead of warning, for linker warnings. > > Add %w to vfinfo to output "warning" if --fatal-warnings isn't used or > "error" otherwise. Replace warning with %w in linker warnings. Thanks for the patch! This will be a great improvement.