From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2043.outbound.protection.outlook.com [40.92.40.43]) by sourceware.org (Postfix) with ESMTPS id BFA0A3858D28 for ; Thu, 25 Jan 2024 08:07:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BFA0A3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BFA0A3858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.40.43 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706170045; cv=pass; b=UN5uBq7qgTkv8E1pLBecGW3m3A2diYzuhA6ecocINd9Pa48/Fg8VPHzhO6vbYGZGGKi8lrJlMutWsICgQpXoDaBaoX/U2y3TrYBe/g52Ci5c6o48N3mdpgjZqLqODst+W67G8yl3SjkYvos9JAHAqagaBdgEgou2rEou3N/ogZA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706170045; c=relaxed/simple; bh=aJMcCbrqZFF68z50/M3Wuz+lI+tzfTvu15qHWf1QYrg=; h=From:Date:Message-ID:Subject:To:MIME-Version; b=xMvR+4PIpxDAFDGmz4umGB6tRiK6h0I+Gw7HjIgBHjYTMNBPsI7Kn09XspfmznCP6ltbG5PplMA3cQGgwmo3k2MBE7zWDPEgGxNzPwsjfqrPYr9iwX60tLMXVI8WK0xWok6C/eOzeo1hrMMMMdpJESTNgnKulXlb0jeMTig9O3g= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eh0FtZivzPG3f3JMlzN6wBjvC244Cqg59/N6w5DkkpQSTw/at/tL9eZofbQph8aJVQV/EU2BqmKeMQMtC/Lev4LBUGAsnCq2Mq2v7/+O33G+Ipp0ZKaw9UNNl3u7T6Pq8Bit2KjcGgBetk82tvmC9Vfxj5ZWrPn1EpOnGOKsgPiSKuA21qXuGhHkmePdtLBo8wV03PJmKOLG8re/xcSLTwzY+Ih86vCEuz7PPpl3tiktpjug6SSBj7yqUTZByIhnpENHy/VW5XLaNbmF3FmuiPuFLzG+LyWYYQI0QXNQn0HPzx0QLnDwketpEA3Jlm4Wh6gIMBC+Aw3PNeHMZg/nZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZAFoX1arB7q2vIreuzvchYRA1iAY/Zul6vHXxnQzrh8=; b=Y/gFyywEQObR4fJ4uLnxyhSeC87B7jvy58rwPmk2XZf/t67OA8+SAY7SDr4PpEW1VD/M6U8O3MsiFwQ/tksMv1zb04/1J+mqxz13E8iDnxAuc5jZT+Nu3e7sGTZz1bl2f8EKoIHaE/GnzDIxvZ4+sydXfQ6dNM+3xnmwAC18/7OXOg7gvyO+Ex1+V4QJhtrwKzk35pCmppMR6ddmBO3nivdX4r+u9iBVhxOs/zRzP73O77dNRP427+6+cJTgEF2+wz4zfAY/d1j7KUHAB2EpThWE+OKlXfSZhFVPQMK6MXR4x2wM4LbL0526Fe0pqXhtMv3eREgYpEnjEF0I4GrmaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) by PH7PR12MB9128.namprd12.prod.outlook.com (2603:10b6:510:2f7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Thu, 25 Jan 2024 08:07:21 +0000 Received: from DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::fa25:6d58:7ae9:9c0b]) by DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::fa25:6d58:7ae9:9c0b%5]) with mapi id 15.20.7228.022; Thu, 25 Jan 2024 08:07:21 +0000 X-Gm-Message-State: AOJu0YwZBSJVMH1bXEu6F3CGVz6Gfzuy2j0lf5DxXcKRM20tf8PCTDrH Tl3bwDmmAhKjTJIsYko4PFo3y42WnEymlzVk1UKyLND+HO17G0f4LlDf3JC4EEaYH/iSLt2C8yV huaXBU3H3N+2tY1zTmSucofsdi0g= X-Google-Smtp-Source: AGHT+IFlLW4/Z6zxJMYwgGF8zitLco+iPnXa6DwNKa2T24sZAVlKP7h1ftB6eOLvPlM2Lfqt15wRO5lVbspNTdcxjpQ= X-Received: by 2002:a1f:7cc9:0:b0:4b6:d9d4:7516 with SMTP id x192-20020a1f7cc9000000b004b6d9d47516mr357036vkc.17.1706169533498; Wed, 24 Jan 2024 23:58:53 -0800 (PST) References: <20240124225103.219222-1-hjl.tools@gmail.com> In-Reply-To: <20240124225103.219222-1-hjl.tools@gmail.com> From: Fangrui Song Date: Wed, 24 Jan 2024 23:58:42 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ld: Improve --fatal-warnings for unknown command-line options To: "H.J. Lu" Cc: binutils@sourceware.org, nickc@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-TMN: [S6z95mQ20nQUpdtFeFe01IwgJCpi2uwZ] X-ClientProxiedBy: SA1P222CA0060.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:2c1::10) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5765:EE_|PH7PR12MB9128:EE_ X-MS-Office365-Filtering-Correlation-Id: 358c58b0-7bce-4394-54b1-08dc1d7ca815 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7z/fpIf7kNy7ddSIIc/ldQ0FhYARTDGbOjFzLp/+rSwFwH2Df5z5rNz/uK5MeE8wSCX4EK4fIej62BwFkOCuc00m+215cnwXX7KLAbkI52k5foJ5WbntK1ok4AHw2TO/RwINmZKGcIyEcEVS85uA84V6m7wuXkmX9LRxlUMPb6F5vYJ7f7IMvLrsiaWUxm4pUHxH5gEqgVc2fA63C6Xh0mROBczfdHttHsLAvKI837RUGx3EAPBw6kL9Xvw6UbZPmpg4DkLY8e2k/gZE621h/miJN7JMRuzR6KHTiMtMnZh1stV28zkVoYk2PU+4SdKFhl3U1ITRWCS2Zs2wylKH+yb9W86IGKwSzYHjhPAEcVTZO0AAmObNR2+YUHlPygF4WuS7eUq+ZGQCh1L0ddwwuQad+Ja+0tktDLXkUTUiH2BW6sZ1SfgUGgb8vhQg3PlKVd1IrWDLw63MC6iBQ1TlfVPlbAAICbHFmF9Eqm3bvrdhDLiw1IXquBlLYjxlE+2Z9V3aCl8WpZhtLo0tmlfNBnWlM6rZfa70rMcUvUkqh+TKqmAxLmHIPW+PvMBV1Ce2 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjBsTFI3NE9uSkhwU29qSjdFdk1pckl1Mk5aME9rcmdzcFE0QXE5YWYxRk9U?= =?utf-8?B?RmIraXR0N1l4NzM3Ri9Ua3NDZDlKME5tcWdqb1FsVmV2N21JbTM2RUxZbXpX?= =?utf-8?B?THV4dGFwTkFzK1NtQTFXTjBSRHM1WHZFMlNYaXhqL1ZhL2JSK1BKYnFtWUdT?= =?utf-8?B?RjVpRE9QS3FBWlJDMllQUitLNVBTU2hvTThiR3RJSURpTDYxckhBekZQeU9Z?= =?utf-8?B?VWs0N2NVQmlqYU5FR29UaUZRZXBVLzBLT2k2em9ZVWdRYmZ5TytKTEdvSWRZ?= =?utf-8?B?VW9ZSEIreFBISGdWZWZnTE1PckRiUTF1KzlUSHFLQ1crd0xBZGsyTy9VNVc4?= =?utf-8?B?MHNlb3U2M25aWVVjVWtqYURaMWg4eTVWWWMydE9LSnk2WEdLUkJlTEJCelJC?= =?utf-8?B?aW1wYitwbTZQdVNxemszWmthTm0xTXdObFh6YUFzYmJzWGxPc0xENXFzK0l6?= =?utf-8?B?RHlnV0tHT0RiQ0lKTm5TUWJXKzJweW8xMTFYblJpY3FNeCtydjhEVER3UjlK?= =?utf-8?B?OUpJY2VKN20yQzZ2eUxJMlpWMC9FQjg1UVgvQ2dseER6M1lsZHJDdURabTc2?= =?utf-8?B?VGVtV0s5am82RzJQLzM5SkhKQXZ5VElIaFBwMzM2bGhYVlorQ3o1THFyUCtC?= =?utf-8?B?OG5Rclk5TkxjanhWai9OM0ZXemtOUW9JRkI2dUhaTUJKWXJWTGdoa244VDNp?= =?utf-8?B?TWllMUFuQVg5bDd3ZFV3aTV1YjVWMXBpYTVHOVhyNm01MndYb2F1dzg1SC9t?= =?utf-8?B?QlROM1gyNG5BMGdpclFnbnppZWpENGNVSW4vOWFOSGt2NjdsV1FwZ0wyZ0V4?= =?utf-8?B?U0YwYTUrVE1GY0NiVHpXSno0eVVBQTRTMVB2cGZ0SHpYK1Y0OVlyODRKNktI?= =?utf-8?B?TVdadTVSMGJqTGoxMkVIU2p1UzE5Z0JBRXY2ZG8vOW5odWl1VTRVdVlrMTdr?= =?utf-8?B?NksvYjhTRmRyVy9aaU9RVnU5Mm13Y3dIN29Yd3VQalN0SUFHYnVWZFFoM21j?= =?utf-8?B?SWNkU0tYcFVwZEg0UHh4dmh1bWd0SVZ0RWkrYkFpN3BUZC9wbFpEL0htV1R0?= =?utf-8?B?cWJoNERhS0tVZ2k3WnJhaUVYQlgyaEFVdUJuSDVJU2pXZ1FZYWlXQjI1cWd3?= =?utf-8?B?MElzNHFNVGIydEV6eXl6WkZTZjhFSWtsSVdqZ1E4bGNVVzNLYzc4VitmYlRi?= =?utf-8?B?RkkvTFZnSktiZzRSWUxsZHFFTHJCRjcrZThwRDN3d1BxdlJVNlRlSlJ0TExp?= =?utf-8?B?Z200L1h1Nm1BL2EyQ25LdGkxaVZLVlczbWJGQ0hpMitCNnVzcFlybnA3Zldo?= =?utf-8?B?QVczZ3Y3MjUvVFc0UkRvZGZlLzUzb2NCWmZvejk5RzZ1YzFVOUV2U3hLb0dt?= =?utf-8?B?bFZ4SGNGNEpnVGYreSsxcXVkYUg3YVJIcVNoMEpNeklNZ0QzSTFWV3h6NWtO?= =?utf-8?B?WTVCMXg4anlIK3B3OXpwMGx2UTNkTlI4d3FhVlkyL1NiQ2JvQXRJL09NZGcx?= =?utf-8?B?T1l1MXFnSWNwRDlnVDZjOS9jeHp4YS9TSnlqeGdKNzRXTkVxUXJoZXA3S2lC?= =?utf-8?Q?Xl5bM8vpdNWnlJhvkvmwHHG9ge5UjN5MlFgpuDFCPO8zYw?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-71ea3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 358c58b0-7bce-4394-54b1-08dc1d7ca815 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 08:07:21.6583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9128 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jan 24, 2024 at 2:51=E2=80=AFPM H.J. Lu wrote= : > > There are 2 problems with --fatal-warnings for ignored command-line > options: > > 1. --fatal-warnings doesn't trigger an error for an unknown command-line > option when --fatal-warnings is the last command-line option. > 2. When --fatal-warnings triggers an error for an unknown command-line > option, the message says that the unknown command-line option is ignored. > > This patch queues unknown command-line option warnings and outputs queued > command-line option warnings after all command-line options have been > processed so that --fatal-warnings can work for unknown command-line > options regardless of the order of --fatal-warnings. > > When --fatal-warnings is used, the linker message is changed from > > ld: warning: -z bad-option ignored > > to > > ld: error: unsupported option: -z bad-option > > The above also applies to "-z dynamic-undefined-weak" when the known > "-z dynamic-undefined-weak" option is ignored. > > PR ld/31289 > * ldelf.c (ldelf_after_parse): Use queue_unknown_cmdline_warning > to warn the ignored -z dynamic-undefined-weak option. > * ldmain.c (main): Call output_unknown_cmdline_warnings after > calling ldemul_after_parse. > * ldmisc.c (CMDLINE_WARNING_SIZE): New. > (cmdline_warning_list): Likewise. > (cmdline_warning_head): Likewise. > (cmdline_warning_tail): Likewise. > (queue_unknown_cmdline_warning): Likewise. > (output_unknown_cmdline_warnings): Likewise. > * ldmisc.h (queue_unknown_cmdline_warning): Likewise. > (output_unknown_cmdline_warnings): Likewise. > * emultempl/elf.em (gld${EMULATION_NAME}_handle_option): Use > queue_unknown_cmdline_warning to warn unknown -z option. > * testsuite/ld-elf/pr31289-1a.d: New file. > * testsuite/ld-elf/pr31289-1b.d: Likewise. > * testsuite/ld-elf/pr31289-2a.d: Likewise. > * testsuite/ld-elf/pr31289-2b.d: Likewise. > * testsuite/ld-elf/pr31289-3a.d: Likewise. > * testsuite/ld-elf/pr31289-3b.d: Likewise. > * testsuite/ld-elf/pr31289-4a.d: Likewise. > * testsuite/ld-elf/pr31289-4b.d: Likewise. > --- > ld/emultempl/elf.em | 2 +- > ld/ldelf.c | 2 +- > ld/ldmain.c | 2 + > ld/ldmisc.c | 75 ++++++++++++++++++++++++++++++++ > ld/ldmisc.h | 2 + > ld/testsuite/ld-elf/pr31289-1a.d | 5 +++ > ld/testsuite/ld-elf/pr31289-1b.d | 5 +++ > ld/testsuite/ld-elf/pr31289-2a.d | 5 +++ > ld/testsuite/ld-elf/pr31289-2b.d | 5 +++ > ld/testsuite/ld-elf/pr31289-3a.d | 5 +++ > ld/testsuite/ld-elf/pr31289-3b.d | 5 +++ > ld/testsuite/ld-elf/pr31289-4a.d | 5 +++ > ld/testsuite/ld-elf/pr31289-4b.d | 5 +++ > 13 files changed, 121 insertions(+), 2 deletions(-) > create mode 100644 ld/testsuite/ld-elf/pr31289-1a.d > create mode 100644 ld/testsuite/ld-elf/pr31289-1b.d > create mode 100644 ld/testsuite/ld-elf/pr31289-2a.d > create mode 100644 ld/testsuite/ld-elf/pr31289-2b.d > create mode 100644 ld/testsuite/ld-elf/pr31289-3a.d > create mode 100644 ld/testsuite/ld-elf/pr31289-3b.d > create mode 100644 ld/testsuite/ld-elf/pr31289-4a.d > create mode 100644 ld/testsuite/ld-elf/pr31289-4b.d Thanks for the patch. For newer tests, I wonder whether a descriptive short name (in this case, fatal-warnings-*[ab].s) would be more suitable than PR. A descriptive name helps future readers group related tests together. A PR number is useful as well, but it can be noted down as a comment. For most other warnings, with --fatal-warnings, "warning: " is still emitted. `ld: error: unsupported option: -z bad-option` is a nice improvement:)