From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2060.outbound.protection.outlook.com [40.92.19.60]) by sourceware.org (Postfix) with ESMTPS id 903613858D32 for ; Thu, 3 Nov 2022 19:34:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 903613858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cm0u38I/EvcXemlBDW8LrQzpRHmbwy/EFI6kmJPkyagvm5wKANtJ3atz+c1p8EdteqQDvQdXb7wQEPIIVBlLpU2/3sKE6DXn19ABUdh3dlW8l+ovrdHaxJGADlE4x64/WH8W1UwLXxgWmvcqpO0A2ekFWUbO0Ys9Tma10/thqY2MNIemerZ8G5V+Q51mWlrHNsrIdEMQeBG5FADHYHUzJxJOzdstRjFX4ZOAUVP8GmU4O2JG3vR+Ch545KgzGa6FMZdgFkpoqfmxj3dCpz0aEVxnHmzhx/Vq+156TXDi8d5rmZ323p6iopGcpUXpV9h97YH8aWbAxuhmVLJr/uGnAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C14E+SVQeJNJwtHlsxhNnUMgU2qaaoUbF0JqUZljRRY=; b=PALsXGCAeuYwDp1FQtnVQ9Hj6nsaMAgx1yCdc6OY27iQqIzVdmZzwYzbzBU5ZtmTg+Ccq2deGhux6rBgPpDXQ/x+r+r2vGNDsH5rZ5QeCFUFtaIv4V2RrSI140cjXhsW0d3Jd3l/tqvp8oTV8GkHSeVomSdDC9Tnb15JhD/iTSaEnyyVF7Bldt61n9uRC5pcBz+niJFMrUuNL30NXLCpnhe9ZHVeuXVynvogcDW6g6Jj0eu5qF0g9kO/eXaY8h/axGmM8QPCMND44HZUCwRcswUcuOesGMahMqGUqP3zUucNmUYBGXHIOy1O/0Fcr08OhL3X0uTcozXT+lD4kieI3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) by DM4PR12MB5248.namprd12.prod.outlook.com (2603:10b6:5:39c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 19:34:31 +0000 Received: from DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::3bfa:9356:c40c:b3db]) by DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::3bfa:9356:c40c:b3db%3]) with mapi id 15.20.5769.016; Thu, 3 Nov 2022 19:34:31 +0000 X-Gm-Message-State: ACrzQf349FBaQPbfX0saXvgqxhvN5B10/jNOELakXtOdO0hQTPf0UhAe gGtvPJkWeOikI8Fo1Y8WSBe5RAeidX5hNbNDC0k= X-Google-Smtp-Source: AMsMyM5UKnmJQgVxICJiR7tMflhl+7Audp/Ys4xn8EMYfF0jaNHoWi51kPG2MQjthF++/RuOHuuQXkG+zwG4ljJjKFA= X-Received: by 2002:a17:902:e80a:b0:187:3a52:d24e with SMTP id u10-20020a170902e80a00b001873a52d24emr14771848plg.171.1667504069727; Thu, 03 Nov 2022 12:34:29 -0700 (PDT) References: <20221102080112.33378-1-rjiejie@linux.alibaba.com> <20221103020409.37322-1-rjiejie@linux.alibaba.com> In-Reply-To: From: Fangrui Song Date: Thu, 3 Nov 2022 12:34:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] Support multiple .eh_frame sections To: Jojo R Cc: Nick Clifton , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-TMN: [AAu8D3TIndOmmIqht/q3H/+mJeFLpvsz] X-ClientProxiedBy: MW4PR04CA0087.namprd04.prod.outlook.com (2603:10b6:303:6b::32) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5765:EE_|DM4PR12MB5248:EE_ X-MS-Office365-Filtering-Correlation-Id: c226539c-aff0-44e3-dcf7-08dabdd26e22 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dAswRV6/E4c33vUgC8uKRKk2MNg5d5iKcMCg4j/p3oAU2Yen2FrokbVwGlffKwGeLrA++tOjItgerRLKGPn0LSWKLpXmtRK57y9CYGsTbBO//xAtabafUd6OsWJqtTrI5c+2iKkC5lQn2xKG8r4hwJx4MJw/RxzvuYbT8IF15oL8vek96uliuIWu2T9zRGk0ywK0hkTYvnF8Ed0PYB4v8Uh710ojl+tKG61IBmMLF7/crFN8GhgSX91Bep+oYW8VpET08rtv32I/e56qA/DhZxr3aFm/Z3Xqqjpw3NJZk4fH8fCYB5R9eCZ4BLYYzbyv5OrBKkOiwIIwRP3M4tzUPXSlydJTzOsCr48JyQ1H25cw7P95tAwSmCPvi8vYvMv2JS91pbJkxuseaMhg1qAaLlh5g/TMBB7ly0u9ni3lscx7xpk5OJYSWhU7S2Y2qzPRJ7m/FfC/AzHYzeKxYDncVBlCHyidQHOVDhSrqd2A1j0YwTCd+Jlma3tCx/mB1A/cc+VJSRd+By9+hMfXW3NRgN5mRokiSp0zTW2ZCLPPtJ2/e4GOgD4x5nM3PmY3HVY0sg0mKoKOBUgQsNpYC4rPWX3wJ0S/eOeXaY7extL/lX/xLQ9uk3nR3hwnpIspU50X2WSrv0JuFMPIcawrpZ5/YVnF9B4f6TkoBz1xqUraIKc= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlRIODNiMklwcXJtUEowSkhKL2YzZDY5dmVhU3dKNlBhaGl2Z0pNanBQRUJU?= =?utf-8?B?VEZYdmJ6L2xQMVRFMGgvV1lZZHp2YzdUQXNnS1lMRUFqVHY5bjJnS1R3cVow?= =?utf-8?B?UGtUekRZZlVpNGdDUmNtNFNWYkRxdS82M01MMkljeDJZaWxkblJmK3crMFJP?= =?utf-8?B?TS83V0tTTTFVbzl2eVYzdlNzdU9EWmJZQUNZenA2Q0VaTWF6aExiNGdDMjZq?= =?utf-8?B?ZjZkTTJXNVdhTmE4bHphUTdRLzRON0hNTkpEWGVZUVEvWm1DNWZhazk4SWth?= =?utf-8?B?TytSR1laN3pWY2RiRTBXYVdYWlNiYXo1dU53aW8zQXJNRGczRDAzR3ovb05x?= =?utf-8?B?S1pPU1Vzd0lwNlVWRGh2Q2JpM2lmV0I1VmhEbHVQVVQ4cGtOZ01jcmw0blhC?= =?utf-8?B?cGxwdHhBQU5HbUUxZjkvd0ViT3h2Uk1aSDVUcDdJajFYbmRHbWFQckcyY0dO?= =?utf-8?B?RnBNNjdFdXZlUDlmWnJEa3ZaMnlNYmFzUlFOdC8wKzB1a3QxRDF0WFdFaExz?= =?utf-8?B?eGpkV0ZKRWI5U1AzalpxVnlFQkZLL3VrMlJYSVVMMTUyeTZnTHRRbTU5NnRa?= =?utf-8?B?MzNOK3UrNEtzczVVREFROHN0MnJCWFRqTmFERy9CcU1JM0NjTmNaYWdtSmtj?= =?utf-8?B?bUZKMzdoVFgzTmxsU3hzWDcxZG93emdLSHlUZXE2NmM3MjA3TUIveEJJNC8z?= =?utf-8?B?am1hbTBHT20vM09JMDdBb1loeDdyR0VVSzFrWWJPWXMxYlAvNmRGM0NRRlRv?= =?utf-8?B?RGtKVDN3MjNZdVFxQ3FiK1h4UmI2ZkF4aFJsbWNyQlViUkdaaXVSYVJ3MVQ1?= =?utf-8?B?MjdnaUo0VTMzL3hXZFdoUDM3VDJUK2ZlVW1pRkVId3Yxbld6aEVLNVRjSEFM?= =?utf-8?B?dUc0WWxoWGFwSEVoTllYU0hLNmNCdE1zSXBuWHdCZFdFc2VhMHlkZUJkWEE3?= =?utf-8?B?ZkZpUGFETTRnUUlOMG5yOVFCRkZudmZCT2FsMWJhcDZIL01MbE5lME83WWR6?= =?utf-8?B?OVhwWTM3eWtKVHZ3ZVlxM1pGNVU5dGltc1pqam5jZG12VXBNN1pjbm5Rci9w?= =?utf-8?B?M0hFbkI0UDNQWkxPREhaZmo1Z0hwR25KdG9hNnNWWDRjcUVreTFlUEhNeEdW?= =?utf-8?B?Zno4UTF3SzN0SlJtSnMrbEl2aFp0R21SMGEveEZmS0N5UVBHRTFXQmhrYXZX?= =?utf-8?B?ZjQxaGwwQnNtd05KbVY5T2ErZzN0NjlLQnNXNlliNWppM3hVNXo3SFFwRXJG?= =?utf-8?B?Slp5a3hXWjlZMGhoLzNXUWhncGd1NFZtNkhrL2VRcWR5dUN4VmYrRCtBbnI5?= =?utf-8?B?dVlhcnVDYmVjSWhJYmQ4SzNBa2VBdmkrNms0QnVWa1lVNGNEYjJwVEdYL3c0?= =?utf-8?B?blEzRGpUZEJHSGJwSjFrVTNIUWl4S0RxTFFqU2VkWVFGMlRiU1N6QTM5N1l6?= =?utf-8?B?QUduM2pnZHJyUFBQTjd3bnkwV21sYXc3QW8yUkdxd0hub0s4TG04cHBheUo3?= =?utf-8?B?cjBndDYvTnR5NWpjVXpCcXA0Q1Z2cGU4UjhMM3R2NlpJMmZrcDZCd1FNWEhu?= =?utf-8?B?WHVsZHpqdTA2UXhIOXBaREJDMG5yanlqM2xGd0dvWWhhTDJ2djRIVWFCNExN?= =?utf-8?B?VXJNTktUUjNZY05jRXIxSkRrYm16SU1aMmUrejE2dWZzWDJjR1EvMHRTMkFI?= =?utf-8?Q?GAayjirzf/jSSG0fMupj?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-71ea3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: c226539c-aff0-44e3-dcf7-08dabdd26e22 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 19:34:31.8669 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5248 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 3, 2022 at 3:26 AM Nick Clifton via Binutils wrote: > > Hi Jojo, > > > This patch is based on MULTIPLE_FRAME_SECTIONS and EH_FRAME_LINKONCE, > > it allows backend to enable this feature and use '--gc-sections' simply. > > > > * gas/dw2gencfi.h (TARGET_MULTIPLE_EH_FRAME_SECTIONS): New. > > (MULTIPLE_FRAME_SECTIONS): Add TARGET_MULTIPLE_EH_FRAME_SECTIONS. > > * gas/dw2gencfi.c (EH_FRAME_LINKONCE): Add TARGET_MULTIPLE_EH_FRAME_SECTIONS. > > (is_now_linkonce_segment): Likewise. > > (get_cfi_seg): Create relocation info between .eh_frame.* and .text.* section. > > > > * bfd/elf-bfd.h (elf_backend_can_make_multiple_eh_frame): New. > > * bfd/elfxx-target.h (elf_backend_can_make_multiple_eh_frame): Likewise. > > * bfd/elflink.c (_bfd_elf_default_action_discarded): Add checking for > > elf_backend_can_make_multiple_eh_frame. > > > Approved - please apply. > > Cheers > Nick > Hi Jojo, is there a test demonstrating the handling of multiple .eh_frame? Input .eh_frame or output .eh_frame? .eh_frame handling is known to be weird with --gc-sections but linkers have gained support: https://maskray.me/blog/2020-11-08-stack-unwinding#linker-perspective Since monolithic .eh_frame has been around for so long, some tools may gain reliance on it and they will need to be fixed. Also, it'd be nice to verify that .eh_frame_hdr and PT_GNU_EH_FRAME creation is still correct.