From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2065.outbound.protection.outlook.com [40.92.42.65]) by sourceware.org (Postfix) with ESMTPS id ED7183858403 for ; Fri, 17 Nov 2023 08:49:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED7183858403 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ED7183858403 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.42.65 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700210970; cv=pass; b=gLnAtJOVbQwPCkVJm3O5/yUJkhp44AovSPHhVXGOcmuYwcrzuiFDD2YBlglU90EF7SsL3v/aLwvrGSUUK2TUp+i9H/1/U++Nuc15mDbEn1rX+ZFLtkgQ+ALAcP1ViUmpmwDxbSWUjDw9ZHL41w/GZqBdzBbVQcKZx0J+jGQHvBs= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700210970; c=relaxed/simple; bh=esF2/gv15bFdi+SFGI3z3VMPw7bDo6W9yLCO+lWEIzE=; h=From:Date:Message-ID:Subject:To:MIME-Version; b=ROHxKmLP97azqC5XNqaAOkMYX5/zh15sLHThDbEt/KwuLVI6Zh9WD8lF0u2gb2Zof4rS9LGX8QPJJgy35AhTssRFzfjzNI0RusL6KtXO9hQhShcDKkvW1iZ2RYsJOQG97r+nVL9uUgPajtqte2buWK/oyJ2Sl22lC/6X3vpIrso= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wn6XzfRVyAc32fIOk+Ogtxx5xHQ61QoLfJP7BpJHXvD9lcZGPsImFsOqGMLoGLqyO3S0DMRci4taOVZlrJeNbOKF/KfTRTU28n21JCTpIsC43oMSoeG7un4ocwLlg0C18+j6yrtSXRvRH5P0R4H0uPBjAqc3PQSmncMbZIHkER6BKxjvzKPHrLIYW+NESivIy0APYqCWDIhBVkSIJE79mcE2Ul9AawkH2Otk/E32MR50gMeodvojp3nGziMdhPJFfCqfYGrm3feqKHDx+5t1G+Y+GSHGT1fX2FjvAxf7PpHEUtoEscLzHQ3Oe8LxeNtTcrMuR3ZgJlDjSB1rS9VP8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9LvMn8B3q5oDyM85hhoHVxkSbFdF4fqYaoSTHs/ebMY=; b=kGxYsT9mIjEvNlnk7UIjv1shHFVWsYcnjM2tNndii6niQblVlXMl240KTIKVWogO3WNU1URUAHMlnR2B6ImsyHaho6wkdODEfUME+u7VICEv/TJ2NLG4rYoEhfA2v3tI1vUuo7NZP4og/iwGTJPkzNvXQNDUz1pr7rMabUZsM5ddLF7TldjIXVPXPO9vOnwy6vqE86rmJSKR0uJvutHjDgGd/Wnea6X/LP3slSiYIkjVkopANk8PW9R/I0NaOSaC+VCu5JG7l6QmjpsLwNNtBIEmNzDXK3iaBANbJ44MoQ3baC7VPTCcA/ceAmBbL6qmzOeYfXs5+SGsHBXpki1HrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) by CH3PR12MB9148.namprd12.prod.outlook.com (2603:10b6:610:19d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.21; Fri, 17 Nov 2023 08:49:26 +0000 Received: from DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::2493:49ba:b06b:fa80]) by DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::2493:49ba:b06b:fa80%6]) with mapi id 15.20.7002.022; Fri, 17 Nov 2023 08:49:26 +0000 X-Gm-Message-State: AOJu0Yy3ljzx8US920rU5mpLw7ZnPmSUwr+iaoY8lRhv6yjS8U6/GL+g y7Q/AKKeYA9qOCLN//EV+tBu5f+DLSqmGQ4O7H0= X-Google-Smtp-Source: AGHT+IGqGOdnEkBAwfu1BT3CADERZFHkqghzqxCR3FtCDEMwcX02qTEbXXE9XuAIIg4SpolGRIOu6yq3Jo6f5LWZToA= X-Received: by 2002:a05:6122:a1e:b0:4ac:9328:a69c with SMTP id 30-20020a0561220a1e00b004ac9328a69cmr14973445vkn.8.1700210569804; Fri, 17 Nov 2023 00:42:49 -0800 (PST) References: In-Reply-To: From: Fangrui Song Date: Fri, 17 Nov 2023 00:42:38 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/5] aarch64 BTI stub fixes To: Szabolcs Nagy Cc: Nick Clifton , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-TMN: [UW3luHCCW3UE/bvAVD4bbEjftnbyKfHs] X-ClientProxiedBy: SA1PR05CA0012.namprd05.prod.outlook.com (2603:10b6:806:2d2::16) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5765:EE_|CH3PR12MB9148:EE_ X-MS-Office365-Filtering-Correlation-Id: 006867ce-af6d-44f4-ee57-08dbe74a1a82 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fQHewTLXuIFrE/AIYboCEciFpUbyf0nd1Cni45yiqsZpxj+jJj4DVknJg3WET8kwIl3m7PGirZRLObiJgRnuOcOB9os7nXDKiIaZH3FsWQ7yAO8IOVoz/HbQnOj1xz61Gbxb4xjEy+X+Z4Y8t61ZER7i3xR7B6DX++m5+VgEwAtCkhaJfKaDQPJduS4MIqg7Na+8LYVF5dVQJfLRZ+HIdFyOgKltJMeoUmeaVHJL7BtVa3ir7I11lVqAyDoLJYSdBPMvWaW2Uw6+UOaiQvZ2cJru9UH2DH07eRVANo+zyXJ+S+TfOYn440JepKl89CEGT0oYiJQtW6NmTSAMt5jS5POy26/8id8PtpYyWttiQ/gVKP6R7CHiBYlESA/oFt+1lrFqdbp2JAcQ9Fy1S6pVP3d2alP4A73dDB8leRbDdXtTmAlGPLftjp9cBhIqvKVf98UR2JfMPjA23q/aSTV2gXlnlUaKkmUGnSMDlOW43w3UB4OsUdiw61WzxXXWMpjNKEtcv9VxVbeGhUN361ZymsWqSx21WaEuohozNlmaZMG9iMVagJVABCWC/VBBLAuviCqCTw3BqzLLJstWUCVFz8kY6kxpaH3FnO7a2auqFSc= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDFiNmtJZXZJM3JyRWc0S2FCVE9iRXRVMkRxNnVsK3hsbjNXTSs5KzNFb0I3?= =?utf-8?B?OG5pMEN3MWo0eFhLSjQ5VHBtRGkwNGtaN2ZYc0tBeEsyMVdjVlV0VFY3OUdH?= =?utf-8?B?R1dCMWZlNy9UL2d3ZmpCMXpkMmJBNXNZTCtDKzRLTHU4Q1c0T0lIR1lRVUg1?= =?utf-8?B?dG5XbkpGZFRvV0VUZmRlSVRIdFZueHdTMVRxQXNUbzZlazVGQkxnTnRzVkJR?= =?utf-8?B?ZEJOZEdYMWgzdCtVRk0ycmtuV05odXJVZjh0ZUo3c2VkTEJ2cVM2bndYU3JD?= =?utf-8?B?MTdIeDdIU0VWbEdhQWUyUzVxV0FjTzNpNzUrektLWGhOTTE3NWY1WGh3Q3A2?= =?utf-8?B?VnZDNlRNcE9hOHZnSXlhU0xpSHE5MzM0cjRmTjZxbmpqb0pEaCtnaDE2M2Ry?= =?utf-8?B?b2JsNWM0Sml4UXFBd2pwUHRLcW9VR3RyTkE1WjBic1NtK0NNWVBZVXpqdmYw?= =?utf-8?B?UnloNEFSK1orQTVSNnV4aXpkUC9DbW10RFB6clUvUnZmYXh6N1lWcWhZUk90?= =?utf-8?B?anZKRCtuZGJPMmRuaWpVZWNueWJ2U2E1aWVOQ2tyaS9uZmhsZENBZUtVdENF?= =?utf-8?B?WVIvZzk1Uk8wUVl2T0ozTnVZMXZkT04wY0RoL0QwM3VSQk16cmROS0hIYlNp?= =?utf-8?B?cnFlTitZTjI3bndFRXpJWnMzaE03ZnRLUFNjb013L1dtdUFhQm53b1JNOTRk?= =?utf-8?B?bEg2TGV6eHJsQzlDR1V0amFDa3RiRlRMd3hUcFhQd3lPaGRTTGtlcGU3bGxh?= =?utf-8?B?bUk2MDB4RmduQ0VjY0RCZW1KdEtqdzJqNTRxN0s0Y2VnazVCUENOZ1NTYUlj?= =?utf-8?B?emxqNGI0a29pbkJjOWhIUkl5ZDlrTXhhdC9ZcG1CUDJCNFcvWXh3UnI5S2Vl?= =?utf-8?B?ektUcUNKdU9GMmJ4VmVXNjBWczdCMzNRZmR1cWNNaVp3emJianJ0YlZRWDZ2?= =?utf-8?B?M2JwaHhRaTBwL0tiUlJLQU1YanV5b2RFbzNvS09IZHlERmNXNi9LTm1ubmlp?= =?utf-8?B?WFZiWGozWjIwem5DMzJDWnF6MnR5QUVZYmVHY1kvNUtuMEpjbFZnWUpYWXRR?= =?utf-8?B?NVlqL2hId0ZmR0pYM1MzWms0Y01UT2liU3JGWFMyQS95MHFGQkVVbUJIZ1dW?= =?utf-8?B?Ni94WEo0cHBnSDdrTVQ4R3liUTJUR2xOenFBNkQ2aVhZNGlCUnNQUTZGdklE?= =?utf-8?B?NWIycXhpdWorNHJNdGhlOE5jbDdwQWUwdE1ZSHl1Y1hJUkZaT1ZTK1pSNWhs?= =?utf-8?B?OHA4VjJqUlhTcTlraUN1MFZJMU5KSGxSLzJBTXdRTXZwa2ZtcEhUVFpPRmZD?= =?utf-8?B?R2ZTZTJ6R0I0a1dUN2JpanBJYjJiUm9sdjdJZjB6TENFUnpaczBObXlEZHRW?= =?utf-8?B?eUgrWFI1dW8rajdoa3NpL1JJaG41RUhmZ2JPSjc1eklkVWorWTZxWVR2ZjlL?= =?utf-8?B?a0w4aU5QMDRoRTRaQjRLWVhpZmpXU1lETkNFakQ2cXhmbFdDYUtjb1NnZXZa?= =?utf-8?B?SnpIbURiQThMemZ2WEJXRis5dFJLcG43TEs4Zy96L0Z6Rm5rL0xrWWlKSmxP?= =?utf-8?Q?I1TExfSdXCRes7W4sv8AZrvDKnZ/zM/xIEt2wZ62ezesnC?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-5183d.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 006867ce-af6d-44f4-ee57-08dbe74a1a82 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 08:49:26.4502 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9148 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 9, 2023 at 6:58=E2=80=AFAM Szabolcs Nagy wrote: > > The 11/07/2023 13:08, Szabolcs Nagy wrote: > > The 11/07/2023 11:38, Nick Clifton wrote: > > > FYI - I did find one regression in the linker testsuite with the patc= h applied: > > > > > > FAIL: Check linker stubs with indirect calls handle BTI (exe). > > > > > > However there are mitigating circumstances: > > > > > > * The failure was for an unusual toolchain configuration: > > > > > > --target=3Daarch64_be-linux-gnu_ilp32 > > > > > > * The three other tests in this part of the testsuite also fail, bo= th > > > with and without your patch applied: > > > > > > FAIL: Check linker stubs with indirect calls handle BTI (shared= lib). > > > FAIL: Check linker stubs with indirect calls handle BTI (exe). > > > FAIL: Check linker stubs with indirect calls handle BTI when ta= rget has BTI. > > > > > > Note: there appear to be *two* tests called "check linker stubs wi= th indirect calls handle BTI (exe)." > > > > > > I leave it up to you to decide if it is worth fixing these tests. > > > > thanks for looking at this. > > i will have to check what's going on. > > i will change the name of the new test to be unique. > > cleaning up ilp32 test issues will be a fair bit of work. > > i can commit a followup patch to force the tests i added to use > lp64 abi, like we do on other tests, but this is not ideal. > > > > PS. My gut feeling at the moment is that we do not need a 2.41.1 rel= ease > > > for this patch, since AArch64 systems with BTI enabled are not yet th= e norm, > > > and those that do exist are being used to test for problems like this= rather > > > than general use. Since your patch will be in the 2.42 release, due = January > > > next year, I think that that will be a reasonable timescale for getti= ng the > > > fix out there. Do you agree ? > > > > makes sense, > > unless it affects hardened kernel builds. > > i will have to check if that's an issue. > > in practice i think the kernel should be fine. > (it's hard to say conclusively) > > but i plan to backport the patches even if we don't arrange > a new release. % grep '\.zero' ld/testsuite/ld-aarch64/bti-far* ld/testsuite/ld-aarch64/bti-far-3a.s:.zero 0x07000000 ld/testsuite/ld-aarch64/bti-far-3b.s:.zero 0x01000000 ld/testsuite/ld-aarch64/bti-far-3b.s:.zero 0x07000000 ld/testsuite/ld-aarch64/bti-far-3c.s:.zero 0x01000000 % size ld/tmpdir/bti-far-* text data bss dec hex filename 117440552 0 0 117440552 7000028 ld/tmpdir/bti-far-3= a.o 134217768 0 0 134217768 8000028 ld/tmpdir/bti-far-3= b.o 16777260 0 0 16777260 100002c ld/tmpdir/bti-far-3= c.o 132 0 0 132 84 ld/tmpdir/bti-far-opt.o `.zero 0x07000000` is 112MiB. Perhaps use output section addresses (e.g. [1]) to make the files smaller? [1]: https://github.com/llvm/llvm-project/blob/de176d8c5496d6cf20e82aface98= e102c593dbe2/lld/test/ELF/aarch64-thunk-pi.s#L112