From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04olkn2081.outbound.protection.outlook.com [40.92.45.81]) by sourceware.org (Postfix) with ESMTPS id 499D13858CDA for ; Fri, 12 May 2023 06:43:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 499D13858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nXDtTKtItGazd4EPd9ryEDt5hRKAJqhnYkRJEHEGBpN4kMf/iINBHC7pEST2j3BvAKCtCAILt8SR+FyPUf9HCmFaUn4ujyDOiZ5Q9Cg5hwcKFUMFjF5p+cA7AmHxxhTClsmFcdekfPIzJzbfUiTtNwtJLaipglz1z2DXHLvGn8b4syJcAKzXMuhVvs1m+tJcMdcvU0C1xCx9NPmRh26vXDkITjp0zUvFBACKMnXzwbydk55tMO4lpRL3D8N8sbjEahPYgFHN98fRrCGn8/6GcUOweXYTuNY0jL4Fa+j+Q3YaD2lxZ6Sq3YZ5VpyjbYO+C8A4yLOK+VooD/A/MUxKLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dCuQsS88dIB/2KbcENdGzrPPEgvDU5DeQC+GLQ+H+V4=; b=QaYE20l0IoqIzgsJpeR7YLQfIQd7d2cg7mNjhwLVvCPDQQ26DQ2PW+BmoJniARrj1GsUHiUs2+ZkLi9jI5Rnm5KF3G5MGSh7A2F4TaiJAJG/gXy0HQyouti2OzVmSdMo5LFuQXN6xz50f8E+t60ITebDQ+EzEHVTFkAh4v7gr93hkMHqOpJ7RmC1P8liaCmYnDjZVl9R2RuROk8PoipL4HvYvf/kckKD7H0RETGBAMB+cfILMU4kG5muQOs0Ll1TQj7emtfckd7srETFm7lAVuNgurLJpiiMTm++U19Xi/IOd7/i3C3pPYNFGOY9bikhH40ChuZzPaMZ26ewyGlTug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) by BN9PR12MB5130.namprd12.prod.outlook.com (2603:10b6:408:137::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.22; Fri, 12 May 2023 06:43:19 +0000 Received: from DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::5b4b:77d7:9922:f37e]) by DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::5b4b:77d7:9922:f37e%2]) with mapi id 15.20.6387.019; Fri, 12 May 2023 06:43:19 +0000 X-Gm-Message-State: AC+VfDwf4ZsGN6jJqP5fHvItEpaxsTK4IWYmJ9qYanQhnoqO40YihhuM ZjypBXyhagvKXjO5qzHZbgHKF35wf0jphA90fhw= X-Google-Smtp-Source: ACHHUZ65xPO4hg+oVVulEUXJhsK9vTQeLvpOGHgDqfeA5ZHWQ+TOBqOVrSHz1X6D3V9Ij3zNB8MBs+jte3SNzxSLFVI= X-Received: by 2002:a17:902:e547:b0:1ac:b03c:a58e with SMTP id n7-20020a170902e54700b001acb03ca58emr11394343plf.25.1683873797276; Thu, 11 May 2023 23:43:17 -0700 (PDT) References: <20230511210232.1491265-1-goldstein.w.n@gmail.com> In-Reply-To: <20230511210232.1491265-1-goldstein.w.n@gmail.com> From: Fangrui Song Date: Thu, 11 May 2023 23:43:06 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1] gold: Make '--section-ordering-file' also specifiable in env variable To: Noah Goldstein Cc: binutils@sourceware.org, hjl.tools@gmail.com, arjan@linux.intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-TMN: [nYQRVbQRWCeevtMEmVsU5koXyqbygmtW] X-ClientProxiedBy: MW4P221CA0011.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::16) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5765:EE_|BN9PR12MB5130:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b722020-4dbc-448a-d340-08db52b42bf8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +VraAVsb1ro73CwO8WhOKWITArdax1u0iejx1rDBn5ouSBOfhKXR/xzCnACBeXL/0ruB3m3Eeo+bqj/Gn6sfPyUcUFdiCzucFBPZgthCXynu7/zjzb0YK1u/pRegRrblnBZ03dsKB633wSRByCXvpaLHJlRZsC+/uqZcJbClzfQ64e2qmz2g2G0j2HQOa57v+LGRvL3HlJLApoBclcevctFVq9xXMGngdH3bJZsJLsdkNzLzjPSBIjR4UIjzWsoYa0R3n/AldDMOnncd8oxmoFyjUrXr7VrQ7/+mlKkAg7Y1uDrFusluCGOW7tCO9UeSinUtAaONxk82s6QdbF93BTFkg33RiGnjNY8UDfd+MRAHuYP0BW1YB0pEgPYOOpC4x37BS0pm0ibAHoOamKjWTIR9usIdAbe6Helz4dggEJjxN1kUwKG0uKZj+rKMvMGDKC/zUetrWDkbNU2Kd3B/MkqmQdtj28z9MSJOMNp4hCmFfygeIZE2UWvrVqR+cTJUblekNsG4M0rWHoeHUdv/9Wmt78M0MFy1hX17wrutsYeIVdARooD0Q5LZKdOYXhfAWM6xygFQ8pQxEy/0B+3ZDa7ajtETgKQHQM2kP/lVDwiscf2PXvoTy8T7PsfhpD6C X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cy9yd3FHOU9ibUVCaHpvanUvNFk3dEhkOXRQZU5Za2tya25tOWxOMTBObkFx?= =?utf-8?B?eHdyeHhKVmJtUTBReHlzWVJKS3JMWENsZG1kN2pLTElpc3NUUXRaTWJxUk1X?= =?utf-8?B?MWhCQ0FnMlFVZi90eUVFZFhBWUphK1hiRUNQQ3N0ZmVaQmdxenhaMkhOT1hk?= =?utf-8?B?NEI3NjVmQW4zd1JZWGJqdjljRUI2MzVRUlJTZHRBVkM5amMzY1NLQVYvNHFh?= =?utf-8?B?dGtJS0VMK25YRlpXaDlhaHV5aGY5bGRPaFJoRURpSGV5Rjh1R0RHWkJ2c2dH?= =?utf-8?B?UFRMNHk0UnhBQmRmU25FSUFuWVRudTZlQ2RqVUExS2VNQm5wNGVBTHlDTEcw?= =?utf-8?B?S0cySElSby9pSEUvNzJnSGJuWGkvOE5IU3lMWmJ6Nnl6Tjd4bFZVckpZMTgw?= =?utf-8?B?c01vazVqTzdQa2ZPdHlkQTd5NDJWSHZnK3R1YU0zMlU4WjJpOVBrc0JOdUtY?= =?utf-8?B?aThybTY1YkRNZmExNWRENlRMZ05aWFNLUWFBWTIzbHZRNk8vR29BQXhEbzZE?= =?utf-8?B?R29sM3JaSll0RnBzWXRvbGVtcHJVejhNK0NjbmZYUlFWS1hFRjE4NG8vK0Zs?= =?utf-8?B?cGFVUTdwQ3d1MmZCY3oxTUxiK3lSMS96SXhXVytjcVl0WW5Lc241NStHdlpU?= =?utf-8?B?cjQvQnoxaFRyQ0xwWlVDbjh5dnZHbWp6eVZkSjl0VmtkSGgwMGR1cUJpenVx?= =?utf-8?B?djVRYkdyUVhpaDVjZGJ5c0ttVmNFa1IxYkMxNkZnS0lMVFhkZkxGVWUvVjEv?= =?utf-8?B?TUg0Zytqa2tpUXBIVG1wOFFlallIVzVmQngxODMvd0ozNjZ5Mk96ZWo5MkdS?= =?utf-8?B?L1F2a01acGozSWN6UXdIWjdqOHJ6ZzJWV1pxcitFWm83cXdicFRQMDIxUzJ0?= =?utf-8?B?Si8zUEs4ejlOWjNtYURtWU5VYU5sb3MxYlVVTXIrckx1S2xnUElrU0k0Y0tE?= =?utf-8?B?YWlOV0VWL29lMU1XRUJoY2tpZmxDS2x2dUR4QlBZczB0bWZlc2tFMTBveGhl?= =?utf-8?B?a3FWRzRKTTMrNlhYWkl4QVpJMzhJVXdaWHl6dk5yR1RyblhVc0dBa05EYmJu?= =?utf-8?B?YUFhNHBFc00vRklsZHRYZ1VhZWJBZmIwZTVYb0ltZFZYNmt6RmpKdmVKaVlv?= =?utf-8?B?R2dqV1NxUnFLMTZSMXZhYjVKUXdrQ0c5bnJES3B4OWRuYVkwRnpJeXRKZktU?= =?utf-8?B?ZnBmTzROZnJDUXNsU3JHTWhKdTZSSTRjZi95ZVBDenRUeWlKYmYvY0xJdnRP?= =?utf-8?B?eEw2WXNqTjlRNkpHb2ZHZHh0TmZmUGsvWDA2MC9GcnJ6a3NaRXBFc0VvTmd1?= =?utf-8?B?ZUtiK2Y0eXh6V1FHUkhCbXRTeTV2ZXhmV3RZZ1o4TnRSbWtSNjZrT1hlZWJp?= =?utf-8?B?QUV5dTFVMzA0YlR6ZWpUVXgxbjFsc3NXcVlhdXhRUUZwZmtCVUQ4QXRvSmtT?= =?utf-8?B?cVBxQk5zVEJRdGw4Q0RVcnp6dkp4SzRKeCtmK1B0SFJkK2loV3pnckpiT255?= =?utf-8?B?UDNtaWJ6RjYySVc4d25FckE0VUdEb1UvWkE4TEVDbFpOc1pmSHJXQ0xQT0or?= =?utf-8?Q?zyACGqIYt4bRlW9Dc7eUX8zpdAy65ArcAW4bxzZvL0nIsQ?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-71ea3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 8b722020-4dbc-448a-d340-08db52b42bf8 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2023 06:43:19.4189 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5130 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 11, 2023 at 2:02=E2=80=AFPM Noah Goldstein via Binutils wrote: > > New proposed env variable is 'GLOBAL_SECTION_ORDERING_FILE'. > > The motivation for this change to help package maintainers use the > section ordering feature. For package maintainers, modifying the link > flags of all their maintained projects, is time consumining to a > degree that it is often considered infeasable. By making the feature > enablable simply with an environment variable, removes this > roadblock. Similiarly, the rationale behind ignoring errors when using > the environment specified file is to make it so that it never create > new problems in the build process. > > The hope by making this feature more accessable it will allow package > maintainers to use ordering lists from profiles of their applications > to distribute better optimized packages. The motivation isn't compelling to me. Using an environment variable to control a linker option isn't a convention. I probably should say, it's very odd, going against the spirit of a linker. Can you use LDFLAGS or a linker wrapper to achieve your goal? % cat ld.gold #!/bin/sh -e ... If some packages don't recognize standard variables CFLAGS/LDFLAGS, just help add them so that other distributions can control global compiler/linker options more conveniently.