From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43266 invoked by alias); 16 Jun 2015 08:29:59 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 43257 invoked by uid 89); 16 Jun 2015 08:29:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 16 Jun 2015 08:29:56 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 12A142853E3F; Tue, 16 Jun 2015 10:29:53 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r0V0Sr3gpXjI; Tue, 16 Jun 2015 10:29:53 +0200 (CEST) Received: from [192.168.0.18] (mtg95-3-82-238-192-125.fbx.proxad.net [82.238.192.125]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 41FDB2853E38; Tue, 16 Jun 2015 10:29:52 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: [2.25][ARM][GAS]Backport "Positively emit symbols for alignment." From: Tristan Gingold In-Reply-To: <557FDD3E.4070401@arm.com> Date: Tue, 16 Jun 2015 08:29:00 -0000 Cc: "binutils@sourceware.org" , "nickc@redhat.com" , Marcus Shawcroft , Richard Earnshaw Content-Transfer-Encoding: quoted-printable Message-Id: References: <553A3CAD.3050208@arm.com> <557FDD3E.4070401@arm.com> To: Renlin Li X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00160.txt.bz2 > On 16 Jun 2015, at 10:24, Renlin Li wrote: >=20 > Hi all, >=20 > This is a merged backport patch from the following three. They together f= ix one problem, So I merge them into one backport patch. The description of= problem is quoted below. >=20 > The initial patch: > https://sourceware.org/ml/binutils/2015-04/msg00381.html >=20 > Fix two failing test case: > https://sourceware.org/ml/binutils/2015-04/msg00457.html >=20 > Fix a bug in the initial patch: > https://sourceware.org/ml/binutils/2015-06/msg00045.html >=20 >=20 > Binutils, ld, gas regression test Okay. Okay to commit? Yes, ok for backporting. >=20 > On 24/04/15 13:53, Renlin Li wrote: >> Hi all, >>=20 >> In arm_init_frag(), when ARM or THUMB are recorded, it will simply >> return without doing anything. This is not correct in a few cases. >>=20 >> For the following two cases: >> case 1: >> nop ----> MAP_ARM >> .long 0 ---> MAP_DATA >> .align 4 ---> >> ---->(1) >> ----> start new frag >> .word 0x12345678 >>=20 >> (1) paddings here are all treated as data, because the previous state is >> MAP_DATA. >>=20 >> case 2: >> nop ----> MAP_ARM >> .long 0 ---> MAP_DATA >> .byte 1 >> .align 2 ---> (1) >> ----> (2) >> ----> start new frag >> .long 0x12345678 ----> (3) >>=20 >> stage 1: while parsing the input file: >> (1) arm_init_frag early returns, No state change, no new symbol. (3)No >> state change, no new symbol. >> stage 2: Later, while writing the object file: >> (2)MAP_DATA, MAP_ARM are inserted by insert_data_mapping_symol to handle >> alignment. (3) interpreted as instruction because of the MAP_ARM >> inserted at (2) >>=20 >>=20 >> This change might generate redundant symbols, some of them can be >> removed later. In check_mapping_symbols(), the symbols at the end of a >> section, and overlapping symbols will be removed. >>=20 >> gas checked without any new issues. Okay to commit? >