Re: .previous

Re: .previous

[Nick Clifton]

Hi Philip,

: 1999-12-20  Philip Blundell  <pb@futuretv.com>
: 
: 	* config/tc-arm.c (arm_s_text): If OBJ_ELF, call the appropriate
: 	hook function when changing sections.
: 	(arm_s_data): Likewise.

This patch is fine.  I have applied it to the sources.

: Also, as far as I can tell, no ELF target accepts that construct
: with `.bss' instead of `.data', because the necessary hooks are
: missing altogether.

Is this a feature that you need ?

Cheers
	Nick

Re: .previous

[Philip Blundell]

>: Also, as far as I can tell, no ELF target accepts that construct
>: with `.bss' instead of `.data', because the necessary hooks are
>: missing altogether.
>
>Is this a feature that you need ?

Not exactly "need".  I came across a situation the other day when it would 
have been nice to have, but I managed fine without.

p.

Re: .previous

[Nick Clifton]

Hi Philip,

: Not exactly "need".  I came across a situation the other day when it
: would have been nice to have, but I managed fine without.

Ok - I won't worry about it then.  Of course if you ever care to
implement it then I will be happy to look at the patch.. ;-)

Cheers
	Nick

.previous

[Philip Blundell]

On an ARM ELF target, GAS does not currently accept:

	.data
	.word 0
	.previous

The reason is that tc-arm.c has its own hooks for .data and .text; these 
override the ones in obj-elf.c and so the code to store the old sections never 
gets called.  The patch below seems to fix this for me.

Also, as far as I can tell, no ELF target accepts that construct with `.bss' 
instead of `.data', because the necessary hooks are missing altogether.

Thanks

p.

1999-12-20  Philip Blundell  <pb@futuretv.com>

	* config/tc-arm.c (arm_s_text): If OBJ_ELF, call the appropriate
	hook function when changing sections.
	(arm_s_data): Likewise.

Index: tc-arm.c
===================================================================
RCS file: /cvs/binutils/binutils/gas/config/tc-arm.c,v
retrieving revision 1.25
diff -u -r1.25 tc-arm.c
--- tc-arm.c	1999/10/28 03:03:53	1.25
+++ tc-arm.c	1999/12/20 14:09:31
@@ -1373,7 +1373,11 @@
   if (now_seg != text_section)
     s_ltorg (0);
   
+#ifdef OBJ_ELF
+  obj_elf_text (ignore);
+#else
   s_text (ignore);
+#endif
 }
 
 static void
@@ -1388,7 +1392,11 @@
   else if (now_seg != data_section)
     s_ltorg (0);
   
+#ifdef OBJ_ELF
+  obj_elf_data (ignore);
+#else
   s_data (ignore);
+#endif
 }
 
 #ifdef OBJ_ELF