From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.smtpout.orange.fr (smtp-25.smtpout.orange.fr [80.12.242.25]) by sourceware.org (Postfix) with ESMTPS id 994283858D33 for ; Sun, 3 Sep 2023 21:59:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 994283858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=jacob.remcomp.fr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=jacob.remcomp.fr Received: from smtpclient.apple ([90.22.252.13]) by smtp.orange.fr with ESMTPS id cv86qcfHYGGIucv86qEod5; Sun, 03 Sep 2023 23:59:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1693778379; bh=HgHCERWIMwHFvbHMZ1R6psf3Pfg3eHPS7ffg/8dheGI=; h=From:Subject:Date:To; b=KPl7LdXjQ1Gmty8TiHN8SFvmm/Dv3awCJK/Xfbl1ODxEXd1n0P70L7aOXBdEMYQhb z0jD1AuCWdyUSxv4qJAzi/Y/Zz1zNYBLadrYU7Zwg+Oo9PNx/r5tu28cNvyStCGBl3 T16cCdOSoNMTurh1O6hO8D9LWXoqWQS92/wR5TipLG12QL1xac+tbA1nPC/HpxQYLO 6DcKsadUm7gE/09zZ0mkX6JX7EoFJICdxY6+/u6QGIUWvDL1kuo2m1CcMp9q2umr93 drJcdwpRQqeyg/pHOzVQC9Tx2dpFrqiicj5Kj9nmC1ycE+uyooOhiT90aKB4v/ro2T sZsqlyJ+WPaew== X-ME-Helo: smtpclient.apple X-ME-Date: Sun, 03 Sep 2023 23:59:39 +0200 X-ME-IP: 90.22.252.13 From: jacob navia Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Misleading names Message-Id: Date: Sun, 3 Sep 2023 23:59:28 +0200 To: binutils@sourceware.org X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi The function riscv_elf_ignore_reloc, contrary to its name, does NOT = ignore the relocation! /* Special handler for relocations which don't have to be relocated. = This * function just simply return bfd_reloc_ok. */ static bfd_reloc_status_type riscv_elf_ignore_reloc(bfd * abfd = ATTRIBUTE_UNUSED, arelent * reloc_entry, asymbol * symbol ATTRIBUTE_UNUSED, void *data ATTRIBUTE_UNUSED, asection * input_section, bfd * output_bfd, char **error_message ATTRIBUTE_UNUSED) { if (output_bfd !=3D NULL)=20 reloc_entry->address +=3D input_section->output_offset; return bfd_reloc_ok; } Despite its name, and the associated comment, nothing is ignored here = and the relocation address is modified. Long, descriptive names are very good WHEN THEY REFLECT THE TRUTH! Otherwise they are completely misleading. Of course this is not a bug.=20 FILE: elfe-riscv.c=20 LINE: 1053 Jacob=