From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, dj@redhat.com,
ktietz70@googlemail.com, binutils@sourceware.org,
gcc-patches@gcc.gnu.org
Subject: Re: [patch libiberty include]: Add additional helper functions for directory-separator searching
Date: Wed, 09 Mar 2011 05:29:00 -0000 [thread overview]
Message-ID: <E1PxBxN-0005a9-GM@fencepost.gnu.org> (raw)
In-Reply-To: <201103082238.00289.pedro@codesourcery.com> (message from Pedro Alves on Tue, 8 Mar 2011 22:37:59 +0000)
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Tue, 8 Mar 2011 22:37:59 +0000
> Cc: DJ Delorie <dj@redhat.com>,
> Eli Zaretskii <eliz@gnu.org>,
> ktietz70@googlemail.com,
> binutils@sourceware.org,
> gcc-patches@gcc.gnu.org
>
> Actually, is there any case where lbasename wouldn't
> work instead of filename_dirrchr?
Almost: lbasename returns a pointer one character _after_ the last
slash. It also skips the drive letter on DOS/Windows (which might be
TRT, actually).
It would be reasonable to rewrite filename_dirrchr in terms of
lbasename, though, by backing up the pointer returned by lbasename if
it points to a slash, and otherwise returning NULL. The case of
"d:foo" should also be resolved (probably, return a pointer to the
colon).
next prev parent reply other threads:[~2011-03-09 5:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 10:56 Kai Tietz
2011-03-08 11:12 ` Eli Zaretskii
2011-03-08 11:25 ` Kai Tietz
2011-03-08 11:53 ` Eli Zaretskii
2011-03-08 12:01 ` Kai Tietz
2011-03-08 12:43 ` Pedro Alves
2011-03-08 12:48 ` Kai Tietz
2011-03-08 13:33 ` Pedro Alves
2011-03-08 13:37 ` Kai Tietz
2011-03-08 18:39 ` Eli Zaretskii
2011-03-08 18:50 ` Pedro Alves
2011-03-08 18:51 ` Kai Tietz
2011-03-08 19:54 ` Eli Zaretskii
[not found] ` <E1Pwupb-0001ns-M8__47566.5626036518$1299582745$gmane$org@fencepost.gnu.org>
2011-03-08 11:55 ` Andreas Schwab
2011-03-08 15:11 ` Kai Tietz
2011-03-08 15:30 ` Kai Tietz
2011-03-08 18:37 ` Eli Zaretskii
2011-03-08 19:41 ` DJ Delorie
2011-03-08 19:59 ` Eli Zaretskii
2011-03-08 22:38 ` Pedro Alves
2011-03-09 5:29 ` Eli Zaretskii [this message]
2011-03-09 11:46 ` Pedro Alves
2011-03-09 12:35 ` Eli Zaretskii
2011-03-09 12:58 ` Pedro Alves
2011-03-09 13:36 ` Eli Zaretskii
2011-03-12 16:40 ` Kai Tietz
2011-03-09 14:37 ` Build regression [Re: [patch libiberty include]: Add additional helper functions for directory-separator searching] Jan Kratochvil
2011-03-09 15:02 ` Pedro Alves
2011-03-09 15:08 ` Jan Kratochvil
2011-03-12 16:44 ` [patch libiberty include]: Add additional helper functions for directory-separator searching Kai Tietz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1PxBxN-0005a9-GM@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=binutils@sourceware.org \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ktietz70@googlemail.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).