From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112845 invoked by alias); 24 Aug 2016 14:55:59 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 112782 invoked by uid 89); 24 Aug 2016 14:55:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.3 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*RU:sk:smtprel, Hx-spam-relays-external:sk:smtprel, HX-HELO:sk:smtprel, miranda X-HELO: smtprelay.synopsys.com Received: from smtprelay.synopsys.com (HELO smtprelay.synopsys.com) (198.182.60.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Aug 2016 14:55:48 +0000 Received: from dc8secmta2.synopsys.com (dc8secmta2.synopsys.com [10.13.218.202]) by smtprelay.synopsys.com (Postfix) with ESMTP id 654E210C0BD8; Wed, 24 Aug 2016 07:55:47 -0700 (PDT) Received: from dc8secmta2.internal.synopsys.com (dc8secmta2.internal.synopsys.com [127.0.0.1]) by dc8secmta2.internal.synopsys.com (Service) with ESMTP id 587F1A4114; Wed, 24 Aug 2016 07:55:47 -0700 (PDT) Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by dc8secmta2.internal.synopsys.com (Service) with ESMTP id 2CEBCA4102; Wed, 24 Aug 2016 07:55:47 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id 12ADDBB5; Wed, 24 Aug 2016 07:55:47 -0700 (PDT) Received: from US01WEHTC3.internal.synopsys.com (us01wehtc3.internal.synopsys.com [10.15.84.232]) by mailhost.synopsys.com (Postfix) with ESMTP id 04F61BB3; Wed, 24 Aug 2016 07:55:47 -0700 (PDT) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by US01WEHTC3.internal.synopsys.com (10.15.84.232) with Microsoft SMTP Server (TLS) id 14.3.266.1; Wed, 24 Aug 2016 07:54:00 -0700 Received: from DE02WEMBXB.internal.synopsys.com ([fe80::95ce:118a:8321:a099]) by DE02WEHTCB.internal.synopsys.com ([::1]) with mapi id 14.03.0266.001; Wed, 24 Aug 2016 16:53:58 +0200 From: Cupertino Miranda To: Nick Clifton , Cupertino Miranda , "binutils@sourceware.org" CC: "Francois.Bedard@synopsys.com" , "Claudiu.Zissulescu@synopsys.com" Subject: Re: [PATCH 2/5] Content for TLS_IE_GOT not written to .got. Date: Wed, 24 Aug 2016 14:55:00 -0000 Message-ID: References: <20160816155116.23937-1-cmiranda@synopsys.com> <20160816155116.23937-3-cmiranda@synopsys.com> Content-Type: multipart/mixed; boundary="_002_EB86EB452ADE4B44B294F7149B8A2777022063A5DE02WEMBXBinter_" MIME-Version: 1.0 X-SW-Source: 2016-08/txt/msg00222.txt.bz2 --_002_EB86EB452ADE4B44B294F7149B8A2777022063A5DE02WEMBXBinter_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-length: 481 Hi Nick, Indeed, a test case makes sense. Please find a new patch attached. Cheers, Cupertino On 08/19/2016 09:43 AM, Nick Clifton wrote: > Hi Cupertino, > >> When no dynamic relocation was generated the .got content would not be >> updated for the TLS_IE_GOT relocation addresses. > I think that this particular patch ought to be accompanied by a testcase > to make sure that it continues to work. Could you see if you rustle one > up please ? > >=20=20 > Cheers > Nick > --_002_EB86EB452ADE4B44B294F7149B8A2777022063A5DE02WEMBXBinter_ Content-Type: text/x-patch; name="0002-Content-for-TLS_IE_GOT-not-written-to-.got.patch" Content-Description: 0002-Content-for-TLS_IE_GOT-not-written-to-.got.patch Content-Disposition: attachment; filename="0002-Content-for-TLS_IE_GOT-not-written-to-.got.patch"; size=3498; creation-date="Wed, 24 Aug 2016 14:53:57 GMT"; modification-date="Wed, 24 Aug 2016 14:53:57 GMT" Content-Transfer-Encoding: base64 Content-length: 4742 RnJvbSA3YWYwYTdkZmZkNGQzOTYyMTRiMWZmYTI4YTU5MjNkYWZkN2U0MTU0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDdXBlcnRpbm8gTWly YW5kYSA8Y21pcmFuZGFAc3lub3BzeXMuY29tPgpEYXRlOiBUdWUsIDEyIEp1 bCAyMDE2IDE2OjMxOjQwICswMjAwClN1YmplY3Q6IFtQQVRDSCAyLzVdIENv bnRlbnQgZm9yIFRMU19JRV9HT1QgIG5vdCB3cml0dGVuIHRvIC5nb3QuCgpX aGVuIG5vIGR5bmFtaWMgcmVsb2NhdGlvbiB3YXMgZ2VuZXJhdGVkIHRoZSAu Z290IGNvbnRlbnQgd291bGQgbm90IGJlCnVwZGF0ZWQgZm9yIHRoZSBUTFNf SUVfR09UIHJlbG9jYXRpb24gYWRkcmVzc2VzLgoKYmZkL0NoYW5nZUxvZzoK CkN1cGVydGlubyBNaXJhbmRhICA8Y21pcmFuZGFAc3lub3BzeXMuY29tPgoK CWFyYy1nb3QuaCAocmVsb2NhdGVfZml4X2dvdF9yZWxvY3NfZm9yX2dvdF9p bmZvKTogRml4ZWQgYWRkcmVzc2VzIGluCglkZWJ1ZyBjb21tZW50cy4gRml4 ZWQgYWRkcmVzcyBpbiAuZ290IHJlbGF0ZWQgdG8gVExTX0lFX0dPVCBkeW5h bWljCglyZWxvY2F0aW9uLgoKbGQvQ2hhbmdlTG9nOgoKQ3VwZXJ0aW5vIE1p cmFuZGEgIDxjbWlyYW5kYUBzeW5vcHN5cy5jb20+CgoJdGVzdHN1aXRlL2xk LWFyYy90bHNfaWUtMDEuczogQWRkZWQgdG8gdmVyaWZ5IGFzc29jaWF0ZWQg Zml4LgoJdGVzdHN1aXRlL2xkLWFyYy90bHNfaWUtMDEuZDogTGlrZXdpc2UK LS0tCiBiZmQvYXJjLWdvdC5oICAgICAgICAgICAgICAgICAgIHwgMjQgKysr KysrKysrKysrKysrKystLS0tLS0tCiBsZC90ZXN0c3VpdGUvbGQtYXJjL3Rs c19pZS0wMS5kIHwgIDkgKysrKysrKysrCiBsZC90ZXN0c3VpdGUvbGQtYXJj L3Rsc19pZS0wMS5zIHwgMTAgKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2Vk LCAzNiBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQogY3JlYXRlIG1v ZGUgMTAwNjQ0IGxkL3Rlc3RzdWl0ZS9sZC1hcmMvdGxzX2llLTAxLmQKIGNy ZWF0ZSBtb2RlIDEwMDY0NCBsZC90ZXN0c3VpdGUvbGQtYXJjL3Rsc19pZS0w MS5zCgpkaWZmIC0tZ2l0IGEvYmZkL2FyYy1nb3QuaCBiL2JmZC9hcmMtZ290 LmgKaW5kZXggN2MzY2ZkOS4uOWFjMDI5NSAxMDA2NDQKLS0tIGEvYmZkL2Fy Yy1nb3QuaAorKysgYi9iZmQvYXJjLWdvdC5oCkBAIC0zMzQsMTMgKzMzNCwx NSBAQCByZWxvY2F0ZV9maXhfZ290X3JlbG9jc19mb3JfZ290X2luZm8gKHN0 cnVjdCBnb3RfZW50cnkgKiogICAgICAgICAgbGlzdF9wLAogCQkJICAgICAg ID8gNCA6IDApKTsKIAogCQlBUkNfREVCVUcgKCJhcmNfaW5mbzogRklYRUQg LT4gJXMgdmFsdWUgPSAlI2x4ICIKLQkJCSAgICJAICVwLCBmb3Igc3ltYm9s ICVzXG4iLAorCQkJICAgIkAgJWx4LCBmb3Igc3ltYm9sICVzXG4iLAogCQkJ ICAgKGVudHJ5LT50eXBlID09IEdPVF9UTFNfR0QgPyAiR09UX1RMU19HRCIg OgogCQkJICAgICJHT1RfVExTX0lFIiksCiAJCQkgICAobG9uZykgKHN5bV92 YWx1ZSAtIHNlY192bWEpLAotCQkJICAgaHRhYi0+c2dvdC0+Y29udGVudHMg KyBlbnRyeS0+b2Zmc2V0Ci0JCQkgICArIChlbnRyeS0+ZXhpc3RpbmdfZW50 cmllcyA9PSBUTFNfR09UX01PRF9BTkRfT0ZGCi0JCQkgICAgICA/IDQgOiAw KSwKKwkJCSAgIChsb25nKSAoaHRhYi0+c2dvdC0+b3V0cHV0X3NlY3Rpb24t PnZtYQorCQkJICAgICAgKyBodGFiLT5zZ290LT5vdXRwdXRfb2Zmc2V0LT52 bWEKKwkJCSAgICAgICsgZW50cnktPm9mZnNldAorCQkJICAgICAgKyAoZW50 cnktPmV4aXN0aW5nX2VudHJpZXMgPT0gVExTX0dPVF9NT0RfQU5EX09GRgor CQkJCSA/IDQgOiAwKSksCiAJCQkgICBzeW1ib2xfbmFtZSk7CiAJICAgICAg fQogCSAgICAgIGJyZWFrOwpAQCAtMzUxLDE0ICszNTMsMjIgQEAgcmVsb2Nh dGVfZml4X2dvdF9yZWxvY3NfZm9yX2dvdF9pbmZvIChzdHJ1Y3QgZ290X2Vu dHJ5ICoqICAgICAgICAgIGxpc3RfcCwKIAkJYmZkX3ZtYSBBVFRSSUJVVEVf VU5VU0VEIHNlY192bWEKIAkJICA9IHRsc19zZWMtPm91dHB1dF9zZWN0aW9u LT52bWE7CiAKKwkJYmZkX3B1dF8zMiAob3V0cHV0X2JmZCwKKwkJCSAgICBz eW1fdmFsdWUgLSBzZWNfdm1hLAorCQkJICAgIGh0YWItPnNnb3QtPmNvbnRl bnRzICsgZW50cnktPm9mZnNldAorCQkJICAgICsgKGVudHJ5LT5leGlzdGlu Z19lbnRyaWVzID09IFRMU19HT1RfTU9EX0FORF9PRkYKKwkJCSAgICAgICA/ IDQgOiAwKSk7CisKIAkJQVJDX0RFQlVHICgiYXJjX2luZm86IEZJWEVEIC0+ ICVzIHZhbHVlID0gJSNseCAiCiAJCQkgICAiQCAlcCwgZm9yIHN5bWJvbCAl c1xuIiwKIAkJCSAgIChlbnRyeS0+dHlwZSA9PSBHT1RfVExTX0dEID8gIkdP VF9UTFNfR0QiIDoKIAkJCSAgICAiR09UX1RMU19JRSIpLAogCQkJICAgKGxv bmcpIChzeW1fdmFsdWUgLSBzZWNfdm1hKSwKLQkJCSAgIGh0YWItPnNnb3Qt PmNvbnRlbnRzICsgZW50cnktPm9mZnNldAotCQkJICAgKyAoZW50cnktPmV4 aXN0aW5nX2VudHJpZXMgPT0gVExTX0dPVF9NT0RfQU5EX09GRgotCQkJICAg ICAgPyA0IDogMCksCisJCQkgICAobG9uZykgKGh0YWItPnNnb3QtPm91dHB1 dF9zZWN0aW9uLT52bWEKKwkJCSAgICAgICsgaHRhYi0+c2dvdC0+b3V0cHV0 X29mZnNldC0+dm1hCisJCQkgICAgICArIGVudHJ5LT5vZmZzZXQKKwkJCSAg ICAgICsgKGVudHJ5LT5leGlzdGluZ19lbnRyaWVzID09IFRMU19HT1RfTU9E X0FORF9PRkYKKwkJCQkgPyA0IDogMCkpLAogCQkJICAgc3ltYm9sX25hbWUp OwogCSAgICAgIH0KIAkgICAgICBicmVhazsKZGlmZiAtLWdpdCBhL2xkL3Rl c3RzdWl0ZS9sZC1hcmMvdGxzX2llLTAxLmQgYi9sZC90ZXN0c3VpdGUvbGQt YXJjL3Rsc19pZS0wMS5kCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLjhkNTNlZjUKLS0tIC9kZXYvbnVsbAorKysgYi9sZC90ZXN0c3Vp dGUvbGQtYXJjL3Rsc19pZS0wMS5kCkBAIC0wLDAgKzEsOSBAQAorI3NvdXJj ZTogdGxzX2llLTAxLnMKKyNhczogLW1jcHU9YXJjNzAwCisjbGQ6Cisjb2Jq ZHVtcDogLXMgLWogLmdvdAorCitbXjpdKzogICAgIGZpbGUgZm9ybWF0IGVs ZjMyLWxpdHRsZWFyYworCitDb250ZW50cyBvZiBzZWN0aW9uIFwuZ290Ogor IFswLTlhLWZdKyAwMDAwMDAwMCAwNDAwMDAwMCAuKwpkaWZmIC0tZ2l0IGEv bGQvdGVzdHN1aXRlL2xkLWFyYy90bHNfaWUtMDEucyBiL2xkL3Rlc3RzdWl0 ZS9sZC1hcmMvdGxzX2llLTAxLnMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uNzRmNDBlZAotLS0gL2Rldi9udWxsCisrKyBiL2xkL3Rl c3RzdWl0ZS9sZC1hcmMvdGxzX2llLTAxLnMKQEAgLTAsMCArMSwxMCBAQAor CS50bHNfY29tbW9uIGZvbyw0LDQKKwkudGxzX2NvbW1vbiBiYXIsNCw0CisK KwkudGV4dAorCS5hbGlnbiA0CisKKyAgICAgICAgLmdsb2JhbCBfX3N0YXJ0 CitfX3N0YXJ0OgorCWxkIHIxNCwgW3BjbCwgQGZvb0B0bHNpZV0KKwlsZCBy MTUsIFtwY2wsIEBiYXJAdGxzaWVdCi0tIAoyLjkuMAoK --_002_EB86EB452ADE4B44B294F7149B8A2777022063A5DE02WEMBXBinter_--