* patches that could interest you
@ 2011-06-27 15:35 Fawzi Mohamed
2011-06-28 7:23 ` Tristan Gingold
2011-06-28 7:46 ` Tristan Gingold
0 siblings, 2 replies; 5+ messages in thread
From: Fawzi Mohamed @ 2011-06-27 15:35 UTC (permalink / raw)
To: binutils; +Cc: André Pönitz
Hi all,
while working on bug http://sourceware.org/bugzilla/show_bug.cgi?id=11488 I made a some changes to binutils.
Thanks to Tristan the main fix of that bug is already in, but this small change should also be added in some way, as it
adds the forgotten ignore of routine_64 load command (which is the equivalent of the 32 bit one, and contains the
init routines of the dylib).
Suppress the "unable to read unknown load command" when loading a 64 bit dylib with init routines
Index: bfd/mach-o.c
===================================================================
RCS file: /cvs/src/src/bfd/mach-o.c,v
retrieving revision 1.57
diff -f -u -r1.57 mach-o.c
--- bfd/mach-o.c 14 Jan 2011 12:35:56 -0000 1.57
+++ bfd/mach-o.c 27 Jun 2011 15:06:23 -0000
@@ -2523,6 +2523,7 @@
case BFD_MACH_O_LC_FVMFILE:
case BFD_MACH_O_LC_PREPAGE:
case BFD_MACH_O_LC_ROUTINES:
+ case BFD_MACH_O_LC_ROUTINES_64:
break;
case BFD_MACH_O_LC_SUB_FRAMEWORK:
case BFD_MACH_O_LC_SUB_UMBRELLA:
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: patches that could interest you
2011-06-27 15:35 patches that could interest you Fawzi Mohamed
@ 2011-06-28 7:23 ` Tristan Gingold
2011-06-28 7:46 ` Tristan Gingold
1 sibling, 0 replies; 5+ messages in thread
From: Tristan Gingold @ 2011-06-28 7:23 UTC (permalink / raw)
To: Fawzi Mohamed; +Cc: binutils, André Pönitz
On Jun 27, 2011, at 5:34 PM, Fawzi Mohamed wrote:
> Hi all,
>
> while working on bug http://sourceware.org/bugzilla/show_bug.cgi?id=11488 I made a some changes to binutils.
> Thanks to Tristan the main fix of that bug is already in, but this small change should also be added in some way, as it
> adds the forgotten ignore of routine_64 load command (which is the equivalent of the 32 bit one, and contains the
> init routines of the dylib).
Hello,
please do not forget the ChangeLog entry when submitting a patch.
This one is so simple that I will take care of that.
Tristan.
>
> Suppress the "unable to read unknown load command" when loading a 64 bit dylib with init routines
>
> Index: bfd/mach-o.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/mach-o.c,v
> retrieving revision 1.57
> diff -f -u -r1.57 mach-o.c
> --- bfd/mach-o.c 14 Jan 2011 12:35:56 -0000 1.57
> +++ bfd/mach-o.c 27 Jun 2011 15:06:23 -0000
> @@ -2523,6 +2523,7 @@
> case BFD_MACH_O_LC_FVMFILE:
> case BFD_MACH_O_LC_PREPAGE:
> case BFD_MACH_O_LC_ROUTINES:
> + case BFD_MACH_O_LC_ROUTINES_64:
> break;
> case BFD_MACH_O_LC_SUB_FRAMEWORK:
> case BFD_MACH_O_LC_SUB_UMBRELLA:
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: patches that could interest you
2011-06-27 15:35 patches that could interest you Fawzi Mohamed
2011-06-28 7:23 ` Tristan Gingold
@ 2011-06-28 7:46 ` Tristan Gingold
2011-06-28 10:49 ` Fawzi Mohamed
1 sibling, 1 reply; 5+ messages in thread
From: Tristan Gingold @ 2011-06-28 7:46 UTC (permalink / raw)
To: Fawzi Mohamed; +Cc: binutils, André Pönitz
On Jun 27, 2011, at 5:34 PM, Fawzi Mohamed wrote:
> Hi all,
>
> while working on bug http://sourceware.org/bugzilla/show_bug.cgi?id=11488 I made a some changes to binutils.
> Thanks to Tristan the main fix of that bug is already in, but this small change should also be added in some way, as it
> adds the forgotten ignore of routine_64 load command (which is the equivalent of the 32 bit one, and contains the
> init routines of the dylib).
>
> Suppress the "unable to read unknown load command" when loading a 64 bit dylib with init routines
Now committed with this ChangeLog entry:
2011-06-28 Fawzi Mohamed <fawzi.mohamed@nokia.com>
* mach-o.c (bfd_mach_o_read_command): Also ignore
BFD_MACH_O_LC_ROUTINES_64.
Tristan.
>
> Index: bfd/mach-o.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/mach-o.c,v
> retrieving revision 1.57
> diff -f -u -r1.57 mach-o.c
> --- bfd/mach-o.c 14 Jan 2011 12:35:56 -0000 1.57
> +++ bfd/mach-o.c 27 Jun 2011 15:06:23 -0000
> @@ -2523,6 +2523,7 @@
> case BFD_MACH_O_LC_FVMFILE:
> case BFD_MACH_O_LC_PREPAGE:
> case BFD_MACH_O_LC_ROUTINES:
> + case BFD_MACH_O_LC_ROUTINES_64:
> break;
> case BFD_MACH_O_LC_SUB_FRAMEWORK:
> case BFD_MACH_O_LC_SUB_UMBRELLA:
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: patches that could interest you
2011-06-28 7:46 ` Tristan Gingold
@ 2011-06-28 10:49 ` Fawzi Mohamed
2011-06-28 10:52 ` Tristan Gingold
0 siblings, 1 reply; 5+ messages in thread
From: Fawzi Mohamed @ 2011-06-28 10:49 UTC (permalink / raw)
To: binutils
On Jun 28, 2011, at 9:46 AM, ext Tristan Gingold wrote:
> On Jun 27, 2011, at 5:34 PM, Fawzi Mohamed wrote:
>
>> Hi all,
>>
>> while working on bug http://sourceware.org/bugzilla/show_bug.cgi?id=11488 I made a some changes to binutils.
>> Thanks to Tristan the main fix of that bug is already in, but this small change should also be added in some way, as it
>> adds the forgotten ignore of routine_64 load command (which is the equivalent of the 32 bit one, and contains the
>> init routines of the dylib).
>>
>> Suppress the "unable to read unknown load command" when loading a 64 bit dylib with init routines
>
> Now committed with this ChangeLog entry:
>
> 2011-06-28 Fawzi Mohamed <fawzi.mohamed@nokia.com>
>
> * mach-o.c (bfd_mach_o_read_command): Also ignore
> BFD_MACH_O_LC_ROUTINES_64.
>
> Tristan.
thank you very much, I will add the changelog next time.
Fawzi
>
>>
>> Index: bfd/mach-o.c
>> ===================================================================
>> RCS file: /cvs/src/src/bfd/mach-o.c,v
>> retrieving revision 1.57
>> diff -f -u -r1.57 mach-o.c
>> --- bfd/mach-o.c 14 Jan 2011 12:35:56 -0000 1.57
>> +++ bfd/mach-o.c 27 Jun 2011 15:06:23 -0000
>> @@ -2523,6 +2523,7 @@
>> case BFD_MACH_O_LC_FVMFILE:
>> case BFD_MACH_O_LC_PREPAGE:
>> case BFD_MACH_O_LC_ROUTINES:
>> + case BFD_MACH_O_LC_ROUTINES_64:
>> break;
>> case BFD_MACH_O_LC_SUB_FRAMEWORK:
>> case BFD_MACH_O_LC_SUB_UMBRELLA:
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: patches that could interest you
2011-06-28 10:49 ` Fawzi Mohamed
@ 2011-06-28 10:52 ` Tristan Gingold
0 siblings, 0 replies; 5+ messages in thread
From: Tristan Gingold @ 2011-06-28 10:52 UTC (permalink / raw)
To: Fawzi Mohamed; +Cc: binutils
On Jun 28, 2011, at 12:49 PM, Fawzi Mohamed wrote:
>
> On Jun 28, 2011, at 9:46 AM, ext Tristan Gingold wrote:
>
>> On Jun 27, 2011, at 5:34 PM, Fawzi Mohamed wrote:
>>
>>> Hi all,
>>>
>>> while working on bug http://sourceware.org/bugzilla/show_bug.cgi?id=11488 I made a some changes to binutils.
>>> Thanks to Tristan the main fix of that bug is already in, but this small change should also be added in some way, as it
>>> adds the forgotten ignore of routine_64 load command (which is the equivalent of the 32 bit one, and contains the
>>> init routines of the dylib).
>>>
>>> Suppress the "unable to read unknown load command" when loading a 64 bit dylib with init routines
>>
>> Now committed with this ChangeLog entry:
>>
>> 2011-06-28 Fawzi Mohamed <fawzi.mohamed@nokia.com>
>>
>> * mach-o.c (bfd_mach_o_read_command): Also ignore
>> BFD_MACH_O_LC_ROUTINES_64.
>>
>> Tristan.
>
> thank you very much, I will add the changelog next time.
Sure.
Please, also make the subject more explicit (such as in this case: [Patch]: ignore ROUTINES_64 load command on Darwin).
Tristan.
>
> Fawzi
>>
>>>
>>> Index: bfd/mach-o.c
>>> ===================================================================
>>> RCS file: /cvs/src/src/bfd/mach-o.c,v
>>> retrieving revision 1.57
>>> diff -f -u -r1.57 mach-o.c
>>> --- bfd/mach-o.c 14 Jan 2011 12:35:56 -0000 1.57
>>> +++ bfd/mach-o.c 27 Jun 2011 15:06:23 -0000
>>> @@ -2523,6 +2523,7 @@
>>> case BFD_MACH_O_LC_FVMFILE:
>>> case BFD_MACH_O_LC_PREPAGE:
>>> case BFD_MACH_O_LC_ROUTINES:
>>> + case BFD_MACH_O_LC_ROUTINES_64:
>>> break;
>>> case BFD_MACH_O_LC_SUB_FRAMEWORK:
>>> case BFD_MACH_O_LC_SUB_UMBRELLA:
>>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-06-28 10:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-27 15:35 patches that could interest you Fawzi Mohamed
2011-06-28 7:23 ` Tristan Gingold
2011-06-28 7:46 ` Tristan Gingold
2011-06-28 10:49 ` Fawzi Mohamed
2011-06-28 10:52 ` Tristan Gingold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).