From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id AB1C53858D3C for ; Mon, 22 Jan 2024 05:45:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB1C53858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AB1C53858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705902332; cv=none; b=laIJXp8bVP2lekcktaRhlWm9HMXsqR8B7RsegrExll5O44AU9TO9blIVve6Aas6TXCo8uGWVv27k536FKSglI4E2qV9aBJrj+3kO8zx0MDw+VZ16T/wn+NGT+AuvVDkhzLuYCycweuPw6BKldApaxIJ5zci0UFFE+qKJZs+BvKw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705902332; c=relaxed/simple; bh=X1SXlC7945Dzpd6Rxr4WNF6nUN/vUnxGe82MpE1QAF0=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=g8QhUWsZ0ioLuimarBfzufA6GUyuYGFEqkTOdDWUbNBBJFnGePBxQFo5/re1lHgl/5IflPbUyuxJlrVrtlYLKfCMI3Y093hXLJEL064BV/43OwY+dcDPNaqYi5nWaY/UnC64YXGihnLlExhetAiSh1DTFqTQXqA896AkiyeiUCU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6d9b760610bso675285b3a.1 for ; Sun, 21 Jan 2024 21:45:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705902329; x=1706507129; darn=sourceware.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8IA74Y9xSzZUWv5bC98T0/47W8cgj9Xy9IJGHx/jOvc=; b=f7hLFic/liPlBKktu6G9vLwMo+DK5ON8H8ISZkkhcKQnI+R1rcnbaN9SFgCfxRyLKH 7P1hn9aGXBP0GiUMFZLc4cW7evDW03Kv5avbu/0U0DxyYNgjkUUPuvHfHWErz9dSvwJj W/2TWmmqP2kRXmp86hB6FCyEKdbZZsP8Fj0/q7kuKoo5E814a5acixhTr/4ytMx52MCF b/haatv2Q+z8i4lJk4d5GahjQapgGQdrZJex3Mdm5Z9OTEz7PPshhicyve61G8ZgUDKQ Pym5E+UnfN9N6d47HPDsNuJh2HCmWWXssTfI3YpFjtyA5t4dqVLQnt5XnX2xLOH9mEdL FLwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705902329; x=1706507129; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8IA74Y9xSzZUWv5bC98T0/47W8cgj9Xy9IJGHx/jOvc=; b=TrWKNvtqj0v8WTGhnXF4lm4QkWrqeQRTn2B1umpoHJ5FCWvLDxnwjOljtVIzmMiIDF xPCZPtlfPo7lX7M6H8YlH4m8XgDYrxgcmBD0jF1cOzRzYzbz3/dzxoQBu27p6cMvLO76 HMmNBBt8kCEZ95ngg/2jCt+DvryvFQNaIHO3sUFj3PmHXI17DbXCsoH4D7VbUSvYNiQK MxU156Nqjtve6vThAWJ71heZMPohBnQaorM0OOhJWGOtLSMQSA0z8VAg67FKx2nqWAwc nrpDym3nOeojhBgR3qeXqkP5FJLaYq3LoZa+jT5nH01R6kM0zhDjM6lW0Wif0bXXK4H8 NxHw== X-Gm-Message-State: AOJu0Ywb6ZznZC7ApxUNi4rBuwFTqvb8ize28/34nWeyWcaUuaygMY/c lh4DKm2kpJXsCN/KJ8iy+0n5QwJLyuWGFFmQVlaUu/mnk59t3NBf X-Google-Smtp-Source: AGHT+IH0nfehQ270uf65GSzdjkv1h4Po85SiNbOQZZYllfGEn3OPmlyznYEhAcQRGCfFBBIh5VcSjg== X-Received: by 2002:a17:902:7292:b0:1d5:b82a:a53 with SMTP id d18-20020a170902729200b001d5b82a0a53mr7541388pll.5.1705902329483; Sun, 21 Jan 2024 21:45:29 -0800 (PST) Received: from smtpclient.apple (152.140.5.103.wi-fi.wi2.ne.jp. [103.5.140.152]) by smtp.gmail.com with ESMTPSA id e15-20020a170902ed8f00b001d704905e9fsm6503211plj.259.2024.01.21.21.45.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Jan 2024 21:45:28 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Subject: Re: [PATCH] LoongArch: Do not add DF_STATIC_TLS for TLS LE From: Tatsuyuki Ishi In-Reply-To: <20231228145802.74719-1-ishitatsuyuki@gmail.com> Date: Mon, 22 Jan 2024 14:45:14 +0900 Cc: binutils@sourceware.org, Lulu Cai , chenglulu@loongson.cn, hejinyang@loongson.cn, i.swmail@xen0n.name, liuzhensong@loongson.cn, luweining@loongson.cn, Fangrui Song , mengqinggang , nickc@redhat.com, wanglei@loongson.cn, xry111@xry111.site, xuchenghua@loongson.cn Content-Transfer-Encoding: quoted-printable Message-Id: References: <20231228145802.74719-1-ishitatsuyuki@gmail.com> To: Tatsuyuki Ishi X-Mailer: Apple Mail (2.3774.300.61.1.2) X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Dec 28, 2023, at 23:58, Tatsuyuki Ishi = wrote: >=20 > TLS LE is exclusively for executables, while DF_STATIC_TLS is for = DLLs. > DF_STATIC_TLS should only be set for TLS IE (and when it's DLL), not = LE. > --- > bfd/elfnn-loongarch.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c > index bd448cda453..64c34e99261 100644 > --- a/bfd/elfnn-loongarch.c > +++ b/bfd/elfnn-loongarch.c > @@ -862,8 +862,6 @@ loongarch_elf_check_relocs (bfd *abfd, struct = bfd_link_info *info, > if (!bfd_link_executable (info)) > return false; >=20 > - info->flags |=3D DF_STATIC_TLS; > - > if (!loongarch_elf_record_tls_and_got_reference (abfd, info, = h, > r_symndx, > GOT_TLS_LE)) > --=20 > 2.40.1 >=20 >=20 Any interest in reviewing / merging this and the other two patches sent = together? The DF_STATIC_TLS change is pretty short, the formatting patch is = trivial. As for the last patch introducing a comment change, I=E2=80=99m not sure = what Mengqing=E2=80=99s stance is, but my intention for the comment = change is to provide a better context for the reader rather than = comparing to a solution that is not currently implemented in the = codebase. Tatsuyuki.