From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3827 invoked by alias); 18 Dec 2017 11:48:00 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 3739 invoked by uid 89); 18 Dec 2017 11:47:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1819 X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50056.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.56) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Dec 2017 11:47:58 +0000 Received: from HE1PR08MB0507.eurprd08.prod.outlook.com (10.161.120.154) by VI1PR0802MB2624.eurprd08.prod.outlook.com (10.175.20.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Mon, 18 Dec 2017 11:47:54 +0000 Received: from HE1PR08MB0507.eurprd08.prod.outlook.com ([fe80::b029:7b7f:ca35:a008]) by HE1PR08MB0507.eurprd08.prod.outlook.com ([fe80::b029:7b7f:ca35:a008%14]) with mapi id 15.20.0323.018; Mon, 18 Dec 2017 11:47:54 +0000 From: Tamar Christina To: "binutils@sourceware.org" CC: nd , Richard Earnshaw , "Marcus Shawcroft" Subject: Re: [PATCH][BINUTILs][GAS][AArch64] Correct disassembly of dot product instructions. [Patch (2/2)] Date: Mon, 18 Dec 2017 11:48:00 -0000 Message-ID: References: <20171207155019.GA9515@arm.com> In-Reply-To: <20171207155019.GA9515@arm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tamar.Christina@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0802MB2624;6:B4f/kVgW8cRk7cMA9sFc8InzL1E9D3ogLnx3iLYAsfw+8x3HssBjzJKR1RScT1IgHH98mNXXgdyAqjn8Wv8qA/p5lcSRHHx29JOkK1ZfplFkMcsFAysTBxawpId5cjY5ByT8ZYEwqeLvgZ6qq9dklIBu+FrV3VfZwJdZi0L0ER8D8sW62optlPf+IIQcrYcvUAydMBs9QN3QrHQGDSe5t/15V/oAwm3FZAjm1AK6qZDW1xwZ78gXlo5bl5GjnGQXGxhf+SOT+oq7vHgbvYphkMnuJEZ0EsnwnF3+pCTu1BGAbNYwQEilR0nQturaGuvbeTkh+9xcJLW2wNiRJSjlNcF291/cRo9xYPx3sgJmVE8=;5:a5acZZxGusg4oGoWNl6Il0uIWtr5LCC0zajpvpLAIs9EYu8cmjGtnte6HEy+Kw5gkoP4I2xLiX2Hb60ZReZkEipuFRUAdbi/Qvy0Jc4Hd0YovVNQfS1t7+M/U+QzGJFDMi7SCpMPV1J/+FJAMu2bt9fhWsL2ZTKHJwGKIUQflDQ=;24:SQCeIUVz9hgL2b1aYdtfpBlaOLnXc15WIn6chmCuYVQ0XBMTF97uiK59NHSt9fzFfEfhnG81hXpcS4oqkA4pOm0ZYdP0xMfrVb0rWlfExDM=;7:j8vaSn3jI3P8q2NYJpUKStg/1+HI5gWkYf9CbAXOgB8h2GHWjfz1zTIYVxSwpK1acmJQiGrFQG5iiCYPW0F3s/pfkUZWagEBQkWHnCz/mK3v7TpkjlpQ4hQNGvYU5P7pv0Sxy6PvWqgbHiCzneWlJwDMhuKfebPWYdK3E9Yh7t7zE3gcZP9xPUuLMNxb7DEpIrYN/okCbnwFgMuPviiimu1eGXgioZ9uhVuBVaRVxIet3UEaigOpsmAN4JLm7bJG x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-correlation-id: 7fc62551-1edb-4f85-47b4-08d5460d2cfb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307);SRVR:VI1PR0802MB2624; x-ms-traffictypediagnostic: VI1PR0802MB2624: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(131327999870524); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3231023)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123558100)(20161123555025)(6072148)(201708071742011);SRVR:VI1PR0802MB2624;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR0802MB2624; x-forefront-prvs: 0525BB0ADF x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(346002)(39860400002)(396003)(366004)(199004)(377424004)(189003)(53754006)(72206003)(5640700003)(9686003)(55016002)(54906003)(316002)(478600001)(5250100002)(5660300001)(6436002)(33656002)(14454004)(3660700001)(97736004)(59450400001)(76176011)(229853002)(2906002)(3280700002)(53546011)(6506007)(53936002)(105586002)(6246003)(81156014)(74316002)(86362001)(1730700003)(8936002)(81166006)(66066001)(4326008)(25786009)(7696005)(99286004)(6116002)(102836003)(3846002)(2950100002)(6916009)(8676002)(305945005)(2501003)(106356001)(2351001)(68736007)(2900100001)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0802MB2624;H:HE1PR08MB0507.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fc62551-1edb-4f85-47b4-08d5460d2cfb X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2017 11:47:54.4102 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2624 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00151.txt.bz2 Ping ________________________________________ From: binutils-owner@sourceware.org on beha= lf of Tamar Christina Sent: Thursday, December 7, 2017 3:50:21 PM To: binutils@sourceware.org Cc: nd; Richard Earnshaw; Marcus Shawcroft Subject: [PATCH][BINUTILs][GAS][AArch64] Correct disassembly of dot product= instructions. [Patch (2/2)] Hi All, Dot products deviate from the normal disassembly rules for lane indexed instruction. Their canonical representation is in the form of: v0.2s, v0.8b, v0.4b[0] instead of v0.2s, v0.8b, v0.b[0] to try to denote that these instructions select 4x 1 byte elements instead of a single 1 byte element. Previously we were disassembling them following the normal rules, this patch corrects the disassembly. Regtested on: * aarch64-none-elf (cross) * aarch64_be-none-elf (cross) * aarch64-none-elf (native) * aarch64-none-elf (native on 32bit host) and no issues. Ok for master? Thanks, Tamar. gas/ 2017-12-07 Tamar Christina PR gas/22559 * config/tc-aarch64.c (vectype_to_qualifier): Support AARCH64_OPND_= QLF_S_4B. * gas/testsuite/gas/aarch64/dotproduct.d: Update disassembly. include/ 2017-12-07 Tamar Christina PR gas/22559 * aarch64.h (aarch64_opnd_qualifier): Add AARCH64_OPND_QLF_S_4B. opcodes/ 2017-12-07 Tamar Christina PR gas/22559 * aarch64-asm.c (aarch64_ins_reglane): Change AARCH64_OPND_QLF_S_B = to AARCH64_OPND_QLF_S_4B * aarch64-dis.c (aarch64_ext_reglane): Change AARCH64_OPND_QLF_S_B = to AARCH64_OPND_QLF_S_4B * aarch64-opc.c (aarch64_opnd_qualifiers): Add 4b variant. * aarch64-tbl.h (QL_V2DOT): Change S_B to S_4B. --