From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10olkn2026.outbound.protection.outlook.com [40.92.41.26]) by sourceware.org (Postfix) with ESMTPS id 9A493385840D for ; Tue, 23 Apr 2024 19:44:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A493385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A493385840D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.41.26 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713901475; cv=pass; b=E6MzN32wHXXMk8tTfqDq9wmAsSiqTjBHQCZzwHbpDec8bqgkmtFtCDvY337Zsk38Cy1hz4gAG+8WnWuWMgj9eP23rY/zGDkCMyS/2IT6ChZbDkGgMGtrZmwhvO8Ss9kOPY70kwjPNFLJ34k+2n71y0qh/MQyQopZWg/DEyLoATY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713901475; c=relaxed/simple; bh=JTi6foqA+tqPpl/BOUZM59XkPESUv3qPtAf178yugno=; h=From:Date:Message-ID:Subject:To:MIME-Version; b=Sa+H0+Ye+pO5fsSNuI1xCvSBzcONl8jw0C/Oiaus3dWhkvCov5zyduAz1s/9QZ5b1fsoG1zdv7KEWxUvBk2mPLeBGMyG8MBvzHb0stkJ+uoe5E+oZoWUxAp3o5YusKvtCnUMulpVnCFSdTMVB+UTaWMrJzlG62gEwlOc/X8xiV4= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MV7f0jtfktSvMxtMNTFsYNvbW/po0OH4j63C0y2F4lH93j96a5HwMyqDZeBhd9OX/SHqhkCWrtZMU1m+xrFb0/DlDHyVAQkkcKtFJRDmZrTYo5u+fVBzHrrVrlCFFhl2YHGgggDG8UB4Jyj27KuDuiuw0jthzhFtt/ymY5uRapl8Mub+PCcPQJiSD3SVJSzYwvyPRbxiRoqLLmDUUtXa0OWpbZoHaz4BW+CDV+1aOTGe/OZMN42fl7FjMcUyiVGoGB9NX/BrsyVhPxjXwJ5Ua5xs4kbQNchrARO6+7VWpbPjgGdZ0SUanGuMblrAqhwux8kQya6N4DJblkm3zVKQpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oZ22IhNlrCIcYvFo8WKJ917s4cUcJSnSjZqJS+qYHuM=; b=M7ubna1AhGkwYK6K0x4v84hVFL+veKuvoog35cjOyOjs2FzGiEeiyI2j0AdA8wuww8HMh1kmwCbe5vCO6EZ4mY+DsoSyZt3PEpCyBLVcHANFKyiTsodrnVaL59fH4LKYKsh2WKtie9yC4VCIOvF2lzvwsPN5O6688HmS8674+/fV8f8BQB7N3w3zbvZnBp/q1dUudFYzlcQW/pbC/X38BT8GhN8rbPHQbd9IdHoBed5Y67HsfJiNkfrm119tBdPm3WkFLbBsf0HnCK3iTx5LzRpnbBQhJr7idA+RQTXlV9vtoUqQOr2U1Roi2GUGUqR/GJZ0CV+e36iW/xLOAm3pGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MN0PR12MB5761.namprd12.prod.outlook.com (2603:10b6:208:374::6) by DM6PR12MB4122.namprd12.prod.outlook.com (2603:10b6:5:214::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Tue, 23 Apr 2024 19:44:31 +0000 Received: from MN0PR12MB5761.namprd12.prod.outlook.com ([fe80::7e30:fc81:d673:d950]) by MN0PR12MB5761.namprd12.prod.outlook.com ([fe80::7e30:fc81:d673:d950%5]) with mapi id 15.20.7472.044; Tue, 23 Apr 2024 19:44:31 +0000 X-Gm-Message-State: AOJu0YxJjQ1fotJgpQpTmePodu6vsLM2rjiPW4pnhNDsnkUKv5mf1U6F 7dDpAeMSCixGjEjZFaitHcGOFOaT8KXdz1tWFJb6wDAQOE/ahmNoHC/AIAnDCfHPgb1PrQLAzH4 OaBTskfS/9igUMQ5srkC1QWwygGo= X-Google-Smtp-Source: AGHT+IFw0PzLX2CzEumakQ7DbsamGFO8O/8iXAS2yPbQ9xh9E5qWLSIrzz+WC6BFfiWgLKY6TF56/7zrIZIngGmwYRU= X-Received: by 2002:a05:6102:22cf:b0:47b:d871:ccb2 with SMTP id a15-20020a05610222cf00b0047bd871ccb2mr622803vsh.13.1713901057351; Tue, 23 Apr 2024 12:37:37 -0700 (PDT) References: <87edbb99kx.fsf@redhat.com> In-Reply-To: From: Fangrui Song Date: Tue, 23 Apr 2024 12:37:26 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Commit: readelf: Improve display of RELR relocations To: Nick Clifton Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-TMN: [+VK6OYfevHiQmIZythogEWLDYbAsiHo2] X-ClientProxiedBy: BN0PR04CA0107.namprd04.prod.outlook.com (2603:10b6:408:ec::22) To MN0PR12MB5761.namprd12.prod.outlook.com (2603:10b6:208:374::6) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR12MB5761:EE_|DM6PR12MB4122:EE_ X-MS-Office365-Filtering-Correlation-Id: b4aa76de-364c-4d58-67ac-08dc63cdcb4e X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|1602099003|3412199016|440099019; X-Microsoft-Antispam-Message-Info: nkpk5dWg1WyKImekHAUfc4CDm/uwoZSkwJ1W8RlheoSBjwQXjkyZmAblk1yu1cAP/I4YDSPsMEiiSdZYsMyHILQ2NGtN3ARkezTuk6x+Ux85w8X+wI9Rl8n08RUCIaP4POgFtkP5pFmZ+dxvXtHBJ2TK0VhxWJi2Y5/lKLTljUjL9JQkAg1QvpRhHpJqz4m2r8BMI05XFJTPFdDGSj0d8S+Jz9G7d225kpvhVeBeGRiDyR9L7+EvRrjRAEu9XbH1z2h6RXZhx1dy97ftODjluC/jhceyLyKbMBDQjZEappcPS7eMoXynIUOlaOo6uiEJdB4uHpaT2zYSI3KtTdIRFBtBi7/oo/k2b79hBrRU+UjWX89zJAYBLkxvaIZPwuPXRHsWRZM/YJ7h8c8oEHAAQIR6E8L4Me5UinvHY2ZzlFTpMT2+u8wKkREgH0A+Z6PrX178LBVRfH5eG5tTibQbGn2KqLcRhX8LCiJWBO/tvupSF6fwRzJRa246NKo3vXJq6IjGka1Rm+UY7bO/DJCdHoAw0D6e3REKMJS1EhCNA6YzpIWOm00TZhbLPAb9fGZd+J1YP+a78JNewNfeEJf+eSGtu5jNa+dhGUYXVyRVnXi2m4tjeQPpoPnN5c/4Ps0lyME4q9MKHGD/rN85y+GN2S1eFAiiW14rK9EtqtO2Y5I= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXlWT2h0NThjS1FSaVFqSWRaQm9IeDFSemZ0UDFycVV3MzRhekhpaXpNbTlG?= =?utf-8?B?Q3dVUHN4UWhIdXdsTW5HK01jUElCQktESjVIa25BMStqYzQwajg5emkzYTJi?= =?utf-8?B?NW5JMVBpOEFKVk9QbGxKTWpCVTg4NGJrdDdIOGxXMnloam9ObnJML2NUWGlF?= =?utf-8?B?OE9tNnFpeitmUUMzcGxvYXFxSlkvWEVrRGsveUgwaTdCMDl4a2RjK1A5ZHRq?= =?utf-8?B?ek5wTVl5dkpxcXNiK0cwVmpTZUg5UzlxcXNGcFdqQXRWY2F4N0xEZEQzRDlG?= =?utf-8?B?dExXd2x5VEEra0xoUEVkTkd0SHlLM3lpeTRTMmxYRGpsUlY2ejBkQ0VndkdI?= =?utf-8?B?bDBzdmVEVHJmSmxtTC9HOStHQ0kyb3Nqa0FvRUJpdkp5WFBRQU9wdmNuZ3M2?= =?utf-8?B?NW9VdGxuM3FlWU9kTERBdEt2RWY4ZHpoSW43VTA4MXYvL08xby9OajFML3h5?= =?utf-8?B?OGpmYjJXdmt1b2s1ZmVEY3BQWFB2TSszTFdNb2pSQ3R5V29uU3VjSy80Vi9I?= =?utf-8?B?dlBLdmlGYlBlZzBPT0ltY0p1VVJtR3RaTWc1OE14dGkySzdTT0V3dTF1a0hF?= =?utf-8?B?Y3RaYVRKc1BiY0lJaHNMMXkxeWZXUmM5Y2hLck5nSmZ4bzJZd0JEbC9BTUdk?= =?utf-8?B?TWNya3BTM0VhSkhWT2RTSGNhNHRsTXI0bHJBb1cwNVhnb2dPeFNINUdaWFlB?= =?utf-8?B?cFczZWR3d3J1aXU4ZElvOHlNZVBNODB0SDNtNCtMejgvcVM2ckZpblYrZkFP?= =?utf-8?B?aTAzWDZKN2k4YTV2MWVlNHVLVHdDV1hKOWNmQ21xODVkaUV6ZzVzbzBVK0Mw?= =?utf-8?B?ZnpTQVVjNXNZYjVjV3U0K3FrcHhMVXVOb3Z3U2xicncvdFI5bTZRUktzcjAy?= =?utf-8?B?Ymw4ZkJFelpsWmRqTGJ4ZW9NcDAvQzZFODE3VTJRMEh3OXVzKzFNaWhIV2V6?= =?utf-8?B?azcxc29SdU9McnBWYXVVME0zSk9YNmc5SmNuOE9NNXhuamZxOHZ4SVJ3S3o4?= =?utf-8?B?YVUveVhxUEVtRlZxOXNLenI3NGNMQ0drL0EweHRnWDlISUpZVml1WHFxcVUw?= =?utf-8?B?U3BpSkRyRzVVQTdROWZBeVJFRS92U1hRbllyVWNPS3dIVGlOMzgwbEppTkI5?= =?utf-8?B?QkpROXBMaVpWaVpjYk94U1pLWjJnaFMrRkJLMW1maTV3K2hLekV0TEU2Nnpo?= =?utf-8?B?UHo0MUFvM3hEejVZazVLNkhLSUNib1lTVjNxNXJjd2xJeUplRXd5VjAyOU9J?= =?utf-8?B?WmV5U2ovdVAyTDNxWks2NncwdmJZUHVLYW1MMDVUWC9GV3kxTTdqelNGbTVM?= =?utf-8?B?bWR3c2VjSXRyV2pEbk5oQXdYVENvclEyNzVvU3prSklHY2lRcFRxZ05ud3ky?= =?utf-8?B?U1BaZzdBZFJkU2ZvYWU5R1VRc2hoTGFFL3VpK1dFK2Q0MEFHVzEybWc1WVBN?= =?utf-8?B?NmlwT2wveVcyMERBd0padlVzS21HT1NkOUhQNVBhMHo4L3lkcXBNZGpQZTEx?= =?utf-8?B?V2ZhcitHRkVSMnhmQTRWMlhWTDFPc3ZRTkZrL1ZLTmQ1a0NLN0YwU2k0bnk3?= =?utf-8?B?ZDdQRUNSaGN6R3JxOUQ1blBxNjBSVzVobmVVdE9wellhZ3I2Wi9XUWZ5YkhU?= =?utf-8?B?K2xGakc1eUZhR0h6c0lmTDEzYUQvNlE9PQ==?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-5183d.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: b4aa76de-364c-4d58-67ac-08dc63cdcb4e X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5761.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 19:44:31.3847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4122 X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Apr 19, 2024 at 3:55=E2=80=AFAM Nick Clifton wro= te: > > Hi Fangrui Song, > > > > Relocation section '.relr.dyn' at offset 0x1f4 contains 2 entries: > > > > Considering REL/RELA output, users might misinterpret "entries" as > > "relocation entries" instead of referring to RELR words. > > Overall, the number of relocation entries seems more valuable than the > > number of RELR words (users can infer the number from the section > > size, or the new "Index:" column). > > A fair point. > > > >> The patch also checks for malformed RELR entries (such as an entry > >> with a value of just 1). > > > > Trailing 1 can be utilized by linkers to avoid convergence issues > > (https://reviews.llvm.org/D67164): > > Interesting. I had not realised that that could happen. > > So how about the attached patch ? It changes the start of the RELR > section display so that it looks something like this: > > Relocation section '.relr.dyn' at offset 0x1a0 contains 3 entries whic= h relocate 27 locations: > > It also removes the warning about an no-op bitmap entry. > > The patch is inefficient in that the section data is loaded twice, once > to count the entries and a second time to display them. But this can > always be fixed up later if it proves to be a significant overhead. > In my testing I did not encounter any delays because of the double > load... > > Cheers > Nick Hi Nick, Thanks for the change. I like the new header "Relocation section '.relr.dyn' at offset 0x1f4 contains 2 entries which relocate 24 locations:" I've only got two nits: Perhaps PRId64 should be changed to PRIu64 as num_rela is unsigned? At /* It is theoretically possible for nentries to be 1. */ , `if (nentries =3D=3D 0` does not free `relrs`. Can `if (nentries =3D=3D 0` be removed since the for loop handles the zero-entry case?