From: Fangrui Song <i@maskray.me>
To: Xi Ruoyao <xry111@xry111.site>
Cc: mengqinggang <mengqinggang@loongson.cn>,
WANG Xuerui <i.swmail@xen0n.name>,
binutils@sourceware.org, xuchenghua@loongson.cn,
chenglulu@loongson.cn, liuzhensong@loongson.cn,
cailulu@loongson.cn, maskray@google.com
Subject: Re: [PATCH] LoongArch: Add support for b ".L1" and beq "$t0", "$t1", ".L1"
Date: Tue, 5 Dec 2023 22:14:26 -0800 [thread overview]
Message-ID: <MN0PR12MB5761526F344F1FBE60CB0596CB84A@MN0PR12MB5761.namprd12.prod.outlook.com> (raw)
In-Reply-To: <c9f466f407c2c0a6b7170472221b7d2fb68d76fd.camel@xry111.site>
On Tue, Dec 5, 2023 at 8:55 PM Xi Ruoyao <xry111@xry111.site> wrote:
>
> On Tue, 2023-12-05 at 19:45 -0800, Fangrui Song wrote:
> > > > diff --git a/gas/testsuite/gas/loongarch/double_quotation_marks.s b/gas/testsuite/gas/loongarch/double_quotation_marks.s
> > > > new file mode 100644
> > > > index 00000000000..bb8acb99a40
> > > > --- /dev/null
> > > > +++ b/gas/testsuite/gas/loongarch/double_quotation_marks.s
> > > > @@ -0,0 +1,2 @@
> > > > +# Before only support beq $t0, $t1, .L1
> > > > +beq "$t0", "$t1", ".L1"
> > > May you provide some explanation as to this feature's intended use case?
> >
> > Agree
> >
> > > Because it seems pointless otherwise without some kind of scenario
> > > that's both valuable to support and impossible to do so without this
> > > feature...
> >
> > I think it will be consistent (with other architectures) to support
> > quoted symbols (".L1"), but it would be odd to support quoted
> > registers.
>
> Just curiously: why did the other architectures have to support quoted
> symbols anyway?
gas allows you to define a symbol whose name contains a special character, e.g.
"a b":
call "a b"
I am not familiar with gas code, but if the patch needs to parse
quotes manually, it feels like a lack of needed abstraction.
I am expecting some function like parseIdentifier to abstract out the logic.
next prev parent reply other threads:[~2023-12-06 6:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 3:17 mengqinggang
2023-12-06 3:28 ` WANG Xuerui
2023-12-06 3:45 ` Fangrui Song
[not found] ` <DS7PR12MB5765C29D265229889294CBF6CB84A@DS7PR12MB5765.namprd12.prod.outlook.com>
2023-12-06 4:55 ` Xi Ruoyao
2023-12-06 6:14 ` Fangrui Song [this message]
[not found] ` <MN0PR12MB5761C1CE97F155CFA535A33CCB84A@MN0PR12MB5761.namprd12.prod.outlook.com>
2023-12-06 6:35 ` Xi Ruoyao
2023-12-06 6:07 ` mengqinggang
2023-12-06 6:16 ` Xi Ruoyao
2023-12-06 6:22 ` Xi Ruoyao
2023-12-06 6:27 ` mengqinggang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR12MB5761526F344F1FBE60CB0596CB84A@MN0PR12MB5761.namprd12.prod.outlook.com \
--to=i@maskray.me \
--cc=binutils@sourceware.org \
--cc=cailulu@loongson.cn \
--cc=chenglulu@loongson.cn \
--cc=i.swmail@xen0n.name \
--cc=liuzhensong@loongson.cn \
--cc=maskray@google.com \
--cc=mengqinggang@loongson.cn \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).