From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10olkn2082.outbound.protection.outlook.com [40.92.41.82]) by sourceware.org (Postfix) with ESMTPS id 079773858C2C for ; Mon, 21 Feb 2022 23:37:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 079773858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I64shh83P2UbMEH7d/9ca4E3bOL1X8Ix3qfAKXDH7OX7jSDFQl/0BL25aaINtn5l/OWWtXwWCYN7rC5QGqPRiLdzpuMpyzwxtJSbPRe6TDym26MIId4LEN6WjhxHMX/eQu5037wiPw3ryNqjU1hv3lX3eO+ayXK1DRcmTXpa1l0bl0PjUB/Z4QnIkcFiezKKPhzm4EcvBEkbYRgwQGkr6FqVmhOtPdRU1GmXbTV3GST5T+JZgY6pjNpDpYnBioy8HCmtQBg4FJjgWRyzPZ0slIetefpmPPzEoW11J/j2MWcQVtWdsIV76pyoPJ8F1ejDFBrqOhj9+NXZsvWsmTp6/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KFn3kWO8ZBfFEnKxIvi98o8Cbf5sWV8ya9yU7dyBTJ8=; b=VewCw2Ug+o6dL75nRjgfBebmsYXVm+A1WKvcSIuK+86ofehwZfjht0wWtijXGaV9hbLjdo5pjWz/yDFIWaiiveBiZPZC3tpiT2TcqzSelpvQRMqzINZubusu6Wz4S7wKWomdAYjqtqxNh/qLjfmH79hD7bwm9RRHhoCq61ZakRyE4Vskg/wvbhsv7HEoGXYHcFZXrOvFX/dSCIskhzkcH0/TR9h4XbSCQkxSsWX/8k8nBGHaQBFGeFIPq7QOiX3JIT37BdnzzrqvRwHCFBH5pABoRs4OkHxhUDwcYGZv9ym1yxvhVRCbX02T7n8BXaanQNGPVf/BAzfGF+hUix/iLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MWHPR1201MB0110.namprd12.prod.outlook.com (2603:10b6:301:56::8) by MN2PR12MB3983.namprd12.prod.outlook.com (2603:10b6:208:169::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Mon, 21 Feb 2022 23:37:10 +0000 Received: from MWHPR1201MB0110.namprd12.prod.outlook.com ([fe80::f9c3:7c8a:55cd:45ee]) by MWHPR1201MB0110.namprd12.prod.outlook.com ([fe80::f9c3:7c8a:55cd:45ee%9]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 23:37:10 +0000 X-Gm-Message-State: AOAM531HjgnHmNn97usnPNE/DFAHOauSjgXuMOZeNyw7W/+WtpoAEV0S dsTHjt/PKtFIZzfXih87eYkWrPujspBa1WqXao8= X-Google-Smtp-Source: ABdhPJwHbTX6eiBwHPwDH2Cle5O9MXrmuPhbks2R1N5T6LDV7QgnNuIYz4WDeHkMg1iv1f0KCamijBaNpsBuA76VwEw= X-Received: by 2002:a67:e1c9:0:b0:31a:a108:4358 with SMTP id p9-20020a67e1c9000000b0031aa1084358mr9810175vsl.8.1645486257076; Mon, 21 Feb 2022 15:30:57 -0800 (PST) References: <251473f45c9c4d2fa5edc3265c5ac77e06bb07b2.camel@debian.org> <740fedd2111e72f785bbe000890193f55a6a1d6d.camel@debian.org> <20220217021219.qqwepnd4yjaq6ogq@gmail.com> In-Reply-To: From: Fangrui Song Date: Mon, 21 Feb 2022 15:30:45 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Output section type (READONLY) To: Alan Modra Cc: Nick Clifton , binutils@sourceware.org, Luca Boccassi X-TMN: [zn7ePJBVIJAtWSg7y7NvJCRy4vmbqXdo] X-ClientProxiedBy: BYAPR11CA0080.namprd11.prod.outlook.com (2603:10b6:a03:f4::21) To MWHPR1201MB0110.namprd12.prod.outlook.com (2603:10b6:301:56::8) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2a2b34b6-29f0-417e-7e53-08d9f5931428 X-MS-TrafficTypeDiagnostic: MN2PR12MB3983:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fvN9Z6DPU510p6ieIMhUP2pFDzz99x7xlwtpmOIliIUqDP23AsaRfeDnYVO19GXtjF3cXmsf73klCmvDHPpM23pFWDslKBlUv1Z7GYqPl+mEIY5WkpRXmC1mSQM8wo+YtDLolmr1c1A6hySE08gts5YYBKC/Io4YrS+/OsvDj94ob4PHCueqM5TWwFg53UMFA7gUAlpzPFLdL+fn9ybh1GNZNcNol4pbBQbdBgJl5vSiUyJL59B/xfCM7fGxweO+iorMHqzspssiieINKi9TVrfT+FwpPOomVzdBS1k1vL0TytiU3twqgSC+VzK9FeZ3s9gD8X7V5KLP1Js037cHdDc1yxSDaCdOvEF+nQhgUulIlqYTay/ycl3cWu4dwcuMgYuseYjaQRDuiWzFecpzI9OwGBqcJripPhIJqi9Dx3Jvjzr7UPj8jQvWCJINSo8rg2fw5zTv63cNJ6q2FPezH5PeSDFsv4SCVS5jSx4asrdX+K+G5EJny74EFGlpC+XUxB0GTM8ixgBlWJSVTlVjkgREg77RKfyoL/9Ukz3s9PqPrjjo+a/axUtZDpLt7S9ek2Qk2Or4IJpQFry59B6Qmw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0ovR0NpcWVTUlZGMGcxYlNiUkU1azNqcUR3bmNSZVJiVVF3bXlGVXpjRzJF?= =?utf-8?B?SStTa0xLWVArakUrUmNnMDZSZ0NyZVRPV3d2QzdjdVlnVlZFSWtaWXMyZThr?= =?utf-8?B?b0JwMkp0QStta0JqY0xRRGJXRXprUEp0VGlzTFB1UFVoMjdRREVURjRXbmlC?= =?utf-8?B?Nm43bFZ4dmlnV25ENVpsZkRqYXJJalBiQ25BNlFhUm44MXVxRExqcVpxVHhx?= =?utf-8?B?STQvTVc4TlVFSVNWOVVDOHZvUGhpcmdVVlBBL1FYeWRzUGhOSnFmd2YvaVNW?= =?utf-8?B?RE1mVk81eGppN0puVGNvWDdvV0JqOVlOck55QXBKQWJoUDJrcTZtUThhNGx6?= =?utf-8?B?MGZlejZmdEkvMld5czhSMUdCNGFCdXc0Q014dU9NQUVpVDVPcjRmcGtzN3Ey?= =?utf-8?B?eTNoTldXUTJObFUxYnVvTmJCbE5DenVveVAzbGY5MUZNZUdOdDVXOFpnb0Yz?= =?utf-8?B?eGIrRUVaVm4zSnZveUFhSHhrbWdpVjRzOUNla2dyaEZ3R2F3NXljQmtHRnZh?= =?utf-8?B?RHkxNDVVV3BMa0U5YzNVb2VMdVkrMTJhZWVyS3RaQkpKeDZZSEJpcEpiaUFS?= =?utf-8?B?UHBCbUJSdmR6V21OR1UyTE50Umg0MEVYMzBrTTlTZjJyWTU1ZThrbXFiU2xj?= =?utf-8?B?TTBzTEFWTGpKTERhQ29xaDZvZTVzbHhDMlNFcnBGVDIrRHVMNTRyR1ZxdEhM?= =?utf-8?B?ZlJKbzM4Sjl1KzAzOU5UYlh6M2F0R1M4a0NVOWpmWUJOTGFtWFlRYkZBbUpk?= =?utf-8?B?Ylk3ckdLK0g1dFNtOHNUZHZvb1BTcW14Vkd0b2EvL291ZHY1c0gwcTZYRDF1?= =?utf-8?B?QmRMRmNCT3NHdlpyV1RWNzYxejAraXVTTlRWUWZycGg1eEhTbHY2ckEvVXF5?= =?utf-8?B?dmtzUkRZVzRFMlJaV2x3ZHM3UzVFN0MwaWpsZkh2aUh5NlNzeW1COU04cHEv?= =?utf-8?B?c0NubzBJK0x3YmNrOWlENmtLZStvUlBPa283OEQ2UHkySlBHUFFFUUhhSTQy?= =?utf-8?B?VFhzNE1pWHZxY041NHhPUi8vR1NaZm1FZVhtWE91S2ZoRFdDRHNMM2U4ZjJh?= =?utf-8?B?NTJPOURPNDE0TmNMNWVybFJMcGVsWnQ4TDJmaVBUbDFUSkc4T1F0WnlMZGdo?= =?utf-8?B?U1pKdTR4MGJ0WDhmRVQ0YzFOQlBsYm1zNDYwNUM3aTRLaTI0ZTFJRlNrdnRz?= =?utf-8?B?Zkdtajd0V0VENnVta3kvbFJoWC82NndWNjVZUjd2emJpZ3pQUVVUSmNYMXU4?= =?utf-8?B?ZE90V0tlQjFPT0JjRkhUY3V4Sk1oV0J2WkR0djFNT0szUkVMZz09?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-71ea3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 2a2b34b6-29f0-417e-7e53-08d9f5931428 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB0110.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 23:37:10.0581 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3983 X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, HTML_MESSAGE, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 23:37:14 -0000 Thanks! On Mon, Feb 21, 2022, 15:04 Alan Modra wrote: > On Wed, Feb 16, 2022 at 06:12:19PM -0800, Fangrui Song wrote: > > On 2022-02-16, Nick Clifton wrote: > > > Hi Guys, > > > > > > I have gone ahead and applied an update form of Fanguri's patch > (attached). > > > > Thanks, this enables a proper way to set the section type in the future. > > Hope someone implements this for gold as well since it does not > > recognize .note* as SHT_NOTE, either. > > "DO NOT EDIT!" says the comment at the top of bfd-in2.h. Move the new > type field where it belongs. > > PR ld/28841 > * section.c (struct bfd_section): Add type. Formatting. > (BFD_FAKE_SECTION): Formatting. > * bfd-in2.h: Regenerate. > > diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h > index 78a0a1dea42..db41e7eb7fe 100644 > --- a/bfd/bfd-in2.h > +++ b/bfd/bfd-in2.h > @@ -1166,11 +1166,13 @@ typedef struct bfd_section > struct bfd_section *s; > const char *linked_to_symbol_name; > } map_head, map_tail; > - /* Points to the output section this section is already assigned to, if > any. > - This is used when support for non-contiguous memory regions is > enabled. */ > - struct bfd_section *already_assigned; > > - /* Explicitly specified section type, if non-zero. */ > + /* Points to the output section this section is already assigned to, > + if any. This is used when support for non-contiguous memory > + regions is enabled. */ > + struct bfd_section *already_assigned; > + > + /* Explicitly specified section type, if non-zero. */ > unsigned int type; > > } asection; > @@ -1356,7 +1358,7 @@ discarded_section (const asection *sec) > (struct bfd_symbol *) SYM, &SEC.symbol, \ > \ > /* map_head, map_tail, already_assigned, type */ \ > - { NULL }, { NULL }, NULL, 0 \ > + { NULL }, { NULL }, NULL, 0 \ > \ > } > > diff --git a/bfd/section.c b/bfd/section.c > index 2de7dbf661a..9a1071454f5 100644 > --- a/bfd/section.c > +++ b/bfd/section.c > @@ -551,9 +551,14 @@ CODE_FRAGMENT > . struct bfd_section *s; > . const char *linked_to_symbol_name; > . } map_head, map_tail; > -. {* Points to the output section this section is already assigned to, if > any. > -. This is used when support for non-contiguous memory regions is > enabled. *} > -. struct bfd_section *already_assigned; > +. > +. {* Points to the output section this section is already assigned to, > +. if any. This is used when support for non-contiguous memory > +. regions is enabled. *} > +. struct bfd_section *already_assigned; > +. > +. {* Explicitly specified section type, if non-zero. *} > +. unsigned int type; > . > .} asection; > . > @@ -738,7 +743,7 @@ CODE_FRAGMENT > . (struct bfd_symbol *) SYM, &SEC.symbol, \ > . \ > . {* map_head, map_tail, already_assigned, type *} > \ > -. { NULL }, { NULL }, NULL, 0 > \ > +. { NULL }, { NULL }, NULL, 0 \ > . \ > . } > . > > -- > Alan Modra > Australia Development Lab, IBM >