* Auto generate ChangeLog for binutils commits?
@ 2020-05-26 17:07 H.J. Lu
2020-05-27 14:10 ` Simon Marchi
0 siblings, 1 reply; 25+ messages in thread
From: H.J. Lu @ 2020-05-26 17:07 UTC (permalink / raw)
To: Binutils, GDB
Hi,
I had an impression that ChangeLog was auto generated for GDB commits.
If it is true, should we do the same for binutils commits?
--
H.J.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto generate ChangeLog for binutils commits?
2020-05-26 17:07 Auto generate ChangeLog for binutils commits? H.J. Lu
@ 2020-05-27 14:10 ` Simon Marchi
2020-05-27 14:20 ` H.J. Lu
0 siblings, 1 reply; 25+ messages in thread
From: Simon Marchi @ 2020-05-27 14:10 UTC (permalink / raw)
To: H.J. Lu, Binutils, GDB
On 2020-05-26 1:07 p.m., H.J. Lu via Gdb wrote:
> Hi,
>
> I had an impression that ChangeLog was auto generated for GDB commits.
> If it is true, should we do the same for binutils commits?
>
> --
> H.J.
>
No we (GDB) don't do that. There was a discussion here
https://sourceware.org/pipermail/gdb-patches/2020-February/165728.html
But it didn't go anywhere. Note that when I actually tried the script, it
didn't produce good results (perhaps because it wasn't designed with C++
in mind).
Simon
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto generate ChangeLog for binutils commits?
2020-05-27 14:10 ` Simon Marchi
@ 2020-05-27 14:20 ` H.J. Lu
2020-05-27 14:29 ` Simon Marchi
0 siblings, 1 reply; 25+ messages in thread
From: H.J. Lu @ 2020-05-27 14:20 UTC (permalink / raw)
To: Simon Marchi; +Cc: Binutils, GDB
On Wed, May 27, 2020 at 7:10 AM Simon Marchi <simark@simark.ca> wrote:
>
> On 2020-05-26 1:07 p.m., H.J. Lu via Gdb wrote:
> > Hi,
> >
> > I had an impression that ChangeLog was auto generated for GDB commits.
> > If it is true, should we do the same for binutils commits?
> >
> > --
> > H.J.
> >
>
> No we (GDB) don't do that. There was a discussion here
>
> https://sourceware.org/pipermail/gdb-patches/2020-February/165728.html
>
> But it didn't go anywhere. Note that when I actually tried the script, it
> didn't produce good results (perhaps because it wasn't designed with C++
> in mind).
GCC will auto generate ChangeLog entry from git commit message. Can
binutils+gdb do the same?
--
H.J.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto generate ChangeLog for binutils commits?
2020-05-27 14:20 ` H.J. Lu
@ 2020-05-27 14:29 ` Simon Marchi
2020-05-27 15:10 ` Auto update ChangeLog for binutils+gdb commits? H.J. Lu
0 siblings, 1 reply; 25+ messages in thread
From: Simon Marchi @ 2020-05-27 14:29 UTC (permalink / raw)
To: H.J. Lu; +Cc: Binutils, GDB
On 2020-05-27 10:20 a.m., H.J. Lu wrote:
> On Wed, May 27, 2020 at 7:10 AM Simon Marchi <simark@simark.ca> wrote:
>>
>> On 2020-05-26 1:07 p.m., H.J. Lu via Gdb wrote:
>>> Hi,
>>>
>>> I had an impression that ChangeLog was auto generated for GDB commits.
>>> If it is true, should we do the same for binutils commits?
>>>
>>> --
>>> H.J.
>>>
>>
>> No we (GDB) don't do that. There was a discussion here
>>
>> https://sourceware.org/pipermail/gdb-patches/2020-February/165728.html
>>
>> But it didn't go anywhere. Note that when I actually tried the script, it
>> didn't produce good results (perhaps because it wasn't designed with C++
>> in mind).
>
> GCC will auto generate ChangeLog entry from git commit message. Can
> binutils+gdb do the same?
Can you please explain what this means? I suspect that we are not talking about
the same thing. You mean, still write the ChangeLog entry by hand, but only put
it in the git commit. And then a script scrapes all the commit messages in order
to produce a ChangeLog file?
Simon
^ permalink raw reply [flat|nested] 25+ messages in thread
* Auto update ChangeLog for binutils+gdb commits?
2020-05-27 14:29 ` Simon Marchi
@ 2020-05-27 15:10 ` H.J. Lu
2020-05-29 7:45 ` Martin Liška
0 siblings, 1 reply; 25+ messages in thread
From: H.J. Lu @ 2020-05-27 15:10 UTC (permalink / raw)
To: Simon Marchi; +Cc: Binutils, GDB
On Wed, May 27, 2020 at 7:29 AM Simon Marchi <simark@simark.ca> wrote:
>
> On 2020-05-27 10:20 a.m., H.J. Lu wrote:
> > On Wed, May 27, 2020 at 7:10 AM Simon Marchi <simark@simark.ca> wrote:
> >>
> >> On 2020-05-26 1:07 p.m., H.J. Lu via Gdb wrote:
> >>> Hi,
> >>>
> >>> I had an impression that ChangeLog was auto generated for GDB commits.
> >>> If it is true, should we do the same for binutils commits?
> >>>
> >>> --
> >>> H.J.
> >>>
> >>
> >> No we (GDB) don't do that. There was a discussion here
> >>
> >> https://sourceware.org/pipermail/gdb-patches/2020-February/165728.html
> >>
> >> But it didn't go anywhere. Note that when I actually tried the script, it
> >> didn't produce good results (perhaps because it wasn't designed with C++
> >> in mind).
> >
> > GCC will auto generate ChangeLog entry from git commit message. Can
> > binutils+gdb do the same?
>
> Can you please explain what this means? I suspect that we are not talking about
> the same thing. You mean, still write the ChangeLog entry by hand, but only put
> it in the git commit. And then a script scrapes all the commit messages in order
> to produce a ChangeLog file?
>
Yes. I updated the email subject. Personally, I think it is a good
exercise to document
what changes are in ChangeLog format in commit message. But adding them to
ChangeLog files is a problem. If git commit hooks can do it
automatically, it will
be very nice. GCC will do it now. Can we do the same?
--
H.J.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-27 15:10 ` Auto update ChangeLog for binutils+gdb commits? H.J. Lu
@ 2020-05-29 7:45 ` Martin Liška
2020-05-29 8:50 ` Martin Liška
` (2 more replies)
0 siblings, 3 replies; 25+ messages in thread
From: Martin Liška @ 2020-05-29 7:45 UTC (permalink / raw)
To: H.J. Lu, Simon Marchi; +Cc: GDB, Binutils
On 5/27/20 5:10 PM, H.J. Lu via Binutils wrote:
> be very nice. GCC will do it now. Can we do the same?
Hello.
I'm the author of the scripts that are currently used in the GCC.
As mentioned, we update ChangeLog files by a script that takes all
the ChangeLog entries from git commit message. The supported ChangeLog
format is documented here:
https://gcc.gnu.org/codingconventions.html#ChangeLogs
and the corresponding script can be seen here:
https://gcc.gnu.org/git/?p=gcc.git;a=tree;f=contrib/gcc-changelog;h=2900264795a520b5fdf7ccd54f7a08a84dcc35f2;hb=HEAD
I briefly looked at binutils commits and I believe the scripts can
be directly adopted.
Martin
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-29 7:45 ` Martin Liška
@ 2020-05-29 8:50 ` Martin Liška
2020-05-29 8:51 ` Martin Liška
2020-05-29 12:15 ` Tom Tromey
2 siblings, 0 replies; 25+ messages in thread
From: Martin Liška @ 2020-05-29 8:50 UTC (permalink / raw)
To: H.J. Lu, Simon Marchi; +Cc: GDB, Binutils
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
On 5/29/20 9:45 AM, Martin Liška wrote:
> I briefly looked at binutils commits and I believe the scripts can
> be directly adopted.
Ok, one would need to adjust list of ChangeLog files and bugzilla components. I've changed
that in the attached patch.
With that one can test it:
$ ./contrib/gcc-changelog/git_check_commit.py -g ~/Programming/binutils -n HEAD~300..HEAD
(see the attached output)
So ~250/300 commit messages can be parsed.
And the generated ChangeLog can be seen with:
./contrib/gcc-changelog/git_check_commit.py -g ~/Programming/binutils -n HEAD~300..HEAD -p
(see the attached output)
Would you be interested in adoption of the script?
Martin
[-- Attachment #2: 0001-gcc-changelog-for-binutils.patch --]
[-- Type: text/x-patch, Size: 4643 bytes --]
diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py
index 084e83c18cc..e2be3843c83 100755
--- a/contrib/gcc-changelog/git_commit.py
+++ b/contrib/gcc-changelog/git_commit.py
@@ -20,110 +20,149 @@ import os
import re
changelog_locations = set([
+ 'bfd',
+ 'binutils',
'config',
'contrib',
- 'contrib/header-tools',
- 'contrib/reghunt',
- 'contrib/regression',
- 'fixincludes',
- 'gcc/ada',
- 'gcc/analyzer',
- 'gcc/brig',
- 'gcc/c',
- 'gcc/c-family',
- 'gcc',
- 'gcc/cp',
- 'gcc/d',
- 'gcc/fortran',
- 'gcc/go',
- 'gcc/jit',
- 'gcc/lto',
- 'gcc/objc',
- 'gcc/objcp',
- 'gcc/po',
- 'gcc/testsuite',
- 'gnattools',
- 'gotools',
+ 'cpu',
+ 'elfcpp',
+ 'etc',
+ 'gas',
+ 'gdb',
+ 'gdb/doc',
+ 'gdbserver',
+ 'gdb/stubs',
+ 'gdbsupport',
+ 'gdb/testsuite',
+ 'gnulib',
+ 'gold',
+ 'gprof',
'include',
+ 'include/gdb',
'intl',
- 'libada',
- 'libatomic',
- 'libbacktrace',
- 'libcc1',
- 'libcpp',
- 'libcpp/po',
+ 'ld',
+ 'libctf',
'libdecnumber',
- 'libffi',
- 'libgcc',
- 'libgcc/config/avr/libf7',
- 'libgcc/config/libbid',
- 'libgfortran',
- 'libgomp',
- 'libhsail-rt',
'libiberty',
- 'libitm',
- 'libobjc',
- 'liboffloadmic',
- 'libphobos',
- 'libquadmath',
- 'libsanitizer',
- 'libssp',
- 'libstdc++-v3',
- 'libvtv',
- 'lto-plugin',
- 'maintainer-scripts',
- 'zlib'])
+ 'opcodes',
+ 'readline',
+ 'readline/readline/examples/rlfe',
+ 'sim/aarch64',
+ 'sim/arm',
+ 'sim/avr',
+ 'sim/bfin',
+ 'sim',
+ 'sim/common',
+ 'sim/cr16',
+ 'sim/cris',
+ 'sim/d10v',
+ 'sim/erc32',
+ 'sim/frv',
+ 'sim/ft32',
+ 'sim/h8300',
+ 'sim/igen',
+ 'sim/iq2000',
+ 'sim/lm32',
+ 'sim/m32c',
+ 'sim/m32r',
+ 'sim/m68hc11',
+ 'sim/mcore',
+ 'sim/microblaze',
+ 'sim/mips',
+ 'sim/mn10300',
+ 'sim/moxie',
+ 'sim/msp430',
+ 'sim/ppc',
+ 'sim/pru',
+ 'sim/rl78',
+ 'sim/rx',
+ 'sim/sh64',
+ 'sim/sh',
+ 'sim/testsuite',
+ 'sim/testsuite/d10v-elf',
+ 'sim/testsuite/frv-elf',
+ 'sim/testsuite/m32r-elf',
+ 'sim/testsuite/mips64el-elf',
+ 'sim/testsuite/sim/aarch64',
+ 'sim/testsuite/sim/arm',
+ 'sim/testsuite/sim/avr',
+ 'sim/testsuite/sim/bfin',
+ 'sim/testsuite/sim/cr16',
+ 'sim/testsuite/sim/cris',
+ 'sim/testsuite/sim/fr30',
+ 'sim/testsuite/sim/frv',
+ 'sim/testsuite/sim/ft32',
+ 'sim/testsuite/sim/h8300',
+ 'sim/testsuite/sim/iq2000',
+ 'sim/testsuite/sim/lm32',
+ 'sim/testsuite/sim/m32c',
+ 'sim/testsuite/sim/m32r',
+ 'sim/testsuite/sim/m68hc11',
+ 'sim/testsuite/sim/mcore',
+ 'sim/testsuite/sim/microblaze',
+ 'sim/testsuite/sim/mips',
+ 'sim/testsuite/sim/mn10300',
+ 'sim/testsuite/sim/moxie',
+ 'sim/testsuite/sim/msp430',
+ 'sim/testsuite/sim/or1k',
+ 'sim/testsuite/sim/pru',
+ 'sim/testsuite/sim/sh64',
+ 'sim/testsuite/sim/sh64/compact',
+ 'sim/testsuite/sim/sh64/media',
+ 'sim/testsuite/sim/sh',
+ 'sim/testsuite/sim/v850',
+ 'sim/v850',
+ 'zlib'
+])
bug_components = set([
+ # GDB components
'ada',
- 'analyzer',
- 'boehm-gc',
- 'bootstrap',
- 'c',
+ 'backtrace',
+ 'breakpoints',
+ 'build',
'c++',
+ 'cli',
+ 'compile',
+ 'corefiles',
'd',
- 'debug',
- 'demangler',
- 'driver',
- 'fastjar',
+ 'exp',
+ 'external',
'fortran',
- 'gcov-profile',
+ 'gdb',
'go',
- 'hsa',
- 'inline-asm',
- 'ipa',
+ 'guile',
+ 'i18n',
'java',
- 'jit',
- 'libbacktrace',
- 'libf2c',
- 'libffi',
- 'libfortran',
- 'libgcc',
- 'libgcj',
- 'libgomp',
- 'libitm',
- 'libobjc',
- 'libquadmath',
- 'libstdc++',
- 'lto',
- 'middle-end',
- 'modula2',
+ 'm2',
+ 'm3',
+ 'macros',
+ 'mi',
'objc',
- 'objc++',
- 'other',
- 'pch',
- 'pending',
- 'plugins',
- 'preprocessor',
- 'regression',
- 'rtl-optimization',
- 'sanitizer',
- 'spam',
- 'target',
+ 'pascal',
+ 'python',
+ 'record',
+ 'remote',
+ 'rust',
+ 'server',
+ 'shlibs',
+ 'sim',
+ 'symtab',
+ 'tdep',
'testsuite',
- 'translation',
- 'tree-optimization',
- 'web'])
+ 'threads',
+ 'tui',
+ 'varobj',
+ 'web',
+ 'win32',
+ # Binutils components
+ 'admin',
+ 'binutils',
+ 'gas',
+ 'gold',
+ 'gprof',
+ 'ld',
+ 'libctf'])
ignored_prefixes = [
'gcc/d/dmd/',
[-- Attachment #3: result-changelog.txt --]
[-- Type: text/plain, Size: 105535 bytes --]
Checking 80e2a3b66ed9055fc26a1e5e26c6158b1c87111d: OK
------ binutils/ChangeLog ------
2020-03-27 Alan Modra <amodra@gmail.com>
* readelf.c (process_archive): Don't double free qualified_name.
Don't break out of loop with "negative" archive_file_size, just
set file offset to max.
Checking 89ff19d45e9acfff9c77bf570631df6b99b62619: FAILED
ERR: cannot find a ChangeLog location in message
Checking a879b4d5a683f8dbebae8cf98297ee4a2db2e9e1: OK
------ include/ChangeLog ------
2020-03-26 John Baldwin <jhb@FreeBSD.org>
* elf/common.h (AT_FREEBSD_BSDFLAGS): Define.
------ gdb/ChangeLog ------
2020-03-26 John Baldwin <jhb@FreeBSD.org>
* fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
Checking 0826b30a9fa085ccee574465523d0560a4a01198: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
(mark_common_block_symbol_computed, read_tag_string_type)
(attr_to_dynamic_prop, read_subrange_type): Update.
(dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
to be methods on struct attribute.
(skip_one_die, process_imported_unit_die, read_namespace_alias)
(read_call_site_scope, partial_die_info::read)
(partial_die_info::read, lookup_die_type, follow_die_ref):
Update.
* dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
from dwarf2_get_ref_die_offset.
(attribute::constant_value): New method, from
dwarf2_get_attr_constant_value.
* dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
Declare method.
<constant_value>: New method.
Checking 2b2558bfacba3813863da6728c021eb89fa34677: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
(dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
(dwarf_type_encoding_name): Move to stringify.c.
* Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
* dwarf2/stringify.c: New file.
* dwarf2/stringify.h: New file.
Checking eeb647814fbfd71dddea45f36cb4847341f5cde7: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
Rewrite.
Checking a39fdb411d43824b27d886bab42cada62a9fe431: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
methods.
* dwarf2/read.c (lookup_addr_base): Move to die.h.
(lookup_ranges_base): Likewise.
(read_cutu_die_from_dwo, read_full_die_1): Update.
Checking 436c571c6afc8c5affe36327ab363b98ec9adb2d: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (read_import_statement, read_file_scope)
(read_type_unit_scope, inherit_abstract_dies, read_func_scope)
(read_lexical_block_scope, read_call_site_scope)
(dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
(handle_struct_member_die, process_structure_scope)
(update_enumeration_type_from_children)
(process_enumeration_scope, read_array_type, read_common_block)
(read_namespace, read_module, read_subroutine_type): Update.
(sibling_die): Remove.
Checking 052c8bb83a515768cd6af2f3707b6e05854cac54: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
(build_type_psymtabs_reader, read_structure_type)
(read_enumeration_type, read_full_die_1): Update.
(dwarf2_attr_no_follow): Move to die.h.
* dwarf2/die.h (struct die_info) <attr>: New method.
Checking 2b24b6e4a6d03efc3e76ce6912394e4a86cc387b: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
<base_address>: Now an optional.
(dwarf2_find_base_address, dwarf2_rnglists_process)
(dwarf2_ranges_process, fill_in_loclist_baton)
(dwarf2_symbol_mark_computed): Update.
Checking c2d50fd0b30f640301c3736038bec82b40a3f0dc: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (struct die_info): Move to die.h.
* dwarf2/die.h: New file.
Checking 0df7ad3a675692fcc75c85c43e475015b87a297e: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/line-header.h (dwarf_decode_line_header): Declare.
* dwarf2/read.c
(dwarf2_statement_list_fits_in_line_number_section_complaint):
Move to line-header.c.
(read_checked_initial_length_and_offset, read_formatted_entries):
Likewise.
(dwarf_decode_line_header): Split into two.
* dwarf2/line-header.c
(dwarf2_statement_list_fits_in_line_number_section_complaint):
Move from read.c.
(read_checked_initial_length_and_offset, read_formatted_entries):
Likewise.
(dwarf_decode_line_header): New function, split from read.c.
Checking 86c0bb4c57111422b30da6b1b20256bd3a06778a: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
Declare method.
* dwarf2/read.c (read_attribute_value): Update.
(dwarf2_per_objfile::read_line_string): Rename from
read_indirect_line_string.
(read_formatted_entries): Update.
Checking 2ef46c2fbbd18c3f411ef294c2c6694a1308a5a5: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
variable.
Checking 4f9c1eda9ffc161015b6d9cc6dc958b67de680e6: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/macro.h (dwarf_decode_macros): Make section parameter
const.
* dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
(dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
parameter const.
Checking 5a0e026fe12a4b1a94878494facf2b5f173a3b9c: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
* dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
* dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
(dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
Checking 8844c11b8bc1cfa70a63a8875e08345c96abecfe: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/line-header.h (struct line_header) <is_valid_file_index,
file_names_size, file_full_name, file_file_name>: Use const.
<file_name_at, file_names>: Add const overload.
* dwarf2/line-header.c (line_header::file_file_name)
(line_header::file_full_name): Update.
Checking c90ec28ae44ebf72d57d58439d02fc5aab90f1f6: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
(macro_start_file, consume_improper_spaces)
(parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
(dwarf_parse_macro_header, dwarf_decode_macro_bytes)
(dwarf_decode_macros): Move to macro.c.
* dwarf2/macro.c: New file.
* dwarf2/macro.h: New file.
* Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
Checking 4f44ae6c69b839712a33a46aaa62d58d2b16b4ca: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
method.
* dwarf2/section.c: New method. From
read_indirect_string_at_offset_from.
* dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
(read_indirect_string_at_offset_from): Move to section.c.
(read_indirect_string_at_offset): Rewrite.
(read_indirect_line_string_at_offset): Remove.
(read_indirect_string, read_indirect_line_string)
(dwarf_decode_macro_bytes): Update.
Checking a0194fa8f23c64bef0f4b4bb4a76e9c64f003169: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/section.h (struct dwarf2_section_info)
<overload_complaint>: Declare.
(dwarf2_section_buffer_overflow_complaint): Don't declare.
* dwarf2/section.c (dwarf2_section_info::overflow_complaint):
Rename from dwarf2_section_buffer_overflow_complaint.
* dwarf2/read.c (skip_one_die, partial_die_info::read)
(skip_form_bytes, dwarf_decode_macro_bytes): Update.
Checking 3d27bbdb4bc02968ffd86c6b5c331d0e04bc3ed9: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
Declare.
* dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
Move from read.c.
* dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
to section.c.
Checking 9eac9650ce7de1f6e4b5ddc103d6530ebc32582d: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
Checking bf80d710525ba743d0046bf1f9cab6a019d7c616: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (macro_start_file): Change "cu" parameter to
"builder".
(dwarf_decode_macro_bytes): Likewise. Add dwarf2_per_objfile
parameter.
(dwarf_decode_macros): Update.
Checking 0314b3901c9cdc21ef9f0c1b0b88528d6f8d3073: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (read_attribute_value): Update.
(read_indirect_string_from_dwz): Move to dwz.c; change into
method.
(dwarf_decode_macro_bytes): Update.
* dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
* dwarf2/dwz.c: New file.
* Makefile.in (COMMON_SFILES): Add dwz.c.
Checking 9fda78b61127cbcf718104b7e5a78cf137c07836: OK
------ gdb/ChangeLog ------
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.h (struct dwz_file): Move to dwz.h.
* dwarf2/read.c: Add include.
* dwarf2/index-write.c: Add include.
* dwarf2/index-cache.c: Add include.
* dwarf2/dwz.h: New file.
Checking aa49fc22c13a685452a2073e252d8b34ecbcc012: OK
------ bfd/ChangeLog ------
2020-03-26 Nick Clifton <nickc@redhat.com>
* cofflink.c (bfd_coff_get_internal_extra_pe_aouthdr): Delete.
* libbfd-in.h (bfd_coff_get_internal_extra_pe_aouthdr): Remove
prototype.
* libbfd.h: Regenerate.
Checking 832a580781060f54731fcf654d76ac1332037a47: OK
------ opcodes/ChangeLog ------
2020-03-26 Alan Modra <amodra@gmail.com>
* disassemble.h (opcodes_assert): Declare.
(OPCODES_ASSERT): Define.
* disassemble.c: Don't include assert.h. Include opintl.h.
(opcodes_assert): New function.
* h8300-dis.c (bfd_h8_disassemble_init): Use OPCODES_ASSERT.
(bfd_h8_disassemble): Reduce size of data array. Correctly
calculate maxlen. Omit insn decoding when insn length exceeds
maxlen. Exit from nibble loop when looking for E, before
accessing next data byte. Move processing of E outside loop.
Replace tests of maxlen in loop with assertions.
Checking ff7685105468702de87b75599b1ea88cc309541c: OK
------ bfd/ChangeLog ------
2020-03-26 Alan Modra <amodra@gmail.com>
* i386msdos.c (msdos_object_p): Catch -1 return from bfd_bread.
Checking 4c4addbe57711f1cdbb72305b8cbd03a68ae2e34: OK
------ opcodes/ChangeLog ------
2020-03-26 Alan Modra <amodra@gmail.com>
* arc-dis.c (find_format): Init needs_limm. Simplify use of limm.
Checking f75fbe8ad2e3d9b34bf1f448a6df328ff361822f: OK
------ bfd/ChangeLog ------
2020-03-26 Alan Modra <amodra@gmail.com>
* vms-alpha.c (dst_define_location): Limit size of dst_ptr_offsets
array.
(_bfd_vms_slurp_object_records): Rename "err" to "ok".
Checking 46b438bb7369a55eefef15cd5d1afbb5c2c5742e: FAILED
ERR: cannot find a ChangeLog location in message
Checking 33aa3c10f663b834c9573ede439b2df3c92f0cfe: OK
------ gdb/ChangeLog ------
2020-03-25 Tom Tromey <tom@tromey.com>
* compile/compile-object-load.c (get_out_value_type): Mention
correct symbol name in error message.
Checking d503b685c6b7384b389767d5153235039e2b8fc4: OK
------ gdb/ChangeLog ------
2020-03-25 Hannes Domani <ssbssa@yahoo.de>
* windows-nat.c (windows_add_all_dlls): Fix system dll paths.
Checking 4c83662712f80abe9a7d8ef645123347a9de7adb: OK
------ binutils/ChangeLog ------
2020-03-25 Alan Modra <amodra@gmail.com>
* readelf.c (process_archive): Prevent endless loop.
Checking aac88046e6cccf13fc408fc4e515aaf2548fe898: OK
------ bfd/ChangeLog ------
2020-03-25 Nick Clifton <nickc@redhat.com>
* cofflink.c (bfd_coff_get_internal_extra_pe_aouthdr): New
function.
* libbfd-in.h (bfd_coff_get_internal_extra_pe_aouthdr): Prototype.
* libbfd.h: Regenerate.
Checking b77809577782d8798bc86dde3a2a28c30d7805f0: OK
------ gas/ChangeLog ------
2020-03-25 J.W. Jagersma <jwjagersma@gmail.com>
* config/obj-coff.c (obj_coff_section): Set the bss flag on
sections with the "b" attribute.
Checking 7b1eff95bed765cb20dd3168cb99896a91fcdca7: OK
------ gdb/ChangeLog ------
2020-03-25 Tom de Vries <tdevries@suse.de>
* symtab.h (is_main_symtab_of_compunit_symtab): New function.
* symmisc.c (dump_symtab_1): Print user and includes fields.
(maintenance_info_symtabs): Same.
Checking dd8953924b0966e363c27ee38a0663c08f742fa0: OK
------ gdb/ChangeLog ------
2020-03-25 Andrew Burgess <andrew.burgess@embecosm.com>
PR gdb/25489
* riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
(riscv_regcache_cooked_write): New function.
(riscv_push_dummy_call): Use new function.
(riscv_return_value): Likewise.
Checking cf2611febcfa6b7c680de31071c5658e7463eee4: OK
------ bfd/ChangeLog ------
2020-03-25 Shahab Vahedi <shahab@synopsys.com>
* elf32-arc.c (PRINT_DEBUG_RELOC_INFO_BEFORE): Use the
correct field name in the output string.
Checking 86fd7e2e109813b3934cf7880b93d4bc8f779b8b: OK
------ ld/ChangeLog ------
2020-03-25 Alan Modra <amodra@gmail.com>
* testsuite/ld-elf/compress1c.d: xfail h8300.
* testsuite/ld-elf/compressed1c.d: Likewise.
* testsuite/ld-elf/compressed1e.d: Likewise.
* testsuite/ld-elf/dynamic1.d: Likewise.
* testsuite/ld-elf/dynsym1.d: Likewise.
* testsuite/ld-elf/ehdr_start-shared.d: Likewise.
* testsuite/ld-elf/exclude3b.d: Likewise.
* testsuite/ld-elf/export-class.exp: Don't run without -shared support.
* testsuite/ld-elf/global1.d: xfail h8300.
* testsuite/ld-elf/hash.d: Likewise.
* testsuite/ld-elf/loadaddr1.d: Likewise.
* testsuite/ld-elf/loadaddr2.d: Likewise.
* testsuite/ld-elf/local1.d: Likewise.
* testsuite/ld-elf/mbind1b.d: Likewise.
* testsuite/ld-elf/mbind1c.d: Likewise.
* testsuite/ld-elf/now-1.d: Likewise.
* testsuite/ld-elf/now-2.d: Likewise.
* testsuite/ld-elf/now-3.d: Likewise.
* testsuite/ld-elf/now-4.d: Likewise.
* testsuite/ld-elf/pie.d: Likewise.
* testsuite/ld-elf/pr12975.d: Likewise.
* testsuite/ld-elf/pr13177.d: Likewise.
* testsuite/ld-elf/pr13195.d: Likewise.
* testsuite/ld-elf/pr16322.d: Likewise.
* testsuite/ld-elf/pr16498a.d: Likewise.
* testsuite/ld-elf/pr16498b.d: Likewise.
* testsuite/ld-elf/pr17615.d: Likewise.
* testsuite/ld-elf/pr19162.d: Likewise.
* testsuite/ld-elf/pr19539.d: Likewise.
* testsuite/ld-elf/pr19617a.d: Likewise.
* testsuite/ld-elf/pr19698.d: Likewise.
* testsuite/ld-elf/pr20513c.d: Likewise.
* testsuite/ld-elf/pr20513d.d: Likewise.
* testsuite/ld-elf/pr21389a.d: Likewise.
* testsuite/ld-elf/pr21389b.d: Likewise.
* testsuite/ld-elf/pr21389c.d: Likewise.
* testsuite/ld-elf/pr21562a.d: Likewise.
* testsuite/ld-elf/pr21562b.d: Likewise.
* testsuite/ld-elf/pr21562c.d: Likewise.
* testsuite/ld-elf/pr21562d.d: Likewise.
* testsuite/ld-elf/pr21562e.d: Likewise.
* testsuite/ld-elf/pr21562f.d: Likewise.
* testsuite/ld-elf/pr21562g.d: Likewise.
* testsuite/ld-elf/pr21562h.d: Likewise.
* testsuite/ld-elf/pr21562i.d: Likewise.
* testsuite/ld-elf/pr21562j.d: Likewise.
* testsuite/ld-elf/pr21562k.d: Likewise.
* testsuite/ld-elf/pr21562l.d: Likewise.
* testsuite/ld-elf/pr21562m.d: Likewise.
* testsuite/ld-elf/pr21562n.d: Likewise.
* testsuite/ld-elf/pr21903a.d: Likewise.
* testsuite/ld-elf/pr21903b.d: Likewise.
* testsuite/ld-elf/pr21903d.d: Likewise.
* testsuite/ld-elf/pr22269a.d: Likewise.
* testsuite/ld-elf/pr22269b.d: Likewise.
* testsuite/ld-elf/pr22393-1a.d: Likewise.
* testsuite/ld-elf/pr22393-1b.d: Likewise.
* testsuite/ld-elf/pr22393-1c.d: Likewise.
* testsuite/ld-elf/pr22393-1d.d: Likewise.
* testsuite/ld-elf/pr22393-1e.d: Likewise.
* testsuite/ld-elf/pr22393-1f.d: Likewise.
* testsuite/ld-elf/pr22423.d: Likewise.
* testsuite/ld-elf/pr22450.d: xfail avr, crx, h8300, ip2k, m68hc11,
and xc16x.
* testsuite/ld-elf/pr23658-1c.d: xfail h8300.
* testsuite/ld-elf/pr25708.d: xfail h8300 and hppa64.
* testsuite/ld-elf/rpath-1.d: xfail h8300.
* testsuite/ld-elf/rpath-2.d: Likewise.
* testsuite/ld-elf/runpath-1.d: Likewise.
* testsuite/ld-elf/runpath-2.d: Likewise.
* testsuite/ld-elf/sizeofb.d: Likewise.
* testsuite/ld-elf/startofb.d: Likewise.
* testsuite/ld-elf/strtab.d: Likewise.
* testsuite/ld-elf/textaddr1.d: Likewise.
* testsuite/ld-elf/textaddr2.d: Likewise.
* testsuite/ld-elf/textaddr4.d: Likewise.
* testsuite/ld-elf/textaddr5.d: Likewise.
* testsuite/ld-elf/textaddr6.d: Likewise.
* testsuite/ld-elf/unknown2.d: Likewise.
* testsuite/ld-undefined/entry-3.d: Likewise.
* testsuite/ld-undefined/entry-4.d: Likewise.
* testsuite/ld-h8300/h8300.exp: Pass appropriate ld -m option.
* testsuite/ld-h8300/gcsection.d: Remove ld -m option and relax
file format match.
* testsuite/ld-h8300/relax-2.d: Likewise.
* testsuite/ld-h8300/relax-3.d: Likewise.
* testsuite/ld-h8300/relax-4.d: Likewise.
* testsuite/ld-h8300/relax-5.d: Likewise.
* testsuite/ld-h8300/relax-6.d: Likewise.
* testsuite/ld-h8300/relax-7.d: Likewise.
* testsuite/ld-h8300/relax.d: Relax file format match.
Checking d16e3d2e5b717cf83c1fe47a70e0a9f2c2024a44: FAILED
ERR: missing PR component:" PR 25662"
Checking 0d4a4bc56fc947565ef0dd4b440a157e7d592b09: FAILED
ERR: cannot find a ChangeLog location in message
Checking 1081065c519d1bfc3847bf4b0a0ce4bc3224bcd3: FAILED
ERR: changed file not mentioned in a ChangeLog:"bfd/libbfd.h"
Checking a18cd0cab43f45b05e9f8bcbf8fed1d67834442d: OK
------ opcodes/ChangeLog ------
2020-03-24 Alan Modra <amodra@gmail.com>
* z80-dis.c (suffix): Init mybuf.
Checking 5ab2fbf185935f387fd5c1f8b14ba9fe04b41b39: OK
------ gdb/ChangeLog ------
2020-03-24 Simon Marchi <simon.marchi@polymtl.ca>
* fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
* fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
* inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
* inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
* infrun.c (follow_fork): Likewise.
(follow_fork_inferior): Likewise.
* linux-nat.c (linux_nat_target::follow_fork): Likewise.
* linux-nat.h (class linux_nat_target): Likewise.
* remote.c (class remote_target) <follow_fork>: Likewise.
(remote_target::follow_fork): Likewise.
* target-delegates.c: Re-generate.
* target.c (default_follow_fork): Likewise.
(target_follow_fork): Likewise.
* target.h (struct target_ops) <follow_fork>: Likewise.
(target_follow_fork): Likewise.
Checking e11cd7c491e4ec0cdd080c6dd45e62789a893606: OK
Checking 0b8448af68b2720d08640604355ef7d961a5acd6: FAILED
ERR: missing PR component:" PR 25713"
Checking ec2e748ad396c868839c977aa27d0333eb085970: FAILED
ERR: missing PR component:" PR 25681"
Checking cda7e5603f6efd7c3716e45cc6ea11b70dd8daae: OK
------ bfd/ChangeLog ------
2020-03-24 H.J. Lu <hjl.tools@gmail.com>
PR binutils/25717
* elf-bfd.h (elf_obj_tdata): Change num_group to unsigned int.
Checking dfb68cc35803369cbd163c2ebc07fb27e81d9950: FAILED
ERR: invalid PR component:" PR lto/94249"
Checking 7e6e972f74aeac0ebdbd95a7f905d871cd2581de: OK
------ bfd/ChangeLog ------
2020-03-24 H.J. Lu <hjl.tools@gmail.com>
PR binutils/25708
* elf-bfd.h (_bfd_elf_get_symbol_version_name): New.
* elf.c (_bfd_elf_get_symbol_version_name): New function. Based
on the previous _bfd_elf_get_symbol_version_string.
(_bfd_elf_get_symbol_version_string): Use it.
------ binutils/ChangeLog ------
2020-03-24 H.J. Lu <hjl.tools@gmail.com>
PR binutils/25708
* nm.c (SYM_NAME): Removed.
(print_symname): Add a pointer to struct extended_symbol_info
argument. Call _bfd_elf_get_symbol_version_name to get symbol
version.
(print_symdef_entry): Pass NULL to print_symname.
(print_symbol_info_bsd): Update call to print_symname.
(print_symbol_info_sysv): Likewise.
(print_symbol_info_posix): Likewise.
------ ld/ChangeLog ------
2020-03-24 H.J. Lu <hjl.tools@gmail.com>
PR binutils/25708
* testsuite/ld-elf/pr25708.d: New file.
Checking a64fafb54577a87919a600474a3e4abe3510341a: OK
------ gdb/ChangeLog ------
2020-03-24 Tom de Vries <tdevries@suse.de>
* psymtab.c (maintenance_info_psymtabs): Print user field.
Checking 65109548f8fb13ac4a6c3311ea46a8b69c548576: OK
------ bfd/ChangeLog ------
2020-03-24 Alan Modra <amodra@gmail.com>
* archive.c (_bfd_generic_read_ar_hdr_mag): Sanity check extended
name size. Use bfd_malloc rather than bfd_zmalloc, clearing just
struct areltdata.
Checking 5a814d6d96bc6426ae1fa8b0d1561ad081deb159: OK
------ binutils/ChangeLog ------
2020-03-24 Alan Modra <amodra@gmail.com>
* readelf.c (process_mips_specific): Free iconf on error path.
Checking 1ce0847daa8de001ed4a1b32341fcc3ce53f5a30: FAILED
ERR: cannot find a ChangeLog location in message
Checking 0636b24556961d705b945f2465432df80e9ebf68: FAILED
ERR: missing PR component:" PR 25714"
Checking fdde2fb60cc2d0c60d9d3f085a7b6c648376991e: FAILED
ERR: line should start with a tab:" * elflink.c (_bfd_elf_tls_setup): Mention .tdata in comment."
Checking cf28cfef6006c41b74af126bc6ef26590d7bd1b9: OK
------ bfd/ChangeLog ------
2020-03-23 Alan Modra <amodra@gmail.com>
* ecoff.c (_bfd_ecoff_slurp_armap): Sanity check parsed_size and
symbol count. Allocate an extra byte to ensure name strings
are terminated. Sanity check name offsets. Release memory on
error return.
Checking 5e737279c6e832a757f0326128e5a5f96fbdd291: OK
------ bfd/ChangeLog ------
2020-03-23 Alan Modra <amodra@gmail.com>
* i386msdos.c (msdos_object_p): Don't access e_lfanew when that
field hasn't been read. Remove unnecessary casts.
------ ld/ChangeLog ------
2020-03-23 Alan Modra <amodra@gmail.com>
* Makefile.am (ALL_EMULATION_SOURCES): Reinstate ei386aout.c.
Include ei386aout dep file.
* Makefile.in: Regenerate.
* po/BLD-POTFILES.in: Regenerate.
Checking 5935fd15306c26ead8274cbeab3287770f2ac92a: OK
------ gdb/testsuite/ChangeLog ------
2020-03-23 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb.fortran/mixed-lang-stack.exp: Replace two hard coded address
with $hex.
Checking 2957d8d05405c53b0d377e578fe1b770af732254: FAILED
ERR: cannot find a ChangeLog location in message
Checking c15a8f173e9b01dd962ba857b7deb547d34bca5b: OK
------ bfd/ChangeLog ------
2020-03-22 Alan Modra <amodra@gmail.com>
* coff64-rs6000.c (xcoff64_slurp_armap): Ensure size is large
enough to read number of symbols.
Checking 57cb32b3c366585f7fafd6a741771ce826ba95f3: OK
------ opcodes/ChangeLog ------
2020-03-22 Alan Modra <amodra@gmail.com>
* h8300-dis.c (bfd_h8_disassemble): Limit data[] access to that
successflly read from section.
Checking beea5cc1bc2249389dc77ea0c86ab82dafd05bb5: OK
------ opcodes/ChangeLog ------
2020-03-22 Alan Modra <amodra@gmail.com>
* arc-dis.c (find_format): Use ISO C string concatenation rather
than line continuation within a string. Don't access needs_limm
before testing opcode != NULL.
Checking 03704c7704870a0e6cbb0eae99488d544c4adb30: OK
------ opcodes/ChangeLog ------
2020-03-22 Alan Modra <amodra@gmail.com>
* ns32k-dis.c (print_insn_arg): Update comment.
(print_insn_ns32k): Reduce size of index_offset array, and
initialize, passing -1 to print_insn_arg for args that are not
an index. Don't exit arg loop early. Abort on bad arg number.
Checking d1023b5d1e4483e5fa3bdab97bc041e1b1c05c5d: OK
------ opcodes/ChangeLog ------
2020-03-22 Alan Modra <amodra@gmail.com>
* s12z-dis.c (abstract_read_memory): Don't print error on EOI.
* s12z-opc.c: Formatting.
(operands_f): Return an int.
(opr_n_bytes_p1): Return -1 on reaching buffer memory limit.
(opr_n_bytes2, bfextins_n_bytes, mul_n_bytes, bm_n_bytes),
(shift_n_bytes, mov_imm_opr_n_bytes, loop_prim_n_bytes),
(exg_sex_discrim): Likewise.
(create_immediate_operand, create_bitfield_operand),
(create_register_operand_with_size, create_register_all_operand),
(create_register_all16_operand, create_simple_memory_operand),
(create_memory_operand, create_memory_auto_operand): Don't
segfault on malloc failure.
(z_ext24_decode): Return an int status, negative on fail, zero
on success.
(x_imm1, imm1_decode, trap_decode, z_opr_decode, z_opr_decode2),
(imm1234, reg_s_imm, reg_s_opr, z_imm1234_8base, z_imm1234_0base),
(z_tfr, z_reg, reg_xy, lea_reg_xys_opr, lea_reg_xys, rel_15_7),
(decode_rel_15_7, cmp_xy, sub_d6_x_y, sub_d6_y_x),
(ld_18bit_decode, mul_decode, bm_decode, bm_rel_decode),
(mov_imm_opr, ld_18bit_decode, exg_sex_decode),
(loop_primitive_decode, shift_decode, psh_pul_decode),
(bit_field_decode): Similarly.
(z_decode_signed_value, decode_signed_value): Similarly. Add arg
to return value, update callers.
(x_opr_decode_with_size): Check all reads, returning NULL on fail.
Don't segfault on NULL operand.
(decode_operation): Return OP_INVALID on first fail.
(decode_s12z): Check all reads, returning -1 on fail.
------ gas/ChangeLog ------
2020-03-22 Alan Modra <amodra@gmail.com>
* testsuite/gas/s12z/truncated.d: Update expected output.
Checking da2efc2050edf4641a22462beeb4c6b9a1a827f2: FAILED
ERR: cannot find a ChangeLog location in message
Checking e3b1fa32c2814772e8c8c4d2788e1d342c7493d0: OK
------ include/ChangeLog ------
2020-03-21 Martin Liska <mliska@suse.cz>
* plugin-api.h (enum ld_plugin_symbol_type): Remove
comma after last value of an enum.
* lto-symtab.h (enum gcc_plugin_symbol_type): Likewise.
Checking d9fb0d71365e3c7e2c0de2ecd9cb9de0c2bf1880: FAILED
ERR: cannot find a ChangeLog location in message
Checking fe26d3a34a223a86fddb59ed70a621a13940a088: OK
------ gdb/ChangeLog ------
2020-03-20 Tom Tromey <tromey@adacore.com>
* dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
const.
* dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
const.
Checking c623cc90890de9958bcee382cc60ff1b605532ab: FAILED
ERR: cannot find a ChangeLog location in message
Checking c884cc46193c98fd0b90ce8a79c081f6a1c18cc6: OK
------ gdb/ChangeLog ------
2020-03-20 Simon Marchi <simon.marchi@efficios.com>
* ptrace.m4: Don't check for ptrace declaration.
* config.in: Re-generate.
* configure: Re-generate.
* nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
not defined.
------ gdbserver/ChangeLog ------
2020-03-20 Simon Marchi <simon.marchi@efficios.com>
* config.in: Re-generate.
* configure: Re-generate.
------ gdbsupport/ChangeLog ------
2020-03-20 Simon Marchi <simon.marchi@efficios.com>
* config.in: Re-generate.
* configure: Re-generate.
Checking 1ff700c202465275d1ca3aee4dd979db36274294: FAILED
ERR: line should start with a tab:" * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to"
ERR: line should start with a tab:" `PTRACE_TYPE_RET'."
ERR: line should start with a tab:" * i386-bsd-nat.c (gdb_ptrace): Likewise."
ERR: line should start with a tab:" * sparc-nat.c (gdb_ptrace): Likewise."
ERR: line should start with a tab:" * x86-bsd-nat.c (gdb_ptrace): Likewise."
Checking f7d4f0b1b9519fa10eb04cb195bdf7b5044d73c7: OK
------ gdb/ChangeLog ------
2020-03-20 Tom Tromey <tromey@adacore.com>
* c-exp.y (lex_one_token): Fix assert.
Checking f67210ff1c4200ea668189d086c6b39145cd876f: OK
------ gdb/ChangeLog ------
2020-03-20 Tom Tromey <tromey@adacore.com>
* ada-tasks.c (read_atcb): Use smaller length in strncpy call.
* linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
strncpy call.
Checking 1773be9ea2207d42442222e6dc3c8fdbe638e28e: OK
------ gdb/ChangeLog ------
2020-03-20 Tom Tromey <tromey@adacore.com>
* symmisc.c (maintenance_print_one_line_table): Use ui_out.
------ gdb/testsuite/ChangeLog ------
2020-03-20 Tom Tromey <tromey@adacore.com>
* gdb.dwarf2/dw2-ranges-base.exp: Update regular expressions.
Checking 70304be939301a91dade0dc7d4234c081372bd24: OK
------ gdb/ChangeLog ------
2020-03-20 Tom Tromey <tromey@adacore.com>
* ada-valprint.c (print_variant_part): Remove parameters; switch
to value-based API.
(print_field_values): Likewise.
(ada_val_print_struct_union): Likewise.
(ada_value_print_1): Update.
------ gdb/testsuite/ChangeLog ------
2020-03-20 Tom Tromey <tromey@adacore.com>
* gdb.ada/sub_variant/subv.adb: New file.
* gdb.ada/sub_variant.exp: New file.
Checking 9faa006d11a5e08264a007463435f84b77864c9c: OK
------ gdb/ChangeLog ------
2020-03-20 Kamil Rytarowski <n54@gmx.com>
* ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
nbsd_nat_target instead of inf_ptrace_target.
* ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
nbsd_nat_target.
Checking 4a90f062056e842c3f53293482e0039db0da3245: OK
------ gdb/ChangeLog ------
2020-03-20 Kamil Rytarowski <n54@gmx.com>
* hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
it to the ptrace call.
* (store_registers): Likewise.
Checking 0dd7b8f788b8d5239800d59f97b43186dcf425e2: OK
------ gdb/testsuite/ChangeLog ------
2020-03-20 Tom de Vries <tdevries@suse.de>
* gdb.threads/step-over-lands-on-breakpoint.exp (do_test): Bail out if
first break fails.
* gdb.threads/step-over-trips-on-watchpoint.exp: (do_test): Same.
Checking 0d832e7f5e8c2e3659a55955c3b419e7cf5c9a34: FAILED
ERR: missing PR component:" PR 25690"
Checking c7da12c72c2eeb4f62e772df5cbb1f50f35a84ee: FAILED
ERR: line should start with a tab:" it to the ptrace call."
ERR: line should start with a tab:" * (store_registers): Likewise."
Checking 5844b4657aa2b9eb52aecc5a6338324032fb6eae: OK
------ binutils/ChangeLog ------
2020-03-20 Nick Clifton <nickc@redhat.com>
* readelf.c (get_compression_header): Add ATTRIBUTE_WARN_UNUSED_RESULT.
(process_section_headers): Check the return value from
get_compression_header.
(dump_section_as_strings): Likewise.
(dump_section_as_bytes): Likewise.
(load_specific_debug_section): Likewise.
Checking 3d98c46092341c1373d960d0a66ca502d5b7ee7f: OK
------ bfd/ChangeLog ------
2020-03-20 H.J. Lu <hjl.tools@gmail.com>
* configure.ac (HAVE_EXECUTABLE_SUFFIX): Removed.
(EXECUTABLE_SUFFIX): Likewise.
* config.in: Regenerated.
* configure: Likewise.
* plugin.c (bfd_plugin_close_and_cleanup): Defined as
_bfd_generic_close_and_cleanup.
(plugin_list_entry): Remove resolution_file, resolution_option,
real_bfd, real_nsyms, real_syms, lto_nsyms, lto_syms, gcc,
lto_wrapper, gcc_env and initialized,
(need_lto_wrapper_p): Removed.
(get_lto_wrapper): Likewise.
(setup_lto_wrapper_env): Likewise.
(register_all_symbols_read): Likewise.
(egister_cleanup): Likewise.
(get_symbols): Likewise.
(add_input_file): Likewise.
(bfd_plugin_set_program_name): Remove need_lto_wrapper.
(add_symbols): Updated.
(try_claim): Likewise.
(try_load_plugin): Likewise.
(bfd_plugin_canonicalize_symtab): Likewise.
* plugin.h (bfd_plugin_set_program_name): Remove int argument.
(plugin_data_struct): Remove real_bfd, real_nsyms and real_syms.
------ binutils/ChangeLog ------
2020-03-20 H.J. Lu <hjl.tools@gmail.com>
* ar.c (main): Update bfd_plugin_set_program_name call.
* nm.c (main): Likewise.
------ ld/ChangeLog ------
2020-03-20 H.J. Lu <hjl.tools@gmail.com>
* testsuite/ld-plugin/lto.exp (lto_link_tests): Run PR ld/25355
test only for GCC 10 or newer.
Checking c3a1714ce7806002726a60c0db09371425fe3097: OK
------ bfd/ChangeLog ------
2020-03-20 H.J. Lu <hjl.tools@gmail.com>
PR binutils/25640
* plugin.c (plugin_list_entry): Add has_symbol_type.
(add_symbols_v2): New function.
(bfd_plugin_open_input): Don't invoke LTO wrapper if LTO plugin
provides symbol type.
(try_load_plugin): Add LDPT_ADD_SYMBOLS_V2.
(bfd_plugin_canonicalize_symtab): Use LTO plugin symbol type if
available.
Checking c02d66610b3b79f6fb5052e8890969bc7185b7be: OK
------ ld/ChangeLog ------
2020-03-20 Alan Modra <amodra@gmail.com>
* testplug.c (parse_symdefstr): Use %hhi to read sym->def, and
clear new fields.
* testplug2.c (parse_symdefstr): Likewise.
* testplug3.c (parse_symdefstr): Likewise.
* testplug4.c (parse_symdefstr): Likewise.
Checking 67338173a49204a2097ca1e2c63c6bc1fe972c3e: OK
------ bfd/ChangeLog ------
2020-03-20 Alan Modra <amodra@gmail.com>
* coff-rs6000.c (_bfd_xcoff_slurp_armap): Ensure size is large
enough to read number of symbols.
Checking 340f3ac8082771ecc473ab938fc3d7cbf607ddaa: OK
------ opcodes/ChangeLog ------
2020-03-20 Alan Modra <amodra@gmail.com>
* metag-dis.c (print_insn_metag): Don't ignore status from
read_memory_func.
Checking fe90ae8a9f54e4fe8b9089fed48b0e1818414f57: OK
------ opcodes/ChangeLog ------
2020-03-20 Alan Modra <amodra@gmail.com>
* nds32-dis.c (print_insn_nds32): Remove unnecessary casts.
Initialize parts of buffer not written when handling a possible
2-byte insn at end of section. Don't attempt decoding of such
an insn by the 4-byte machinery.
Checking 833d919c93d52644173d587a6fc8e4dd36edc49e: OK
------ opcodes/ChangeLog ------
2020-03-20 Alan Modra <amodra@gmail.com>
* ppc-dis.c (print_insn_powerpc): Only clear needed bytes of
partially filled buffer. Prevent lookup of 4-byte insns when
only VLE 2-byte insns are possible due to section size. Print
".word" rather than ".long" for 2-byte leftovers.
Checking a859124df20f6544dbef96084e4e024bccebd853: OK
------ bfd/ChangeLog ------
2020-03-20 Alan Modra <amodra@gmail.com>
* elf.c (_bfd_elf_setup_sections): Don't test known non-NULL
backend functions for NULL before calling.
(copy_special_section_fields, _bfd_elf_copy_private_bfd_data),
(bfd_section_from_shdr, assign_section_numbers): Likewise.
* elfcode.h (elf_write_relocs, elf_slurp_reloc_table): Likewise.
* elfnn-ia64.c (ignore_errors): New function.
(elf_backend_link_order_error_handler): Redefine as ignore_errors.
Checking ce2ea1c7e055b3b70f03dc33db3b77b0d775f5de: FAILED
ERR: cannot find a ChangeLog location in message
Checking 9a6c68caa9543e09b064b7ac7c2b658f277bc19c: FAILED
ERR: line should start with a tab:" * options.h (General_options): Add --no-rosegment option."
Checking f09db380942d1393e6f60d1ecaa7d4b6edfaaecf: OK
------ gdb/ChangeLog ------
2020-03-19 Kamil Rytarowski <n54@gmx.com>
* inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
* inf-ptrace.c: Likewise.
* (gdb_ptrace): Add.
* (inf_ptrace_target::resume): Update.
* (inf_ptrace_target::xfer_partial): Likewise.
* (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
* (inf_ptrace_peek_poke): Update.
Checking f3a08f77787cfe1b9edb7b5ab82ce7a2d527c8cf: FAILED
ERR: missing PR component:" PR 25676"
ERR: line should start with a tab:"bfd * dwarf2.c (struct varinfo): Add unit_offset field to record the"
ERR: first line should start with a tab, asterisk and space:" location of the varinfo in the unit's debug info data. Change the"
ERR: first line should start with a tab, asterisk and space:" type of the stack field to a boolean."
ERR: first line should start with a tab, asterisk and space:" (lookup_var_by_offset): New function. Returns the varinfo"
ERR: first line should start with a tab, asterisk and space:" structure for the variable described at the given offset in the"
ERR: first line should start with a tab, asterisk and space:" unit's debug info."
ERR: first line should start with a tab, asterisk and space:" (scan_unit_for_symbols): Add support for variables which have the"
ERR: first line should start with a tab, asterisk and space:" DW_AT_specification attribute."
ERR: line should start with a tab:"binutils* testsuite/binutils-all/dw4.s: New test source file."
ERR: could not deduce ChangeLog file
Checking 3734bec8336f6f33927ab99460cb681035c2ca4f: OK
------ include/ChangeLog ------
2020-03-19 Martin Liska <mliska@suse.cz>
* lto-symtab.h (enum gcc_plugin_symbol_type): New.
(enum gcc_plugin_symbol_section_kind): Likewise.
------ include/ChangeLog ------
2020-03-19 Martin Liska <mliska@suse.cz>
Martin Liska <mliska@suse.cz>
* plugin-api.h (struct ld_plugin_symbol): Split
int def into 4 char fields.
(enum ld_plugin_symbol_type): New.
(enum ld_plugin_symbol_section_kind): New.
(enum ld_plugin_tag): Add LDPT_ADD_SYMBOLS_V2.
Checking 2d07da271eee9a83a1f5c975204d7d6dfd66fe1f: OK
------ gdb/ChangeLog ------
2020-03-19 Luis Machado <luis.machado@linaro.org>
* nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
valid, fetch vg value from ptrace.
Checking 6a541707f341275fa5081ec36cc6f2551042c21e: FAILED
ERR: missing PR component:" PR 25699"
Checking fcc7376e0a4c3a68ef0b9d12fcc3733416b1cc8c: OK
------ gdb/ChangeLog ------
2020-03-19 Kamil Rytarowski <n54@gmx.com>
* x86-bsd-nat.c (gdb_ptrace): New.
* (x86bsd_dr_set): Add new argument `ptid'.
* (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
x86bsd_dr_set_addr): Update.
Checking ef3df11042c3dbaf695c1260b42364688cafa8ea: OK
------ binutils/ChangeLog ------
2020-03-19 H.J. Lu <hjl.tools@gmail.com>
* readelf.c (process_symbol_table): Use unsigned long for si.
Checking cada5fc921e39a1945c422eea055c8b326d8d353: OK
------ gdb/ChangeLog ------
2020-03-19 Andrew Burgess <andrew.burgess@embecosm.com>
* remote.c (remote_target::process_stop_reply): Handle events for
all threads differently.
------ gdb/testsuite/ChangeLog ------
2020-03-19 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb.server/exit-multiple-threads.c: New file.
* gdb.server/exit-multiple-threads.exp: New file.
Checking 6b8c53f2f1c0cf5bee46120d892d4c72571375eb: OK
------ gdb/testsuite/ChangeLog ------
2020-03-19 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb.fortran/mixed-lang-stack.c: New file.
* gdb.fortran/mixed-lang-stack.cpp: New file.
* gdb.fortran/mixed-lang-stack.exp: New file.
* gdb.fortran/mixed-lang-stack.f90: New file.
Checking 19a2740f7f2ea0f65745a3c00cf8a64647378aa3: FAILED
ERR: line should start with a tab:"Change-Id: Ie5c7c9fc8ecf973072cfb4a9650867104bf7f50c"
Checking 724fd9ba432a20ef2e3f2c0d6060bff131226816: FAILED
ERR: line should start with a tab:"Change-Id: I9d1db52c489ca0041b8959ca0d53b7d3af8aea72"
Checking d8c8b84859d057c58c901c08367ecc9f8a9f09dc: OK
------ gdb/testsuite/ChangeLog ------
2020-03-19 Tom de Vries <tdevries@suse.de>
* gdb.opt/inline-locals.exp: Add kfail PR number. Make kfail matching
more precise.
Checking effc14f54c3fdcb700f22ce53cef97665c0fdf7f: FAILED
ERR: line should start with a tab:" * elfxx-riscv.c (riscv_parse_subset): Don't use C99."
Checking 81a65eb338cf7b40ef76b1cdb150eefd8495e282: OK
------ binutils/ChangeLog ------
2020-03-19 Alan Modra <amodra@gmail.com>
* elfcomm.c: Don't include bfd.h or bucomm.h.
(program_name): Declare.
(process_archive_index_and_symbols): Replace bfd_boolean with int,
and substitute FALSE and TRUE.
(setup_archive, setup_nested_archive): Likewise.
* elfcomm.h: Likewise.
Checking 1cb7d8b1afc7c71cfacfe017e0692c9064bf9818: OK
------ binutils/ChangeLog ------
2020-03-19 Alan Modra <amodra@gmail.com>
* readelf.c (process_archive): Always return via path freeing
memory. Formatting.
Checking b966f55ffa570a05081b2030577b2158e8116c5a: OK
------ binutils/ChangeLog ------
2020-03-19 Alan Modra <amodra@gmail.com>
* readelf.c (process_netbsd_elf_note): Validate descsz before
accessing descdata. Formatting.
Checking 645ba68105ee79511a79386811dd932be8becafa: OK
------ binutils/ChangeLog ------
2020-03-19 Alan Modra <amodra@gmail.com>
* elfcomm.c (setup_archive): Make file_size an off_t. Comment.
* elfcomm.h (setup_archive): Update prototype.
Checking cdf236890ce1a8f44d24841d888728f9feb38c44: FAILED
ERR: cannot find a ChangeLog location in message
Checking a9933ccf467ac771747db9dba541afdf1b72a3f8: OK
------ gdb/testsuite/ChangeLog ------
2020-03-18 Tom de Vries <tdevries@suse.de>
* gdb.dwarf2/break-inline-psymtab-2.c: New test.
* gdb.dwarf2/break-inline-psymtab.c: New test.
* gdb.dwarf2/break-inline-psymtab.exp: New file.
Checking aef397a1548908f82907854a6efc0cd4c0539904: FAILED
ERR: line should start with a tab:"Change-Id: I8870800177e1ff79cdd05af13613ec53ef95681f"
ERR: could not deduce ChangeLog file
Checking ac4bf06ca22b641b10fe37763bf57e177ee22864: FAILED
ERR: missing PR component:" PR 25673"
Checking 53215f214c61b850085196a8d69774eed026ecd9: FAILED
ERR: line should start with a tab:"Change-Id: I60deaeeee59d4e7cab06b8a40a3e51837c43a8ab"
Checking 5a82b8a12b6a9b8167517ab1df1dcdcc4711ffda: OK
------ gdb/ChangeLog ------
2020-03-18 Kamil Rytarowski <n54@gmx.com>
* regformats/regdef.h: Put reg in gdb namespace.
------ gdbserver/ChangeLog ------
2020-03-18 Kamil Rytarowski <n54@gmx.com>
* regcache.cc (find_register_by_number): Update.
* tdesc.cc (init_target_desc): Likewise.
* tdesc.h (target_desc::reg_defs): Likewise.
Checking fb516a69133999df3e30fccb7c4f5759eb1090eb: OK
------ gdb/ChangeLog ------
2020-03-18 Kamil Rytarowski <n54@gmx.com>
* i386-bsd-nat.c (gdb_ptrace): New.
* (i386bsd_fetch_inferior_registers,
i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
* (i386bsd_fetch_inferior_registers,
i386bsd_store_inferior_registers) Use gdb_ptrace.
Checking 1c0aa1fbb2fb1920c12400940704ee90491b7290: OK
------ gdb/ChangeLog ------
2020-03-18 Kamil Rytarowski <n54@gmx.com>
* amd64-bsd-nat.c (gdb_ptrace): New.
* (amd64bsd_fetch_inferior_registers,
amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
* (amd64bsd_fetch_inferior_registers,
amd64bsd_store_inferior_registers) Use gdb_ptrace.
Checking d3e2a5e85df4c8454135503c1034b95fecd522ab: OK
------ gdbsupport/ChangeLog ------
2020-03-18 Kamil Rytarowski <n54@gmx.com>
* common-defs.h: Include alloca.h if HAVE_ALLOCA_H is defined.
Checking 5ccd2fb722d1900adf799dd808fa2146cac85d0d: OK
------ gdb/ChangeLog ------
2020-03-18 Kamil Rytarowski <n54@gmx.com>
* user-regs.c (user_reg::read): Rename to...
(user_reg::xread): ...this.
* (append_user_reg): Rename argument `read' to `xread'.
* (user_reg_add_builtin): Likewise.
* (user_reg_add): Likewise.
* (value_of_user_reg): Likewise.
Checking fe64b263e025c5abc02738138d9283f53641ca42: FAILED
ERR: cannot find a ChangeLog location in message
Checking 2108a63a5a736c2329a2a92ca58e0b9993dc5d42: OK
------ gdb/ChangeLog ------
2020-03-17 Kamil Rytarowski <n54@gmx.com>
* sparc-nat.c (gdb_ptrace): New.
* sparc-nat.c (sparc_fetch_inferior_registers)
(sparc_store_inferior_registers) Remove obsolete comment.
* sparc-nat.c (sparc_fetch_inferior_registers)
(sparc_store_inferior_registers) Switch from pid_t to ptid_t.
* sparc-nat.c (sparc_fetch_inferior_registers)
(sparc_store_inferior_registers) Use gdb_ptrace.
Checking d3c3c54293ce8c42503e66f8076059a7c8b1639f: OK
Checking 327ef784ba105f067f5c1d587908259d7aabb971: FAILED
ERR: missing PR component:" PR 25633"
Checking 68e52bc7ecfbfdc8d5f85716a8ac7668e211f360: FAILED
ERR: missing PR component:" PR 25641"
ERR: missing PR component:" PR 25668"
ERR: missing PR component:" PR 25633"
ERR: line should start with a tab:"gas Fix disassembling ED+A4/AC/B4/BC opcodes."
ERR: first line should start with a tab, asterisk and space:" Fix assembling lines containing colonless label and instruction"
ERR: first line should start with a tab, asterisk and space:" with first operand inside parentheses."
ERR: first line should start with a tab, asterisk and space:" Fix registration of unsupported by target CPU registers."
ERR: line should start with a tab:"opcodes * z80-dis.c: Fix disassembling ED+A4/AC/B4/BC opcodes."
ERR: could not deduce ChangeLog file
Checking ecbbbdba7182865e522e0893915e9be487fe14b0: FAILED
ERR: missing PR component:" PR 25687"
Checking a225c9a8692814b4a29360479aee217d73e22d50: OK
------ gdb/ChangeLog ------
2020-03-17 Kamil Rytarowski <n54@gmx.com>
* sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
it to the ptrace call.
* sh-nbsd-nat.c (store_registers): Likewise.
Checking 9809762324491b851332ce600ae9bde8dd34f601: OK
------ gdb/ChangeLog ------
2020-03-17 Kamil Rytarowski <n54@gmx.com>
* sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
nbsd_nat_target instead of inf_ptrace_target.
* sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
nbsd_nat_target.
Checking 946ffddcae7a8d0d135dd550b4bc7193b2ac1c5c: FAILED
ERR: cannot find a ChangeLog location in message
Checking 9e38d619101a7637c9aba3f722690bef127fa6a6: OK
------ gdb/ChangeLog ------
2020-03-17 Kamil Rytarowski <n54@gmx.com>
* amd64-bsd-nat.c: Include amd64-bsd-nat.h".
Checking a2ecbe9fb7355698aad97841f9717cdfd7096d95: OK
------ gdb/ChangeLog ------
2020-03-17 Kamil Rytarowski <n54@gmx.com>
* nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
<sys/sysctl.h>.
* nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
Checking 589902954da0d1dd140b33e578954746c9bfc374: OK
------ gdb/ChangeLog ------
2020-03-17 Tom de Vries <tdevries@suse.de>
PR gdb/23710
* dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
fields.
* dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
fields.
(process_imported_unit_die): Skip import of c++ CUs.
Checking 7325b16ba4dc33a54356fd2b8fde79311c51b121: FAILED
ERR: cannot find a ChangeLog location in message
Checking 771dd3a88b1f0e03a110fc4f2207913df45f8b4b: OK
------ gdb/ChangeLog ------
2020-03-16 Tom Tromey <tom@tromey.com>
* p-valprint.c (pascal_object_print_value): Initialize
base_value.
Checking 817a7585764366397879cbbedfd7e9c1454b656c: FAILED
ERR: line should start with a tab:" (arc_read_description): New function to cache target descriptions."
Checking 67430cd00afcc270a27e44b10f9ef4249d554e66: FAILED
ERR: first line should start with a tab, asterisk and space:" PR gdb/25663:"
Checking 30efb6c7af7ad8b50936157fe0a0ef22d6787dd7: OK
------ gdb/ChangeLog ------
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
PR gdb/21500
* amd64-windows-tdep.c (amd64_windows_init_abi): Rename
to...
(amd64_windows_init_abi_common): ... this. Don't set size of
long type.
(amd64_windows_init_abi): New function.
(amd64_cygwin_init_abi): New function.
(_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
the Cygwin OS ABI.
* i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
comment.
Checking 8db52437243e251c01e352cdb325bc9ace578e7c: OK
------ gdb/ChangeLog ------
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
* windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
* windows-tdep.c (CYGWIN_DLL_NAME): New.
(pe_import_directory_entry): New struct type.
(is_linked_with_cygwin_dll): New function.
* amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
* i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
Checking 5982a56ab9d161923e75712fcb358824748ea4ba: OK
------ gdb/ChangeLog ------
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
* i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
i386_cygwin_core_osabi_sniffer.
Checking 7a1998dffb58ee1fab5edbd13458373654a1da42: OK
------ gdb/ChangeLog ------
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
* i386-cygwin-tdep.c: Rename to...
* i386-windows-tdep.c: ... this.
* Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
i386-windows-tdep.c.
* configure.tgt: Likewise.
Checking 053205cc4021026a5a1db05869d04bf7ad9ea1bd: OK
------ gdb/ChangeLog ------
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
* osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
* osabi.c (gdb_osabi_names): Add "Windows".
* i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
(i386_cygwin_core_osabi_sniffer): New function, extracted from
i386_cygwin_osabi_sniffer.
(_initialize_i386_cygwin_tdep): Register OS ABI
GDB_OSABI_WINDOWS for i386.
* amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
(_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
for x86-64.
* configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
when the target matches '*-*-mingw*'.
Checking fe4b2ee65cfe923fcb25427db884e1d2e90fef6e: OK
------ gdb/ChangeLog ------
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
* defs.h (enum gdb_osabi): Move to...
* osabi.h (enum gdb_osabi): ... here.
* gdbarch.sh: Include osabi.h in gdbarch.h.
* gdbarch.h: Re-generate.
Checking cb9b645d3e6b6164317104ed1a2a41c06da37bf4: OK
------ gdb/ChangeLog ------
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
* amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
function.
(_initialize_amd64_windows_tdep): Register osabi sniffer.
Checking 2f89101fe8b6a2423116a1ad1891f56bf6fc9510: OK
------ gdb/testsuite/ChangeLog ------
2020-03-16 Tom de Vries <tdevries@suse.de>
* lib/cache.exp (gdb_do_cache): Add and handle local variables
cache_verify and cache_verify_proc.
Checking 4b3ecb3b91b1b6154a6444efdcbadb90854a6654: FAILED
ERR: missing PR component:" PR 25675"
Checking 28d1356774c2c61adc7d6e6723de2351cd9f4ddc: OK
------ binutils/ChangeLog ------
2020-03-16 Alan Modra <amodra@gmail.com>
* readelf.c (get_symbols): New function.
(process_relocs, ia64_process_unwind, hppa_process_unwind),
(arm_process_unwind, get_symbol_for_build_attribute): Use it.
Checking 60e63c3e9750b036d50e58bc173591fa450601b6: OK
------ binutils/ChangeLog ------
2020-03-16 Alan Modra <amodra@gmail.com>
* unwind-ia64.c (unw_decode_uleb128): Prevent overlarge shifts.
Detect shift overflows and check that terminating byte is found.
Print an error on a bad uleb128.
Checking 7bac4137d757be98de8f6f8d8a649f04cacfdd2f: OK
------ bfd/ChangeLog ------
2020-03-16 Alan Modra <amodra@gmail.com>
* vms-alpha.c (dst_restore_location): Validate index into
dst_ptr_offsets array before accessing. Return status.
(dst_retrieve_location): Similarly, making "loc" parameter a
pointer to return value.
(_bfd_vms_slurp_etir): Update calls to above functions.
Checking 6b9374f1e07cb250736815ff8db263199416adc6: OK
------ gdb/testsuite/ChangeLog ------
2020-03-15 Tom de Vries <tdevries@suse.de>
* gdb.server/solib-list.exp: Handle
'Load new symbol table from "/lib64/ld-2.26.so"? (y or n)'.
Checking eaeaf44cfdc9a4096a0dd52fa0606f29d4bfd48e: OK
------ gdb/testsuite/ChangeLog ------
2020-03-15 Tom de Vries <tdevries@suse.de>
* gdb.base/maint.exp: Use exp_continue in long lines for "maint print
objfiles".
Checking 3293bbaffac9a22fc6d1a08ac6602a4a63b5e68b: OK
------ gdb/ChangeLog ------
2020-03-14 Tom Tromey <tom@tromey.com>
* c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
for C++.
(c_type_print_modifier): Likewise. Add "language" parameter.
(c_type_print_varspec_prefix, c_type_print_base_struct_union)
(c_type_print_base_1): Update.
* type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
constants.
* type-stack.c (type_stack::insert): Handle tp_atomic and
tp_restrict.
(type_stack::follow_type_instance_flags): Likewise.
(type_stack::follow_types): Likewise. Merge type-following code.
* c-exp.y (RESTRICT, ATOMIC): New tokens.
(space_identifier, cv_with_space_id)
(const_or_volatile_or_space_identifier_noopt)
(const_or_volatile_or_space_identifier): Remove.
(single_qualifier, qualifier_seq_noopt, qualifier_seq): New
rules.
(ptr_operator, typebase): Update.
(enum token_flag) <FLAG_C>: New constant.
(ident_tokens): Add "restrict", "__restrict__", "__restrict", and
"_Atomic".
(lex_one_token): Handle FLAG_C.
------ gdb/testsuite/ChangeLog ------
2020-03-14 Tom Tromey <tom@tromey.com>
* gdb.base/cvexpr.exp: Add test for _Atomic and restrict.
Checking ab44624cea74dca3e6d19c3275d9d5a8d381c084: OK
------ gdb/testsuite/ChangeLog ------
2020-03-14 Tom de Vries <tdevries@suse.de>
* gdb.mi/mi-fortran-modules.exp: Use exp_continue.
Checking 154151a6e303fa4b17e3597e3434a1c5999df8e1: FAILED
ERR: line should start with a tab:" * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass"
ERR: line should start with a tab:" it to the ptrace call."
ERR: line should start with a tab:" * m68k-bsd-nat.c (store_registers): Likewise."
Checking bc10778499a971ab9ccecb074cc406d49e1ee608: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
gdb_byte *.
* m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
* m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
* m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
Checking 01a801176ea15ddfc988cade2e3d84c3b0abfec3: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
nbsd_nat_target instead of inf_ptrace_target.
* m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
nbsd_nat_target.
Checking f90280caf5b34ebd564809a7f66685efc79bbf6d: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
register_t.
Checking 6def66f1404e58b376655f6fb622aeb9dfc0f587: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
it to the ptrace call.
* alpha-bsd-nat.c (store_registers): Likewise.
Checking 66eaca97ebd0f1b456ffe158fce73bafcce561bb: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
includes.
* alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
* alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
fill_fpregset): Likewise.
Checking 4fed520be264b60893aa674071947890f8172915: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
nbsd_nat_target instead of inf_ptrace_target.
* alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
nbsd_nat_target.
Checking 2190cf067b87e804c59c0a0c14c8ae48deabfbf4: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
register_t.
Checking 54c4382534f0c894434deca5eb89cd02661d6feb: OK
------ gdb/testsuite/ChangeLog ------
2020-03-14 Tom de Vries <tdevries@suse.de>
* gdb.threads/attach-many-short-lived-threads.exp: Read "info threads"
result in line-by-line fashion.
Checking 75c56d3d1298de72aa67555f2c723a80b4818e04: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* arm-nbsd-nat.c (fetch_register): New variable lwp and pass
it to the ptrace call.
* arm-nbsd-nat.c (fetch_fp_register): Likewise.
* arm-nbsd-nat.c (fetch_fp_regs): Likewise.
* arm-nbsd-nat.c (store_register): Likewise.
* arm-nbsd-nat.c (store_regs): Likewise.
* arm-nbsd-nat.c (store_fp_register): Likewise.
* arm-nbsd-nat.c (store_fp_regs): Likewise.
Checking 6018d381a00515933016c539d2fdc18ad0d304b8: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
nbsd_nat_target instead of inf_ptrace_target.
* arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
nbsd_nat_target.
Checking 013f99f035c49b000ca058db80ad15e00aa330dc: FAILED
ERR: line should start with a tab:" * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass"
ERR: line should start with a tab:" it to the ptrace call."
ERR: line should start with a tab:" * x86-bsd-nat.c (x86bsd_dr_set): Likewise."
Checking 6227b330d563add042066259e5f933c89a85b3b5: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
it to the ptrace call.
* vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
Checking 12753073036aad1250b5e9a1bd6991c125150269: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const gdb_byte *.
* vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
Checking d5be5fa4207da00d039a1d5a040ba316e7092cbd: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
instead of inf_ptrace_target.
* vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
nbsd_nat_target.
Checking 8110f842bc52940d27b6f1e8e5ab711238d9d210: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
register_t.
Checking 52feded7781821d227db0be188e564698d29fe9e: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
register_t.
Checking 25567eeece4efdea99a9a2b3a6daf81ec31b4b07: OK
------ gdb/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
register_t.
Checking 8b5d0a4f6ff67aa81275c705508e3f49accc8120: OK
------ bfd/ChangeLog ------
2020-03-14 Kamil Rytarowski <n54@gmx.com>
* configure.ac: Include netbsd-core.lo for all NetBSD arm and mips
targets.
* configure: Regenerated.
Checking 1bd6175ae79099173c1510d209ad9978129e22c0: OK
------ binutils/ChangeLog ------
2020-03-14 Alan Modra <amodra@gmail.com>
* readelf.c (process_file): Clean ba_cache.
Checking 2ac70237d2458fb2eb5e73de6bb02a396b5bada0: OK
------ gdb/testsuite/ChangeLog ------
2020-03-14 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (supports_statement_frontiers): New proc.
* gdb.cp/step-and-next-inline.exp: Use supports_statement_frontiers.
Checking 09546b56ede31ca2b401e9b03466e8e1fb84d85f: OK
------ gdb/testsuite/ChangeLog ------
2020-03-14 Tom de Vries <tdevries@suse.de>
* gdb.base/printcmds.exp: Add missing quoting for "print
teststring2".
Checking 780f96aed2b4db1014e8fa2b50118676d8af0e46: OK
------ binutils/ChangeLog ------
2020-03-14 Alan Modra <amodra@gmail.com>
* elfcomm.h (setup_archive): Update prototype.
* elfcomm.c (setup_archive): Add file_size parameter and sanity
check longnames_size.
(setup_nested_archive): Get file size and pass to setup_archive.
* elfedit.c (process_archive): Likewise.
* readelf.c (process_archive): Pass filedata->file_size to
setup_archive.
Checking f761cb13a903da6a5a1b3f9a5cb984600124ac31: OK
------ binutils/ChangeLog ------
2020-03-14 Alan Modra <amodra@gmail.com>
* readelf.c (dump_section_as_strings): Free memory on error exit.
(dump_section_as_bytes, process_notes_at): Likewise.
(get_build_id): Free enote.
Checking 02a8180e6f6146f95593001247f6cd080bdb7b38: OK
------ ld/ChangeLog ------
2020-03-14 Alan Modra <amodra@gmail.com>
* testsuite/ld-elf/non-contiguous.d: Don't xfail generic ELF
targets. Don't skip xtensa, xfail instead.
Checking 48e81d7f6314345a5d8648ab7b7b0ac0c6a8a381: OK
------ bfd/ChangeLog ------
2020-03-14 Alan Modra <amodra@gmail.com>
* section.c (BFD_FAKE_SECTIONS): Formatting.
* bfd-in2.h: Regenerate.
Checking 426a9c18dddcdd5f640b702734dd8f9c108b7372: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* value.h (val_print): Don't declare.
* valprint.h (val_print_array_elements)
(val_print_scalar_formatted, generic_val_print): Don't declare.
* valprint.c (generic_val_print_array): Take a struct value.
(generic_val_print_ptr, generic_val_print_memberptr)
(generic_val_print_bool, generic_val_print_int)
(generic_val_print_char, generic_val_print_complex)
(generic_val_print): Remove.
(generic_value_print): Update.
(do_val_print): Remove unused parameters. Don't call
la_val_print.
(val_print): Remove.
(common_val_print): Update. Don't call value_check_printable.
(val_print_scalar_formatted, val_print_array_elements): Remove.
* rust-lang.c (rust_val_print): Remove.
(rust_language_defn): Update.
* p-valprint.c (pascal_val_print): Remove.
(pascal_value_print_inner): Update.
(pascal_object_print_val_fields, pascal_object_print_val):
Remove.
(pascal_object_print_static_field): Update.
* p-lang.h (pascal_val_print): Don't declare.
* p-lang.c (pascal_language_defn): Update.
* opencl-lang.c (opencl_language_defn): Update.
* objc-lang.c (objc_language_defn): Update.
* m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
* m2-lang.h (m2_val_print): Don't declare.
* m2-lang.c (m2_language_defn): Update.
* language.h (struct language_defn) <la_val_print>: Remove.
* language.c (unk_lang_value_print_inner): Rename. Change
argument types.
(unknown_language_defn, auto_language_defn): Update.
* go-valprint.c (go_val_print): Remove.
* go-lang.h (go_val_print): Don't declare.
* go-lang.c (go_language_defn): Update.
* f-valprint.c (f_val_print): Remove.
* f-lang.h (f_value_print): Don't declare.
* f-lang.c (f_language_defn): Update.
* d-valprint.c (d_val_print): Remove.
* d-lang.h (d_value_print): Don't declare.
* d-lang.c (d_language_defn): Update.
* cp-valprint.c (cp_print_value_fields)
(cp_print_value_fields_rtti, cp_print_value): Remove.
(cp_print_static_field): Update.
* c-valprint.c (c_val_print_array, c_val_print_ptr)
(c_val_print_struct, c_val_print_union, c_val_print_int)
(c_val_print_memberptr, c_val_print): Remove.
* c-lang.h (c_val_print_array, cp_print_value_fields)
(cp_print_value_fields_rtti): Don't declare.
* c-lang.c (c_language_defn, cplus_language_defn)
(asm_language_defn, minimal_language_defn): Update.
* ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
(ada_val_print_enum): Take a struct value.
(ada_val_print_flt, ada_val_print_array, ada_val_print_1)
(ada_val_print): Remove.
(ada_value_print_1): Update.
(printable_val_type): Remove.
* ada-lang.h (ada_val_print): Don't declare.
* ada-lang.c (ada_language_defn): Update.
Checking 42331a1ea2a13ce15ec202c5f0fbef3e5171253c: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (do_val_print): Update.
* python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
a struct value.
(value_to_value_object_no_release): Declare.
* python/py-value.c (value_to_value_object_no_release): New
function.
* python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
struct value.
* guile/scm-value.c (vlscm_scm_from_value_no_release): New
function.
* guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
a struct value.
* guile/guile-internal.h (vlscm_scm_from_value_no_release):
Declare.
(gdbscm_apply_val_pretty_printer): Take a struct value.
* extension.h (apply_ext_lang_val_pretty_printer): Take a struct
value.
* extension.c (apply_ext_lang_val_pretty_printer): Take a struct
value.
* extension-priv.h (struct extension_language_ops)
<apply_val_pretty_printer>: Take a struct value.
* cp-valprint.c (cp_print_value): Create a struct value.
(cp_print_value): Update.
Checking 3a916a975745f386cabbaba64531ed9b5f8be509: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* ada-valprint.c (print_field_values): Call common_val_print.
Checking b59eac373217394503946dc360692d81809e08af: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* ada-valprint.c (val_print_packed_array_elements): Remove
bitoffset and val parameters. Call common_val_print.
(ada_val_print_string): Remove offset, address, and original_value
parameters.
(ada_val_print_array): Update.
(ada_value_print_array): New function.
(ada_value_print_1): Call it.
Checking 033711290333b0d4ec5c1b744af512f7ab133478: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* ada-valprint.c (ada_value_print): Use common_val_print.
Checking 2e088f8b6ea61fa9db1b592cbd4a6aa80b4e0ab5: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* ada-valprint.c (ada_val_print_ref): Use common_val_print.
Checking 39ef85a896e7efa0391a7ed14cc965fe1d46cbb9: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* ada-valprint.c (ada_value_print_num): New function.
(ada_value_print_1): Use it.
Checking b9fa6e07980f901f2a3f99b7eed4356d3209a3c4: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
Checking 416595d6409b1bd2e2f9862c133ca764688da77f: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* ada-valprint.c (ada_value_print_ptr): New function.
(ada_value_print_1): Use it.
Checking 5b5e15ecddafc43de2da632aa68f935a879d9a91: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
call common_val_print.
(ada_val_print_1): Update.
(ada_value_print_1): New function.
(ada_value_print_inner): Rewrite.
Checking fbf54e7554e0dcd60e18b1821c5c127fb3eb48ff: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* cp-valprint.c (cp_print_value_fields): Update.
(cp_print_value): New function.
Checking 64b653ca7058bfd4f91879dea628809d398b488e: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* m2-valprint.c (m2_value_print_inner): Use
cp_print_value_fields.
* cp-valprint.c (cp_print_value_fields): New function.
* c-valprint.c (c_value_print_struct): New function.
(c_value_print_inner): Use c_value_print_struct.
* c-lang.h (cp_print_value_fields): Declare.
Checking 6999f067c1b30c1a2c3e41a0f68f74e459652560: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* c-valprint.c (c_value_print_array): New function.
(c_value_print_inner): Use it.
Checking ce80b8bd374e14c1cebe149724274b1894f5f8cf: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* c-valprint.c (c_value_print_memberptr): New function.
(c_value_print_inner): Use it.
Checking 2faac269d59e57a49cd9f9209e1d39e03e2744bc: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* c-valprint.c (c_value_print_int): New function.
(c_value_print_inner): Use it.
Checking da3e2c2923b5c16c47c962bc53ea96678ca6a0e5: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* c-valprint.c (c_value_print_ptr): New function.
(c_value_print_inner): Use it.
Checking 5083623134c2ac383a8d8412b6d3c530452fda51: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* c-valprint.c (c_value_print_inner): Rewrite.
Checking 4f412b6e31369f27725872391a70f0520883701c: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (generic_value_print_complex): New function.
(generic_value_print): Use it.
Checking f5354008862defe83fc6d3620d51da52f860f5bf: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (generic_val_print_float): Don't call
val_print_scalar_formatted.
(generic_val_print, generic_value_print): Update.
Checking 3eec3b05b9ecf5e726c606f0bba916e095dcbe98: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (generic_value_print_char): New function
(generic_value_print): Use it.
Checking fdddfccba1cc4f70089873441b7e6c38de09ae37: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (generic_value_print_int): New function.
(generic_value_print): Use it.
Checking 6dde752183769c712eb22f49a5b74bfadad4a6be: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (generic_value_print_bool): New function.
(generic_value_print): Use it.
Checking 4112d2e602fed7157ce6bb30f46969129633d0f2: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (generic_val_print_func): Simplify.
(generic_val_print, generic_value_print): Update.
Checking 65786af6265044c67b25db23267f942c73b6fc20: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (generic_val_print_flags): Remove.
(generic_val_print, generic_value_print): Update.
(val_print_type_code_flags): Add original_value parameter.
Checking 40f3ce189e3c16398f2e56442e6d8db5573587ee: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (generic_val_print): Update.
(generic_value_print): Update.
* valprint.c (generic_val_print_enum): Don't call
val_print_scalar_formatted.
Checking 2a5b130bcb6f376b6a28d8378172ed3f9b92e9d9: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (generic_value_print): Call generic_value_print_ptr.
* valprint.c (generic_value_print_ptr): New function.
Checking abc66ce95eee79db058123b985e19dcfc03dc1a7: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (generic_value_print): Rewrite.
Checking 07a328583de159941b64bad3ca94f20185c905ed: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* p-valprint.c (pascal_object_print_value_fields)
(pascal_object_print_value): New functions.
Checking 64d64d3a76bb57305b278082ed1a29f0982b664d: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* p-valprint.c (pascal_value_print_inner): Rewrite.
Checking 6a95a1f58dd9dabcade13f7a332eed601baf25f8: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* f-valprint.c (f_value_print_innner): Rewrite.
Checking 59fcdac646cf4ed3168cd787a883d282b4d9de1f: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* m2-valprint.c (m2_print_unbounded_array): New overload.
(m2_print_unbounded_array): Update.
(m2_print_array_contents): Take a struct value.
(m2_value_print_inner): Rewrite.
Checking d133c3e1a877259bbee460897d9a6a2820ffe451: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* d-valprint.c (dynamic_array_type): Call d_value_print_inner.
(d_value_print_inner): New function.
* d-lang.h (d_value_print_inner): Declare.
* d-lang.c (d_language_defn): Use d_value_print_inner.
Checking 23b0f06be43054a9b182e7ea60a763c35302924a: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* go-valprint.c (go_value_print_inner): New function.
* go-lang.h (go_value_print_inner): Declare.
* go-lang.c (go_language_defn): Use go_value_print_inner.
Checking 5f56f7cbd22219e84df3caece06f469c5063e5fb: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* rust-lang.c (val_print_struct, rust_print_enum): Use the value
API.
(rust_val_print): Rewrite.
(rust_value_print_inner): New function, from rust_val_print.
(rust_language_defn): Use rust_value_print_inner.
Checking 26792ee0345c09bd1c76f3ee0e16ed15ab7215b9: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* ada-valprint.c (ada_value_print_inner): New function.
* ada-lang.h (ada_value_print_inner): Declare.
* ada-lang.c (ada_language_defn): Use ada_value_print_inner.
Checking 24051bbe843abcdcc108542da195e009c3f19910: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* f-valprint.c (f_value_print_innner): New function.
* f-lang.h (f_value_print_innner): Declare.
* f-lang.c (f_language_defn): Use f_value_print_innner.
Checking c0941be613054fe525891a2898e7d938b8e8ceed: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* p-valprint.c (pascal_value_print_inner): New function.
* p-lang.h (pascal_value_print_inner): Declare.
* p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
Checking 62c4663d3c59b53e622b2f83eeae7c8d47c656dd: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* m2-valprint.c (m2_value_print_inner): New function.
* m2-lang.h (m2_value_print_inner): Declare.
* m2-lang.c (m2_language_defn): Use m2_value_print_inner.
Checking 621821900289e9ef3472dc430d6fcf4d55b301e2: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
* objc-lang.c (objc_language_defn): Use c_value_print_inner.
* c-valprint.c (c_value_print_inner): New function.
* c-lang.h (c_value_print_inner): Declare.
* c-lang.c (c_language_defn, cplus_language_defn)
(asm_language_defn, minimal_language_defn): Use
c_value_print_inner.
Checking 1e592a8ae0985645e61f6ffbfee064af8826b457: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* p-valprint.c (pascal_object_print_value_fields): Now static.
* p-lang.h (pascal_object_print_value_fields): Don't declare.
Checking 7fe471e9ae8dbc61b898f7572fed31c4224a0b89: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* c-valprint.c (c_val_print_array): Simplify.
Checking d121c6ce897d34ae168f78cbdacacb109d4833e6: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (value_print_array_elements): New function.
* valprint.h (value_print_array_elements): Declare.
Checking 4dba70eee1fadcb3c1bb50ba17e0fe3512c84180: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* printcmd.c (print_formatted): Use value_print_scalar_formatted.
* mips-tdep.c (mips_print_register): Use
value_print_scalar_formatted.
Checking 4f9ae810130bc4202ec1c5eae934900c542a9016: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.h (value_print_scalar_formatted): Declare.
* valprint.c (value_print_scalar_formatted): New function.
Checking 156bfec999186e3eccaf51fa3b81280bf51dbaa4: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.h (generic_value_print): Declare.
* valprint.c (generic_value_print): New function.
Checking 2b4e573d62be3a59057895054b1b5faa67557ce6: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (do_val_print): Call la_value_print_inner, if
available.
* rust-lang.c (rust_language_defn): Update.
* p-lang.c (pascal_language_defn): Update.
* opencl-lang.c (opencl_language_defn): Update.
* objc-lang.c (objc_language_defn): Update.
* m2-lang.c (m2_language_defn): Update.
* language.h (struct language_defn) <la_value_print_inner>: New
member.
* language.c (unknown_language_defn, auto_language_defn): Update.
* go-lang.c (go_language_defn): Update.
* f-lang.c (f_language_defn): Update.
* d-lang.c (d_language_defn): Update.
* c-lang.c (c_language_defn, cplus_language_defn)
(asm_language_defn, minimal_language_defn): Update.
* ada-lang.c (ada_language_defn): Update.
Checking a1f6a07c3d1d3a34d36d4e49f0fd3c66554e41b2: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* c-valprint.c (c_value_print): Use common_val_print.
------ gdb/testsuite/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* gdb.base/printcmds.exp (test_print_strings): Add regression
test.
* gdb.base/printcmds.c (charptr): New typedef.
(teststring2): New global.
Checking 410cf315014145f169c146442e9c28163d9ae10a: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* cp-valprint.c (cp_print_static_field): Use common_val_print.
Checking 72a45c938438f33bf8e7de6a5f068ba31c8c1e36: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* f-valprint.c (f77_print_array_1, f_val_print): Use
common_val_print.
Checking 040f66bd2d6aea4d35a2e5cb88b499799ee4c466: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* riscv-tdep.c (riscv_print_one_register_info): Use
common_val_print.
Checking a6e05a6c3a9439a7253d2eab7ee4fe760b4cc829: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* mi/mi-main.c (output_register): Use common_val_print.
Checking 3444c526a33e61aeff86cbe1184e765458007890: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* infcmd.c (default_print_one_register_info): Use
common_val_print.
Checking c2a44efee1cbe5321a850c53f34e9c205a1d6ca0: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.h (common_val_print_checked): Declare.
* valprint.c (common_val_print_checked): New function.
* stack.c (print_frame_arg): Use common_val_print_checked.
Checking b0c26e99f50d6926dd628ec51c1e9a037c521ab5: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (do_val_print): New function, from val_print.
(val_print): Use do_val_print.
(common_val_print): Use do_val_print.
Checking ce3acbe9fa876647649cc88f94264a5c56bf46a1: OK
------ gdb/ChangeLog ------
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.c (value_print): Use scoped_value_mark.
Checking 1b83d09cd503d7fde57c50db51d5780ee8df5fae: OK
------ gdb/testsuite/ChangeLog ------
2020-03-13 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb.base/break-interp.exp: Use the tail of the filename, not the
full path in the test name.
(test_ld): Add some with_test_prefix blocks to make test names
unique.
Checking 06d949ec3121f4732e789db1efc53986355c9481: OK
------ bfd/ChangeLog ------
2020-03-13 Kamil Rytarowski <n54@gmx.com>
* elf.c (elfcore_grok_netbsd_note): Add support for
NT_NETBSDCORE_LWPSTATUS notes.
------ binutils/ChangeLog ------
2020-03-13 Kamil Rytarowski <n54@gmx.com>
* readelf.c (get_netbsd_elfcore_note_type): Add support for
NT_NETBSDCORE_LWPSTATUS notes.
------ include/ChangeLog ------
2020-03-13 Kamil Rytarowski <n54@gmx.com>
* elf/common.h (NT_NETBSDCORE_LWPSTATUS): New define.
Checking 9fcbd8a90a92bf303c41be816040789e1ed6cf4e: OK
------ include/ChangeLog ------
2020-03-13 Kamil Rytarowski <n54@gmx.com>
* elf/common.h (NT_NETBSDCORE_AUXV): New define.
Checking abf874aafe3d717573e4a48bf0e3c6334e666a55: FAILED
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm.d"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm.ld"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm.s"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm2.d"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm3.d"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm3.ld"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm4.d"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm4.ld"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm5.d"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm5.ld"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm6.d"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm6.ld"
ERR: file not changed in a patch:"ld/testsuite/ld-powerpc/non-contiguous-powerpc.sd"
Checking 74e10d1742f1b8312359c59a2af06c9e661252b3: OK
------ bfd/ChangeLog ------
2020-03-13 H.J. Lu <hjl.tools@gmail.com>
PR ld/24920
* elf-linker-x86.h (elf_linker_x86_params): Add
static_before_all_inputs and has_dynamic_linker.
* elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Report
dynamic input objects if -static is passed at command-line
before all input files without --dynamic-linker unless
--no-dynamic-linker is used.
------ ld/ChangeLog ------
2020-03-13 H.J. Lu <hjl.tools@gmail.com>
PR ld/24920
* emulparams/elf32_x86_64.sh: Use static.sh.
* emulparams/elf_i386.sh: Likewise.
* emulparams/elf_x86_64.sh: Likewise.
* emulparams/static.sh: New file.
* emultempl/elf-x86.em: Include "ldlex.h".
* testsuite/ld-elf/pr24920.err: New file.
* testsuite/ld-elf/linux-x86.exp: Run ld/24920 tests.
Checking 2d61316c32a9fa3e14786c3312d9ca87c9298db5: OK
------ gdb/testsuite/ChangeLog ------
2020-03-13 Tom de Vries <tdevries@suse.de>
* gdb.mi/mi-sym-info.exp: Fix buffer full errors, and timeouts.
Checking 2e9145ace2a520f942d74fea7df9458cc8a16523: OK
------ gdb/testsuite/ChangeLog ------
2020-03-13 Tom de Vries <tdevries@suse.de>
* gdb.mi/mi-sym-info.exp: Make matching more precise.
Checking 66d1f7cc129495ea6c820bcd16242ec5ff39b172: FAILED
ERR: missing PR component:" PR 25660"
ERR: one space should follow asterisk:" * config/tc-arm.c (operand_parse_code): Add OP_RNSDMQR and OP_oRNSDMQ."
ERR: first line should start with a tab, asterisk and space:" (parse_operands): Handle new operand codes."
ERR: first line should start with a tab, asterisk and space:" (do_neon_dyadic_long): Make shape check accept the scalar variants."
ERR: first line should start with a tab, asterisk and space:" (asm_opcode_insns): Fix operand codes for vaddl and vsubl."
Checking 015ec493d8603095d212df443e7b75017b572455: OK
------ bfd/ChangeLog ------
2020-03-13 Kamil Rytarowski <n54@gmx.com>
* elf.c (elfcore_grok_netbsd_note): Add support for aarch64.
Checking 1673df3278637a911b55983a92e4d1f61816e57c: FAILED
ERR: cannot find a ChangeLog location in message
Checking 96c7f873945c31bb0f9facd526bfe6dac74d3ccb: OK
------ gdb/ChangeLog ------
2020-03-13 Tom de Vries <tdevries@suse.de>
PR symtab/25646
* psymtab.c (partial_symtab::partial_symtab): Don't set
globals_offset and statics_offset. Push element onto
current_global_psymbols and current_static_psymbols stacks.
(concat): New function.
(end_psymtab_common): Set globals_offset and statics_offset. Pop
element from current_global_psymbols and current_static_psymbols
stacks. Concat popped elements to global_psymbols and
static_symbols.
(add_psymbol_to_list): Use current_global_psymbols and
current_static_psymbols stacks.
* psymtab.h (class psymtab_storage): Add current_global_psymbols and
current_static_psymbols fields.
------ gdb/testsuite/ChangeLog ------
2020-03-13 Tom de Vries <tdevries@suse.de>
PR symtab/25646
* gdb.dwarf2/imported-unit.exp: Add test.
Checking 666318230c54a348763927c80d085542d9890c42: OK
------ include/ChangeLog ------
2020-03-13 Christian Eggers <ceggers@gmx.de>
* bfdlink.h (struct bfd_link_order): Add unit (bytes/octets) to
offset and size members.
* elf/internal.h (struct elf_internal_phdr): Likewise for
p_align member.
(struct elf_segment_map): Likewise for p_paddr and p_size
members
------ bfd/ChangeLog ------
2020-03-13 Christian Eggers <ceggers@gmx.de>
* bfd.c (bfd_record_phdr): New local "opb". Fix assignment of
"p_paddr" from "at".
* elfcode.h (bfd_from_remote_memory): Add units to several
parameters. New local "opb". Fix usage of p_align. Fix
calculation of "localbase" from "ehdr_vma" and "p_vaddr". Fix
call of target_read_memory.
* elflink.c (elf_fixup_link_order): Fix scope of "s" local. Fix
calculation of "offset" and "output_offset".
(bfd_elf_final_link): New local "opb". Fix calculation of "size"
from "offset" and fix calculation of "end" from "vma+size". Fix
comparison between "sh_addr" and "vma"/"output_offset".
(bfd_elf_discard_info): Fix calculation of "eh_alignment".
* elf-bfd.h (struct elf_link_hash_table): Add unit to tls_size
member.
* elf.c (_bfd_elf_map_sections_to_segments): Add unit (bytes/
octets) to "wrap_to2 and "phdr_size" locals. Fix calculation of
"wrap_to" value. Add unit (bytes) to phdr_lma variable. Fix
assignment of p_paddr from phdr_lma. Fix comparison between
"lma+size" and "next->lma".
(elf_sort_segments): Fix assignment from p_paddr to lma.
(assign_file_positions_for_load_sections): Add unit (bytes) to
local "align". Fix calculation of local "off_adjust". Fix
calculation of local "filehdr_vaddr".
(assign_file_positions_for_non_load_sections): New local "opb".
Fix calculation of "end" from "p_size". Fix comparison between
"vma+SECTION_SIZE" and "start". Fix calculation of "p_memsz"
from "end" and "p_vaddr".
(rewrite_elf_program_header): Fix comparison between p_vaddr and
vma. Fix assignment to p_paddr from lma. Fix comparison between
p_paddr and lma. Fix assignment to p_paddr from lma.
* merge.c (sec_merge_emit): New local "opb". Convert
"alignment_power" to octets.
(_bfd_add_merge_section): New locals "alignment_power" and
"opb". Fix comparison between "alignment_power" and
"sizeof(align)".
(_bfd_merge_sections): New local "opb". Divide size by opb
before checking align mask.
Checking 502794d4321dc17d5c9fb591bedc8761118b2943: OK
------ include/ChangeLog ------
2020-03-13 Christian Eggers <ceggers@gmx.de>
* elf/internal.h (struct elf_internal_phdr): Add unit (octets)
to several member field comments.
(Elf_Internal_Shdr): likewise.
------ bfd/ChangeLog ------
2020-03-13 Christian Eggers <ceggers@gmx.de>
* elf.c (_bfd_elf_make_section_from_shdr): Introduce new temp
opb. Divide Elf_Internal_Shdr::sh_addr by opb when setting
section LMA/VMA.
(_bfd_elf_make_section_from_phdr): Similarly.
(elf_fake_sections): Fix calculation of
Elf_Internal_shdr::sh_addr from section VMA.
(_bfd_elf_map_sections_to_segments): Fix mixup between octets
and bytes.
(assign_file_positions_for_load_sections): Fix calculations of
Elf_Internal_shdr::p_vaddr and p_paddr from section LMA/VMA. Fix
comparison between program header address and section LMA.
(assign_file_positions_for_non_load_sections): Likewise.
(rewrite_elf_program_header): Likewise. Introduce new temp opb.
(IS_CONTAINED_BY_VMA): Add parameter opb.
(IS_CONTAINED_BY_LMA,IS_SECTION_IN_INPUT_SEGMENT,
INCLUDE_SECTION_IN_SEGMENT): Likewise.
(copy_elf_program_header): Update call to ELF_SECTION_IN_SEGMENT.
Fix calculations of p_addr_valid and p_vaddr_offset.
* elflink.c (elf_link_add_object_symbols): Multiply section VMA
with octets per byte when comparing against p_vaddr.
------ ld/ChangeLog ------
2020-03-13 Christian Eggers <ceggers@gmx.de>
* ldexp.c (fold_name): Return SIZEOF_HEADERS in bytes.
Checking fd486f32d15e3299b905084a697fac6349c43f76: OK
------ binutils/ChangeLog ------
2020-03-13 Alan Modra <amodra@gmail.com>
* elfcomm.c (get_archive_member_name): Always return malloc'd
string or NULL.
* elfedit.c (process_archive): Tidy memory on all return paths.
* readelf.c (process_archive): Likewise.
(process_symbol_table): Likewise.
(ba_cache): New, replacing ..
(get_symbol_for_build_attribute): ..static vars here. Free
strtab and symtab before loading new ones. Reject symtab without
valid strtab in loop, breaking out of loop on valid symtab.
(process_file): Free ba_cache symtab and strtab here, resetting
ba_cache.
Checking 49ba92c0a6765ee7dc3a773c1a044680d29cee0e: OK
------ gdb/testsuite/ChangeLog ------
2020-03-13 Tom de Vries <tdevries@suse.de>
* gdb.mi/mi-sym-info-2.c (another_char_t, another_short_t): New typedef.
(var1, var2): New variable.
* gdb.mi/mi-sym-info.exp: Add --name to various commands to restrict
matching symbols.
Checking 301b21e0dfee41c7a93f41089428d5d03fee685b: OK
------ gdb/testsuite/ChangeLog ------
2020-03-13 Tom de Vries <tdevries@suse.de>
* lib/tuiterm.exp (Term::command_no_prompt_prefix): New proc.
(Term::command): Use prompt prefix.
(Term::enter_tui): Use command_no_prompt_prefix instead of prefix.
* gdb.tui/tui-layout-asm-short-prog.exp: Use
command_no_prompt_prefix instead of prefix.
* gdb.tui/tui-layout-asm.exp: Same.
Checking 6ba0a321037b748f0b1285c44af762021a380bd3: OK
------ gdb/ChangeLog ------
2020-03-12 Christian Biesinger <cbiesinger@google.com>
* corelow.c (sniff_core_bfd): Remove.
(class core_target) <m_core_vec>: Remove.
(core_target::core_target): Update.
(core_file_fns): Remove.
(deprecated_add_core_fns): Remove.
(default_core_sniffer): Remove.
(sniff_core_bfd): Remove.
(default_check_format): Remove.
(gdb_check_format): Remove.
(core_target_open): Update.
(core_target::get_core_register_section): Update.
(get_core_registers_cb): Update.
(core_target::fetch_registers): Update.
* gdbcore.h (struct core_fns): Remove.
(deprecated_add_core_fns): Remove.
(default_core_sniffer): Remove.
(default_check_format): Remove.
Checking 4635ff975351603e64da3cbdeec3b999ee842ac8: FAILED
ERR: could not deduce ChangeLog file, not unique location
Checking 213291361b4ddb2d05b8c89bf47d23ca4306912e: FAILED
ERR: ChangeLog must contain a file entry:"gdbsupport"
Checking 9a665d62266e75f0519f3a663784c458885b5c63: FAILED
ERR: could not deduce ChangeLog file, not unique location
Checking 227031b2bf03e7735601845d6c420995740c8fca: OK
------ gdb/ChangeLog ------
2020-03-12 Tom Tromey <tom@tromey.com>
* arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
CORE_ADDR.
(struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
Checking 53807e9f3d83bc0f67b9b9471cc60fb37182e5ab: OK
------ gdb/ChangeLog ------
2020-03-12 Tom Tromey <tom@tromey.com>
* remote.c (remote_target::download_tracepoint)
(remote_target::enable_tracepoint)
(remote_target::disable_tracepoint): Use phex, not sprintf_vma.
* breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
sprintf_vma.
Checking 64f251023bcbd068861d4cb83b4e925083e0ea35: OK
------ gdb/ChangeLog ------
2020-03-12 Tom Tromey <tom@tromey.com>
* symfile-mem.c: Update CORE_ADDR size assert.
Checking 3f512721a829ce7b2d38236917309a32f42faa99: OK
------ gdb/testsuite/ChangeLog ------
2020-03-12 Simon Marchi <simon.marchi@efficios.com>
* gdb.base/break-interp.exp: Use foreach_with_prefix.
Checking 40310f30a51c1343b954d1fee7feb9a1d9455e9f: OK
------ gdb/testsuite/ChangeLog ------
2020-03-12 Simon Marchi <simon.marchi@efficios.com>
* gdb.arch/amd64-disp-step-avx.S: Add nops after _start.
* gdb.arch/amd64-disp-step-avx.exp: Enable "set debug displaced
on" while stepping over the test instruction, match printed
message.
Checking 272cd5a31e7ff16fe46a5532e857b98229404c48: FAILED
ERR: changed file not mentioned in a ChangeLog:"gdbsupport/Makefile.in"
Checking 74cd3f9d7e2bc82a295011230dc5261cd1129b4f: FAILED
ERR: changed file not mentioned in a ChangeLog:"gdb/configure"
Checking db6878ac5538661c8d66c916a533bd4268217fcb: OK
------ gdb/ChangeLog ------
2020-03-12 Simon Marchi <simon.marchi@efficios.com>
* configure.ac: Don't source bfd/development.sh.
* selftest.m4: Modify comment.
* configure: Re-generate.
------ gdbserver/ChangeLog ------
2020-03-12 Simon Marchi <simon.marchi@efficios.com>
* configure.ac: Don't source bfd/development.sh, move
GDB_AC_COMMON higher.
* configure: Re-generate.
------ gdbsupport/ChangeLog ------
2020-03-12 Simon Marchi <simon.marchi@efficios.com>
* configure.ac: Don't source bfd/development.sh.
* common.m4: Source bfd/development.sh.
* configure: Re-generate.
Checking 4d696a5c686730d75623d7e41805e42ce5fcc60c: OK
------ gdb/ChangeLog ------
2020-03-12 Simon Marchi <simon.marchi@efficios.com>
* selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
not "true" or "false".
* configure: Re-generate.
------ gdbserver/ChangeLog ------
2020-03-12 Simon Marchi <simon.marchi@efficios.com>
* configure: Re-generate.
------ gdbsupport/ChangeLog ------
2020-03-12 Simon Marchi <simon.marchi@efficios.com>
* configure: Re-generate.
Checking 8dd8e1c7228d5dd57b3b36379718c806017988e1: OK
------ gdb/ChangeLog ------
2020-03-12 Christian Biesinger <cbiesinger@google.com>
* Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
* arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
renamed to arm_nbsd_supply_gregset.
(fetch_register): Update to call arm_nbsd_supply_gregset.
(fetch_regs): Remove in favor of fetch_register with a -1 regno.
(arm_netbsd_nat_target::fetch_registers): Update.
(fetch_elfcore_registers): Removed.
(_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
* arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
(arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
not require NetBSD system headers.
(arm_nbsd_regset): New struct.
(arm_nbsd_iterate_over_regset_sections): New function.
(arm_netbsd_init_abi_common): Updated to call
set_gdbarch_iterate_over_regset_sections.
* arm-nbsd-tdep.h: New file.
Checking 7a20f753ef28251e4d3bca211e9ee338f67aa2a8: OK
------ sim/ppc/ChangeLog ------
2020-03-12 Kamil Rytarowski <n54@gmx.com>
* emul_netbsd.c (netbsd_signal_names): Sync with NetBSD 9.99.49.
Checking 607c69321064f57595038d39af3328b0de73eb85: OK
------ sim/ppc/ChangeLog ------
2020-03-12 Kamil Rytarowski <n54@gmx.com>
* emul_netbsd.c (netbsd_error_names): Sync with NetBSD 9.99.49.
Checking 09252140293763eaa230314dee27f605a37154d4: OK
------ gdb/testsuite/ChangeLog ------
2020-03-12 Tom de Vries <tdevries@suse.de>
* gdb.base/info-types.exp: Use exp_continue during matching of output
of "info types".
Checking 14e9c72c334205c0171d62e716c1fb65472a0eab: OK
------ gdb/testsuite/ChangeLog ------
2020-03-12 Tom de Vries <tdevries@suse.de>
* gdb.threads/execl.exp: Delete breakpoint after hitting it.
Checking e515d67ed61f7c588a3154589a8a25c7bef66d20: OK
------ gdb/testsuite/ChangeLog ------
2020-03-12 Tom de Vries <tdevries@suse.de>
* gdb.fortran/module.exp: Use exp_continue during matching of output
of "info variable -n".
Checking 307eafd8df3ec820bb62a71324aeed06b86ec050: OK
------ gdb/testsuite/ChangeLog ------
2020-03-12 Tom de Vries <tdevries@suse.de>
* gdb.dwarf2/dw2-ranges-base.exp: Limit "maint info line-table" to
gdb.dwarf2/dw2-ranges-base.c.
Checking 9a2de3fc7f7c40da6e8d5553c29e6cb8a2430dc8: OK
------ gdb/testsuite/ChangeLog ------
2020-03-12 Tom de Vries <tdevries@suse.de>
* gdb.linespec/explicit.exp: Fix "complete non-unique file name" test
in presence of GLIBC debuginfo.
Checking 3217502e1ba7409676e192100a0147a49dd5ae7a: OK
------ gdb/testsuite/ChangeLog ------
2020-03-12 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (gdb_core_cmd): Use string_to_regexp for regexp-matching
$core.
Checking 1281424ccf3d05410398f4f495443d9e54426f91: OK
------ gdb/testsuite/ChangeLog ------
2020-03-12 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (gdb_core_cmd): Make "No such file or directory" regexp
more precise.
Checking 8fb879cd16a3e3d1fe93e333c4c720fd33bcc416: OK
------ binutils/ChangeLog ------
2020-03-12 Alan Modra <amodra@gmail.com>
* readelf.c (process_section_headers): Don't just set
filedata->section_headers NULL, free it first. Similarly for
dynamic_symbols, dynamic_strings, dynamic_syminfo and
symtab_shndx_list. Zero associated counts too.
(process_object): Free symtab_shndx_list.
(process_file): Free various allocated filedata tables.
Checking dd69bf7a78a489783c397f2552eeb7999defcb6a: FAILED
ERR: line should start with a tab:"Change-Id: I595470be6ab5f61ca7e4e9e70c61a252c0deaeaa"
Checking 038b97fcd75a338a515fe7def5db142e6952ca7c: OK
------ gdb/testsuite/ChangeLog ------
2020-03-11 Simon Marchi <simon.marchi@efficios.com>
* lib/gdb.exp (standard_output_file): Use `pwd -W` to convert
from Unix to Windows path.
Checking a0761e34f054767de6d6389929d27e9015fb299b: OK
------ gdb/ChangeLog ------
2020-03-11 Simon Marchi <simon.marchi@efficios.com>
* configure: Re-generate.
------ gdbserver/ChangeLog ------
2020-03-11 Simon Marchi <simon.marchi@efficios.com>
* configure: Re-generate.
------ gdbsupport/ChangeLog ------
2020-03-11 Simon Marchi <simon.marchi@efficios.com>
* configure: Re-generate.
* warning.m4: Enable -Wmissing-prototypes.
Checking 5308d1e77167b4bb133302d7a6f66e599abee420: OK
------ gdb/testsuite/ChangeLog ------
2020-03-11 Tom de Vries <tdevries@suse.de>
* gdb.ada/minsyms.exp: Set language to ada.
Checking 9e8f1c9000fa42b68982ee69f622010a81656e81: OK
------ gas/ChangeLog ------
2020-03-11 H.J. Lu <hjl.tools@gmail.com>
* NEWS: Mention x86 assembler options for CVE-2020-0551.
Checking f870f78fb2dc15cc5a4738d7ee592b39e2001c4e: OK
------ gdb/testsuite/ChangeLog ------
2020-03-11 Tom de Vries <tdevries@suse.de>
* gdb.server/sysroot.exp: Allow GLIBC's printf alias __printf.
Checking 97b4a8f744f437fa35afbe20f53e657e9de957cd: OK
------ gas/ChangeLog ------
2020-03-11 H.J. Lu <hjl.tools@gmail.com>
* testsuite/gas/i386/i386.exp: Run new tests.
* testsuite/gas/i386/lfence-byte.d: New file.
* testsuite/gas/i386/lfence-byte.e: Likewise.
* testsuite/gas/i386/lfence-byte.s: Likewise.
* testsuite/gas/i386/lfence-indbr-a.d: Likewise.
* testsuite/gas/i386/lfence-indbr-b.d: Likewise.
* testsuite/gas/i386/lfence-indbr-c.d: Likewise.
* testsuite/gas/i386/lfence-indbr.e: Likewise.
* testsuite/gas/i386/lfence-indbr.s: Likewise.
* testsuite/gas/i386/lfence-load.d: Likewise.
* testsuite/gas/i386/lfence-load.s: Likewise.
* testsuite/gas/i386/lfence-ret-a.d: Likewise.
* testsuite/gas/i386/lfence-ret-b.d: Likewise.
* testsuite/gas/i386/lfence-ret.s: Likewise.
* testsuite/gas/i386/x86-64-lfence-byte.d: Likewise.
* testsuite/gas/i386/x86-64-lfence-byte.e: Likewise.
* testsuite/gas/i386/x86-64-lfence-byte.s: Likewise.
* testsuite/gas/i386/x86-64-lfence-indbr-a.d: Likewise.
* testsuite/gas/i386/x86-64-lfence-indbr-b.d: Likewise.
* testsuite/gas/i386/x86-64-lfence-indbr-c.d: Likewise.
* testsuite/gas/i386/x86-64-lfence-indbr.e: Likewise.
* testsuite/gas/i386/x86-64-lfence-indbr.s: Likewise.
* testsuite/gas/i386/x86-64-lfence-load.d: Likewise.
* testsuite/gas/i386/x86-64-lfence-load.s: Likewise.
* testsuite/gas/i386/x86-64-lfence-ret-a.d: Likewise.
* testsuite/gas/i386/x86-64-lfence-ret-b.d: Likewise.
Checking ae531041c7c5956672342f89c486a011c84f027f: FAILED
ERR: file not changed in a patch:"gas/config/tc-i386.h"
Checking 5a13315d1c6993ab84075ff94797eb8c6da1f20b: OK
------ gdb/testsuite/ChangeLog ------
2020-03-11 Tom de Vries <tdevries@suse.de>
* gdb.btrace/reconnect.exp: Allow source line pattern after stepi.
Checking e7a82140af00e632f06e27d0ec9ad1f4fb704d92: OK
------ gdb/ChangeLog ------
2020-03-11 Tom Tromey <tromey@adacore.com>
* ada-typeprint.c (print_choices): Fix comment.
Checking 976862ed563047be58effc4b02fe75ed064f77b7: OK
------ gdb/testsuite/ChangeLog ------
2020-03-11 Tom Tromey <tromey@adacore.com>
* gdb.dwarf2/variant.exp: Mark discriminants as artificial.
Checking 7462c383f9849aab40f156854a72f0a93305124a: OK
------ gdb/testsuite/ChangeLog ------
2020-03-11 Tom de Vries <tdevries@suse.de>
* gdb.base/foll-fork.exp: Allow "Reading in symbols" messages.
Checking 1c6c46a012a43aefb6183fa2dd16ec6db5751aa3: OK
------ gdb/testsuite/ChangeLog ------
2020-03-11 Tom de Vries <tdevries@suse.de>
* gdb.base/break-interp.exp: Limit verbose scope.
Checking 8248d21a5b8b7bb9970163b8b327f5ac2f857f33: OK
------ bfd/ChangeLog ------
2020-03-11 Alan Modra <amodra@gmail.com>
* som.c (setup_sections): Sanity check subspace.name.
Checking 44f41bb7a1568dbe2e4e642e6c3c2e9ba3d47d92: OK
------ gdb/testsuite/ChangeLog ------
2020-03-11 Tom de Vries <tdevries@suse.de>
* gdb.fortran/logical.f90: Define variable with character type.
* gdb.fortran/logical.exp: Use character type instead of uint8_t.
Checking dcc050c86c3e5160497da7aab480adae9ba284aa: FAILED
ERR: file not changed in a patch:"gdb/buildsyms.c"
ERR: changed file not mentioned in a ChangeLog:"gdb/buildsym.c"
Checking 5496f3c635dce3e12348d6e81c3f74815fdfe7b5: FAILED
ERR: missing PR component:" PR 25611"
ERR: missing PR component:" PR 25614"
ERR: line should start with a tab:"gas * dwarf2dbg.c (DWARF2_FILE_TIME_NAME): Default to -1."
ERR: first line should start with a tab, asterisk and space:" (DWARF2_FILE_SIZE_NAME): Default to -1."
ERR: first line should start with a tab, asterisk and space:" (DWARF2_LINE_VERSION): Default to the current dwarf level or 3,"
ERR: first line should start with a tab, asterisk and space:" whichever is higher."
ERR: first line should start with a tab, asterisk and space:" (DWARF2_LINE_MAX_OPS_PER_INSN): Provide a default value of 1."
ERR: first line should start with a tab, asterisk and space:" (NUM_MD5_BYTES): Define."
ERR: first line should start with a tab, asterisk and space:" (struct file entry): Add md5 field."
ERR: first line should start with a tab, asterisk and space:" (get_filenum): Delete and replace with..."
ERR: first line should start with a tab, asterisk and space:" (get_basename): New function."
ERR: first line should start with a tab, asterisk and space:" (get_directory_table_entry): New function."
ERR: first line should start with a tab, asterisk and space:" (allocate_filenum): New function."
ERR: first line should start with a tab, asterisk and space:" (allocate_filename_to_slot): New function."
ERR: first line should start with a tab, asterisk and space:" (dwarf2_where): Use new functions."
ERR: first line should start with a tab, asterisk and space:" (dwarf2_directive_filename): Add support for extended .file"
ERR: first line should start with a tab, asterisk and space:" pseudo-op."
ERR: first line should start with a tab, asterisk and space:" (dwarf2_directive_loc): Allow the use of file number zero with"
ERR: first line should start with a tab, asterisk and space:" DWARF 5 or higher."
ERR: first line should start with a tab, asterisk and space:" (out_file_list): Rename to..."
ERR: first line should start with a tab, asterisk and space:" (out_dir_and_file_list): Add DWARF 5 support."
ERR: first line should start with a tab, asterisk and space:" (out_debug_line): Emit extra values into the section header for"
ERR: first line should start with a tab, asterisk and space:" DWARF 5."
ERR: first line should start with a tab, asterisk and space:" (out_debug_str): Allow for file 0 to be used with DWARF 5."
Checking b76f3a42371cb0d83a1128a434852447da76b5e9: OK
------ gdb/testsuite/ChangeLog ------
2020-03-11 Tom de Vries <tdevries@suse.de>
* gdb.base/list-ambiguous.exp: Set EDITOR to true.
Checking 119789424b62321e74a18fc1c088ebf479d999c4: OK
------ libctf/ChangeLog ------
2020-03-11 John Baldwin <jhb@FreeBSD.org>
* swap.h (bswap_identity_64): Make static.
Checking 435edf0bf231240ccecb474b74ebb49dc8db2633: OK
------ bfd/ChangeLog ------
2020-03-11 Alan Modra <amodra@gmail.com>
* elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop.
Checking 9cc89dc0acc140cb27e21d2597af42d36444673b: FAILED
ERR: missing PR component:" PR 25651"
Checking 1db6f990303ab6c45909f8e133641ef6c24a04d2: OK
------ ld/ChangeLog ------
2020-03-11 Alan Modra <amodra@gmail.com>
* ldelf.c (elf_orphan_compatible): Return false when two sections
have differing SHF_MASKPROC or SHF_MASKOS flags.
Checking 1c33af7764d9f4eabc02e0f6f6df99917fbce0a6: OK
------ gdb/ChangeLog ------
2020-03-11 Tom de Vries <tdevries@suse.de>
* dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
PROP_LOCLIST handling code.
------ gdb/testsuite/ChangeLog ------
2020-03-11 Tom de Vries <tdevries@suse.de>
* gdb.ada/access_to_packed_array.exp: Test printing of expanded
symtabs.
Checking 8c95582da858ac981f689a6f599acacb8c5c490f: OK
------ gdb/ChangeLog ------
2020-03-10 Andrew Burgess <andrew.burgess@embecosm.com>
* buildsym-legacy.c (record_line): Pass extra parameter to
record_line.
* buildsym.c (buildsym_compunit::record_line): Take an extra
parameter, reduce duplication in the line table, and record the
is_stmt flag in the line table.
* buildsym.h (buildsym_compunit::record_line): Add extra
parameter.
* disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
non-statement lines.
* dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
this to the symtab builder.
(dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
(lnp_state_machine::record_line): Pass a suitable is_stmt flag
through to dwarf_record_line_1.
* infrun.c (process_event_stop_test): When stepping, don't stop at
a non-statement instruction, and only refresh the step info when
we land in the middle of a line's range. Also add an extra
comment.
* jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
field.
* record-btrace.c (btrace_find_line_range): Only record lines
marked as is-statement.
* stack.c (frame_show_address): Show the frame address if we are
in a non-statement sal.
* symmisc.c (dump_symtab_1): Print the is_stmt flag.
(maintenance_print_one_line_table): Print a header for the is_stmt
column, and include is_stmt information in the output.
* symtab.c (find_pc_sect_line): Find lines marked as statements in
preference to non-statements.
(find_pcs_for_symtab_line): Prefer is-statement entries.
(find_line_common): Likewise.
* symtab.h (struct linetable_entry): Add is_stmt field.
(struct symtab_and_line): Likewise.
* xcoffread.c (arrange_linetable): Initialise is_stmt field when
arranging the line table.
------ gdb/testsuite/ChangeLog ------
2020-03-10 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb.cp/step-and-next-inline.cc: New file.
* gdb.cp/step-and-next-inline.exp: New file.
* gdb.cp/step-and-next-inline.h: New file.
* gdb.dwarf2/dw2-is-stmt.c: New file.
* gdb.dwarf2/dw2-is-stmt.exp: New file.
* gdb.dwarf2/dw2-is-stmt-2.c: New file.
* gdb.dwarf2/dw2-is-stmt-2.exp: New file.
* gdb.dwarf2/dw2-ranges-base.exp: Update line table pattern.
Checking cecf854779049c3f491caf23f80d13eabbb90c86: FAILED
ERR: line should start with a tab:"Change-Id: Ia3f61d523826382dd2333f65b9aae368ad29c4a5"
Checking a6a1f5e050c3d4444b8074ba9ba02f547b725892: OK
------ gas/ChangeLog ------
2020-03-10 Alan Modra <amodra@gmail.com>
* config/tc-csky.c (get_operand_value): Rewrite 1 << 31 expressions
to avoid signed overflow.
* config/tc-mcore.c (md_assemble): Likewise.
* config/tc-mips.c (gpr_read_mask, gpr_write_mask): Likewise.
* config/tc-nds32.c (SET_ADDEND): Likewise.
* config/tc-nios2.c (nios2_assemble_arg_R): Likewise.
Checking e10ac147c80240c2d0aa0a2ae2ec7f6a934c198f: OK
------ include/ChangeLog ------
2020-03-10 Alan Modra <amodra@gmail.com>
* som/aout.h (SOM_AUX_ID_MANDATORY, SOM_SPACE_IS_LOADABLE),
(SOM_SYMBOL_HIDDEN, SOM_SYMBOL_HAS_LONG_RETURN): Use 1u << 31.
* som/lst.h (LST_SYMBOL_HIDDEN): Likewise.
[-- Attachment #4: result.txt --]
[-- Type: text/plain, Size: 25924 bytes --]
Checking 80e2a3b66ed9055fc26a1e5e26c6158b1c87111d: OK
Checking 89ff19d45e9acfff9c77bf570631df6b99b62619: FAILED
ERR: cannot find a ChangeLog location in message
Checking a879b4d5a683f8dbebae8cf98297ee4a2db2e9e1: OK
Checking 0826b30a9fa085ccee574465523d0560a4a01198: OK
Checking 2b2558bfacba3813863da6728c021eb89fa34677: OK
Checking eeb647814fbfd71dddea45f36cb4847341f5cde7: OK
Checking a39fdb411d43824b27d886bab42cada62a9fe431: OK
Checking 436c571c6afc8c5affe36327ab363b98ec9adb2d: OK
Checking 052c8bb83a515768cd6af2f3707b6e05854cac54: OK
Checking 2b24b6e4a6d03efc3e76ce6912394e4a86cc387b: OK
Checking c2d50fd0b30f640301c3736038bec82b40a3f0dc: OK
Checking 0df7ad3a675692fcc75c85c43e475015b87a297e: OK
Checking 86c0bb4c57111422b30da6b1b20256bd3a06778a: OK
Checking 2ef46c2fbbd18c3f411ef294c2c6694a1308a5a5: OK
Checking 4f9c1eda9ffc161015b6d9cc6dc958b67de680e6: OK
Checking 5a0e026fe12a4b1a94878494facf2b5f173a3b9c: OK
Checking 8844c11b8bc1cfa70a63a8875e08345c96abecfe: OK
Checking c90ec28ae44ebf72d57d58439d02fc5aab90f1f6: OK
Checking 4f44ae6c69b839712a33a46aaa62d58d2b16b4ca: OK
Checking a0194fa8f23c64bef0f4b4bb4a76e9c64f003169: OK
Checking 3d27bbdb4bc02968ffd86c6b5c331d0e04bc3ed9: OK
Checking 9eac9650ce7de1f6e4b5ddc103d6530ebc32582d: OK
Checking bf80d710525ba743d0046bf1f9cab6a019d7c616: OK
Checking 0314b3901c9cdc21ef9f0c1b0b88528d6f8d3073: OK
Checking 9fda78b61127cbcf718104b7e5a78cf137c07836: OK
Checking aa49fc22c13a685452a2073e252d8b34ecbcc012: OK
Checking 832a580781060f54731fcf654d76ac1332037a47: OK
Checking ff7685105468702de87b75599b1ea88cc309541c: OK
Checking 4c4addbe57711f1cdbb72305b8cbd03a68ae2e34: OK
Checking f75fbe8ad2e3d9b34bf1f448a6df328ff361822f: OK
Checking 46b438bb7369a55eefef15cd5d1afbb5c2c5742e: FAILED
ERR: cannot find a ChangeLog location in message
Checking 33aa3c10f663b834c9573ede439b2df3c92f0cfe: OK
Checking d503b685c6b7384b389767d5153235039e2b8fc4: OK
Checking 4c83662712f80abe9a7d8ef645123347a9de7adb: OK
Checking aac88046e6cccf13fc408fc4e515aaf2548fe898: OK
Checking b77809577782d8798bc86dde3a2a28c30d7805f0: OK
Checking 7b1eff95bed765cb20dd3168cb99896a91fcdca7: OK
Checking dd8953924b0966e363c27ee38a0663c08f742fa0: OK
Checking cf2611febcfa6b7c680de31071c5658e7463eee4: OK
Checking 86fd7e2e109813b3934cf7880b93d4bc8f779b8b: OK
Checking d16e3d2e5b717cf83c1fe47a70e0a9f2c2024a44: FAILED
ERR: missing PR component:" PR 25662"
Checking 0d4a4bc56fc947565ef0dd4b440a157e7d592b09: FAILED
ERR: cannot find a ChangeLog location in message
Checking 1081065c519d1bfc3847bf4b0a0ce4bc3224bcd3: FAILED
ERR: changed file not mentioned in a ChangeLog:"bfd/libbfd.h"
Checking a18cd0cab43f45b05e9f8bcbf8fed1d67834442d: OK
Checking 5ab2fbf185935f387fd5c1f8b14ba9fe04b41b39: OK
Checking e11cd7c491e4ec0cdd080c6dd45e62789a893606: OK
Checking 0b8448af68b2720d08640604355ef7d961a5acd6: FAILED
ERR: missing PR component:" PR 25713"
Checking ec2e748ad396c868839c977aa27d0333eb085970: FAILED
ERR: missing PR component:" PR 25681"
Checking cda7e5603f6efd7c3716e45cc6ea11b70dd8daae: OK
Checking dfb68cc35803369cbd163c2ebc07fb27e81d9950: FAILED
ERR: invalid PR component:" PR lto/94249"
Checking 7e6e972f74aeac0ebdbd95a7f905d871cd2581de: OK
Checking a64fafb54577a87919a600474a3e4abe3510341a: OK
Checking 65109548f8fb13ac4a6c3311ea46a8b69c548576: OK
Checking 5a814d6d96bc6426ae1fa8b0d1561ad081deb159: OK
Checking 1ce0847daa8de001ed4a1b32341fcc3ce53f5a30: FAILED
ERR: cannot find a ChangeLog location in message
Checking 0636b24556961d705b945f2465432df80e9ebf68: FAILED
ERR: missing PR component:" PR 25714"
Checking fdde2fb60cc2d0c60d9d3f085a7b6c648376991e: FAILED
ERR: line should start with a tab:" * elflink.c (_bfd_elf_tls_setup): Mention .tdata in comment."
Checking cf28cfef6006c41b74af126bc6ef26590d7bd1b9: OK
Checking 5e737279c6e832a757f0326128e5a5f96fbdd291: OK
Checking 5935fd15306c26ead8274cbeab3287770f2ac92a: OK
Checking 2957d8d05405c53b0d377e578fe1b770af732254: FAILED
ERR: cannot find a ChangeLog location in message
Checking c15a8f173e9b01dd962ba857b7deb547d34bca5b: OK
Checking 57cb32b3c366585f7fafd6a741771ce826ba95f3: OK
Checking beea5cc1bc2249389dc77ea0c86ab82dafd05bb5: OK
Checking 03704c7704870a0e6cbb0eae99488d544c4adb30: OK
Checking d1023b5d1e4483e5fa3bdab97bc041e1b1c05c5d: OK
Checking da2efc2050edf4641a22462beeb4c6b9a1a827f2: FAILED
ERR: cannot find a ChangeLog location in message
Checking e3b1fa32c2814772e8c8c4d2788e1d342c7493d0: OK
Checking d9fb0d71365e3c7e2c0de2ecd9cb9de0c2bf1880: FAILED
ERR: cannot find a ChangeLog location in message
Checking fe26d3a34a223a86fddb59ed70a621a13940a088: OK
Checking c623cc90890de9958bcee382cc60ff1b605532ab: FAILED
ERR: cannot find a ChangeLog location in message
Checking c884cc46193c98fd0b90ce8a79c081f6a1c18cc6: OK
Checking 1ff700c202465275d1ca3aee4dd979db36274294: FAILED
ERR: line should start with a tab:" * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to"
ERR: line should start with a tab:" `PTRACE_TYPE_RET'."
ERR: line should start with a tab:" * i386-bsd-nat.c (gdb_ptrace): Likewise."
ERR: line should start with a tab:" * sparc-nat.c (gdb_ptrace): Likewise."
ERR: line should start with a tab:" * x86-bsd-nat.c (gdb_ptrace): Likewise."
Checking f7d4f0b1b9519fa10eb04cb195bdf7b5044d73c7: OK
Checking f67210ff1c4200ea668189d086c6b39145cd876f: OK
Checking 1773be9ea2207d42442222e6dc3c8fdbe638e28e: OK
Checking 70304be939301a91dade0dc7d4234c081372bd24: OK
Checking 9faa006d11a5e08264a007463435f84b77864c9c: OK
Checking 4a90f062056e842c3f53293482e0039db0da3245: OK
Checking 0dd7b8f788b8d5239800d59f97b43186dcf425e2: OK
Checking 0d832e7f5e8c2e3659a55955c3b419e7cf5c9a34: FAILED
ERR: missing PR component:" PR 25690"
Checking c7da12c72c2eeb4f62e772df5cbb1f50f35a84ee: FAILED
ERR: line should start with a tab:" it to the ptrace call."
ERR: line should start with a tab:" * (store_registers): Likewise."
Checking 5844b4657aa2b9eb52aecc5a6338324032fb6eae: OK
Checking 3d98c46092341c1373d960d0a66ca502d5b7ee7f: OK
Checking c3a1714ce7806002726a60c0db09371425fe3097: OK
Checking c02d66610b3b79f6fb5052e8890969bc7185b7be: OK
Checking 67338173a49204a2097ca1e2c63c6bc1fe972c3e: OK
Checking 340f3ac8082771ecc473ab938fc3d7cbf607ddaa: OK
Checking fe90ae8a9f54e4fe8b9089fed48b0e1818414f57: OK
Checking 833d919c93d52644173d587a6fc8e4dd36edc49e: OK
Checking a859124df20f6544dbef96084e4e024bccebd853: OK
Checking ce2ea1c7e055b3b70f03dc33db3b77b0d775f5de: FAILED
ERR: cannot find a ChangeLog location in message
Checking 9a6c68caa9543e09b064b7ac7c2b658f277bc19c: FAILED
ERR: line should start with a tab:" * options.h (General_options): Add --no-rosegment option."
Checking f09db380942d1393e6f60d1ecaa7d4b6edfaaecf: OK
Checking f3a08f77787cfe1b9edb7b5ab82ce7a2d527c8cf: FAILED
ERR: missing PR component:" PR 25676"
ERR: line should start with a tab:"bfd * dwarf2.c (struct varinfo): Add unit_offset field to record the"
ERR: first line should start with a tab, asterisk and space:" location of the varinfo in the unit's debug info data. Change the"
ERR: first line should start with a tab, asterisk and space:" type of the stack field to a boolean."
ERR: first line should start with a tab, asterisk and space:" (lookup_var_by_offset): New function. Returns the varinfo"
ERR: first line should start with a tab, asterisk and space:" structure for the variable described at the given offset in the"
ERR: first line should start with a tab, asterisk and space:" unit's debug info."
ERR: first line should start with a tab, asterisk and space:" (scan_unit_for_symbols): Add support for variables which have the"
ERR: first line should start with a tab, asterisk and space:" DW_AT_specification attribute."
ERR: line should start with a tab:"binutils* testsuite/binutils-all/dw4.s: New test source file."
ERR: could not deduce ChangeLog file
Checking 3734bec8336f6f33927ab99460cb681035c2ca4f: OK
Checking 2d07da271eee9a83a1f5c975204d7d6dfd66fe1f: OK
Checking 6a541707f341275fa5081ec36cc6f2551042c21e: FAILED
ERR: missing PR component:" PR 25699"
Checking fcc7376e0a4c3a68ef0b9d12fcc3733416b1cc8c: OK
Checking ef3df11042c3dbaf695c1260b42364688cafa8ea: OK
Checking cada5fc921e39a1945c422eea055c8b326d8d353: OK
Checking 6b8c53f2f1c0cf5bee46120d892d4c72571375eb: OK
Checking 19a2740f7f2ea0f65745a3c00cf8a64647378aa3: FAILED
ERR: line should start with a tab:"Change-Id: Ie5c7c9fc8ecf973072cfb4a9650867104bf7f50c"
Checking 724fd9ba432a20ef2e3f2c0d6060bff131226816: FAILED
ERR: line should start with a tab:"Change-Id: I9d1db52c489ca0041b8959ca0d53b7d3af8aea72"
Checking d8c8b84859d057c58c901c08367ecc9f8a9f09dc: OK
Checking effc14f54c3fdcb700f22ce53cef97665c0fdf7f: FAILED
ERR: line should start with a tab:" * elfxx-riscv.c (riscv_parse_subset): Don't use C99."
Checking 81a65eb338cf7b40ef76b1cdb150eefd8495e282: OK
Checking 1cb7d8b1afc7c71cfacfe017e0692c9064bf9818: OK
Checking b966f55ffa570a05081b2030577b2158e8116c5a: OK
Checking 645ba68105ee79511a79386811dd932be8becafa: OK
Checking cdf236890ce1a8f44d24841d888728f9feb38c44: FAILED
ERR: cannot find a ChangeLog location in message
Checking a9933ccf467ac771747db9dba541afdf1b72a3f8: OK
Checking aef397a1548908f82907854a6efc0cd4c0539904: FAILED
ERR: line should start with a tab:"Change-Id: I8870800177e1ff79cdd05af13613ec53ef95681f"
ERR: could not deduce ChangeLog file
Checking ac4bf06ca22b641b10fe37763bf57e177ee22864: FAILED
ERR: missing PR component:" PR 25673"
Checking 53215f214c61b850085196a8d69774eed026ecd9: FAILED
ERR: line should start with a tab:"Change-Id: I60deaeeee59d4e7cab06b8a40a3e51837c43a8ab"
Checking 5a82b8a12b6a9b8167517ab1df1dcdcc4711ffda: OK
Checking fb516a69133999df3e30fccb7c4f5759eb1090eb: OK
Checking 1c0aa1fbb2fb1920c12400940704ee90491b7290: OK
Checking d3e2a5e85df4c8454135503c1034b95fecd522ab: OK
Checking 5ccd2fb722d1900adf799dd808fa2146cac85d0d: OK
Checking fe64b263e025c5abc02738138d9283f53641ca42: FAILED
ERR: cannot find a ChangeLog location in message
Checking 2108a63a5a736c2329a2a92ca58e0b9993dc5d42: OK
Checking d3c3c54293ce8c42503e66f8076059a7c8b1639f: OK
Checking 327ef784ba105f067f5c1d587908259d7aabb971: FAILED
ERR: missing PR component:" PR 25633"
Checking 68e52bc7ecfbfdc8d5f85716a8ac7668e211f360: FAILED
ERR: missing PR component:" PR 25641"
ERR: missing PR component:" PR 25668"
ERR: missing PR component:" PR 25633"
ERR: line should start with a tab:"gas Fix disassembling ED+A4/AC/B4/BC opcodes."
ERR: first line should start with a tab, asterisk and space:" Fix assembling lines containing colonless label and instruction"
ERR: first line should start with a tab, asterisk and space:" with first operand inside parentheses."
ERR: first line should start with a tab, asterisk and space:" Fix registration of unsupported by target CPU registers."
ERR: line should start with a tab:"opcodes * z80-dis.c: Fix disassembling ED+A4/AC/B4/BC opcodes."
ERR: could not deduce ChangeLog file
Checking ecbbbdba7182865e522e0893915e9be487fe14b0: FAILED
ERR: missing PR component:" PR 25687"
Checking a225c9a8692814b4a29360479aee217d73e22d50: OK
Checking 9809762324491b851332ce600ae9bde8dd34f601: OK
Checking 946ffddcae7a8d0d135dd550b4bc7193b2ac1c5c: FAILED
ERR: cannot find a ChangeLog location in message
Checking 9e38d619101a7637c9aba3f722690bef127fa6a6: OK
Checking a2ecbe9fb7355698aad97841f9717cdfd7096d95: OK
Checking 589902954da0d1dd140b33e578954746c9bfc374: OK
Checking 7325b16ba4dc33a54356fd2b8fde79311c51b121: FAILED
ERR: cannot find a ChangeLog location in message
Checking 771dd3a88b1f0e03a110fc4f2207913df45f8b4b: OK
Checking 817a7585764366397879cbbedfd7e9c1454b656c: FAILED
ERR: line should start with a tab:" (arc_read_description): New function to cache target descriptions."
Checking 67430cd00afcc270a27e44b10f9ef4249d554e66: FAILED
ERR: first line should start with a tab, asterisk and space:" PR gdb/25663:"
Checking 30efb6c7af7ad8b50936157fe0a0ef22d6787dd7: OK
Checking 8db52437243e251c01e352cdb325bc9ace578e7c: OK
Checking 5982a56ab9d161923e75712fcb358824748ea4ba: OK
Checking 7a1998dffb58ee1fab5edbd13458373654a1da42: OK
Checking 053205cc4021026a5a1db05869d04bf7ad9ea1bd: OK
Checking fe4b2ee65cfe923fcb25427db884e1d2e90fef6e: OK
Checking cb9b645d3e6b6164317104ed1a2a41c06da37bf4: OK
Checking 2f89101fe8b6a2423116a1ad1891f56bf6fc9510: OK
Checking 4b3ecb3b91b1b6154a6444efdcbadb90854a6654: FAILED
ERR: missing PR component:" PR 25675"
Checking 28d1356774c2c61adc7d6e6723de2351cd9f4ddc: OK
Checking 60e63c3e9750b036d50e58bc173591fa450601b6: OK
Checking 7bac4137d757be98de8f6f8d8a649f04cacfdd2f: OK
Checking 6b9374f1e07cb250736815ff8db263199416adc6: OK
Checking eaeaf44cfdc9a4096a0dd52fa0606f29d4bfd48e: OK
Checking 3293bbaffac9a22fc6d1a08ac6602a4a63b5e68b: OK
Checking ab44624cea74dca3e6d19c3275d9d5a8d381c084: OK
Checking 154151a6e303fa4b17e3597e3434a1c5999df8e1: FAILED
ERR: line should start with a tab:" * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass"
ERR: line should start with a tab:" it to the ptrace call."
ERR: line should start with a tab:" * m68k-bsd-nat.c (store_registers): Likewise."
Checking bc10778499a971ab9ccecb074cc406d49e1ee608: OK
Checking 01a801176ea15ddfc988cade2e3d84c3b0abfec3: OK
Checking f90280caf5b34ebd564809a7f66685efc79bbf6d: OK
Checking 6def66f1404e58b376655f6fb622aeb9dfc0f587: OK
Checking 66eaca97ebd0f1b456ffe158fce73bafcce561bb: OK
Checking 4fed520be264b60893aa674071947890f8172915: OK
Checking 2190cf067b87e804c59c0a0c14c8ae48deabfbf4: OK
Checking 54c4382534f0c894434deca5eb89cd02661d6feb: OK
Checking 75c56d3d1298de72aa67555f2c723a80b4818e04: OK
Checking 6018d381a00515933016c539d2fdc18ad0d304b8: OK
Checking 013f99f035c49b000ca058db80ad15e00aa330dc: FAILED
ERR: line should start with a tab:" * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass"
ERR: line should start with a tab:" it to the ptrace call."
ERR: line should start with a tab:" * x86-bsd-nat.c (x86bsd_dr_set): Likewise."
Checking 6227b330d563add042066259e5f933c89a85b3b5: OK
Checking 12753073036aad1250b5e9a1bd6991c125150269: OK
Checking d5be5fa4207da00d039a1d5a040ba316e7092cbd: OK
Checking 8110f842bc52940d27b6f1e8e5ab711238d9d210: OK
Checking 52feded7781821d227db0be188e564698d29fe9e: OK
Checking 25567eeece4efdea99a9a2b3a6daf81ec31b4b07: OK
Checking 8b5d0a4f6ff67aa81275c705508e3f49accc8120: OK
Checking 1bd6175ae79099173c1510d209ad9978129e22c0: OK
Checking 2ac70237d2458fb2eb5e73de6bb02a396b5bada0: OK
Checking 09546b56ede31ca2b401e9b03466e8e1fb84d85f: OK
Checking 780f96aed2b4db1014e8fa2b50118676d8af0e46: OK
Checking f761cb13a903da6a5a1b3f9a5cb984600124ac31: OK
Checking 02a8180e6f6146f95593001247f6cd080bdb7b38: OK
Checking 48e81d7f6314345a5d8648ab7b7b0ac0c6a8a381: OK
Checking 426a9c18dddcdd5f640b702734dd8f9c108b7372: OK
Checking 42331a1ea2a13ce15ec202c5f0fbef3e5171253c: OK
Checking 3a916a975745f386cabbaba64531ed9b5f8be509: OK
Checking b59eac373217394503946dc360692d81809e08af: OK
Checking 033711290333b0d4ec5c1b744af512f7ab133478: OK
Checking 2e088f8b6ea61fa9db1b592cbd4a6aa80b4e0ab5: OK
Checking 39ef85a896e7efa0391a7ed14cc965fe1d46cbb9: OK
Checking b9fa6e07980f901f2a3f99b7eed4356d3209a3c4: OK
Checking 416595d6409b1bd2e2f9862c133ca764688da77f: OK
Checking 5b5e15ecddafc43de2da632aa68f935a879d9a91: OK
Checking fbf54e7554e0dcd60e18b1821c5c127fb3eb48ff: OK
Checking 64b653ca7058bfd4f91879dea628809d398b488e: OK
Checking 6999f067c1b30c1a2c3e41a0f68f74e459652560: OK
Checking ce80b8bd374e14c1cebe149724274b1894f5f8cf: OK
Checking 2faac269d59e57a49cd9f9209e1d39e03e2744bc: OK
Checking da3e2c2923b5c16c47c962bc53ea96678ca6a0e5: OK
Checking 5083623134c2ac383a8d8412b6d3c530452fda51: OK
Checking 4f412b6e31369f27725872391a70f0520883701c: OK
Checking f5354008862defe83fc6d3620d51da52f860f5bf: OK
Checking 3eec3b05b9ecf5e726c606f0bba916e095dcbe98: OK
Checking fdddfccba1cc4f70089873441b7e6c38de09ae37: OK
Checking 6dde752183769c712eb22f49a5b74bfadad4a6be: OK
Checking 4112d2e602fed7157ce6bb30f46969129633d0f2: OK
Checking 65786af6265044c67b25db23267f942c73b6fc20: OK
Checking 40f3ce189e3c16398f2e56442e6d8db5573587ee: OK
Checking 2a5b130bcb6f376b6a28d8378172ed3f9b92e9d9: OK
Checking abc66ce95eee79db058123b985e19dcfc03dc1a7: OK
Checking 07a328583de159941b64bad3ca94f20185c905ed: OK
Checking 64d64d3a76bb57305b278082ed1a29f0982b664d: OK
Checking 6a95a1f58dd9dabcade13f7a332eed601baf25f8: OK
Checking 59fcdac646cf4ed3168cd787a883d282b4d9de1f: OK
Checking d133c3e1a877259bbee460897d9a6a2820ffe451: OK
Checking 23b0f06be43054a9b182e7ea60a763c35302924a: OK
Checking 5f56f7cbd22219e84df3caece06f469c5063e5fb: OK
Checking 26792ee0345c09bd1c76f3ee0e16ed15ab7215b9: OK
Checking 24051bbe843abcdcc108542da195e009c3f19910: OK
Checking c0941be613054fe525891a2898e7d938b8e8ceed: OK
Checking 62c4663d3c59b53e622b2f83eeae7c8d47c656dd: OK
Checking 621821900289e9ef3472dc430d6fcf4d55b301e2: OK
Checking 1e592a8ae0985645e61f6ffbfee064af8826b457: OK
Checking 7fe471e9ae8dbc61b898f7572fed31c4224a0b89: OK
Checking d121c6ce897d34ae168f78cbdacacb109d4833e6: OK
Checking 4dba70eee1fadcb3c1bb50ba17e0fe3512c84180: OK
Checking 4f9ae810130bc4202ec1c5eae934900c542a9016: OK
Checking 156bfec999186e3eccaf51fa3b81280bf51dbaa4: OK
Checking 2b4e573d62be3a59057895054b1b5faa67557ce6: OK
Checking a1f6a07c3d1d3a34d36d4e49f0fd3c66554e41b2: OK
Checking 410cf315014145f169c146442e9c28163d9ae10a: OK
Checking 72a45c938438f33bf8e7de6a5f068ba31c8c1e36: OK
Checking 040f66bd2d6aea4d35a2e5cb88b499799ee4c466: OK
Checking a6e05a6c3a9439a7253d2eab7ee4fe760b4cc829: OK
Checking 3444c526a33e61aeff86cbe1184e765458007890: OK
Checking c2a44efee1cbe5321a850c53f34e9c205a1d6ca0: OK
Checking b0c26e99f50d6926dd628ec51c1e9a037c521ab5: OK
Checking ce3acbe9fa876647649cc88f94264a5c56bf46a1: OK
Checking 1b83d09cd503d7fde57c50db51d5780ee8df5fae: OK
Checking 06d949ec3121f4732e789db1efc53986355c9481: OK
Checking 9fcbd8a90a92bf303c41be816040789e1ed6cf4e: OK
Checking abf874aafe3d717573e4a48bf0e3c6334e666a55: FAILED
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm.d"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm.ld"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm.s"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm2.d"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm3.d"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm3.ld"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm4.d"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm4.ld"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm5.d"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm5.ld"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm6.d"
ERR: file not changed in a patch:"ld/testsuite/ld-arm/arm-elf/non-contiguous-arm6.ld"
ERR: file not changed in a patch:"ld/testsuite/ld-powerpc/non-contiguous-powerpc.sd"
Checking 74e10d1742f1b8312359c59a2af06c9e661252b3: OK
Checking 2d61316c32a9fa3e14786c3312d9ca87c9298db5: OK
Checking 2e9145ace2a520f942d74fea7df9458cc8a16523: OK
Checking 66d1f7cc129495ea6c820bcd16242ec5ff39b172: FAILED
ERR: missing PR component:" PR 25660"
ERR: one space should follow asterisk:" * config/tc-arm.c (operand_parse_code): Add OP_RNSDMQR and OP_oRNSDMQ."
ERR: first line should start with a tab, asterisk and space:" (parse_operands): Handle new operand codes."
ERR: first line should start with a tab, asterisk and space:" (do_neon_dyadic_long): Make shape check accept the scalar variants."
ERR: first line should start with a tab, asterisk and space:" (asm_opcode_insns): Fix operand codes for vaddl and vsubl."
Checking 015ec493d8603095d212df443e7b75017b572455: OK
Checking 1673df3278637a911b55983a92e4d1f61816e57c: FAILED
ERR: cannot find a ChangeLog location in message
Checking 96c7f873945c31bb0f9facd526bfe6dac74d3ccb: OK
Checking 666318230c54a348763927c80d085542d9890c42: OK
Checking 502794d4321dc17d5c9fb591bedc8761118b2943: OK
Checking fd486f32d15e3299b905084a697fac6349c43f76: OK
Checking 49ba92c0a6765ee7dc3a773c1a044680d29cee0e: OK
Checking 301b21e0dfee41c7a93f41089428d5d03fee685b: OK
Checking 6ba0a321037b748f0b1285c44af762021a380bd3: OK
Checking 4635ff975351603e64da3cbdeec3b999ee842ac8: FAILED
ERR: could not deduce ChangeLog file, not unique location
Checking 213291361b4ddb2d05b8c89bf47d23ca4306912e: FAILED
ERR: ChangeLog must contain a file entry:"gdbsupport"
Checking 9a665d62266e75f0519f3a663784c458885b5c63: FAILED
ERR: could not deduce ChangeLog file, not unique location
Checking 227031b2bf03e7735601845d6c420995740c8fca: OK
Checking 53807e9f3d83bc0f67b9b9471cc60fb37182e5ab: OK
Checking 64f251023bcbd068861d4cb83b4e925083e0ea35: OK
Checking 3f512721a829ce7b2d38236917309a32f42faa99: OK
Checking 40310f30a51c1343b954d1fee7feb9a1d9455e9f: OK
Checking 272cd5a31e7ff16fe46a5532e857b98229404c48: FAILED
ERR: changed file not mentioned in a ChangeLog:"gdbsupport/Makefile.in"
Checking 74cd3f9d7e2bc82a295011230dc5261cd1129b4f: FAILED
ERR: changed file not mentioned in a ChangeLog:"gdb/configure"
Checking db6878ac5538661c8d66c916a533bd4268217fcb: OK
Checking 4d696a5c686730d75623d7e41805e42ce5fcc60c: OK
Checking 8dd8e1c7228d5dd57b3b36379718c806017988e1: OK
Checking 7a20f753ef28251e4d3bca211e9ee338f67aa2a8: OK
Checking 607c69321064f57595038d39af3328b0de73eb85: OK
Checking 09252140293763eaa230314dee27f605a37154d4: OK
Checking 14e9c72c334205c0171d62e716c1fb65472a0eab: OK
Checking e515d67ed61f7c588a3154589a8a25c7bef66d20: OK
Checking 307eafd8df3ec820bb62a71324aeed06b86ec050: OK
Checking 9a2de3fc7f7c40da6e8d5553c29e6cb8a2430dc8: OK
Checking 3217502e1ba7409676e192100a0147a49dd5ae7a: OK
Checking 1281424ccf3d05410398f4f495443d9e54426f91: OK
Checking 8fb879cd16a3e3d1fe93e333c4c720fd33bcc416: OK
Checking dd69bf7a78a489783c397f2552eeb7999defcb6a: FAILED
ERR: line should start with a tab:"Change-Id: I595470be6ab5f61ca7e4e9e70c61a252c0deaeaa"
Checking 038b97fcd75a338a515fe7def5db142e6952ca7c: OK
Checking a0761e34f054767de6d6389929d27e9015fb299b: OK
Checking 5308d1e77167b4bb133302d7a6f66e599abee420: OK
Checking 9e8f1c9000fa42b68982ee69f622010a81656e81: OK
Checking f870f78fb2dc15cc5a4738d7ee592b39e2001c4e: OK
Checking 97b4a8f744f437fa35afbe20f53e657e9de957cd: OK
Checking ae531041c7c5956672342f89c486a011c84f027f: FAILED
ERR: file not changed in a patch:"gas/config/tc-i386.h"
Checking 5a13315d1c6993ab84075ff94797eb8c6da1f20b: OK
Checking e7a82140af00e632f06e27d0ec9ad1f4fb704d92: OK
Checking 976862ed563047be58effc4b02fe75ed064f77b7: OK
Checking 7462c383f9849aab40f156854a72f0a93305124a: OK
Checking 1c6c46a012a43aefb6183fa2dd16ec6db5751aa3: OK
Checking 8248d21a5b8b7bb9970163b8b327f5ac2f857f33: OK
Checking 44f41bb7a1568dbe2e4e642e6c3c2e9ba3d47d92: OK
Checking dcc050c86c3e5160497da7aab480adae9ba284aa: FAILED
ERR: file not changed in a patch:"gdb/buildsyms.c"
ERR: changed file not mentioned in a ChangeLog:"gdb/buildsym.c"
Checking 5496f3c635dce3e12348d6e81c3f74815fdfe7b5: FAILED
ERR: missing PR component:" PR 25611"
ERR: missing PR component:" PR 25614"
ERR: line should start with a tab:"gas * dwarf2dbg.c (DWARF2_FILE_TIME_NAME): Default to -1."
ERR: first line should start with a tab, asterisk and space:" (DWARF2_FILE_SIZE_NAME): Default to -1."
ERR: first line should start with a tab, asterisk and space:" (DWARF2_LINE_VERSION): Default to the current dwarf level or 3,"
ERR: first line should start with a tab, asterisk and space:" whichever is higher."
ERR: first line should start with a tab, asterisk and space:" (DWARF2_LINE_MAX_OPS_PER_INSN): Provide a default value of 1."
ERR: first line should start with a tab, asterisk and space:" (NUM_MD5_BYTES): Define."
ERR: first line should start with a tab, asterisk and space:" (struct file entry): Add md5 field."
ERR: first line should start with a tab, asterisk and space:" (get_filenum): Delete and replace with..."
ERR: first line should start with a tab, asterisk and space:" (get_basename): New function."
ERR: first line should start with a tab, asterisk and space:" (get_directory_table_entry): New function."
ERR: first line should start with a tab, asterisk and space:" (allocate_filenum): New function."
ERR: first line should start with a tab, asterisk and space:" (allocate_filename_to_slot): New function."
ERR: first line should start with a tab, asterisk and space:" (dwarf2_where): Use new functions."
ERR: first line should start with a tab, asterisk and space:" (dwarf2_directive_filename): Add support for extended .file"
ERR: first line should start with a tab, asterisk and space:" pseudo-op."
ERR: first line should start with a tab, asterisk and space:" (dwarf2_directive_loc): Allow the use of file number zero with"
ERR: first line should start with a tab, asterisk and space:" DWARF 5 or higher."
ERR: first line should start with a tab, asterisk and space:" (out_file_list): Rename to..."
ERR: first line should start with a tab, asterisk and space:" (out_dir_and_file_list): Add DWARF 5 support."
ERR: first line should start with a tab, asterisk and space:" (out_debug_line): Emit extra values into the section header for"
ERR: first line should start with a tab, asterisk and space:" DWARF 5."
ERR: first line should start with a tab, asterisk and space:" (out_debug_str): Allow for file 0 to be used with DWARF 5."
Checking b76f3a42371cb0d83a1128a434852447da76b5e9: OK
Checking 119789424b62321e74a18fc1c088ebf479d999c4: OK
Checking 435edf0bf231240ccecb474b74ebb49dc8db2633: OK
Checking 9cc89dc0acc140cb27e21d2597af42d36444673b: FAILED
ERR: missing PR component:" PR 25651"
Checking 1db6f990303ab6c45909f8e133641ef6c24a04d2: OK
Checking 1c33af7764d9f4eabc02e0f6f6df99917fbce0a6: OK
Checking 8c95582da858ac981f689a6f599acacb8c5c490f: OK
Checking cecf854779049c3f491caf23f80d13eabbb90c86: FAILED
ERR: line should start with a tab:"Change-Id: Ia3f61d523826382dd2333f65b9aae368ad29c4a5"
Checking a6a1f5e050c3d4444b8074ba9ba02f547b725892: OK
Checking e10ac147c80240c2d0aa0a2ae2ec7f6a934c198f: OK
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-29 7:45 ` Martin Liška
2020-05-29 8:50 ` Martin Liška
@ 2020-05-29 8:51 ` Martin Liška
2020-05-29 12:15 ` Tom Tromey
2 siblings, 0 replies; 25+ messages in thread
From: Martin Liška @ 2020-05-29 8:51 UTC (permalink / raw)
To: H.J. Lu, Simon Marchi; +Cc: GDB, Binutils
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
On 5/29/20 9:45 AM, Martin Liška wrote:
> I briefly looked at binutils commits and I believe the scripts can
> be directly adopted.
Ok, one would need to adjust list of ChangeLog files and bugzilla components. I've changed
that in the attached patch.
With that one can test it:
$ ./contrib/gcc-changelog/git_check_commit.py -g ~/Programming/binutils -n HEAD~300..HEAD
(see the attached output)
So ~250/300 commit messages can be parsed.
And the generated ChangeLog can be seen with:
./contrib/gcc-changelog/git_check_commit.py -g ~/Programming/binutils -n HEAD~300..HEAD -p
(see the attached output)
Would you be interested in adoption of the script?
Martin
[-- Attachment #2: result.txt.bz2 --]
[-- Type: application/x-bzip, Size: 8942 bytes --]
[-- Attachment #3: result-changelog.txt.bz2 --]
[-- Type: application/x-bzip, Size: 24666 bytes --]
[-- Attachment #4: 0001-gcc-changelog-for-binutils.patch --]
[-- Type: text/x-patch, Size: 4643 bytes --]
diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py
index 084e83c18cc..e2be3843c83 100755
--- a/contrib/gcc-changelog/git_commit.py
+++ b/contrib/gcc-changelog/git_commit.py
@@ -20,110 +20,149 @@ import os
import re
changelog_locations = set([
+ 'bfd',
+ 'binutils',
'config',
'contrib',
- 'contrib/header-tools',
- 'contrib/reghunt',
- 'contrib/regression',
- 'fixincludes',
- 'gcc/ada',
- 'gcc/analyzer',
- 'gcc/brig',
- 'gcc/c',
- 'gcc/c-family',
- 'gcc',
- 'gcc/cp',
- 'gcc/d',
- 'gcc/fortran',
- 'gcc/go',
- 'gcc/jit',
- 'gcc/lto',
- 'gcc/objc',
- 'gcc/objcp',
- 'gcc/po',
- 'gcc/testsuite',
- 'gnattools',
- 'gotools',
+ 'cpu',
+ 'elfcpp',
+ 'etc',
+ 'gas',
+ 'gdb',
+ 'gdb/doc',
+ 'gdbserver',
+ 'gdb/stubs',
+ 'gdbsupport',
+ 'gdb/testsuite',
+ 'gnulib',
+ 'gold',
+ 'gprof',
'include',
+ 'include/gdb',
'intl',
- 'libada',
- 'libatomic',
- 'libbacktrace',
- 'libcc1',
- 'libcpp',
- 'libcpp/po',
+ 'ld',
+ 'libctf',
'libdecnumber',
- 'libffi',
- 'libgcc',
- 'libgcc/config/avr/libf7',
- 'libgcc/config/libbid',
- 'libgfortran',
- 'libgomp',
- 'libhsail-rt',
'libiberty',
- 'libitm',
- 'libobjc',
- 'liboffloadmic',
- 'libphobos',
- 'libquadmath',
- 'libsanitizer',
- 'libssp',
- 'libstdc++-v3',
- 'libvtv',
- 'lto-plugin',
- 'maintainer-scripts',
- 'zlib'])
+ 'opcodes',
+ 'readline',
+ 'readline/readline/examples/rlfe',
+ 'sim/aarch64',
+ 'sim/arm',
+ 'sim/avr',
+ 'sim/bfin',
+ 'sim',
+ 'sim/common',
+ 'sim/cr16',
+ 'sim/cris',
+ 'sim/d10v',
+ 'sim/erc32',
+ 'sim/frv',
+ 'sim/ft32',
+ 'sim/h8300',
+ 'sim/igen',
+ 'sim/iq2000',
+ 'sim/lm32',
+ 'sim/m32c',
+ 'sim/m32r',
+ 'sim/m68hc11',
+ 'sim/mcore',
+ 'sim/microblaze',
+ 'sim/mips',
+ 'sim/mn10300',
+ 'sim/moxie',
+ 'sim/msp430',
+ 'sim/ppc',
+ 'sim/pru',
+ 'sim/rl78',
+ 'sim/rx',
+ 'sim/sh64',
+ 'sim/sh',
+ 'sim/testsuite',
+ 'sim/testsuite/d10v-elf',
+ 'sim/testsuite/frv-elf',
+ 'sim/testsuite/m32r-elf',
+ 'sim/testsuite/mips64el-elf',
+ 'sim/testsuite/sim/aarch64',
+ 'sim/testsuite/sim/arm',
+ 'sim/testsuite/sim/avr',
+ 'sim/testsuite/sim/bfin',
+ 'sim/testsuite/sim/cr16',
+ 'sim/testsuite/sim/cris',
+ 'sim/testsuite/sim/fr30',
+ 'sim/testsuite/sim/frv',
+ 'sim/testsuite/sim/ft32',
+ 'sim/testsuite/sim/h8300',
+ 'sim/testsuite/sim/iq2000',
+ 'sim/testsuite/sim/lm32',
+ 'sim/testsuite/sim/m32c',
+ 'sim/testsuite/sim/m32r',
+ 'sim/testsuite/sim/m68hc11',
+ 'sim/testsuite/sim/mcore',
+ 'sim/testsuite/sim/microblaze',
+ 'sim/testsuite/sim/mips',
+ 'sim/testsuite/sim/mn10300',
+ 'sim/testsuite/sim/moxie',
+ 'sim/testsuite/sim/msp430',
+ 'sim/testsuite/sim/or1k',
+ 'sim/testsuite/sim/pru',
+ 'sim/testsuite/sim/sh64',
+ 'sim/testsuite/sim/sh64/compact',
+ 'sim/testsuite/sim/sh64/media',
+ 'sim/testsuite/sim/sh',
+ 'sim/testsuite/sim/v850',
+ 'sim/v850',
+ 'zlib'
+])
bug_components = set([
+ # GDB components
'ada',
- 'analyzer',
- 'boehm-gc',
- 'bootstrap',
- 'c',
+ 'backtrace',
+ 'breakpoints',
+ 'build',
'c++',
+ 'cli',
+ 'compile',
+ 'corefiles',
'd',
- 'debug',
- 'demangler',
- 'driver',
- 'fastjar',
+ 'exp',
+ 'external',
'fortran',
- 'gcov-profile',
+ 'gdb',
'go',
- 'hsa',
- 'inline-asm',
- 'ipa',
+ 'guile',
+ 'i18n',
'java',
- 'jit',
- 'libbacktrace',
- 'libf2c',
- 'libffi',
- 'libfortran',
- 'libgcc',
- 'libgcj',
- 'libgomp',
- 'libitm',
- 'libobjc',
- 'libquadmath',
- 'libstdc++',
- 'lto',
- 'middle-end',
- 'modula2',
+ 'm2',
+ 'm3',
+ 'macros',
+ 'mi',
'objc',
- 'objc++',
- 'other',
- 'pch',
- 'pending',
- 'plugins',
- 'preprocessor',
- 'regression',
- 'rtl-optimization',
- 'sanitizer',
- 'spam',
- 'target',
+ 'pascal',
+ 'python',
+ 'record',
+ 'remote',
+ 'rust',
+ 'server',
+ 'shlibs',
+ 'sim',
+ 'symtab',
+ 'tdep',
'testsuite',
- 'translation',
- 'tree-optimization',
- 'web'])
+ 'threads',
+ 'tui',
+ 'varobj',
+ 'web',
+ 'win32',
+ # Binutils components
+ 'admin',
+ 'binutils',
+ 'gas',
+ 'gold',
+ 'gprof',
+ 'ld',
+ 'libctf'])
ignored_prefixes = [
'gcc/d/dmd/',
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-29 7:45 ` Martin Liška
2020-05-29 8:50 ` Martin Liška
2020-05-29 8:51 ` Martin Liška
@ 2020-05-29 12:15 ` Tom Tromey
2020-05-29 12:25 ` Martin Liška
` (2 more replies)
2 siblings, 3 replies; 25+ messages in thread
From: Tom Tromey @ 2020-05-29 12:15 UTC (permalink / raw)
To: Martin Liška; +Cc: H.J. Lu, Simon Marchi, GDB, Binutils
Martin> I'm the author of the scripts that are currently used in the GCC.
Martin> As mentioned, we update ChangeLog files by a script that takes all
Martin> the ChangeLog entries from git commit message. The supported ChangeLog
Martin> format is documented here:
Martin> https://gcc.gnu.org/codingconventions.html#ChangeLogs
IIUC, we still have to write the ChangeLog entries by hand, just in the
commit message, and using a much stricter format. Is that accurate?
If so, then this seems less convenient than the status quo. At least
for me, editing the files is simpler -- I use scripts to handle the
merges, rebases, and date-updating; and Emacs provides direct support
for writing the entries in the correct files and it usually gets the
function name correct as well.
It's the convenience of the last part that I'm most concerned about
losing. If there's a script that does as good a job, then maybe; but
otherwise it is a -1 from me. My reasoning here is that editing a
ChangeLog entry is labor-intensive, and anything increasing the labor is
a negative. It's already a reasonably significant drag on submitting
patches.
I'd be receptive to removing ChangeLog entirely. I don't believe they
provide much value. However, I know others disagree on this point, so I
don't plan to press it.
I'd also be open to changing the format to something requiring zero
manual intervention. For example, if we could have a commit script that
simply listed the files and didn't require editing in the names of the
functions.
thanks,
Tom
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-29 12:15 ` Tom Tromey
@ 2020-05-29 12:25 ` Martin Liška
2020-05-29 12:44 ` Tom Tromey
2020-05-29 12:28 ` Martin Liška
2020-05-29 13:57 ` Eli Zaretskii
2 siblings, 1 reply; 25+ messages in thread
From: Martin Liška @ 2020-05-29 12:25 UTC (permalink / raw)
To: Tom Tromey; +Cc: H.J. Lu, Simon Marchi, GDB, Binutils
On 5/29/20 2:15 PM, Tom Tromey wrote:
> Martin> I'm the author of the scripts that are currently used in the GCC.
> Martin> As mentioned, we update ChangeLog files by a script that takes all
> Martin> the ChangeLog entries from git commit message. The supported ChangeLog
> Martin> format is documented here:
>
> Martin> https://gcc.gnu.org/codingconventions.html#ChangeLogs
>
> IIUC, we still have to write the ChangeLog entries by hand, just in the
> commit message, and using a much stricter format. Is that accurate?
Yes, the entries should be places to git message.
>
> If so, then this seems less convenient than the status quo. At least
> for me, editing the files is simpler -- I use scripts to handle the
> merges, rebases, and date-updating; and Emacs provides direct support
> for writing the entries in the correct files and it usually gets the
> function name correct as well.
For generation of ChangeLog template, you can use:
https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=contrib/mklog.py;h=243edbb15c522169709902b27a8558c6e0755107;hb=HEAD
It takes a diff a generates a template. Note that PR entries are auto-filled,
new and removed files are automatically added.
About the merges: it's a pain to make a backport (a.k.a) as you're very likely
conflict in ChangeLog entries. Having the ChangeLog entries in message one
can do simple git cherry-pick and it's done.
Note that quite all developers have self made scripts for these situations
and it seems to me an extra work everybody has to do.
>
> It's the convenience of the last part that I'm most concerned about
> losing. If there's a script that does as good a job, then maybe; but
> otherwise it is a -1 from me. My reasoning here is that editing a
> ChangeLog entry is labor-intensive, and anything increasing the labor is
> a negative. It's already a reasonably significant drag on submitting
> patches.
>
> I'd be receptive to removing ChangeLog entirely. I don't believe they
> provide much value. However, I know others disagree on this point, so I
> don't plan to press it.
>
> I'd also be open to changing the format to something requiring zero
> manual intervention. For example, if we could have a commit script that
> simply listed the files and didn't require editing in the names of the
> functions.
Yes, mklog.py does that.
>
> thanks,
> Tom
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-29 12:15 ` Tom Tromey
2020-05-29 12:25 ` Martin Liška
@ 2020-05-29 12:28 ` Martin Liška
2020-05-29 13:57 ` Eli Zaretskii
2 siblings, 0 replies; 25+ messages in thread
From: Martin Liška @ 2020-05-29 12:28 UTC (permalink / raw)
To: Tom Tromey; +Cc: H.J. Lu, Simon Marchi, GDB, Binutils
On 5/29/20 2:15 PM, Tom Tromey wrote:
> merges, rebases, and date-updating; and Emacs provides direct support
About the date-updating: it's also pain to always update a timestamp before
a patch is installed. We recommend not using an author line and datestamp and
both these information can be taken from a git commit.
Martin
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-29 12:25 ` Martin Liška
@ 2020-05-29 12:44 ` Tom Tromey
2020-05-29 13:56 ` Martin Liška
0 siblings, 1 reply; 25+ messages in thread
From: Tom Tromey @ 2020-05-29 12:44 UTC (permalink / raw)
To: Martin Liška; +Cc: Tom Tromey, H.J. Lu, Simon Marchi, GDB, Binutils
Martin> For generation of ChangeLog template, you can use:
Martin> https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=contrib/mklog.py;h=243edbb15c522169709902b27a8558c6e0755107;hb=HEAD
Can it be used without manual intervention?
Or do I still have to edit in all the function names?
Could you run it on some recent gdb commits and show the output?
Martin> About the merges: it's a pain to make a backport (a.k.a) as you're very likely
Martin> conflict in ChangeLog entries. Having the ChangeLog entries in message one
Martin> can do simple git cherry-pick and it's done.
This is emphatically not the case for me.
Martin> About the date-updating: it's also pain to always update a timestamp before
Martin> a patch is installed.
What I'm saying is that it isn't a pain. It's a single command before
pushing. I can't remember the last time the scripts failed but it's
surely been more than 5 years.
I write a lot of patches in gdb and I have already filed off as many
annoying parts as I could -- which is why my default stance is not to
want to change. Changing implies that maybe I'd have to redo this work.
Tom
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-29 12:44 ` Tom Tromey
@ 2020-05-29 13:56 ` Martin Liška
2020-05-30 10:23 ` Aktemur, Tankut Baris
2020-05-30 19:41 ` Tom Tromey
0 siblings, 2 replies; 25+ messages in thread
From: Martin Liška @ 2020-05-29 13:56 UTC (permalink / raw)
To: Tom Tromey; +Cc: H.J. Lu, Simon Marchi, GDB, Binutils
On 5/29/20 2:44 PM, Tom Tromey wrote:
> Martin> For generation of ChangeLog template, you can use:
> Martin> https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=contrib/mklog.py;h=243edbb15c522169709902b27a8558c6e0755107;hb=HEAD
>
> Can it be used without manual intervention?
> Or do I still have to edit in all the function names?
One only needs to describe what's purpose of a change.
> Could you run it on some recent gdb commits and show the output?
Sure:
$ git format-patch -1 2b2558bfacba3813863da6728c021eb89fa34677 && ~/Programming/gcc/contrib/mklog.py 00*
0001-Move-DWARF-constant-stringifying-code-to-new-file.patch
ChangeLog:
* gdb/ChangeLog:
* gdb/Makefile.in:
* gdb/dwarf2/read.c (dwarf_tag_name):
(dwarf_attr_name):
(dwarf_form_name):
(dwarf_bool_name):
(dwarf_type_encoding_name):
(dwarf_unknown):
* gdb/dwarf2/stringify.c: New file.
* gdb/dwarf2/stringify.h: New file.
>
> Martin> About the merges: it's a pain to make a backport (a.k.a) as you're very likely
> Martin> conflict in ChangeLog entries. Having the ChangeLog entries in message one
> Martin> can do simple git cherry-pick and it's done.
>
> This is emphatically not the case for me.
>
> Martin> About the date-updating: it's also pain to always update a timestamp before
> Martin> a patch is installed.
>
> What I'm saying is that it isn't a pain. It's a single command before
> pushing. I can't remember the last time the scripts failed but it's
> surely been more than 5 years.
>
> I write a lot of patches in gdb and I have already filed off as many
> annoying parts as I could -- which is why my default stance is not to
> want to change. Changing implies that maybe I'd have to redo this work.
Sure. You're a skilled GDB developer with long experience. But for newcomers or
people without the scripts, this can simplify their workflow.
Martin
>
> Tom
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-29 12:15 ` Tom Tromey
2020-05-29 12:25 ` Martin Liška
2020-05-29 12:28 ` Martin Liška
@ 2020-05-29 13:57 ` Eli Zaretskii
2020-05-30 19:23 ` Tom Tromey
2 siblings, 1 reply; 25+ messages in thread
From: Eli Zaretskii @ 2020-05-29 13:57 UTC (permalink / raw)
To: Tom Tromey; +Cc: mliska, simark, hjl.tools, binutils, gdb
> From: Tom Tromey <tom@tromey.com>
> Date: Fri, 29 May 2020 06:15:01 -0600
> Cc: Simon Marchi <simark@simark.ca>, "H.J. Lu" <hjl.tools@gmail.com>,
> Binutils <binutils@sourceware.org>, GDB <gdb@sourceware.org>
>
> I'd also be open to changing the format to something requiring zero
> manual intervention. For example, if we could have a commit script that
> simply listed the files and didn't require editing in the names of the
> functions.
Having the names of the functions in the log is one of the most
important reasons for following the ChangeLog format. If it were not
for that reason, we could let people write free-text log messages,
because file names are easily gleaned from the VCS log.
^ permalink raw reply [flat|nested] 25+ messages in thread
* RE: Auto update ChangeLog for binutils+gdb commits?
2020-05-29 13:56 ` Martin Liška
@ 2020-05-30 10:23 ` Aktemur, Tankut Baris
2020-05-30 11:22 ` Martin Liška
2020-05-30 19:41 ` Tom Tromey
1 sibling, 1 reply; 25+ messages in thread
From: Aktemur, Tankut Baris @ 2020-05-30 10:23 UTC (permalink / raw)
To: Martin Liška, Tom Tromey; +Cc: Simon Marchi, H.J. Lu, Binutils, GDB
On Friday, May 29, 2020 3:57 PM, Martin Liška wrote:
>
> $ git format-patch -1 2b2558bfacba3813863da6728c021eb89fa34677 && ~/Programming/gcc/contrib/mklog.py 00*
> 0001-Move-DWARF-constant-stringifying-code-to-new-file.patch
>
> ChangeLog:
>
> * gdb/ChangeLog:
> * gdb/Makefile.in:
> * gdb/dwarf2/read.c (dwarf_tag_name):
> (dwarf_attr_name):
> (dwarf_form_name):
> (dwarf_bool_name):
> (dwarf_type_encoding_name):
> (dwarf_unknown):
> * gdb/dwarf2/stringify.c: New file.
> * gdb/dwarf2/stringify.h: New file.
Is this actually correct? I think it should have been
gdb/
* Makefile.in:
* dwarf2/read.c (dwarf_tag_name):
... and so on.
-Baris
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-30 10:23 ` Aktemur, Tankut Baris
@ 2020-05-30 11:22 ` Martin Liška
0 siblings, 0 replies; 25+ messages in thread
From: Martin Liška @ 2020-05-30 11:22 UTC (permalink / raw)
To: Aktemur, Tankut Baris, Tom Tromey; +Cc: Simon Marchi, H.J. Lu, Binutils, GDB
On 5/30/20 12:23 PM, Aktemur, Tankut Baris wrote:
> Is this actually correct? I think it should have been
>
> gdb/
>
> * Makefile.in:
> * dwarf2/read.c (dwarf_tag_name):
>
> ... and so on.
Yes, I forgot to change directory root from gcc to binutils:
$ git format-patch -1 2b2558bfacba3813863da6728c021eb89fa34677 && ~/Programming/gcc/contrib/mklog.py 00*
0001-Move-DWARF-constant-stringifying-code-to-new-file.patch
gdb/ChangeLog:
* ChangeLog:
* Makefile.in:
* dwarf2/read.c (dwarf_tag_name):
(dwarf_attr_name):
(dwarf_form_name):
(dwarf_bool_name):
(dwarf_type_encoding_name):
(dwarf_unknown):
* dwarf2/stringify.c: New file.
* dwarf2/stringify.h: New file.
Martin
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-29 13:57 ` Eli Zaretskii
@ 2020-05-30 19:23 ` Tom Tromey
2020-05-30 19:35 ` Eli Zaretskii
0 siblings, 1 reply; 25+ messages in thread
From: Tom Tromey @ 2020-05-30 19:23 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Tom Tromey, mliska, simark, hjl.tools, binutils, gdb
Eli> Having the names of the functions in the log is one of the most
Eli> important reasons for following the ChangeLog format. If it were not
Eli> for that reason, we could let people write free-text log messages,
Eli> because file names are easily gleaned from the VCS log.
If the mklog script works, then the function names are also easily
computed from the diff.
Tom
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-30 19:23 ` Tom Tromey
@ 2020-05-30 19:35 ` Eli Zaretskii
2020-06-01 7:39 ` Martin Liška
0 siblings, 1 reply; 25+ messages in thread
From: Eli Zaretskii @ 2020-05-30 19:35 UTC (permalink / raw)
To: Tom Tromey; +Cc: mliska, simark, hjl.tools, binutils, gdb
> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>, mliska@suse.cz, simark@simark.ca,
> hjl.tools@gmail.com, binutils@sourceware.org, gdb@sourceware.org
> Date: Sat, 30 May 2020 13:23:57 -0600
>
> Eli> Having the names of the functions in the log is one of the most
> Eli> important reasons for following the ChangeLog format. If it were not
> Eli> for that reason, we could let people write free-text log messages,
> Eli> because file names are easily gleaned from the VCS log.
>
> If the mklog script works, then the function names are also easily
> computed from the diff.
If all the script does is look at the hunk headers of the diffs, then
indeed such a script doesn't have any added value. I thought it did a
more thorough (and thus more accurate) job than that.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-29 13:56 ` Martin Liška
2020-05-30 10:23 ` Aktemur, Tankut Baris
@ 2020-05-30 19:41 ` Tom Tromey
2020-05-31 4:40 ` Fangrui Song
2020-06-01 7:51 ` Martin Liška
1 sibling, 2 replies; 25+ messages in thread
From: Tom Tromey @ 2020-05-30 19:41 UTC (permalink / raw)
To: Martin Liška; +Cc: Tom Tromey, H.J. Lu, Simon Marchi, GDB, Binutils
>> Could you run it on some recent gdb commits and show the output?
I tried it out a little as well.
It seems promising. However, I noticed some issues.
First, in the basic output:
Martin> * gdb/Makefile.in:
It would be more convenient for editing if the ":" were followed by a
space, since I'm normally going to have to add one anyway.
Next, try it like:
$ git show af0b2a3e85df9f49a3528e5b7578fcf9412f1acc | ./contrib/mklog.py
I get:
gdb/ChangeLog:
* ChangeLog:
* dwarf2/abbrev.c (hash_abbrev):
(abbrev_table::add_abbrev):
(struct abbrev_info):
(abbrev_table::lookup_abbrev):
(abbrev_table::read):
* dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H):
(struct abbrev_table):
abbrev.c says:
(struct abbrev_info):
... but I didn't see anything that would be relevant in the patch.
abbrev.h says:
* dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H):
... but this is very incorrect. In gdb we normally ignore changes to
the #includes, but if needed I suppose this could mention the addition
of one; but either way mentioning the include guard name is wrong --
macros should be ignored unless each preceding line ends with a
backslash.
If you try 89bcba74f89baceba3fa7387622e3d60e1de02e8, you'll see that
mklog ignores namespaces.
Martin> Sure. You're a skilled GDB developer with long experience. But for newcomers or
Martin> people without the scripts, this can simplify their workflow.
IMO we should optimize for reducing the overhead for regular
contributors. Newcomers normally have many things to learn.
Tom
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-30 19:41 ` Tom Tromey
@ 2020-05-31 4:40 ` Fangrui Song
2020-06-01 7:51 ` Martin Liška
1 sibling, 0 replies; 25+ messages in thread
From: Fangrui Song @ 2020-05-31 4:40 UTC (permalink / raw)
To: Martin Liška; +Cc: Tom Tromey, Simon Marchi, Binutils, GDB
I tried mklog.py on my gold patch.
% ~/Dev/gcc/contrib/mklog.py < 0001-gold-Set-DF_1_PIE-for-pie.patch
ChangeLog:
* elfcpp/elfcpp.h (enum DF_1):
* gold/layout.cc (Layout::finish_dynamic_section):
IIUC, the practice is to group ChangeLog's by the top-level directories
elfcpp
* elfcpp.h (enum DF_1):
gold
* layout.cc (Layout::finish_dynamic_section):
On Sat, May 30, 2020 at 12:41 PM Tom Tromey <tom@tromey.com> wrote:
>
> >> Could you run it on some recent gdb commits and show the output?
>
> I tried it out a little as well.
>
> It seems promising. However, I noticed some issues.
>
> First, in the basic output:
>
> Martin> * gdb/Makefile.in:
>
> It would be more convenient for editing if the ":" were followed by a
> space, since I'm normally going to have to add one anyway.
>
>
> Next, try it like:
>
> $ git show af0b2a3e85df9f49a3528e5b7578fcf9412f1acc | ./contrib/mklog.py
>
> I get:
>
> gdb/ChangeLog:
>
> * ChangeLog:
> * dwarf2/abbrev.c (hash_abbrev):
> (abbrev_table::add_abbrev):
> (struct abbrev_info):
> (abbrev_table::lookup_abbrev):
> (abbrev_table::read):
> * dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H):
> (struct abbrev_table):
>
> abbrev.c says:
>
> (struct abbrev_info):
>
> ... but I didn't see anything that would be relevant in the patch.
>
> abbrev.h says:
>
> * dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H):
>
> ... but this is very incorrect. In gdb we normally ignore changes to
> the #includes, but if needed I suppose this could mention the addition
> of one; but either way mentioning the include guard name is wrong --
> macros should be ignored unless each preceding line ends with a
> backslash.
>
> If you try 89bcba74f89baceba3fa7387622e3d60e1de02e8, you'll see that
> mklog ignores namespaces.
>
> Martin> Sure. You're a skilled GDB developer with long experience. But for newcomers or
> Martin> people without the scripts, this can simplify their workflow.
>
> IMO we should optimize for reducing the overhead for regular
> contributors. Newcomers normally have many things to learn.
>
> Tom
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-30 19:35 ` Eli Zaretskii
@ 2020-06-01 7:39 ` Martin Liška
2020-06-01 14:59 ` Eli Zaretskii
0 siblings, 1 reply; 25+ messages in thread
From: Martin Liška @ 2020-06-01 7:39 UTC (permalink / raw)
To: Eli Zaretskii, Tom Tromey; +Cc: simark, hjl.tools, binutils, gdb
On 5/30/20 9:35 PM, Eli Zaretskii wrote:
>> From: Tom Tromey <tom@tromey.com>
>> Cc: Tom Tromey <tom@tromey.com>, mliska@suse.cz, simark@simark.ca,
>> hjl.tools@gmail.com, binutils@sourceware.org, gdb@sourceware.org
>> Date: Sat, 30 May 2020 13:23:57 -0600
>>
>> Eli> Having the names of the functions in the log is one of the most
>> Eli> important reasons for following the ChangeLog format. If it were not
>> Eli> for that reason, we could let people write free-text log messages,
>> Eli> because file names are easily gleaned from the VCS log.
>>
>> If the mklog script works, then the function names are also easily
>> computed from the diff.
>
> If all the script does is look at the hunk headers of the diffs, then
> indeed such a script doesn't have any added value. I thought it did a
> more thorough (and thus more accurate) job than that.
>
It does, it tries to find a function name, macro, struct in a diff hunk
and this name is taken as changed. If nothing like this is found, then
diff header name is used.
Martin
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-05-30 19:41 ` Tom Tromey
2020-05-31 4:40 ` Fangrui Song
@ 2020-06-01 7:51 ` Martin Liška
1 sibling, 0 replies; 25+ messages in thread
From: Martin Liška @ 2020-06-01 7:51 UTC (permalink / raw)
To: Tom Tromey; +Cc: H.J. Lu, Simon Marchi, GDB, Binutils
On 5/30/20 9:41 PM, Tom Tromey wrote:
>>> Could you run it on some recent gdb commits and show the output?
>
> I tried it out a little as well.
>
> It seems promising. However, I noticed some issues.
>
> First, in the basic output:
>
> Martin> * gdb/Makefile.in:
>
> It would be more convenient for editing if the ":" were followed by a
> space, since I'm normally going to have to add one anyway.
Yes, that would be very easy to add.
>
>
> Next, try it like:
>
> $ git show af0b2a3e85df9f49a3528e5b7578fcf9412f1acc | ./contrib/mklog.py
>
> I get:
>
> gdb/ChangeLog:
>
> * ChangeLog:
> * dwarf2/abbrev.c (hash_abbrev):
> (abbrev_table::add_abbrev):
> (struct abbrev_info):
> (abbrev_table::lookup_abbrev):
> (abbrev_table::read):
> * dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H):
> (struct abbrev_table):
>
> abbrev.c says:
>
> (struct abbrev_info):
>
> ... but I didn't see anything that would be relevant in the patch.
>
> abbrev.h says:
>
> * dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H):
>
> ... but this is very incorrect. In gdb we normally ignore changes to
> the #includes, but if needed I suppose this could mention the addition
> of one; but either way mentioning the include guard name is wrong --
> macros should be ignored unless each preceding line ends with a
> backslash.
You are right, there are limitations, one of the reasons is that GCC
requires a return function type to be on a separate line from function name.
>
> If you try 89bcba74f89baceba3fa7387622e3d60e1de02e8, you'll see that
> mklog ignores namespaces.
Yes, it's missing right now.
Martin
>
> Martin> Sure. You're a skilled GDB developer with long experience. But for newcomers or
> Martin> people without the scripts, this can simplify their workflow.
>
> IMO we should optimize for reducing the overhead for regular
> contributors. Newcomers normally have many things to learn.
>
> Tom
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-06-01 7:39 ` Martin Liška
@ 2020-06-01 14:59 ` Eli Zaretskii
2020-06-02 6:49 ` Martin Liška
0 siblings, 1 reply; 25+ messages in thread
From: Eli Zaretskii @ 2020-06-01 14:59 UTC (permalink / raw)
To: Martin Liška; +Cc: tom, simark, hjl.tools, binutils, gdb
> Cc: simark@simark.ca, hjl.tools@gmail.com, binutils@sourceware.org,
> gdb@sourceware.org
> From: Martin Liška <mliska@suse.cz>
> Date: Mon, 1 Jun 2020 09:39:08 +0200
>
> > If all the script does is look at the hunk headers of the diffs, then
> > indeed such a script doesn't have any added value. I thought it did a
> > more thorough (and thus more accurate) job than that.
> >
>
> It does, it tries to find a function name, macro, struct in a diff hunk
> and this name is taken as changed. If nothing like this is found, then
> diff header name is used.
How does it handle the frequent case where the change is attributed by
Diff to the previous function because the function's type or argument
list is being modified?
And how does the script decide that "nothing like this is found",
i.e. how does it know that what is in the hunk header is not really a
function name?
Thanks.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-06-01 14:59 ` Eli Zaretskii
@ 2020-06-02 6:49 ` Martin Liška
2021-01-15 1:18 ` Fangrui Song
0 siblings, 1 reply; 25+ messages in thread
From: Martin Liška @ 2020-06-02 6:49 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: tom, simark, hjl.tools, binutils, gdb
On 6/1/20 4:59 PM, Eli Zaretskii wrote:
>> Cc: simark@simark.ca, hjl.tools@gmail.com, binutils@sourceware.org,
>> gdb@sourceware.org
>> From: Martin Liška <mliska@suse.cz>
>> Date: Mon, 1 Jun 2020 09:39:08 +0200
>>
>>> If all the script does is look at the hunk headers of the diffs, then
>>> indeed such a script doesn't have any added value. I thought it did a
>>> more thorough (and thus more accurate) job than that.
>>>
>>
>> It does, it tries to find a function name, macro, struct in a diff hunk
>> and this name is taken as changed. If nothing like this is found, then
>> diff header name is used.
>
> How does it handle the frequent case where the change is attributed by
> Diff to the previous function because the function's type or argument
> list is being modified?
It's handled by parsing of each diff line where we try to identify
beginning of a function, strut or something else. In that case the
diff header is ignored.
>
> And how does the script decide that "nothing like this is found",
> i.e. how does it know that what is in the hunk header is not really a
> function name?
It's best effort approach and it's not easy task ;)
Martin
>
> Thanks.
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: Auto update ChangeLog for binutils+gdb commits?
2020-06-02 6:49 ` Martin Liška
@ 2021-01-15 1:18 ` Fangrui Song
0 siblings, 0 replies; 25+ messages in thread
From: Fangrui Song @ 2021-01-15 1:18 UTC (permalink / raw)
To: binutils; +Cc: Eli Zaretskii, Martin Liška, simark, tom, gdb
On Mon, Jun 1, 2020 at 11:49 PM Martin Liška <mliska@suse.cz> wrote:
>
> On 6/1/20 4:59 PM, Eli Zaretskii wrote:
> >> Cc: simark@simark.ca, hjl.tools@gmail.com, binutils@sourceware.org,
> >> gdb@sourceware.org
> >> From: Martin Liška <mliska@suse.cz>
> >> Date: Mon, 1 Jun 2020 09:39:08 +0200
> >>
> >>> If all the script does is look at the hunk headers of the diffs, then
> >>> indeed such a script doesn't have any added value. I thought it did a
> >>> more thorough (and thus more accurate) job than that.
> >>>
> >>
> >> It does, it tries to find a function name, macro, struct in a diff hunk
> >> and this name is taken as changed. If nothing like this is found, then
> >> diff header name is used.
> >
> > How does it handle the frequent case where the change is attributed by
> > Diff to the previous function because the function's type or argument
> > list is being modified?
>
> It's handled by parsing of each diff line where we try to identify
> beginning of a function, strut or something else. In that case the
> diff header is ignored.
>
> >
> > And how does the script decide that "nothing like this is found",
> > i.e. how does it know that what is in the hunk header is not really a
> > function name?
>
> It's best effort approach and it's not easy task ;)
>
> Martin
>
> >
> > Thanks.
> >
>
Seems that ChangeLog files in binutils and gdb are still being
modified manually.
See glibc tag changelog-ends-here. They stopped updating ChangeLog
files manually.
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2021-01-15 1:18 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-26 17:07 Auto generate ChangeLog for binutils commits? H.J. Lu
2020-05-27 14:10 ` Simon Marchi
2020-05-27 14:20 ` H.J. Lu
2020-05-27 14:29 ` Simon Marchi
2020-05-27 15:10 ` Auto update ChangeLog for binutils+gdb commits? H.J. Lu
2020-05-29 7:45 ` Martin Liška
2020-05-29 8:50 ` Martin Liška
2020-05-29 8:51 ` Martin Liška
2020-05-29 12:15 ` Tom Tromey
2020-05-29 12:25 ` Martin Liška
2020-05-29 12:44 ` Tom Tromey
2020-05-29 13:56 ` Martin Liška
2020-05-30 10:23 ` Aktemur, Tankut Baris
2020-05-30 11:22 ` Martin Liška
2020-05-30 19:41 ` Tom Tromey
2020-05-31 4:40 ` Fangrui Song
2020-06-01 7:51 ` Martin Liška
2020-05-29 12:28 ` Martin Liška
2020-05-29 13:57 ` Eli Zaretskii
2020-05-30 19:23 ` Tom Tromey
2020-05-30 19:35 ` Eli Zaretskii
2020-06-01 7:39 ` Martin Liška
2020-06-01 14:59 ` Eli Zaretskii
2020-06-02 6:49 ` Martin Liška
2021-01-15 1:18 ` Fangrui Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).