Re: hppa64-hp-hpux11.00: HP ELF64 brokeness (incorrect .dynamic section)

[ross.alexander@uk.neceur.com]

[-- Attachment #1: Type: text/plain, Size: 2456 bytes --]


HP have sent me a copy of ld64 with the bug fixed but here is the patch
anyway.

bfd/Changelog
      * elf.c (bfd_elf_get_bfd_needed_list): Current HP ld64 and existing
shared
      libraries erronously set sh_link in the .dynamic section to 0.  It
should be
      set to the index of the .dynstr section.  Should be fixed on ld
patches later
      than PHSS_26262 as HP has produced a site specific fix.

(See attached file: elf.c.patch)

---------------------------------------------------------------------------------

Ross Alexander                           "He knows no more about his
MIS - NEC Europe Limited            destiny than a tea leaf knows
Work ph: +44 20 8752 3394         the history of East India Company"


|---------+------------------------------>
|         |           Jeff Law           |
|         |           <law@porcupine.slc.|
|         |           redhat.com>        |
|         |                              |
|         |           02/07/2002 19:23   |
|         |           Please respond to  |
|         |           law                |
|         |                              |
|---------+------------------------------>
  >------------------------------------------------------------------------------------------------------------|
  |                                                                                                            |
  |       To:       ross.alexander@uk.neceur.com                                                               |
  |       cc:       binutils@sources.redhat.com                                                                |
  |       Subject:  Re: hppa64-hp-hpux11.00: HP ELF64 brokeness (incorrect .dynamic  section)                  |
  >------------------------------------------------------------------------------------------------------------|




In message <OF57EE2279.B5306762-ON80256BEA.0056AFF9@uk.neceur.com>,
ross.alexan
der@uk.neceur.com writes:
  >
  > I don't mind producing a patch to create a workaround (it is very
straight
  > forward, for a change) or we could produce a program which 'corrects'
the
  > defective libraries.  However, because these are system libraries, a
lot
  > of people may be unwilling to go near then.
I suspect "fixing" the defective libraries won't be palatable to most
folks.  If we can engineer a clean workaround in bfd so that we can deal
with the broken libraries in a sane way that would probably be best.

jeff





[-- Attachment #2: elf.c.patch --]
[-- Type: application/octet-stream, Size: 602 bytes --]

*** binutils-020702/bfd/elf.c.orig	Tue Jul  2 05:31:22 2002
--- binutils-020702/bfd/elf.c	Wed Jul  3 12:07:33 2002
***************
*** 1568,1573 ****
--- 1568,1580 ----
  
    shlink = elf_elfsections (abfd)[elfsec]->sh_link;
  
+ /* HP ELF linker brokeness.  The sh_link on dynamic is set to 0. */
+   if (shlink == 0)
+     {
+       asection *dynstr = bfd_get_section_by_name(abfd, ".dynstr");
+       shlink = _bfd_elf_section_from_bfd_section (abfd, dynstr);
+     }
+ 
    extdynsize = get_elf_backend_data (abfd)->s->sizeof_dyn;
    swap_dyn_in = get_elf_backend_data (abfd)->s->swap_dyn_in;