public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "CHIGOT, CLEMENT" <clement.chigot@atos.net>
To: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: [PATCH] bfd: add missing smclass when creating csect for xcoff64
Date: Mon, 15 Feb 2021 15:03:02 +0000	[thread overview]
Message-ID: <PA4PR02MB66864A86B181527897682A24EA889@PA4PR02MB6686.eurprd02.prod.outlook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

Hi everyone, 

I've started to refresh a bit the AIX port of binutils. 
I've a few patches that I guess can be integrated even if they might 
change in the future. I mean to say that they are stable but as most
of the tests are failing on AIX, I cannot ensure that I'm not doing any
mistakes. 
Tell me if you're okay with that or if you'd rather have me fixing all
tests and be sure that everything is working correctly before 
submitting any patch ?

This one is pretty simple, so I know that it won't change anyway. 

Sincerely,
Clément

[-- Attachment #2: 0001-bfd-add-missing-smclass-when-creating-csect-for-xcof.patch --]
[-- Type: application/octet-stream, Size: 1393 bytes --]

From 025760e988855470a6bd38fa637d40cc9441e1b4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= <clement.chigot@atos.net>
Date: Fri, 16 Oct 2020 13:49:23 +0200
Subject: [PATCH] bfd: add missing smclass when creating csect for xcoff64
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

ChangeLog:
2020-10-16  Clément Chigot  <clement.chigot@atos.net>

	* bfd/coff64-rs6000.c (xcoff64_create_csect_from_smclas): Add
	missing smclass.
---
 bfd/coff64-rs6000.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/bfd/coff64-rs6000.c b/bfd/coff64-rs6000.c
index 9aa0304ec9f..8cabf74acc4 100644
--- a/bfd/coff64-rs6000.c
+++ b/bfd/coff64-rs6000.c
@@ -2130,14 +2130,14 @@ xcoff64_create_csect_from_smclas (bfd *abfd, union internal_auxent *aux,
   /* Changes from 32 :
      .sv == 8, is only for 32 bit programs
      .ti == 12 and .tb == 13 are now reserved.  */
-  static const char *names[19] =
+  static const char * const names[] =
   {
     ".pr", ".ro", ".db", ".tc", ".ua", ".rw", ".gl", ".xo",
     NULL, ".bs", ".ds", ".uc", NULL,  NULL,  NULL,  ".tc0",
-    ".td", ".sv64", ".sv3264"
+    ".td", ".sv64", ".sv3264", NULL, ".tl", ".ul", ".te"
   };
 
-  if ((19 >= aux->x_csect.x_smclas)
+  if ((aux->x_csect.x_smclas < ARRAY_SIZE (names))
       && (NULL != names[aux->x_csect.x_smclas]))
     {
 
-- 
2.25.0


             reply	other threads:[~2021-02-15 15:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 15:03 CHIGOT, CLEMENT [this message]
2021-02-16  2:14 ` Alan Modra
2021-02-16  9:31   ` CHIGOT, CLEMENT
2021-02-22  4:57     ` Alan Modra
2021-02-23  9:02       ` CHIGOT, CLEMENT
2021-02-23 12:13         ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PA4PR02MB66864A86B181527897682A24EA889@PA4PR02MB6686.eurprd02.prod.outlook.com \
    --to=clement.chigot@atos.net \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).