From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smarthost3.atos.net (smtppost.atos.net [193.56.114.176]) by sourceware.org (Postfix) with ESMTPS id 6A4F8384A018 for ; Fri, 5 Mar 2021 13:37:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6A4F8384A018 X-IronPort-AV: E=Sophos;i="5.81,224,1610406000"; d="scan'208";a="169556664" X-MGA-submission: =?us-ascii?q?MDENpfoquALuyxyuWmjG8xp3H7/zprejkc0Y0M?= =?us-ascii?q?zJ6YcMmD9V7IiUG5cmoUJ9xTQLJzCDZjDAFuUeqTzDlaLRi4BKpT1leu?= =?us-ascii?q?zzgSi/W/mW39bF8qq9GcfBVwLwcfAH+O/rYPF4Hr3jN6/W8kl11Izlky?= =?us-ascii?q?wg?= Received: from mail.sis.atos.net (HELO GITEXCPRDMB22.ww931.my-it-solutions.net) ([10.89.29.132]) by smarthost3.atos.net with ESMTP/TLS/AES256-GCM-SHA384; 05 Mar 2021 14:37:18 +0100 Received: from GITEXCPRDMB21.ww931.my-it-solutions.net (10.89.29.131) by GITEXCPRDMB22.ww931.my-it-solutions.net (10.89.29.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 5 Mar 2021 14:37:18 +0100 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (172.16.214.170) by GITEXCPRDMB21.ww931.my-it-solutions.net (10.89.29.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2 via Frontend Transport; Fri, 5 Mar 2021 14:37:18 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=giNe6r50ZK1S+5NueKE+PZ2gmjUScvb3DuxdMXQY9Ac9P5qjWlivbnNLvgoZtdgFItvsfPHgAnTHa7fDb68Ds9efleNpZTIG7XHVid0/t7OfW/CmdxfeLhsPK/aMPGwR35as5TESYHJPx14FKIFvQ/FHJBe+atAwvt0azo2aRqGg0jszH9MoXHF3ngK5aQY6yqRxYSkOLAZbpPG9qdSzTMttIwXZpHY6hoQqtRWwDZNMS96vCEVXuxffdf0mh1JoQQdDCLEZFUq7Dg9h3JvGl8zZnlSIjkOjxx7qvUM6sdm1DvzNLtncLh4iJgj7HTqgPdUXTrOUu55WGfnPypjVag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=46gJESCaeTF5/sfZ+JUMq1tUOww+umi+f2cBwyf3Cvo=; b=iDwQvMsscCMMD3GbJojeKmdHM/fbTBtZovXglYR5D6HJfQiEs3RvsCdbV3cc46dWx7JA5zEO50qV7+S6REWIXlh10hhUyoHoMqAQvJoLrtqfvHF34KPvrhtrpwJCmQlB03lkm6wlucXRoWLn5iD7iIv9XUalwudcAIxmtoQrqjUP6SQG74+scHwaYnneFfdKMXOvny+J46ffKWdHnzoXhw9tec3uUK9ZkHIw9exWrIhxATKX2y6f8FXaXGYqGvHs1T3PhT2VM2ga1PK66tnvBx4cnrOobiNT8slA2WEL5zh4mlu4seglHpVFcaizwFktBJ2rxACvQBj1DBU4tDWyKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=atos.net; dmarc=pass action=none header.from=atos.net; dkim=pass header.d=atos.net; arc=none Received: from PA4PR02MB6686.eurprd02.prod.outlook.com (2603:10a6:102:ff::14) by PR3PR02MB5995.eurprd02.prod.outlook.com (2603:10a6:102:67::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Fri, 5 Mar 2021 13:37:17 +0000 Received: from PA4PR02MB6686.eurprd02.prod.outlook.com ([fe80::e187:6d8d:478b:5402]) by PA4PR02MB6686.eurprd02.prod.outlook.com ([fe80::e187:6d8d:478b:5402%4]) with mapi id 15.20.3912.022; Fri, 5 Mar 2021 13:37:17 +0000 From: "CHIGOT, CLEMENT" To: Alan Modra CC: "binutils@sourceware.org" Subject: Re: [PATCH 6/6] aix: implement TLS relocation for gas and ld Thread-Topic: [PATCH 6/6] aix: implement TLS relocation for gas and ld Thread-Index: AQHXBEppPfWB27Vqv0ChNSjhkSizAqpqUwaAgAsri1g= Date: Fri, 5 Mar 2021 13:37:17 +0000 Message-ID: References: , <20210226105449.GW6042@bubble.grove.modra.org> In-Reply-To: <20210226105449.GW6042@bubble.grove.modra.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_Enabled=True; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_SiteId=33440fc6-b7c7-412c-bb73-0e70b0198d5a; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_SetDate=2021-03-05T13:37:17.072Z; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_Name=Atos For Internal Use - All Employees; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_ContentBits=0; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_Method=Standard; x-originating-ip: [165.225.77.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1bfce1df-08c6-4a75-ff94-08d8dfdbcb6d x-ms-traffictypediagnostic: PR3PR02MB5995: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LNVu2VYzCRxF3sAmptiNZHrqs6z7FhwUHfcvFS3PZg10oEfjxUBxDvRmI2C1hE35cB/5YGy9vrtgyDvNiYUt9Q5yBpqXOLUgK2304ZwfNanszicmZ/FwiyUuGK48wCqB7wywj30IlA3vL2J4KlPkYFYrZrTct+w0Vo59Bd9LZ6KrAsJlfAW2+BMQBvMl/39JMCQNDi7JKda2wpKQWMhmzTH67ErQYBbZQRMvCs9A2qpnha/ds/XC7p/unLdH4je19mJvRorPZw8bJ87jnia0gCadHzpQgDyEq2qZImFWAksLMER7a8fqkQuqR5AA0+7lUdZJh1k7zkChp+WImkfNOvbvml33InbvqfAne7+shta02Pao0ZLNObB5iL0TEDoQYhVqJJfdwEwpyPuI7fITqPeAF57NATnbes706vm0/+mm23NLN0inStkmOE1aueDTtHiWShI06JYR1JcJLrHOuhp6scms5JW/Sz0mnviWphWK4KCDPeRC3j3hRl5l/+FY+YHTQuEW39nCmG387vyEHQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR02MB6686.eurprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(366004)(39860400002)(346002)(396003)(66476007)(26005)(66556008)(83380400001)(478600001)(55236004)(186003)(316002)(33656002)(5660300002)(6916009)(64756008)(66946007)(66574015)(7696005)(9686003)(52536014)(55016002)(6506007)(71200400001)(86362001)(4326008)(8936002)(8676002)(76116006)(2906002)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?Nzqrehp5W+RiY5TUxU4kDI1x1e4OtmeP1/dc23RKDyHUlC9J1R8NRnOGlN?= =?iso-8859-1?Q?JM9rY1e7t2Az80jd7j19r+L2DI/6Hgjh4fAW95R1DJSFKLqmmmqZ26EAmK?= =?iso-8859-1?Q?qQV0Aq7SQxvz6m5DpLoej8xbT+LgiQDeXpLE8GyJJJVyufoqaqEpm6CkO9?= =?iso-8859-1?Q?8XoR4QYxyi8sEAl4oFf/8jdLsORr69B5iA24ddyLoOL4/CunvWLZhB5f08?= =?iso-8859-1?Q?60sX+89s/x4Ke/tw6NQ7p6+AnAlTU9lZkcVHE9A4VvOabjxIl5yIGfhXVy?= =?iso-8859-1?Q?W9zIwEKV3xjZUEiV9Vw1GqS2glJkUQV5GCPeRMhrgF4Uns86abKopviNB7?= =?iso-8859-1?Q?4ZH0KhzdLxdVpodWmCeo2FjkoPAbluxjDE3PT9mj9A8roftUcNbvR1zz+t?= =?iso-8859-1?Q?Lych7xrIdj7AhhTulxYmVSdlRw8Sdz/ToEbmMPzwXuS0ay8X6d/jU2SysA?= =?iso-8859-1?Q?N8ldJ48Nax/LN1qyOcqc4zChRH7MJtqVL3zky2Lw0FBp/DEipoJyyD6ZYY?= =?iso-8859-1?Q?2ZxK3Buy4popoxgxSOE3XjzzMxV/FXVeaHxWqSiLIYYEQGgHHBWAbz4iid?= =?iso-8859-1?Q?sRM0Oa8NEc5aN0acHIDMOozM2CzGoIiBRw7bAQfiqMRoNz9PdieZsyZVHX?= =?iso-8859-1?Q?QUTRcoL6ZGOP93/Cn7keZlZPo/+Z3NnH58xXJH/QdzwG8bTXasZuUF0xVh?= =?iso-8859-1?Q?6mQkM3x/xagTKHO0igkzdpD0o1kx856AFYDj6rUaeX4AHlR8QGdRFU+QBr?= =?iso-8859-1?Q?7n1NWfH9hwTalGg4A0UeOKGLuB4jrgaOQlZ116vEQqUSX/L50m0LcPJvyD?= =?iso-8859-1?Q?8HOBXGEdJnNUaxEQUqjVai0vN3eiLqwpGLYeqbLJutLAWNSnQpjfEa/vCG?= =?iso-8859-1?Q?aEZTuhEvmEjhcmwy9KWbHq+Auzx5q4J7R0vItZYjOpeUJewWiSVaBbTBcx?= =?iso-8859-1?Q?5G2c1qV+eX3youiKqm4PvObUQrG2Qz81uASOKdcMDwC3meOKVLNRtE2h4c?= =?iso-8859-1?Q?rbgFfb4Kun7O+mGon+u+F3i07WfRnLzsnQS9ZBXI0PpmlDZtZKJDTab5O4?= =?iso-8859-1?Q?a5TQ+PxS9ynu5emfyAHE4oP4mS9r7XM4hCcIXZI8YlqV8+gDy3538M4xWr?= =?iso-8859-1?Q?Na6p40RGbiuLVTM7zGxKb0j4zqEaxmVw0wVSNzYglw/wFPt/QJNfSEeKnZ?= =?iso-8859-1?Q?URqKWnRm0AM5yqpSLiQOsWAswfkU9XJ41VkI4VMIVL2NavoQubnH2pxa4Q?= =?iso-8859-1?Q?Ba5N+AsOVnQtcQPDvoDBSs6tn7tEduD85QfU25UcGthSEA/ZGTNlDsBJxx?= =?iso-8859-1?Q?VhOkeflFnl+23QR99fn7iNnOGu5Le0CBwof+J5lm6aFQidQ=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR02MB6686.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bfce1df-08c6-4a75-ff94-08d8dfdbcb6d X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2021 13:37:17.5924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 33440fc6-b7c7-412c-bb73-0e70b0198d5a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E6qsiXPEnK7yKVw7j8cr6xeeC6u3IgyPsbAqO/c+RPSxuJAo8chOEAqYZnX3rsJRl5XTDNZIg5qyghFbOQrEEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR02MB5995 X-OriginatorOrg: atos.net X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 13:37:23 -0000 >> --- a/ld/emultempl/aix.em=0A= >> +++ b/ld/emultempl/aix.em=0A= >> @@ -969,6 +969,26 @@ gld${EMULATION_NAME}_before_allocation (void)=0A= >>=A0=A0=A0=A0=A0=A0=A0=A0=A0 sec->flags |=3D SEC_KEEP;=0A= >>=A0=A0=A0=A0=A0=A0=A0 }=0A= >>=A0 =0A= >> +=A0 /* Make sure .tdata is removed if empty, even with -r flag.=0A= >> +=A0=A0=A0=A0 .tdata is always being generated because its size is neede= d=0A= >> +=A0=A0=A0=A0 to cumpute .data address.=A0 */=0A= >> +=A0 if (bfd_link_relocatable (&link_info))=0A= >> +=A0=A0=A0 {=0A= >> +=A0=A0=A0=A0=A0 asection *sec;=0A= >> +=0A= >> +=A0=A0=A0=A0=A0 sec =3D bfd_get_section_by_name (link_info.output_bfd,= =0A= >> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ".tdata");=0A= >=0A= > Needs a "sec !=3D NULL" test here, and I think even with that this code= =0A= > won't work as you expect.=A0 I might be wrong though, did you test to=0A= > see whether a non-empty .tdata is kept?=0A= > =0A= >> +=A0=A0=A0=A0=A0 if (sec->rawsize =3D=3D 0=0A= >> +=A0=A0=A0=A0=A0=A0 && (sec->flags & SEC_KEEP) =3D=3D 0=0A= >> +=A0=A0=A0=A0=A0=A0 && !bfd_section_removed_from_list (link_info.output_= bfd,=0A= >> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 sec))=0A= >> +=A0=A0=A0=A0 {=0A= >> +=A0=A0=A0=A0=A0=A0 sec->flags |=3D SEC_EXCLUDE;=0A= >> +=A0=A0=A0=A0=A0=A0 bfd_section_list_remove (link_info.output_bfd, sec);= =0A= >> +=A0=A0=A0=A0=A0=A0 link_info.output_bfd->section_count--;=0A= >> +=A0=A0=A0=A0 }=0A= >> +=A0=A0=A0 }=0A= >> +=0A= >> =A0=A0 before_allocation_default ();=0A= >>=A0 }=0A= =0A= Indeed, a non-empty .tdata is being removed too. =0A= My goal here is to avoid having a ".tdata" section in every files generated= =0A= with "-r". The reason why it keeps appearing is because I'm using .tdata si= ze =0A= to compute "dot" in aix.sc. =0A= I'm sure it can be fixed directly inside aix.sc but I didn't find how, as I= need=0A= to place .tdata before .data and have everything align correctly... =0A= Otherwise, any ideas how to detect when .tdata is non-empty there ? =0A= =0A= Thanks, =0A= Cl=E9ment=