From: Tamar Christina <Tamar.Christina@arm.com>
To: "nickc@redhat.com" <nickc@redhat.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Cc: nd <nd@arm.com>, Richard Earnshaw <Richard.Earnshaw@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Subject: RE: [PATCH][Binutils][Arm] BFD: Exclude sections with no content from compress check.
Date: Tue, 21 Apr 2020 15:50:31 +0000 [thread overview]
Message-ID: <PR2PR08MB47475FE56630E27A00D2BA83FFD50@PR2PR08MB4747.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <a45efa2d-014e-88f2-4f74-bff93f667499@redhat.com>
Hi Nick,
>
> > Cross-compiled and regtested on
> > aarch64-none-linux-gnu, aarch64_be-none-linux-gnu,
> > arm-none-eabi, armeb-none-eabi, arm-wince-pe
>
> Since your patch affects generic code, please could you widen your testing ?
> At least include x86_64-pc-linux-gnu and maybe a toolchain configured with -
> -enable-targets=all.
Ah I have tested x86_64-pc-linux-gnu and it's clean, I have also tried one configured with --enable-targets=all
and while the build seems to have taken longer I don't see the number of tests actually increasing.
I am just doing ../binutils-gdb-fsf/configure --prefix=(readlink -f .)/install; and make -j; and make check -j
Do I need to do something else?
I did however already commit the patch after Alan's approval.
>
> The added code also references PR 24753, but this thread has not be
> included in that PR. Ideally it would be nice if you could reopen the PR and
> add your patch there, so that there is a permanent record of the addition
> which is easy to locate based on the comment. Also, if you do this, please
> reference the PR in the changelog message.
Sorry I noticed after I sent it out that I forgot to add the PR. The PR was added however before I committed it
so the commits are on Bugzilla.
In general should re-open old PRs before committing to them?
Thanks,
Tamar
>
> Cheers
> Nick
>
next prev parent reply other threads:[~2020-04-21 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 13:41 Tamar Christina
2020-04-21 13:58 ` Alan Modra
2020-04-21 14:01 ` Tamar Christina
2020-04-21 14:29 ` Nick Clifton
2020-04-21 15:50 ` Tamar Christina [this message]
2020-04-21 16:51 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PR2PR08MB47475FE56630E27A00D2BA83FFD50@PR2PR08MB4747.eurprd08.prod.outlook.com \
--to=tamar.christina@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=binutils@sourceware.org \
--cc=nd@arm.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).