From: Tamar Christina <Tamar.Christina@arm.com>
To: Amol <suratiamol@gmail.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
nd <nd@arm.com>, Richard Earnshaw <Richard.Earnshaw@arm.com>,
"nickc@redhat.com" <nickc@redhat.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Subject: RE: [PATCH 2/2][Binutils][Arm]: Fix LSB of GOT for Thumb2 only PLT
Date: Wed, 1 Apr 2020 09:28:55 +0000 [thread overview]
Message-ID: <PR2PR08MB474778173BABE115BE91AA8CFFC90@PR2PR08MB4747.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CA+nuEB_jrcGc0Sq-9TPUEp=Vo8nX=P+r3VQNS=BosPPp_gZmcQ@mail.gmail.com>
Hi Amol,
> -----Original Message-----
> From: Amol <suratiamol@gmail.com>
> Sent: Tuesday, March 31, 2020 11:44 AM
> To: Tamar Christina <Tamar.Christina@arm.com>
> Cc: binutils@sourceware.org; nd <nd@arm.com>; Richard Earnshaw
> <Richard.Earnshaw@arm.com>; nickc@redhat.com; Ramana Radhakrishnan
> <Ramana.Radhakrishnan@arm.com>
> Subject: Re: [PATCH 2/2][Binutils][Arm]: Fix LSB of GOT for Thumb2 only PLT
>
> Hi Tamar,
>
> On 30/03/2020, Tamar Christina <tamar.christina@arm.com> wrote:
> > However I have not been able to do an execution test since I do not
> > have a way to actually test this. I am hoping the user who reported it
> > can test it but the patch is sound based on principles.
> >
>
> The issue was originally reported on Arm's community by a user rgujju [1]; I
> was just the debugger.
>
> > Amol would you be able to confirm the patch works on your setup?
> >
>
> The .got entries for both the binaries
> (a) on the ld/16017, and
> (b) on the setup at [1],
> now have the LSB set, where previously they did not.
>
> I tested the setup at [1], but on qemu alone; the control now successfully
> jumps to the plt0 stub, where previously it would just crash attempting that
> jump.
Thanks for testing!
>
> If it isn't too late, you may want to flag rgujju as the reporter of the bug.
> Apologies for any inconvenience caused.
>
> [1] https://community.arm.com/developer/ip-
> products/processors/f/cortex-m-forum/45919/gcc-does-not-generate-
> correct-code-while-building-pic
Oh.. I didn't even know about this section of community.arm.com.. Thanks for bringing the bug to our attention!
I'll credit rgujju for reporting it.
Thanks,
Tamar
>
> Thanks,
> amol
prev parent reply other threads:[~2020-04-01 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 8:12 Tamar Christina
2020-03-30 9:28 ` Nick Clifton
2020-03-31 10:43 ` Amol
2020-04-01 9:28 ` Tamar Christina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PR2PR08MB474778173BABE115BE91AA8CFFC90@PR2PR08MB4747.eurprd08.prod.outlook.com \
--to=tamar.christina@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=binutils@sourceware.org \
--cc=nd@arm.com \
--cc=nickc@redhat.com \
--cc=suratiamol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).