From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21806 invoked by alias); 8 Feb 2005 17:05:26 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 21748 invoked from network); 8 Feb 2005 17:05:18 -0000 Received: from unknown (HELO dair.pair.com) (209.68.1.49) by sourceware.org with SMTP; 8 Feb 2005 17:05:18 -0000 Received: (qmail 84863 invoked by uid 20157); 8 Feb 2005 17:05:18 -0000 Date: Tue, 08 Feb 2005 20:22:00 -0000 From: Hans-Peter Nilsson X-X-Sender: hp@dair.pair.com To: Jan Beulich cc: binutils@sources.redhat.com Subject: Re: [PATCH] Re: .macro behavior In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-02/txt/msg00131.txt.bz2 On Tue, 8 Feb 2005, Jan Beulich wrote: > >>> Ian Lance Taylor 14.01.05 17:50:05 >>> > >"Jan Beulich" writes: > > > >> Is it intentional that .macro > >> > >> - ignores the (configurable) set of symbol name characters and > instead > >> only allows [[:alpha:]_$][[:alnum:]_$]* I think this restriction is actually good. Calls for the least amount of surprises when applying the same macro to different GAS ports. > * gas/mmix/relax2.s: Use .altmacro and & to separate macro > parameter > references. Ew. Please just get rid of the ":"s instead (my mistake, as it's a symbol character, not the usual label-ending thingy). And a nitpick: > /home/jbeulich/src/binutils/mainline/2005-02-01/gas/testsuite/gas/mmix/relax2.s 2003-10-18 > 18:00:21.000000000 +0200 > +++ 2005-02-01/gas/testsuite/gas/mmix/relax2.s 2005-02-08 > 09:38:12.000000000 +0100 > @@ -1,35 +1,37 @@ > # PUSHJ stub border-cases: two with either or both stubs unreachable, > # local symbols, ditto non-local labels, similar with three PUSHJs. > > +.altmacro > + Pseudos shouldn't be first on a line. Accepting it in gas is ok, but we shouldn't get sloppy in the test-suite. For consistency, it should also be aligned with the other pseudos in that file. (I guess you don't need the ".altmacro" pseudo if you just remove the ":"s so this is mostly for the record.) brgds, H-P