[PATCH]: missing trailing slash in toplevel makefile

[PATCH]: missing trailing slash in toplevel makefile

[Christian Groessler]

Hi,

pretty obvious.

Ok to apply, or should I report this somewhere else?

regards,
chris



2005-08-15  Christian Groessler  <chris@groessler.org>

	* Makefile.tpl: (USUAL_CC_FOR_TARGET): Add missing trailing slash.
	* Makefile.in: Regenerate.


Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/Makefile.in,v
retrieving revision 1.219
diff -u -r1.219 Makefile.in
--- Makefile.in 8 Aug 2005 09:20:58 -0000       1.219
+++ Makefile.in 15 Aug 2005 20:10:31 -0000
@@ -365,7 +365,7 @@
 CONFIGURED_CC_FOR_TARGET=@CONFIGURED_CC_FOR_TARGET@
 USUAL_CC_FOR_TARGET = ` \
   if [ -f $$r/$(HOST_SUBDIR)/gcc/xgcc ] ; then \
-    echo $$r/$(HOST_SUBDIR)/gcc/xgcc -B$$r/$(HOST_SUBDIR)/gcc ; \
+    echo $$r/$(HOST_SUBDIR)/gcc/xgcc -B$$r/$(HOST_SUBDIR)/gcc/ ; \
   else \
     if [ '$(host)' = '$(target)' ] ; then \
       echo $(CC); \
Index: Makefile.tpl
===================================================================
RCS file: /cvs/src/src/Makefile.tpl,v
retrieving revision 1.143
diff -u -r1.143 Makefile.tpl
--- Makefile.tpl        8 Aug 2005 09:21:05 -0000       1.143
+++ Makefile.tpl        15 Aug 2005 20:10:31 -0000
@@ -368,7 +368,7 @@
 CONFIGURED_CC_FOR_TARGET=@CONFIGURED_CC_FOR_TARGET@
 USUAL_CC_FOR_TARGET = ` \
   if [ -f $$r/$(HOST_SUBDIR)/gcc/xgcc ] ; then \
-    echo $$r/$(HOST_SUBDIR)/gcc/xgcc -B$$r/$(HOST_SUBDIR)/gcc ; \
+    echo $$r/$(HOST_SUBDIR)/gcc/xgcc -B$$r/$(HOST_SUBDIR)/gcc/ ; \
   else \
     if [ '$(host)' = '$(target)' ] ; then \
       echo $(CC); \

Re: [PATCH]: missing trailing slash in toplevel makefile

[DJ Delorie]

> Ok to apply, or should I report this somewhere else?
> 
> 2005-08-15  Christian Groessler  <chris@groessler.org>
> 
> 	* Makefile.tpl: (USUAL_CC_FOR_TARGET): Add missing trailing slash.
> 	* Makefile.in: Regenerate.

Ok to apply, but both gcc and src if you can please.

Re: [PATCH]: missing trailing slash in toplevel makefile

[Hans-Peter Nilsson]

On Mon, 15 Aug 2005, Christian Groessler wrote:
> Hi,
>
> pretty obvious.

Hm somewhat, but is it needed?  ISTR things had changed such
that the slash isn't needed anymore.  Did something break or was
it just spotted by code inspection?

brgds, H-P

Re: [PATCH]: missing trailing slash in toplevel makefile

[Christian Groessler]

Hi,

On Mon, 15 Aug 2005, Hans-Peter Nilsson wrote:

> Hm somewhat, but is it needed?  ISTR things had changed such
> that the slash isn't needed anymore.  Did something break or was
> it just spotted by code inspection?

I'm compiling a tree with newlib and an old gcc inside.
I wasn't aware that newer gcc versions don't required the slash anymore.

But it doesn't hurt to have it either.

Ok to commit, or should I keep it locally?

regards,
chris

Re: [PATCH]: missing trailing slash in toplevel makefile

[Paolo Bonzini]

>I'm compiling a tree with newlib and an old gcc inside.
>I wasn't aware that newer gcc versions don't required the slash anymore.
>
AFAIK, you should always try the toplevel of your gcc tree first, even 
if it is older.

Paolo

Re: [PATCH]: missing trailing slash in toplevel makefile

[Hans-Peter Nilsson]

On Tue, 16 Aug 2005, Christian Groessler wrote:
> Ok to commit, or should I keep it locally?

I'm not an approver, so just for the record I don't particuarly
mind, I was just curious how this broke for you.

brgds, H-P

Re: [PATCH]: missing trailing slash in toplevel makefile

[Christian Groessler]

On Tue, 16 Aug 2005, Paolo Bonzini wrote:

>
> >I'm compiling a tree with newlib and an old gcc inside.
> >I wasn't aware that newer gcc versions don't required the slash anymore.
> >
> AFAIK, you should always try the toplevel of your gcc tree first, even
> if it is older.

Yes, but my gcc version still is quite old...

regards,
chris

Re: [PATCH]: missing trailing slash in toplevel makefile

[Christian Groessler]

On Mon, 15 Aug 2005, DJ Delorie wrote:

>
> > Ok to apply, or should I report this somewhere else?
> >
> > 2005-08-15  Christian Groessler  <chris@groessler.org>
> >
> > 	* Makefile.tpl: (USUAL_CC_FOR_TARGET): Add missing trailing slash.
> > 	* Makefile.in: Regenerate.
>
> Ok to apply, but both gcc and src if you can please.

I can apply it in src, but I don't have write access to gcc. Can someone
else apply it in gcc?

regards,
chris

Re: [PATCH]: missing trailing slash in toplevel makefile

[Paolo Bonzini]

>I can apply it in src, but I don't have write access to gcc. Can someone
>else apply it in gcc?
>  
>
I'll take care of that.

Paolo

Re: [PATCH]: missing trailing slash in toplevel makefile

[Christian Groessler]

Hi,

On Wed, 17 Aug 2005, Paolo Bonzini wrote:

>
> >I can apply it in src, but I don't have write access to gcc. Can someone
> >else apply it in gcc?
> >
> >
> I'll take care of that.

Thanks. I've installed the patch in src.

regards,
chris