(patch) hpjyg07: include/hp-symtab.h

(patch) hpjyg07: include/hp-symtab.h

[Jimmy Guo]

This patch is sent to both gdb-patches and binutils.

1999-11-03      Jimmy Guo       <guo@cup.hp.com>

        * hp-symtab.h (HP_LANGUAGE_FORTRAN): Declare, replaces
        HP_LANGUAGE_F77.

Index: include/hp-symtab.h
/opt/gnu/bin/diff -r -c -N  /view/guo.wdb.c//CLO/Components/WDB/Src/gnu/include/hp-symtab.h include/hp-symtab.h
*** /view/guo.wdb.c//CLO/Components/WDB/Src/gnu/include/hp-symtab.h	Wed Nov  3 13:15:36 1999
--- include/hp-symtab.h	Wed Nov  3 13:16:18 1999
***************
*** 88,94 ****
  {
    HP_LANGUAGE_UNKNOWN,
    HP_LANGUAGE_C,
!   HP_LANGUAGE_F77,
    HP_LANGUAGE_PASCAL,
    HP_LANGUAGE_MODCAL,
    HP_LANGUAGE_COBOL,
--- 88,94 ----
  {
    HP_LANGUAGE_UNKNOWN,
    HP_LANGUAGE_C,
!   HP_LANGUAGE_FORTRAN,
    HP_LANGUAGE_PASCAL,
    HP_LANGUAGE_MODCAL,
    HP_LANGUAGE_COBOL,

Re: (patch) hpjyg07: include/hp-symtab.h

[Jeffrey A Law]

  In message <Pine.LNX.4.10.9911031804490.19890-100000@hpcll168.cup.hp.com>you 
write:
  > This patch is sent to both gdb-patches and binutils.
  > 
  > 1999-11-03      Jimmy Guo       <guo@cup.hp.com>
  > 
  >         * hp-symtab.h (HP_LANGUAGE_FORTRAN): Declare, replaces
  >         HP_LANGUAGE_F77.
I don't see the point behind making this change.  Also note that it will
break gdb unless you change hp-psymtab-read.c at the same time.

Why are you making this change?
jeff

Re: (patch) hpjyg07: include/hp-symtab.h

[Jeffrey A Law]

  In message < Pine.LNX.4.10.9911031804490.19890-100000@hpcll168.cup.hp.com >you 
write:
  > This patch is sent to both gdb-patches and binutils.
  > 
  > 1999-11-03      Jimmy Guo       <guo@cup.hp.com>
  > 
  >         * hp-symtab.h (HP_LANGUAGE_FORTRAN): Declare, replaces
  >         HP_LANGUAGE_F77.
I don't see the point behind making this change.  Also note that it will
break gdb unless you change hp-psymtab-read.c at the same time.

Why are you making this change?
jeff

Re: (patch) hpjyg07: include/hp-symtab.h

[Jimmy Guo]

>  > 1999-11-03      Jimmy Guo       <guo@cup.hp.com>
>  > 
>  >         * hp-symtab.h (HP_LANGUAGE_FORTRAN): Declare, replaces
>  >         HP_LANGUAGE_F77.
>I don't see the point behind making this change.  Also note that it will
>break gdb unless you change hp-psymtab-read.c at the same time.

>Why are you making this change?

We've added Fortran 90 support and this change is to cover Fortran90 as
well.  But it could be that hp-psymtab-read.c needs change at the same
time ... I thought I tested each patch but one can never be sure.

- Jimmy

Re: (patch) hpjyg07: include/hp-symtab.h

[Jeffrey A Law]

  In message < Pine.LNX.4.10.9912150840410.29519-100000@hpcll168.cup.hp.com >you 
write:
  > >  > 1999-11-03      Jimmy Guo       <guo@cup.hp.com>
  > >  > 
  > >  >         * hp-symtab.h (HP_LANGUAGE_FORTRAN): Declare, replaces
  > >  >         HP_LANGUAGE_F77.
  > >I don't see the point behind making this change.  Also note that it will
  > >break gdb unless you change hp-psymtab-read.c at the same time.
  > 
  > >Why are you making this change?
  > 
  > We've added Fortran 90 support and this change is to cover Fortran90 as
  > well.
Ah yes.  That makes perfect sense.

  > But it could be that hp-psymtab-read.c needs change at the same
  > time ... I thought I tested each patch but one can never be sure.
grep HP_LANGUAGE_F77 will show one use in hp-psymtab-read.c  so it
should be updated to the newer name.  I'll take care of that.

It probably does not matter for this specific patch, but in general if we can
keep compatibility we should.  I went ahead and updated the patch so that it
provides by HP_LANGUAGE_FORTRAN and HP_LANGUAGE_F77.

The changes should appear in the next gdb snapshot.

Thanks,
jeff