FAIL: strings

FAIL: strings

[John David Anglin]

The gas test "strings" fails with todays CVS source under hpux 10.20:

./as-new   -o dump.o /xxx/gnu/binutils-2.9.5/gas/testsuite/gas/macros/strings.s
/xxx/gnu/binutils-2.9.5/gas/testsuite/gas/macros/strings.s: Assembler messages:
/xxx/gnu/binutils-2.9.5/gas/testsuite/gas/macros/strings.s:1: Fatal error: Not i
n a space.

FAIL: strings

The configuration was

# ./configure  --host=hppa1.1-hp-hpux10.20 --target=hppa1.1-hp-hpux10.20 --with-gnu-as --enable-shared --enable-targets=all --enable-commonbfdlib --cache-file=.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6605)

FAIL: strings

[Ulf Carlsson]

Hi John,

 > The gas test "strings" fails with todays CVS source under hpux 10.20:
 > 
 > ./as-new -o dump.o
 > /xxx/gnu/binutils-2.9.5/gas/testsuite/gas/macros/strings.s
 > /xxx/gnu/binutils-2.9.5/gas/testsuite/gas/macros/strings.s:
 > Assembler messages:
 > /xxx/gnu/binutils-2.9.5/gas/testsuite/gas/macros/strings.s:1: Fatal
 > error: Not i n a space.
 > 
 > FAIL: strings

Please try the appended patch and tell me whether it works.  I'm not
sure what's going on since I couldn't test it.  I didn't manage to
build the hppa binutils for some reason.  Has anyone built this on
i386 lately?

Ulf

2000-06-16  Ulf Carlsson  <ulfc@engr.sgi.com>

	* config/tc-hppa.c (pa_stringer): Do not incorrectly skip over the
	first character.


Index: tc-hppa.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-hppa.c,v
retrieving revision 1.57
diff -p -r1.57 tc-hppa.c
*** tc-hppa.c	2000/06/14 02:58:49	1.57
--- tc-hppa.c	2000/06/17 04:28:03
*************** pa_stringer (append_zero)
*** 8020,8028 ****
       For example, \xDD where DD is a hexidecimal number should be
       changed to \OOO where OOO is an octal number.  */
  
-   /* Skip the opening quote.  */
-   s = input_line_pointer + 1;
- 
    while (is_a_char (c = pa_stringer_aux (s++)))
      {
        if (c == '\\')
--- 8020,8025 ----

Re: FAIL: strings

[Alan Modra]

On Fri, 16 Jun 2000, Ulf Carlsson wrote:

> sure what's going on since I couldn't test it.  I didn't manage to
> build the hppa binutils for some reason.  Has anyone built this on
> i386 lately?

SOM targets only build on an HP-UX host.  bfd/som.c uses HP-UX header 
files.

-- 
Linuxcare.  Support for the Revolution.

Re: FAIL: strings

[Alan Modra]

On Fri, 16 Jun 2000, John David Anglin wrote:

> The gas test "strings" fails with todays CVS source under hpux 10.20:

I'm just about to commit the following to fix this problem.

gas/testsuite/ChangeLog
	* gas/macros/strings.s: Don't start directives in first column
	(for LABELS_WITHOUT_COLONS targets).

Index: gas/macros/strings.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/macros/strings.s,v
retrieving revision 1.1
diff -u -p -r1.1 strings.s
--- strings.s	2000/06/13 21:23:28	1.1
+++ strings.s	2000/06/17 12:03:51
@@ -1,6 +1,6 @@
-.macro M arg1
+	.macro M arg1
 	.ascii	"\arg1"
-.endm
+	.endm
 
 	.data
 foo:

Alan Modra
-- 
Linuxcare.  Support for the Revolution.