From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Modra To: Timothy Wall Cc: binutils@sourceware.cygnus.com Subject: Re: [PATCH] tic54x gas target Date: Mon, 19 Jun 2000 18:17:00 -0000 Message-id: References: <394EA77F.79B966FF@cygnus.com> X-SW-Source: 2000-06/msg00382.html On Mon, 19 Jun 2000, Timothy Wall wrote: > These patches implement GAS for the tic54x. > > About 3Mb of test files have been excised for brevity. It's still not exactly brief :-) Some comments: - Someone has gone to a bit of trouble to add autoconf checks for libm in all the aclocal.m4 files. You should probably use the autoconf value rather than plain "-lm", or better still get rid of -lm altogether. - I noticed C++ style comments lurking in your source. As a general rule, binutils source ought to compile with pre-ANSI K&R compilers. There are a number of people reading the binutils list who can probably help test your code for K&R compatibility. If these things are fixed, consider it approved. Regards, Alan Modra -- Linuxcare. Support for the Revolution.