public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <alan@linuxcare.com.au>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: BINUTILS Patches <binutils@sourceware.cygnus.com>,
	GDB Patches <gdb-patches@sourceware.cygnus.com>
Subject: Re: [rfc] For mips, sign-extended ecoff offsets
Date: Mon, 19 Jun 2000 18:50:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.21.0006201128050.12273-100000@front.linuxcare.com.au> (raw)
In-Reply-To: <394EC637.24300B87@cygnus.com>

On Tue, 20 Jun 2000, Andrew Cagney wrote:

> > I'm worried about what happens if things like PDR.adr get changed from
> > 0xa0000000 to 0xffffffffa0000000.
> 
> Thats why I'm asking :-) Remember though, on the MIPS platform, if
> ``PDR.adr'' is an address then, the canonical form of the value
> ``0xa0000000'' obtained from an elf32 binary is 0xffffffffa00000000. 
> GDB and BFD have, for too many years, been bribed and cajoled into
> perpetuated the lie that MIPS doesn't sign extend addresses.   GDB's now
> decided to come clean on this matter (and purge an amazing amount of
> bogus code :-).

Well, it's the likelihood of other "bogus code" existing in binutils that
assumes addresses are _not_ sign extended that worries me.  If you work to
the "You break it, you fix it" rule, then you may be taking on quite a bit
of work :-)

> Any way I've attached a revised patch.  I wasn't ruthless enough the
> first time....  With this revision the linker appears to work :-) 
> Testing is continuing.

There's an ECOF_ typo still in a comment.

> I guess the question for BFD people is, is this the correct approach to
> fixing this bug?

I'd like to hear Ian's comments on this before you check it in.

Regards, Alan Modra
-- 
Linuxcare.  Support for the Revolution.

  parent reply	other threads:[~2000-06-19 18:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-06-19  5:14 Andrew Cagney
2000-06-19  8:48 ` Alan Modra
2000-06-19 18:18   ` Andrew Cagney
2000-06-19 18:47     ` Ulf Carlsson
2000-06-19 18:57       ` Alan Modra
2000-06-19 19:16       ` Andrew Cagney
2000-06-19 20:08       ` Geoff Keating
2000-06-19 20:41         ` Ian Lance Taylor
2000-06-25 14:13           ` Ralf Baechle
     [not found]         ` <14670.59816.517716.492387@calypso.engr.sgi.com>
2000-06-19 21:30           ` Geoff Keating
2000-06-19 18:50     ` Alan Modra [this message]
2000-06-19 19:23       ` Andrew Cagney
2000-06-19 20:39       ` Ian Lance Taylor
2000-06-23  0:28         ` Andrew Cagney
2000-06-23  9:48           ` Ian Lance Taylor
2000-07-03 23:47             ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.21.0006201128050.12273-100000@front.linuxcare.com.au \
    --to=alan@linuxcare.com.au \
    --cc=ac131313@cygnus.com \
    --cc=binutils@sourceware.cygnus.com \
    --cc=gdb-patches@sourceware.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).