public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <alan@linuxcare.com.au>
To: binutils@sourceware.cygnus.com
Subject: bfd warning fixes
Date: Sun, 09 Jul 2000 22:22:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.21.0007101518190.684-100000@front.linuxcare.com.au> (raw)

I've just checked in some warning fixes from
Ryan Bradetich <rbradetich@uswest.net>

Alan Modra
-- 
Linuxcare.  Support for the Revolution.

bfd/ChangeLog
	* dwarf1.c (parse_die): Cure signed/unsigned char warnings.
	(parse_line_table): Ditto.
	(_bfd_dwarf1_find_nearest_line): Ditto.
	* syms.c (cmpindexentry): Remove extra `*' from params.

Index: dwarf1.c
===================================================================
RCS file: /cvs/src/src/bfd/dwarf1.c,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -p -r1.4 -r1.5
--- dwarf1.c	1999/10/18 12:45:21	1.4
+++ dwarf1.c	2000/07/10 05:14:13	1.5
@@ -1,5 +1,5 @@
 /* DWARF 1 find nearest line (_bfd_dwarf1_find_nearest_line).
-   Copyright 1998, 1999 Free Software Foundation, Inc.
+   Copyright 1998, 1999, 2000 Free Software Foundation, Inc.
 
 Written by Gavin Romig-Koch of Cygnus Solutions (gavin@cygnus.com).  
 
@@ -184,7 +184,7 @@ parse_die (abfd, aDieInfo, aDiePtr)
   memset (aDieInfo,0,sizeof(*aDieInfo));
 
   /* First comes the length. */
-  aDieInfo->length = bfd_get_32 (abfd, xptr);
+  aDieInfo->length = bfd_get_32 (abfd, (bfd_byte *) xptr);
   xptr += 4;
   if (aDieInfo->length == 0)
     return false;
@@ -196,7 +196,7 @@ parse_die (abfd, aDieInfo, aDiePtr)
     }
 
   /* Then the tag. */
-  aDieInfo->tag = bfd_get_16 (abfd, xptr);
+  aDieInfo->tag = bfd_get_16 (abfd, (bfd_byte *) xptr);
   xptr += 2;
       
   /* Then the attributes. */
@@ -208,7 +208,7 @@ parse_die (abfd, aDieInfo, aDiePtr)
          must handle all dwarf1 forms, but need only handle the
 	 actual attributes that we care about. */
 
-      attr = bfd_get_16 (abfd, xptr);
+      attr = bfd_get_16 (abfd, (bfd_byte *) xptr);
       xptr += 2;
       
       switch (FORM_FROM_ATTR (attr))
@@ -219,10 +219,10 @@ parse_die (abfd, aDieInfo, aDiePtr)
 	case FORM_DATA4:
 	case FORM_REF:
 	  if (attr == AT_sibling)
-	    aDieInfo->sibling = bfd_get_32 (abfd, xptr);
+	    aDieInfo->sibling = bfd_get_32 (abfd, (bfd_byte *) xptr);
 	  else if (attr == AT_stmt_list)
 	    {
-	      aDieInfo->stmt_list_offset = bfd_get_32 (abfd, xptr);
+	      aDieInfo->stmt_list_offset = bfd_get_32 (abfd, (bfd_byte *) xptr);
 	      aDieInfo->has_stmt_list = 1;
 	    }
 	  xptr += 4;
@@ -232,16 +232,16 @@ parse_die (abfd, aDieInfo, aDiePtr)
 	  break;
 	case FORM_ADDR:
 	  if (attr == AT_low_pc)
-	    aDieInfo->low_pc = bfd_get_32 (abfd, xptr);
+	    aDieInfo->low_pc = bfd_get_32 (abfd, (bfd_byte *) xptr);
 	  else if (attr == AT_high_pc)
-	    aDieInfo->high_pc = bfd_get_32 (abfd, xptr);
+	    aDieInfo->high_pc = bfd_get_32 (abfd, (bfd_byte *) xptr);
 	  xptr += 4;
 	  break;
 	case FORM_BLOCK2:
-	  xptr += 2 + bfd_get_16 (abfd, xptr);
+	  xptr += 2 + bfd_get_16 (abfd, (bfd_byte *) xptr);
 	  break;
 	case FORM_BLOCK4:
-	  xptr += 4 + bfd_get_32 (abfd, xptr);
+	  xptr += 4 + bfd_get_32 (abfd, (bfd_byte *) xptr);
 	  break;
 	case FORM_STRING:
 	  if (attr == AT_name)
@@ -276,7 +276,7 @@ parse_line_table (stash, aUnit)
 	return false;
 	  
       size = bfd_get_section_size_before_reloc (msec);
-      stash->line_section = (unsigned char*) bfd_alloc (stash->abfd, size);
+      stash->line_section = (char *) bfd_alloc (stash->abfd, size);
       
       if (! stash->line_section)
 	return false;
@@ -299,11 +299,11 @@ parse_line_table (stash, aUnit)
       unsigned long base;
 
       /* First comes the length. */
-      tblend = bfd_get_32 (stash->abfd, xptr) + xptr;
+      tblend = bfd_get_32 (stash->abfd, (bfd_byte *) xptr) + xptr;
       xptr += 4;
 
       /* Then the base address for each address in the table. */
-      base = bfd_get_32 (stash->abfd, xptr);
+      base = bfd_get_32 (stash->abfd, (bfd_byte *) xptr);
       xptr += 4;
 
       /* How many line entrys?
@@ -311,7 +311,7 @@ parse_line_table (stash, aUnit)
       aUnit->line_count = (tblend - xptr) / 10;
 
       /* Allocate an array for the entries. */
-      aUnit->linenumber_table = (struct linenumber*)
+      aUnit->linenumber_table = (struct linenumber *)
 	bfd_alloc (stash->abfd, 
 		   sizeof (struct linenumber) * aUnit->line_count);
 	
@@ -319,7 +319,7 @@ parse_line_table (stash, aUnit)
 	{
 	  /* A line number. */
 	  aUnit->linenumber_table[eachLine].linenumber
-	    = bfd_get_32 (stash->abfd, xptr);
+	    = bfd_get_32 (stash->abfd, (bfd_byte *) xptr);
 	  xptr += 4;
 
 	  /* Skip the position within the line. */
@@ -327,7 +327,7 @@ parse_line_table (stash, aUnit)
 
 	  /* And finally the address. */
 	  aUnit->linenumber_table[eachLine].addr 
-	    = base + bfd_get_32 (stash->abfd, xptr);
+	    = base + bfd_get_32 (stash->abfd, (bfd_byte *) xptr);
 	  xptr += 4;
 	}
     }
@@ -495,7 +495,7 @@ _bfd_dwarf1_find_nearest_line (abfd, sec
 	}
 
       size = bfd_get_section_size_before_reloc (msec);
-      stash->debug_section = (unsigned char*) bfd_alloc (abfd, size);
+      stash->debug_section = (char *) bfd_alloc (abfd, size);
       
       if (! stash->debug_section)
 	return false;
Index: syms.c
===================================================================
RCS file: /cvs/src/src/bfd/syms.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -p -r1.6 -r1.7
--- syms.c	2000/06/29 15:06:34	1.6
+++ syms.c	2000/07/10 05:14:13	1.7
@@ -1,5 +1,5 @@
 /* Generic symbol-table support for the BFD library.
-   Copyright (C) 1990, 91, 92, 93, 94, 95, 96, 97, 98, 1999
+   Copyright (C) 1990, 91, 92, 93, 94, 95, 96, 97, 98, 99, 2000
    Free Software Foundation, Inc.
    Written by Cygnus Support.
 
@@ -788,8 +788,8 @@ struct indexentry
 
 static int
 cmpindexentry (a, b)
-     const PTR *a;
-     const PTR *b;
+     const PTR a;
+     const PTR b;
 {
   const struct indexentry *contestantA = (const struct indexentry *) a;
   const struct indexentry *contestantB = (const struct indexentry *) b;

             reply	other threads:[~2000-07-09 22:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-07-09 22:22 Alan Modra [this message]
2004-11-19 11:57 Alan Modra
2005-02-17 16:07 Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.21.0007101518190.684-100000@front.linuxcare.com.au \
    --to=alan@linuxcare.com.au \
    --cc=binutils@sourceware.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).